Re: [PATCH] nvedit: simplify do_env_indirect()

2023-03-31 Thread Tom Rini
On Mon, Mar 06, 2023 at 02:27:21PM +0100, Rasmus Villemoes wrote: > Instead of calling env_get(from) up to three times, just do it once, > computing the value we will put into 'to' and error out if that is > NULL (i.e. no 'from' variable and no default provided). > > No functional change. > > Si

Re: [PATCH] nvedit: simplify do_env_indirect()

2023-03-06 Thread Simon Glass
On Mon, 6 Mar 2023 at 06:27, Rasmus Villemoes wrote: > > Instead of calling env_get(from) up to three times, just do it once, > computing the value we will put into 'to' and error out if that is > NULL (i.e. no 'from' variable and no default provided). > > No functional change. > > Signed-off-by:

[PATCH] nvedit: simplify do_env_indirect()

2023-03-06 Thread Rasmus Villemoes
Instead of calling env_get(from) up to three times, just do it once, computing the value we will put into 'to' and error out if that is NULL (i.e. no 'from' variable and no default provided). No functional change. Signed-off-by: Rasmus Villemoes --- cmd/nvedit.c | 11 --- 1 file changed