Re: [PATCH] net: phy: xilinx: Break while loop over ethernet phy

2021-04-29 Thread Michal Simek
Hi Bin, On 4/28/21 6:36 PM, Bin Meng wrote: > Hi Michal, > > On Thu, Apr 29, 2021 at 12:17 AM Michal Simek wrote: >> >> Hi Bin, >> >> On 4/28/21 5:57 PM, Bin Meng wrote: >>> Hi Michal, >>> >>> On Wed, Apr 28, 2021 at 11:03 PM Michal Simek >>> wrote: Hi Bin, On 4/28/21 4:37

Re: [PATCH] net: phy: xilinx: Break while loop over ethernet phy

2021-04-28 Thread Bin Meng
Hi Michal, On Thu, Apr 29, 2021 at 12:17 AM Michal Simek wrote: > > Hi Bin, > > On 4/28/21 5:57 PM, Bin Meng wrote: > > Hi Michal, > > > > On Wed, Apr 28, 2021 at 11:03 PM Michal Simek > > wrote: > >> > >> Hi Bin, > >> > >> On 4/28/21 4:37 PM, Bin Meng wrote: > >>> Hi Michal, > >>> > >>> On Tue

Re: [PATCH] net: phy: xilinx: Break while loop over ethernet phy

2021-04-28 Thread Michal Simek
Hi Bin, On 4/28/21 5:57 PM, Bin Meng wrote: > Hi Michal, > > On Wed, Apr 28, 2021 at 11:03 PM Michal Simek wrote: >> >> Hi Bin, >> >> On 4/28/21 4:37 PM, Bin Meng wrote: >>> Hi Michal, >>> >>> On Tue, Apr 27, 2021 at 7:22 PM Michal Simek >>> wrote: Hi Bin, On 4/27/21 7:17 A

Re: [PATCH] net: phy: xilinx: Break while loop over ethernet phy

2021-04-28 Thread Bin Meng
Hi Michal, On Wed, Apr 28, 2021 at 11:03 PM Michal Simek wrote: > > Hi Bin, > > On 4/28/21 4:37 PM, Bin Meng wrote: > > Hi Michal, > > > > On Tue, Apr 27, 2021 at 7:22 PM Michal Simek > > wrote: > >> > >> Hi Bin, > >> > >> On 4/27/21 7:17 AM, Bin Meng wrote: > >>> Hi Michal, > >>> > >>> On Mon,

Re: [PATCH] net: phy: xilinx: Break while loop over ethernet phy

2021-04-28 Thread Michal Simek
Hi Bin, On 4/28/21 4:37 PM, Bin Meng wrote: > Hi Michal, > > On Tue, Apr 27, 2021 at 7:22 PM Michal Simek wrote: >> >> Hi Bin, >> >> On 4/27/21 7:17 AM, Bin Meng wrote: >>> Hi Michal, >>> >>> On Mon, Apr 26, 2021 at 8:31 PM Michal Simek >>> wrote: The commit 6c993815bbea ("net: phy:

Re: [PATCH] net: phy: xilinx: Break while loop over ethernet phy

2021-04-28 Thread Bin Meng
Hi Michal, On Tue, Apr 27, 2021 at 7:22 PM Michal Simek wrote: > > Hi Bin, > > On 4/27/21 7:17 AM, Bin Meng wrote: > > Hi Michal, > > > > On Mon, Apr 26, 2021 at 8:31 PM Michal Simek > > wrote: > >> > >> The commit 6c993815bbea ("net: phy: xilinx: Be compatible with live OF > >> tree") change d

Re: [PATCH] net: phy: xilinx: Break while loop over ethernet phy

2021-04-27 Thread Michal Simek
Hi Bin, On 4/27/21 7:17 AM, Bin Meng wrote: > Hi Michal, > > On Mon, Apr 26, 2021 at 8:31 PM Michal Simek wrote: >> >> The commit 6c993815bbea ("net: phy: xilinx: Be compatible with live OF >> tree") change driver behavior to while loop which wasn't correct because >> the driver was looping over

Re: [PATCH] net: phy: xilinx: Break while loop over ethernet phy

2021-04-26 Thread Bin Meng
Hi Michal, On Mon, Apr 26, 2021 at 8:31 PM Michal Simek wrote: > > The commit 6c993815bbea ("net: phy: xilinx: Be compatible with live OF > tree") change driver behavior to while loop which wasn't correct because > the driver was looping over again and again. The reason was that > ofnode_valid()

[PATCH] net: phy: xilinx: Break while loop over ethernet phy

2021-04-26 Thread Michal Simek
The commit 6c993815bbea ("net: phy: xilinx: Be compatible with live OF tree") change driver behavior to while loop which wasn't correct because the driver was looping over again and again. The reason was that ofnode_valid() is taking 0 as correct value. Fix it by changing while loop to ofnode_for_e