Re: [PATCH] moveconfig: Fix code relying on now-stripped newline characters

2022-01-30 Thread Simon Glass
Hi Alper, On Sun, 30 Jan 2022 at 13:14, Alper Nebi Yasak wrote: > > On 30/01/2022 00:09, Simon Glass wrote: > > On Sat, 29 Jan 2022 at 08:22, Alper Nebi Yasak > > wrote: > >> Commit 37f815cad07d ("moveconfig: Use a function to read files") adds a > >> helper function that can read a file as lin

Re: [PATCH] moveconfig: Fix code relying on now-stripped newline characters

2022-01-30 Thread Alper Nebi Yasak
On 30/01/2022 00:09, Simon Glass wrote: > On Sat, 29 Jan 2022 at 08:22, Alper Nebi Yasak > wrote: >> Commit 37f815cad07d ("moveconfig: Use a function to read files") adds a >> helper function that can read a file as lines, but strips the newline >> characters. This change broke parts of moveconfi

Re: [PATCH] moveconfig: Fix code relying on now-stripped newline characters

2022-01-29 Thread Simon Glass
Hi Alper, On Sat, 29 Jan 2022 at 08:22, Alper Nebi Yasak wrote: > > Commit 37f815cad07d ("moveconfig: Use a function to read files") adds a > helper function that can read a file as lines, but strips the newline > characters. This change broke parts of moveconfig code that relied on > their exist

[PATCH] moveconfig: Fix code relying on now-stripped newline characters

2022-01-29 Thread Alper Nebi Yasak
Commit 37f815cad07d ("moveconfig: Use a function to read files") adds a helper function that can read a file as lines, but strips the newline characters. This change broke parts of moveconfig code that relied on their existence, resulting in a few issues: Configs that are defined as empty aren't r