Re: [PATCH] lib/rsa: avoid -Wdiscarded-qualifiers

2022-01-10 Thread Tom Rini
On Sun, Jan 09, 2022 at 03:39:40PM +0100, Heinrich Schuchardt wrote: > The return type of EVP_PKEY_get0_RSA() is const struct rsa_st *. > Our code drops the const qualifier leading to > > In file included from tools/lib/rsa/rsa-sign.c:1: > ./tools/../lib/rsa/rsa-sign.c: In function ‘rsa_add_verif

Re: [PATCH] lib/rsa: avoid -Wdiscarded-qualifiers

2022-01-10 Thread Heinrich Schuchardt
On 1/10/22 17:48, Simon Glass wrote: Hi, On Mon, 10 Jan 2022 at 08:00, Alex G. wrote: On 1/9/22 8:39 AM, Heinrich Schuchardt wrote: The return type of EVP_PKEY_get0_RSA() is const struct rsa_st *. Our code drops the const qualifier leading to In file included from tools/lib/rsa/rsa-sign.c

Re: [PATCH] lib/rsa: avoid -Wdiscarded-qualifiers

2022-01-10 Thread Simon Glass
Hi, On Mon, 10 Jan 2022 at 08:00, Alex G. wrote: > > > > On 1/9/22 8:39 AM, Heinrich Schuchardt wrote: > > The return type of EVP_PKEY_get0_RSA() is const struct rsa_st *. > > Our code drops the const qualifier leading to > > > > In file included from tools/lib/rsa/rsa-sign.c:1: > > ./tools/../li

Re: [PATCH] lib/rsa: avoid -Wdiscarded-qualifiers

2022-01-10 Thread Heinrich Schuchardt
On 1/10/22 17:29, Tom Rini wrote: On Mon, Jan 10, 2022 at 05:22:15PM +0100, Heinrich Schuchardt wrote: On 1/10/22 17:12, Tom Rini wrote: On Mon, Jan 10, 2022 at 05:11:29PM +0100, Heinrich Schuchardt wrote: On 1/10/22 16:06, Tom Rini wrote: On Mon, Jan 10, 2022 at 09:00:29AM -0600, Alex G. wro

Re: [PATCH] lib/rsa: avoid -Wdiscarded-qualifiers

2022-01-10 Thread Tom Rini
On Mon, Jan 10, 2022 at 05:22:15PM +0100, Heinrich Schuchardt wrote: > On 1/10/22 17:12, Tom Rini wrote: > > On Mon, Jan 10, 2022 at 05:11:29PM +0100, Heinrich Schuchardt wrote: > > > On 1/10/22 16:06, Tom Rini wrote: > > > > On Mon, Jan 10, 2022 at 09:00:29AM -0600, Alex G. wrote: > > > > > > > >

Re: [PATCH] lib/rsa: avoid -Wdiscarded-qualifiers

2022-01-10 Thread Heinrich Schuchardt
On 1/10/22 17:12, Tom Rini wrote: On Mon, Jan 10, 2022 at 05:11:29PM +0100, Heinrich Schuchardt wrote: On 1/10/22 16:06, Tom Rini wrote: On Mon, Jan 10, 2022 at 09:00:29AM -0600, Alex G. wrote: On 1/9/22 8:39 AM, Heinrich Schuchardt wrote: The return type of EVP_PKEY_get0_RSA() is const str

Re: [PATCH] lib/rsa: avoid -Wdiscarded-qualifiers

2022-01-10 Thread Tom Rini
On Mon, Jan 10, 2022 at 05:11:29PM +0100, Heinrich Schuchardt wrote: > On 1/10/22 16:06, Tom Rini wrote: > > On Mon, Jan 10, 2022 at 09:00:29AM -0600, Alex G. wrote: > > > > > > > > > On 1/9/22 8:39 AM, Heinrich Schuchardt wrote: > > > > The return type of EVP_PKEY_get0_RSA() is const struct rsa_

Re: [PATCH] lib/rsa: avoid -Wdiscarded-qualifiers

2022-01-10 Thread Heinrich Schuchardt
On 1/10/22 16:06, Tom Rini wrote: On Mon, Jan 10, 2022 at 09:00:29AM -0600, Alex G. wrote: On 1/9/22 8:39 AM, Heinrich Schuchardt wrote: The return type of EVP_PKEY_get0_RSA() is const struct rsa_st *. Our code drops the const qualifier leading to In file included from tools/lib/rsa/rsa-sign

Re: [PATCH] lib/rsa: avoid -Wdiscarded-qualifiers

2022-01-10 Thread Tom Rini
On Mon, Jan 10, 2022 at 09:00:29AM -0600, Alex G. wrote: > > > On 1/9/22 8:39 AM, Heinrich Schuchardt wrote: > > The return type of EVP_PKEY_get0_RSA() is const struct rsa_st *. > > Our code drops the const qualifier leading to > > > > In file included from tools/lib/rsa/rsa-sign.c:1: > > ./tool

Re: [PATCH] lib/rsa: avoid -Wdiscarded-qualifiers

2022-01-10 Thread Alex G.
On 1/9/22 8:39 AM, Heinrich Schuchardt wrote: The return type of EVP_PKEY_get0_RSA() is const struct rsa_st *. Our code drops the const qualifier leading to In file included from tools/lib/rsa/rsa-sign.c:1: ./tools/../lib/rsa/rsa-sign.c: In function ‘rsa_add_verify_data’: ./tools/../lib/rsa/r

[PATCH] lib/rsa: avoid -Wdiscarded-qualifiers

2022-01-09 Thread Heinrich Schuchardt
The return type of EVP_PKEY_get0_RSA() is const struct rsa_st *. Our code drops the const qualifier leading to In file included from tools/lib/rsa/rsa-sign.c:1: ./tools/../lib/rsa/rsa-sign.c: In function ‘rsa_add_verify_data’: ./tools/../lib/rsa/rsa-sign.c:631:13: warning: assignment discards ‘con