Re: [PATCH] image.h: Change android_image_get_dtb* to use uint and not u32

2020-02-17 Thread Tom Rini
On Mon, Feb 17, 2020 at 04:45:57PM +0900, Masahiro Yamada wrote: > Hi Eugeniu, Tom, > > > On Mon, Feb 17, 2020 at 7:05 AM Eugeniu Rosca wrote: > > > > Hi Tom, > > > > On Sun, Feb 16, 2020 at 11:53:23AM -0500, Tom Rini wrote: > > > On Sun, Feb 16, 2020 at 05:23:14PM +0100, Eugeniu Rosca wrote: >

Re: [PATCH] image.h: Change android_image_get_dtb* to use uint and not u32

2020-02-17 Thread Eugeniu Rosca
Hello Yamada-san, Thank you for your precious thoughts! On Mon, Feb 17, 2020 at 04:45:57PM +0900, Masahiro Yamada wrote: > If you need a fixed-width type, > you can use uint32_t if you like. > > It is already used. See line 183 of include/image.h > > typedef struct image_header { > uin

Re: [PATCH] image.h: Change android_image_get_dtb* to use uint and not u32

2020-02-16 Thread Masahiro Yamada
Hi Eugeniu, Tom, On Mon, Feb 17, 2020 at 7:05 AM Eugeniu Rosca wrote: > > Hi Tom, > > On Sun, Feb 16, 2020 at 11:53:23AM -0500, Tom Rini wrote: > > On Sun, Feb 16, 2020 at 05:23:14PM +0100, Eugeniu Rosca wrote: > > > On Fri, Feb 14, 2020 at 12:38:19PM -0500, Tom Rini wrote: > > > > The image.h h

Re: [PATCH] image.h: Change android_image_get_dtb* to use uint and not u32

2020-02-16 Thread Eugeniu Rosca
Hi Tom, On Sun, Feb 16, 2020 at 11:53:23AM -0500, Tom Rini wrote: > On Sun, Feb 16, 2020 at 05:23:14PM +0100, Eugeniu Rosca wrote: > > On Fri, Feb 14, 2020 at 12:38:19PM -0500, Tom Rini wrote: > > > The image.h header can be used fairly widely in U-Boot builds. We > > > cannot use u32 here as it

Re: [PATCH] image.h: Change android_image_get_dtb* to use uint and not u32

2020-02-16 Thread Tom Rini
On Sun, Feb 16, 2020 at 05:23:14PM +0100, Eugeniu Rosca wrote: > Hi Tom, > Cc: Masahiro Yamada > > On Fri, Feb 14, 2020 at 12:38:19PM -0500, Tom Rini wrote: > > The image.h header can be used fairly widely in U-Boot builds. We > > cannot use u32 here as it may be used in cases where we don't have

Re: [PATCH] image.h: Change android_image_get_dtb* to use uint and not u32

2020-02-16 Thread Eugeniu Rosca
Hi Tom, Cc: Masahiro Yamada On Fri, Feb 14, 2020 at 12:38:19PM -0500, Tom Rini wrote: > The image.h header can be used fairly widely in U-Boot builds. We > cannot use u32 here as it may be used in cases where we don't have that > typedef available and don't want to expose it either. Use uint ins

[PATCH] image.h: Change android_image_get_dtb* to use uint and not u32

2020-02-14 Thread Tom Rini
The image.h header can be used fairly widely in U-Boot builds. We cannot use u32 here as it may be used in cases where we don't have that typedef available and don't want to expose it either. Use uint instead here. Cc: Eugeniu Rosca Cc: Sam Protsenko Signed-off-by: Tom Rini --- include/image