Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-28 Thread Andrew Jeffery
On Tue, 1 Mar 2022, at 08:42, Alex G. wrote: > On 2/27/22 19:29, Andrew Jeffery wrote: >> >> >> On Tue, 15 Feb 2022, at 13:55, Andrew Jeffery wrote: >>> On Tue, 15 Feb 2022, at 13:42, Dhananjay Phadke wrote: On 2/14/2022 3:13 PM, Patrick Williams wrote: > On Mon, Feb 14, 2022 at 11:14

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-28 Thread Alex G.
On 2/27/22 19:29, Andrew Jeffery wrote: On Tue, 15 Feb 2022, at 13:55, Andrew Jeffery wrote: On Tue, 15 Feb 2022, at 13:42, Dhananjay Phadke wrote: On 2/14/2022 3:13 PM, Patrick Williams wrote: On Mon, Feb 14, 2022 at 11:14:53AM -0800, Dhananjay Phadke wrote: There's a key-requirement polic

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-27 Thread Andrew Jeffery
On Tue, 15 Feb 2022, at 13:55, Andrew Jeffery wrote: > On Tue, 15 Feb 2022, at 13:42, Dhananjay Phadke wrote: >> On 2/14/2022 3:13 PM, Patrick Williams wrote: >>> On Mon, Feb 14, 2022 at 11:14:53AM -0800, Dhananjay Phadke wrote: There's a key-requirement policy already implemented [1].

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-14 Thread Patrick Williams
On Mon, Feb 14, 2022 at 11:14:53AM -0800, Dhananjay Phadke wrote: > On 2/13/2022 5:13 PM, Andrew Jeffery wrote: > > We can decouple HW RoT and runtime control on enforcing secure boot > (requiring one or keys) on FIT image. Conflating two raises lot of > questions. I won't claim to be a security

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-14 Thread Andrew Jeffery
On Tue, 15 Feb 2022, at 13:42, Dhananjay Phadke wrote: > On 2/14/2022 3:13 PM, Patrick Williams wrote: >> On Mon, Feb 14, 2022 at 11:14:53AM -0800, Dhananjay Phadke wrote: >>> There's a key-requirement policy already implemented [1]. >>> >>> [1] >>> https://lore.kernel.org/u-boot/cover.159764301

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-14 Thread Dhananjay Phadke
On 2/14/2022 3:13 PM, Patrick Williams wrote: On Mon, Feb 14, 2022 at 11:14:53AM -0800, Dhananjay Phadke wrote: On 2/13/2022 5:13 PM, Andrew Jeffery wrote: We can decouple HW RoT and runtime control on enforcing secure boot (requiring one or keys) on FIT image. Conflating two raises lot of ques

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-14 Thread Andrew Jeffery
On Tue, 15 Feb 2022, at 09:43, Patrick Williams wrote: > On Mon, Feb 14, 2022 at 11:14:53AM -0800, Dhananjay Phadke wrote: >> On 2/13/2022 5:13 PM, Andrew Jeffery wrote: >> >> We can decouple HW RoT and runtime control on enforcing secure boot >> (requiring one or keys) on FIT image. Conflating

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-14 Thread Andrew Jeffery
On Tue, 15 Feb 2022, at 05:44, Dhananjay Phadke wrote: > On 2/13/2022 5:13 PM, Andrew Jeffery wrote: >> Right, I think this question is an indication that I could write a more >> informative commit message, so if we converge on something acceptable >> I'll update it. Let me provide some more con

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-14 Thread Dhananjay Phadke
On 2/13/2022 5:13 PM, Andrew Jeffery wrote: Right, I think this question is an indication that I could write a more informative commit message, so if we converge on something acceptable I'll update it. Let me provide some more context: As mentioned above this is motivated by use with BMCs, speci

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-13 Thread Andrew Jeffery
Hi Alex, thanks for taking a look at the patch. On Sun, 13 Feb 2022, at 05:25, Alex G. wrote: > On 1/30/22 21:41, Andrew Jeffery wrote: >> Some platform designs include support for disabling secure-boot via a >> jumper on the board. Sometimes this control can be separate from the >> mechanism enab

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-12 Thread Alex G.
On 1/30/22 21:41, Andrew Jeffery wrote: Some platform designs include support for disabling secure-boot via a jumper on the board. Sometimes this control can be separate from the mechanism enabling the root-of-trust for the platform. Add support for this latter scenario by allowing boards to impl

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-08 Thread Andrew Jeffery
On Mon, 7 Feb 2022, at 11:37, ChiaWei Wang wrote: > Hi Andrew, > > I am curious about the usage scenario. > Is the runtime control required for production release? Yes. > As this control acts like a backdoor to bypass the chain-of-trust. Right, just as strap pin controlling the SB ROM in the

RE: [PATCH] image: Control FIT signature verification at runtime

2022-02-06 Thread ChiaWei Wang
Hi Andrew, I am curious about the usage scenario. Is the runtime control required for production release? As this control acts like a backdoor to bypass the chain-of-trust. If it is for debugging/development purposes, should we encourage the use of unsigned images under RD environments? Beyond th

[PATCH] image: Control FIT signature verification at runtime

2022-01-31 Thread Andrew Jeffery
Some platform designs include support for disabling secure-boot via a jumper on the board. Sometimes this control can be separate from the mechanism enabling the root-of-trust for the platform. Add support for this latter scenario by allowing boards to implement board_fit_image_require_verfied(), w