Re: [PATCH] gpio-uclass: fix gpio flags save condition

2021-02-05 Thread Simon Glass
Hi Köry, On Fri, 5 Feb 2021 at 07:48, Köry Maincent wrote: > > Hi Simon, > > On Thu, 4 Feb 2021 19:45:22 -0700 > Simon Glass wrote: > > > > Thank you for that. I think that is because dm_gpio_set_dir_flags() > > does not clear the flags first. But we now do actually update > > desc->flags, where

Re: [PATCH] gpio-uclass: fix gpio flags save condition

2021-02-05 Thread Köry Maincent
Hi Simon, On Thu, 4 Feb 2021 19:45:22 -0700 Simon Glass wrote: > Thank you for that. I think that is because dm_gpio_set_dir_flags() > does not clear the flags first. But we now do actually update > desc->flags, where as before it was just supposed to happen. So I > think this function needs to

Re: [PATCH] gpio-uclass: fix gpio flags save condition

2021-02-04 Thread Simon Glass
Hi Köry, On Mon, 25 Jan 2021 at 07:27, Köry Maincent wrote: > > Hello Simon, > > On Sun, 24 Jan 2021 13:24:14 -0700 > Simon Glass wrote: > > > Hi Kory, > > > > On Fri, 22 Jan 2021 at 08:23, Kory Maincent > > wrote: > > > > > > The commit cd2faeba1a moves the location where we save the flags to

Re: [PATCH] gpio-uclass: fix gpio flags save condition

2021-01-25 Thread Köry Maincent
Hello Simon, On Sun, 24 Jan 2021 13:24:14 -0700 Simon Glass wrote: > Hi Kory, > > On Fri, 22 Jan 2021 at 08:23, Kory Maincent wrote: > > > > The commit cd2faeba1a moves the location where we save the flags to the gpio > > descriptor but it adds a "!" character. > > This breaks the condition we

Re: [PATCH] gpio-uclass: fix gpio flags save condition

2021-01-24 Thread Simon Glass
Hi Kory, On Fri, 22 Jan 2021 at 08:23, Kory Maincent wrote: > > The commit cd2faeba1a moves the location where we save the flags to the gpio > descriptor but it adds a "!" character. > This breaks the condition we expect to save the flags. > > Signed-off-by: Kory Maincent > --- > drivers/gpio/g

[PATCH] gpio-uclass: fix gpio flags save condition

2021-01-22 Thread Kory Maincent
The commit cd2faeba1a moves the location where we save the flags to the gpio descriptor but it adds a "!" character. This breaks the condition we expect to save the flags. Signed-off-by: Kory Maincent --- drivers/gpio/gpio-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi