Re: [PATCH] gpio: zynq: Read using DATA register when direction is output

2025-06-02 Thread Michal Simek
On 4/10/25 10:25, Michal Simek wrote: From: Venkatesh Yadav Abbarapu Gpio status command reads the DATA_RO register rather than DATA registers even when the direction is "output", fix this by reading from DATA register when direction is "output". Signed-off-by: Nam Ian Signed-off-by: Venka

Re: [PATCH] gpio: zynq: Read using DATA register when direction is output

2025-04-10 Thread Heiko Schocher
Hello Michal, On 10.04.25 10:25, Michal Simek wrote: From: Venkatesh Yadav Abbarapu Gpio status command reads the DATA_RO register rather than DATA registers even when the direction is "output", fix this by reading from DATA register when direction is "output". Signed-off-by: Nam Ian Signed-

Re: [PATCH] gpio: zynq: Read using DATA register when direction is output

2025-04-10 Thread Mike Looijmans
That looks broken to me. When reading a GPIO pin, you want to get the actual state of the pin. Even though the output state may be driving it high, the actual pin may still be low because it's shorted to ground. M. On 10-04-2025 10:25, Michal Simek wrote: From: Venkatesh Yadav Abbarapu Gp

[PATCH] gpio: zynq: Read using DATA register when direction is output

2025-04-10 Thread Michal Simek
From: Venkatesh Yadav Abbarapu Gpio status command reads the DATA_RO register rather than DATA registers even when the direction is "output", fix this by reading from DATA register when direction is "output". Signed-off-by: Nam Ian Signed-off-by: Venkatesh Yadav Abbarapu Signed-off-by: Michal