Re: [PATCH] fastboot: Fix overflow when calculating chunk size

2021-05-26 Thread Tom Rini
On Fri, Apr 16, 2021 at 05:58:21PM -0400, Sean Anderson wrote: > If a chunk was larger than 4GiB, then chunk_data_sz would overflow and > blkcnt would not be calculated correctly. Upgrade it to a u64 and cast > its multiplicands as well. Also fix bytes_written while we're at it. > > Signed-off-by

Re: [PATCH] fastboot: Fix overflow when calculating chunk size

2021-05-26 Thread Lukasz Majewski
Hi Sean, > On 5/13/21 11:54 AM, Sean Anderson wrote: > > Hi Lukasz, > > > > Can this make it into 2020.07? Thanks, > > ping? Should Tom pick this up instead? > Yes, Tom please pick it up - as I will not prepare PR sooner than June. > --Sean > > > > > --Sean > > > > On 4/16/21 5:58 PM, Se

Re: [PATCH] fastboot: Fix overflow when calculating chunk size

2021-05-25 Thread Sean Anderson
On 5/13/21 11:54 AM, Sean Anderson wrote: Hi Lukasz, Can this make it into 2020.07? Thanks, ping? Should Tom pick this up instead? --Sean --Sean On 4/16/21 5:58 PM, Sean Anderson wrote: If a chunk was larger than 4GiB, then chunk_data_sz would overflow and blkcnt would not be calculat

Re: [PATCH] fastboot: Fix overflow when calculating chunk size

2021-05-13 Thread Sean Anderson
Hi Lukasz, Can this make it into 2020.07? Thanks, --Sean On 4/16/21 5:58 PM, Sean Anderson wrote: If a chunk was larger than 4GiB, then chunk_data_sz would overflow and blkcnt would not be calculated correctly. Upgrade it to a u64 and cast its multiplicands as well. Also fix bytes_written whil

Re: [PATCH] fastboot: Fix overflow when calculating chunk size

2021-04-19 Thread Sean Anderson
On 4/19/21 12:31 AM, Heiko Schocher wrote: > Hello Sean, > > On 16.04.21 23:58, Sean Anderson wrote: >> If a chunk was larger than 4GiB, then chunk_data_sz would overflow and >> blkcnt would not be calculated correctly. Upgrade it to a u64 and cast >> its multiplicands as well. Also fix bytes_w

Re: [PATCH] fastboot: Fix overflow when calculating chunk size

2021-04-18 Thread Heiko Schocher
Hello Sean, On 16.04.21 23:58, Sean Anderson wrote: > If a chunk was larger than 4GiB, then chunk_data_sz would overflow and > blkcnt would not be calculated correctly. Upgrade it to a u64 and cast > its multiplicands as well. Also fix bytes_written while we're at it. > > Signed-off-by: Sean Ande

[PATCH] fastboot: Fix overflow when calculating chunk size

2021-04-16 Thread Sean Anderson
If a chunk was larger than 4GiB, then chunk_data_sz would overflow and blkcnt would not be calculated correctly. Upgrade it to a u64 and cast its multiplicands as well. Also fix bytes_written while we're at it. Signed-off-by: Sean Anderson --- lib/image-sparse.c | 12 ++-- 1 file change