Re: [PATCH] efi_loader: fix ipv4 device path node conversion

2025-03-26 Thread Ilias Apalodimas
Thanks Vincent! On Mon, 24 Mar 2025 at 10:35, Vincent Stehlé wrote: > > When converting an IPv4 device path node to text, the > EFI_DEVICE_PATH_TO_TEXT_PROTOCOL will produce the following string: > > IPv4(5.6.7.8,TCP,UDP,0x6,DHCP,1.2.3.4,9.10.11.12,255.255.255.0) > > This string erroneously con

Re: [PATCH] efi_loader: fix ipv4 device path node conversion

2025-03-24 Thread Heinrich Schuchardt
On 24.03.25 09:34, Vincent Stehlé wrote: When converting an IPv4 device path node to text, the EFI_DEVICE_PATH_TO_TEXT_PROTOCOL will produce the following string: IPv4(5.6.7.8,TCP,UDP,0x6,DHCP,1.2.3.4,9.10.11.12,255.255.255.0) This string erroneously contains multiple protocols: TCP, UDP and

Re: [PATCH] efi_loader: fix ipv4 device path node conversion

2025-03-24 Thread Andre Przywara
On Mon, 24 Mar 2025 09:34:43 +0100 Vincent Stehlé wrote: Hi, Tom: I think this is v2025.04 material, as this code was introduced in this cycle. > When converting an IPv4 device path node to text, the > EFI_DEVICE_PATH_TO_TEXT_PROTOCOL will produce the following string: > > IPv4(5.6.7.8,TCP,U

[PATCH] efi_loader: fix ipv4 device path node conversion

2025-03-24 Thread Vincent Stehlé
When converting an IPv4 device path node to text, the EFI_DEVICE_PATH_TO_TEXT_PROTOCOL will produce the following string: IPv4(5.6.7.8,TCP,UDP,0x6,DHCP,1.2.3.4,9.10.11.12,255.255.255.0) This string erroneously contains multiple protocols: TCP, UDP and 0x6. Add the missing `break' statements in