Re: [PATCH] efi_loader: add comments on efi_file_from_path() regarding alignment

2022-11-10 Thread Heinrich Schuchardt
On 11/10/22 14:31, Ilias Apalodimas wrote: UEFI specification requires pointers that are passed to protocol member functions to be aligned. There's a u16_strdup in that function which doesn't make sense otherwise Add a comment so no one removes it accidentally Signed-off-by: Ilias Apalodimas

Re: [PATCH] efi_loader: add comments on efi_file_from_path() regarding alignment

2022-11-10 Thread Heinrich Schuchardt
On 11/10/22 15:09, Ilias Apalodimas wrote: Hi Heinrich On Thu, 10 Nov 2022 at 15:46, Heinrich Schuchardt wrote: On 11/10/22 14:31, Ilias Apalodimas wrote: UEFI specification requires pointers that are passed to protocol member functions to be aligned. There's a u16_strdup in that function w

Re: [PATCH] efi_loader: add comments on efi_file_from_path() regarding alignment

2022-11-10 Thread Ilias Apalodimas
Hi Heinrich On Thu, 10 Nov 2022 at 15:46, Heinrich Schuchardt wrote: > > On 11/10/22 14:31, Ilias Apalodimas wrote: > > UEFI specification requires pointers that are passed to protocol member > > functions to be aligned. There's a u16_strdup in that function which > > doesn't make sense otherwis

Re: [PATCH] efi_loader: add comments on efi_file_from_path() regarding alignment

2022-11-10 Thread Heinrich Schuchardt
On 11/10/22 14:31, Ilias Apalodimas wrote: UEFI specification requires pointers that are passed to protocol member functions to be aligned. There's a u16_strdup in that function which doesn't make sense otherwise Add a comment so no one removes it accidentally Signed-off-by: Ilias Apalodimas

[PATCH] efi_loader: add comments on efi_file_from_path() regarding alignment

2022-11-10 Thread Ilias Apalodimas
UEFI specification requires pointers that are passed to protocol member functions to be aligned. There's a u16_strdup in that function which doesn't make sense otherwise Add a comment so no one removes it accidentally Signed-off-by: Ilias Apalodimas --- lib/efi_loader/efi_file.c | 5 + 1 f