Re: [PATCH] efi_loader: Enable run-time variable support for tee based variables

2021-01-15 Thread Andreas Schwab
On Jan 15 2021, Ilias Apalodimas wrote: > Anyway removing -fpic should work as well, but I'd rather do this [1], > instead of relying on linker flags. It's not the linker that breaks this, but the compiler, by forcing GOT addressing. And it can easily break again any time. Andreas. -- Andreas

Re: [PATCH] efi_loader: Enable run-time variable support for tee based variables

2021-01-15 Thread Ilias Apalodimas
Hi Andreas, On Fri, Jan 15, 2021 at 05:34:04PM +0100, Andreas Schwab wrote: > On Jan 14 2021, Atish Patra wrote: > > > I am a bit confused how this will work. This means it will reside in GOT > > which is not mapped in virtual address for Linux. Whenever we try to > > invoke get_variable service,

Re: [PATCH] efi_loader: Enable run-time variable support for tee based variables

2021-01-15 Thread Andreas Schwab
On Jan 14 2021, Atish Patra wrote: > I am a bit confused how this will work. This means it will reside in GOT > which is not mapped in virtual address for Linux. Whenever we try to > invoke get_variable service, it will panic. > Did we miss a trick in RISC-V ? I think the problem really is that R

Re: [PATCH] efi_loader: Enable run-time variable support for tee based variables

2021-01-14 Thread Ilias Apalodimas
Hi Atish, > > > > diff --git a/lib/efi_loader/efi_var_mem.c b/lib/efi_loader/efi_var_mem.c > > index 7a2dba7dc263..fd97d5b56300 100644 > > --- a/lib/efi_loader/efi_var_mem.c > > +++ b/lib/efi_loader/efi_var_mem.c > > @@ -10,7 +10,7 @@ > > #include > > #include > > > > -static struct efi_var_fi

Re: [PATCH] efi_loader: Enable run-time variable support for tee based variables

2021-01-14 Thread Atish Patra
On Thu, Jul 23, 2020 at 12:53 AM Ilias Apalodimas wrote: > > We recently added functions for storing/restoring variables > from a file to a memory backed buffer marked as __efi_runtime_data > commit f1f990a8c958 ("efi_loader: memory buffer for variables") > commit 5f7dcf079de8 ("efi_loader: UEFI v

Re: [PATCH] efi_loader: Enable run-time variable support for tee based variables

2020-07-23 Thread ilias . apalodimas
On Thu, Jul 23, 2020 at 12:32:01PM +0200, Heinrich Schuchardt wrote: > On 23.07.20 09:53, Ilias Apalodimas wrote: > > We recently added functions for storing/restoring variables > > from a file to a memory backed buffer marked as __efi_runtime_data > > commit f1f990a8c958 ("efi_loader: memory buffe

Re: [PATCH] efi_loader: Enable run-time variable support for tee based variables

2020-07-23 Thread Heinrich Schuchardt
On 23.07.20 09:53, Ilias Apalodimas wrote: > We recently added functions for storing/restoring variables > from a file to a memory backed buffer marked as __efi_runtime_data > commit f1f990a8c958 ("efi_loader: memory buffer for variables") > commit 5f7dcf079de8 ("efi_loader: UEFI variable persisten

[PATCH] efi_loader: Enable run-time variable support for tee based variables

2020-07-23 Thread Ilias Apalodimas
We recently added functions for storing/restoring variables from a file to a memory backed buffer marked as __efi_runtime_data commit f1f990a8c958 ("efi_loader: memory buffer for variables") commit 5f7dcf079de8 ("efi_loader: UEFI variable persistence") Using the same idea we now can support GetVar