Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-26 Thread AKASHI Takahiro
Hi Michal, Sughosh, On Wed, Jul 26, 2023 at 06:36:56PM +0200, Michal Simek wrote: > > > On 7/26/23 15:07, Ilias Apalodimas wrote: > > Hi all > > > > [...] > > > > > > > > > > > > > > > Hello Sugosh, > > > > > > > > fwu_empty_capsule() detects an empty capsule as one with a GUID > > > > fwu_

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-26 Thread Ilias Apalodimas
Hi all [...] > > > > > > > Hello Sugosh, > > > > fwu_empty_capsule() detects an empty capsule as one with a GUID > > fwu_guid_os_request_fw_revert or fwu_guid_os_request_fw_accept. > > > > I am not aware of a requirement in the UEFI specification to treat > > capsules read from file in a differen

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-26 Thread Ilias Apalodimas
Hi Heinirch, On Tue, 18 Jul 2023 at 18:41, Heinrich Schuchardt wrote: > > On 13.07.23 16:35, Michal Simek wrote: > > Empty capsule are also allowed to be process. Without it updated images > > can't change their Image Acceptance state from no to yes. > > Is there any documentation describing the

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-26 Thread Michal Simek
On 7/26/23 15:07, Ilias Apalodimas wrote: Hi all [...] Hello Sugosh, fwu_empty_capsule() detects an empty capsule as one with a GUID fwu_guid_os_request_fw_revert or fwu_guid_os_request_fw_accept. I am not aware of a requirement in the UEFI specification to treat capsules read from fil

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-20 Thread AKASHI Takahiro
On Thu, Jul 20, 2023 at 10:42:10PM +0200, Heinrich Schuchardt wrote: > On 7/20/23 11:48, Sughosh Ganu wrote: > > On Thu, 20 Jul 2023 at 14:56, Michal Simek wrote: > > > > > > > > > > > > On 7/20/23 10:45, Sughosh Ganu wrote: > > > > On Thu, 20 Jul 2023 at 13:26, Michal Simek wrote: > > > > >

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-20 Thread Heinrich Schuchardt
On 7/20/23 11:48, Sughosh Ganu wrote: On Thu, 20 Jul 2023 at 14:56, Michal Simek wrote: On 7/20/23 10:45, Sughosh Ganu wrote: On Thu, 20 Jul 2023 at 13:26, Michal Simek wrote: On 7/20/23 08:36, Sughosh Ganu wrote: On Thu, 20 Jul 2023 at 11:37, Michal Simek wrote: Hi, On 7/20/23 07

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-20 Thread Sughosh Ganu
On Thu, 20 Jul 2023 at 14:56, Michal Simek wrote: > > > > On 7/20/23 10:45, Sughosh Ganu wrote: > > On Thu, 20 Jul 2023 at 13:26, Michal Simek wrote: > >> > >> > >> > >> On 7/20/23 08:36, Sughosh Ganu wrote: > >>> On Thu, 20 Jul 2023 at 11:37, Michal Simek wrote: > > Hi, > >

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-20 Thread Michal Simek
On 7/20/23 10:45, Sughosh Ganu wrote: On Thu, 20 Jul 2023 at 13:26, Michal Simek wrote: On 7/20/23 08:36, Sughosh Ganu wrote: On Thu, 20 Jul 2023 at 11:37, Michal Simek wrote: Hi, On 7/20/23 07:49, AKASHI Takahiro wrote: Hi, On Wed, Jul 19, 2023 at 08:28:41AM +0200, Michal Simek wr

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-20 Thread Sughosh Ganu
On Thu, 20 Jul 2023 at 13:26, Michal Simek wrote: > > > > On 7/20/23 08:36, Sughosh Ganu wrote: > > On Thu, 20 Jul 2023 at 11:37, Michal Simek wrote: > >> > >> Hi, > >> > >> On 7/20/23 07:49, AKASHI Takahiro wrote: > >>> Hi, > >>> > >>> On Wed, Jul 19, 2023 at 08:28:41AM +0200, Michal Simek wrote

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-20 Thread Michal Simek
On 7/20/23 08:36, Sughosh Ganu wrote: On Thu, 20 Jul 2023 at 11:37, Michal Simek wrote: Hi, On 7/20/23 07:49, AKASHI Takahiro wrote: Hi, On Wed, Jul 19, 2023 at 08:28:41AM +0200, Michal Simek wrote: On 7/18/23 17:41, Heinrich Schuchardt wrote: On 13.07.23 16:35, Michal Simek wrote:

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-19 Thread Sughosh Ganu
On Thu, 20 Jul 2023 at 11:37, Michal Simek wrote: > > Hi, > > On 7/20/23 07:49, AKASHI Takahiro wrote: > > Hi, > > > > On Wed, Jul 19, 2023 at 08:28:41AM +0200, Michal Simek wrote: > >> > >> > >> On 7/18/23 17:41, Heinrich Schuchardt wrote: > >>> On 13.07.23 16:35, Michal Simek wrote: > Empty

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-19 Thread Michal Simek
Hi, On 7/20/23 07:49, AKASHI Takahiro wrote: Hi, On Wed, Jul 19, 2023 at 08:28:41AM +0200, Michal Simek wrote: On 7/18/23 17:41, Heinrich Schuchardt wrote: On 13.07.23 16:35, Michal Simek wrote: Empty capsule are also allowed to be process. Without it updated images can't change their Imag

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-19 Thread AKASHI Takahiro
Hi, On Wed, Jul 19, 2023 at 08:28:41AM +0200, Michal Simek wrote: > > > On 7/18/23 17:41, Heinrich Schuchardt wrote: > > On 13.07.23 16:35, Michal Simek wrote: > > > Empty capsule are also allowed to be process. Without it updated images > > > can't change their Image Acceptance state from no to

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-18 Thread Michal Simek
On 7/18/23 17:41, Heinrich Schuchardt wrote: On 13.07.23 16:35, Michal Simek wrote: Empty capsule are also allowed to be process. Without it updated images can't change their Image Acceptance state from no to yes. Is there any documentation describing the usage of empty capsule to set the i

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-18 Thread Heinrich Schuchardt
On 13.07.23 16:35, Michal Simek wrote: Empty capsule are also allowed to be process. Without it updated images can't change their Image Acceptance state from no to yes. Is there any documentation describing the usage of empty capsule to set the image acceptance state? Best regards Heinrich

[PATCH] efi_loader: Allow also empty capsule to be process

2023-07-13 Thread Michal Simek
Empty capsule are also allowed to be process. Without it updated images can't change their Image Acceptance state from no to yes. Signed-off-by: Michal Simek --- lib/efi_loader/efi_capsule.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/efi_loader/efi_capsule.c b/lib