Re: [PATCH] dm: core: Fix incorrect flag check

2020-11-30 Thread Simon Glass
On Sun, 15 Nov 2020 at 13:23, Marek Vasut wrote: > > The test should be checking whether $flags are non-zero and $drv_flags > contain specific flags, however these two sets of flags are separate, > and the two tests should be logically ANDed, not bitwise ANDed. > > Signed-off-by: Marek Vasut > Cc

Re: [PATCH] dm: core: Fix incorrect flag check

2020-11-18 Thread Simon Glass
On Sun, 15 Nov 2020 at 13:23, Marek Vasut wrote: > > The test should be checking whether $flags are non-zero and $drv_flags > contain specific flags, however these two sets of flags are separate, > and the two tests should be logically ANDed, not bitwise ANDed. > > Signed-off-by: Marek Vasut > Cc

[PATCH] dm: core: Fix incorrect flag check

2020-11-15 Thread Marek Vasut
The test should be checking whether $flags are non-zero and $drv_flags contain specific flags, however these two sets of flags are separate, and the two tests should be logically ANDed, not bitwise ANDed. Signed-off-by: Marek Vasut Cc: Simon Glass --- drivers/core/device-remove.c | 2 +- 1 file