Re: [PATCH] checkpatch.pl: Reword IS_ENABLED() warning

2022-08-05 Thread Tom Rini
On Fri, Aug 05, 2022 at 10:48:17AM -0600, Simon Glass wrote: > Hi, > > On Fri, 5 Aug 2022 at 09:13, Tom Rini wrote: > > > > On Wed, Aug 03, 2022 at 09:43:00AM +0200, Rasmus Villemoes wrote: > > > On 02/08/2022 14.33, Tom Rini wrote: > > > > While there are good reasons to use 'if (IS_ENABLED(CONF

Re: [PATCH] checkpatch.pl: Reword IS_ENABLED() warning

2022-08-05 Thread Simon Glass
Hi, On Fri, 5 Aug 2022 at 09:13, Tom Rini wrote: > > On Wed, Aug 03, 2022 at 09:43:00AM +0200, Rasmus Villemoes wrote: > > On 02/08/2022 14.33, Tom Rini wrote: > > > While there are good reasons to use 'if (IS_ENABLED(CONFIG_...))' for > > > runtime tests, there's equally good reasons to use '#if

Re: [PATCH] checkpatch.pl: Reword IS_ENABLED() warning

2022-08-05 Thread Tom Rini
On Wed, Aug 03, 2022 at 09:43:00AM +0200, Rasmus Villemoes wrote: > On 02/08/2022 14.33, Tom Rini wrote: > > While there are good reasons to use 'if (IS_ENABLED(CONFIG_...))' for > > runtime tests, there's equally good reasons to use '#ifdef CONFIG_...' > > for build time tests. Reword this messag

Re: [PATCH] checkpatch.pl: Reword IS_ENABLED() warning

2022-08-03 Thread Rasmus Villemoes
On 02/08/2022 14.33, Tom Rini wrote: > While there are good reasons to use 'if (IS_ENABLED(CONFIG_...))' for > runtime tests, there's equally good reasons to use '#ifdef CONFIG_...' > for build time tests. Reword this message to hopefully avoid confusion. > > Cc: Simon Glass > Signed-off-by: Tom

Re: [PATCH] checkpatch.pl: Reword IS_ENABLED() warning

2022-08-02 Thread Simon Glass
On Tue, 2 Aug 2022 at 06:33, Tom Rini wrote: > > While there are good reasons to use 'if (IS_ENABLED(CONFIG_...))' for > runtime tests, there's equally good reasons to use '#ifdef CONFIG_...' > for build time tests. Reword this message to hopefully avoid confusion. > > Cc: Simon Glass > Signed-o

[PATCH] checkpatch.pl: Reword IS_ENABLED() warning

2022-08-02 Thread Tom Rini
While there are good reasons to use 'if (IS_ENABLED(CONFIG_...))' for runtime tests, there's equally good reasons to use '#ifdef CONFIG_...' for build time tests. Reword this message to hopefully avoid confusion. Cc: Simon Glass Signed-off-by: Tom Rini --- scripts/checkpatch.pl | 2 +- 1 file