Re: [PATCH] button: add udevice forward declaration

2021-02-22 Thread Neil Armstrong
On 20/02/2021 12:55, Simon Glass wrote: > On Fri, 19 Feb 2021 at 00:41, Neil Armstrong wrote: >> >> After 401d1c4f5d2d ("common: Drop asm/global_data.h from common header") >> build fails with : >> >> drivers/button/button-uclass.c:13:5: error: conflicting types for >> 'button_get_by_label' >> in

Re: [PATCH] button: add udevice forward declaration

2021-02-20 Thread Simon Glass
On Fri, 19 Feb 2021 at 00:41, Neil Armstrong wrote: > > After 401d1c4f5d2d ("common: Drop asm/global_data.h from common header") > build fails with : > > drivers/button/button-uclass.c:13:5: error: conflicting types for > 'button_get_by_label' > int button_get_by_label(const char *label, struct u

[PATCH] button: add udevice forward declaration

2021-02-18 Thread Neil Armstrong
After 401d1c4f5d2d ("common: Drop asm/global_data.h from common header") build fails with : drivers/button/button-uclass.c:13:5: error: conflicting types for 'button_get_by_label' int button_get_by_label(const char *label, struct udevice **devp) ^~~ Adding struct udevice forw