Re: [PATCH] binman: Skip node generation for images read from files

2022-01-30 Thread Simon Glass
Hi Jan, On Fri, 28 Jan 2022 at 12:37, Jan Kiszka wrote: > > From: Jan Kiszka > > We can and should run the node generator only when creating a new image. > When we read it back, there is no need to generate nodes - they already > exits, and binman does not dive that deep into the image - and the

[PATCH] binman: Skip node generation for images read from files

2022-01-28 Thread Jan Kiszka
From: Jan Kiszka We can and should run the node generator only when creating a new image. When we read it back, there is no need to generate nodes - they already exits, and binman does not dive that deep into the image - and there is no way to provide the required fdt-list. So store the mode in

Re: [PATCH] binman: Skip node generation for images read from files

2022-01-16 Thread Simon Glass
Hi Jan, On Sun, 16 Jan 2022 at 08:51, Jan Kiszka wrote: > > From: Jan Kiszka > > This unbreaks all read-backs of images that contain generator nodes in > their fdtmap. This issue is subtle enough that I think it could use a few lines of explanation. > > Signed-off-by: Jan Kiszka > --- > > I t

[PATCH] binman: Skip node generation for images read from files

2022-01-16 Thread Jan Kiszka
From: Jan Kiszka This unbreaks all read-backs of images that contain generator nodes in their fdtmap. Signed-off-by: Jan Kiszka --- I tried to write some test case as well, but the testsuite is too fragile and too non-intuitive to me to extend it. E.g., just adding a fdtmap to 170_fit_fdt.dts