Re: [PATCH] arm: mvebu: spl: Always fallback to BootROM boot method

2022-08-09 Thread Stefan Roese
On 02.08.22 11:55, Pali Rohár wrote: BootROM boot method should always work so always add it as fallback method to spl_boot_list. In case U-Boot SPI driver fails it is better to try using BootROM than hanging as by default only one boot method is specified. Signed-off-by: Pali Rohár Applied t

Re: [PATCH] arm: mvebu: spl: Always fallback to BootROM boot method

2022-08-05 Thread Pali Rohár
On Thursday 04 August 2022 16:06:30 Tony Dinh wrote: > Hi Pali, > > Follow up on the topic of slow/fast SPL SPI loading. > > common/spl/spl_spi.c > /* > * Load U-Boot image from SPI flash into RAM > * In DM mode: defaults speed and mode will be > * taken from DT

Re: [PATCH] arm: mvebu: spl: Always fallback to BootROM boot method

2022-08-04 Thread Tony Dinh
Hi Pali, Follow up on the topic of slow/fast SPL SPI loading. common/spl/spl_spi.c /* * Load U-Boot image from SPI flash into RAM * In DM mode: defaults speed and mode will be * taken from DT when available */ flash = spi_flash_probe(sf_bus, sf_

Re: [PATCH] arm: mvebu: spl: Always fallback to BootROM boot method

2022-08-03 Thread Tony Dinh
Hi Pali, On Wed, Aug 3, 2022 at 3:24 AM Pali Rohár wrote: > > On Tuesday 02 August 2022 15:13:13 Tony Dinh wrote: > > Hi Pali, > > > > On Tue, Aug 2, 2022 at 3:00 PM Pali Rohár wrote: > > > > > > Hello! We have tested that A385 BootROM on Turris Omnia board is much > > > slower when reading prop

Re: [PATCH] arm: mvebu: spl: Always fallback to BootROM boot method

2022-08-03 Thread Pali Rohár
On Tuesday 02 August 2022 15:13:13 Tony Dinh wrote: > Hi Pali, > > On Tue, Aug 2, 2022 at 3:00 PM Pali Rohár wrote: > > > > Hello! We have tested that A385 BootROM on Turris Omnia board is much > > slower when reading proper U-Boot from SPI NOR than native SPL SPI > > driver. > > > > If you have

Re: [PATCH] arm: mvebu: spl: Always fallback to BootROM boot method

2022-08-02 Thread Stefan Roese
On 02.08.22 11:55, Pali Rohár wrote: BootROM boot method should always work so always add it as fallback method to spl_boot_list. In case U-Boot SPI driver fails it is better to try using BootROM than hanging as by default only one boot method is specified. Signed-off-by: Pali Rohár Reviewed-

Re: [PATCH] arm: mvebu: spl: Always fallback to BootROM boot method

2022-08-02 Thread Tony Dinh
Hi Pali, On Tue, Aug 2, 2022 at 3:00 PM Pali Rohár wrote: > > Hello! We have tested that A385 BootROM on Turris Omnia board is much > slower when reading proper U-Boot from SPI NOR than native SPL SPI > driver. > > If you have different test results on A385, could you check SPI speed > used by U-

Re: [PATCH] arm: mvebu: spl: Always fallback to BootROM boot method

2022-08-02 Thread Pali Rohár
Hello! We have tested that A385 BootROM on Turris Omnia board is much slower when reading proper U-Boot from SPI NOR than native SPL SPI driver. If you have different test results on A385, could you check SPI speed used by U-Boot? I think that CONFIG_SF_DEFAULT_SPEED should define it. For Omnia we

Re: [PATCH] arm: mvebu: spl: Always fallback to BootROM boot method

2022-08-02 Thread Tony Dinh
Hi Pali, It works great! An observation: BootROM boot method is a lot faster than SPL SPI driver method on this Armada 385 board. The BootROM took a fraction of a second to load the u-boot image. SPL SPI driver took a few seconds to load. Perhaps the SPI flash speed vs some probing code in SPL SP

[PATCH] arm: mvebu: spl: Always fallback to BootROM boot method

2022-08-02 Thread Pali Rohár
BootROM boot method should always work so always add it as fallback method to spl_boot_list. In case U-Boot SPI driver fails it is better to try using BootROM than hanging as by default only one boot method is specified. Signed-off-by: Pali Rohár --- arch/arm/mach-mvebu/spl.c | 7 +++ 1 file