Re: [PATCH] USB: Fix NULLPTR dereference when serial# is unset

2025-01-27 Thread Marek Vasut
On 1/28/25 12:12 AM, Michael wrote: The problem can be reproduced with U-Boot's sandbox with the default config. Then, run the following commands at the shell: Hit any key to stop autoboot: 0 => env set serial# test => env default -f serial# at which point the program will crash. Maybe the fix

Re: [PATCH] USB: Fix NULLPTR dereference when serial# is unset

2025-01-27 Thread Michael
The problem can be reproduced with U-Boot's sandbox with the default config. Then, run the following commands at the shell: Hit any key to stop autoboot: 0 => env set serial# test => env default -f serial# at which point the program will crash. The following change will show that the env default

Re: [PATCH] USB: Fix NULLPTR dereference when serial# is unset

2025-01-27 Thread Marek Vasut
On 1/27/25 10:07 PM, Michael Ferolito wrote: The current behaviour of this function will dereference a null pointer if the serial# environment variable is unset. This was discovered on a board where U-Boot did not have access to the first 256MB of ram, resulting in a board crash. In the event tha

[PATCH] USB: Fix NULLPTR dereference when serial# is unset

2025-01-27 Thread Michael Ferolito
The current behaviour of this function will dereference a null pointer if the serial# environment variable is unset. This was discovered on a board where U-Boot did not have access to the first 256MB of ram, resulting in a board crash. In the event that U-Boot has full access to memory, it will sti