Re: [PATCH] Revert "fdtdec: drop needlessly convoluted CONFIG_PHANDLE_CHECK_SEQ"

2023-04-24 Thread Simon Glass
Hi Rasmus, On Tue, 18 Apr 2023 at 23:30, Rasmus Villemoes wrote: > > On 19/04/2023 03.49, Simon Glass wrote: > > Hi Rasmus, > > > > Returning to this old thread... > > > >> > >> There's no problematic device tree, having two nodes with the same > >> (base)name is perfectly fine and in fact someti

Re: [PATCH] Revert "fdtdec: drop needlessly convoluted CONFIG_PHANDLE_CHECK_SEQ"

2023-04-18 Thread Rasmus Villemoes
On 19/04/2023 03.49, Simon Glass wrote: > Hi Rasmus, > > Returning to this old thread... > >> >> There's no problematic device tree, having two nodes with the same >> (base)name is perfectly fine and in fact sometimes expected/required (in >> the cases where a node name is standardized; e.g. havi

Re: [PATCH] Revert "fdtdec: drop needlessly convoluted CONFIG_PHANDLE_CHECK_SEQ"

2023-04-18 Thread Simon Glass
Hi Rasmus, On Mon, 1 Aug 2022 at 07:13, Rasmus Villemoes wrote: > > On 31/07/2022 15.28, Tom Rini wrote: > > On Sat, Jul 30, 2022 at 07:27:26PM -0600, Simon Glass wrote: > >> Hi Tom, > >> > > >> Shall I pick it up for the upcoming release? > > > > I don't think we should pick up the revert as I d

Re: [PATCH] Revert "fdtdec: drop needlessly convoluted CONFIG_PHANDLE_CHECK_SEQ"

2022-08-01 Thread Rasmus Villemoes
On 31/07/2022 15.28, Tom Rini wrote: > On Sat, Jul 30, 2022 at 07:27:26PM -0600, Simon Glass wrote: >> Hi Tom, >> >> Shall I pick it up for the upcoming release? > > I don't think we should pick up the revert as I don't think there's > agreement that reverting this is the right step forward among

Re: [PATCH] Revert "fdtdec: drop needlessly convoluted CONFIG_PHANDLE_CHECK_SEQ"

2022-07-31 Thread Tom Rini
On Sat, Jul 30, 2022 at 07:27:26PM -0600, Simon Glass wrote: > Hi Tom, > > On Tue, 5 Jul 2022 at 10:42, Simon Glass wrote: > > > > Hi Rasmus, > > > > On Tue, 5 Jul 2022 at 07:47, Rasmus Villemoes > > wrote: > > > > > > On 05/07/2022 11.47, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Su

Re: [PATCH] Revert "fdtdec: drop needlessly convoluted CONFIG_PHANDLE_CHECK_SEQ"

2022-07-30 Thread Simon Glass
Hi Tom, On Tue, 5 Jul 2022 at 10:42, Simon Glass wrote: > > Hi Rasmus, > > On Tue, 5 Jul 2022 at 07:47, Rasmus Villemoes > wrote: > > > > On 05/07/2022 11.47, Simon Glass wrote: > > > Hi Tom, > > > > > > On Sun, 3 Jul 2022 at 06:43, Tom Rini wrote: > > >> > > >> On Sun, Jul 03, 2022 at 02:32:42

Re: [PATCH] Revert "fdtdec: drop needlessly convoluted CONFIG_PHANDLE_CHECK_SEQ"

2022-07-05 Thread Simon Glass
Hi Rasmus, On Tue, 5 Jul 2022 at 07:47, Rasmus Villemoes wrote: > > On 05/07/2022 11.47, Simon Glass wrote: > > Hi Tom, > > > > On Sun, 3 Jul 2022 at 06:43, Tom Rini wrote: > >> > >> On Sun, Jul 03, 2022 at 02:32:42AM -0600, Simon Glass wrote: > >>> Hi, > >>> > >>> On Sun, 3 Jul 2022 at 02:25, S

Re: [PATCH] Revert "fdtdec: drop needlessly convoluted CONFIG_PHANDLE_CHECK_SEQ"

2022-07-05 Thread Rasmus Villemoes
On 05/07/2022 11.47, Simon Glass wrote: > Hi Tom, > > On Sun, 3 Jul 2022 at 06:43, Tom Rini wrote: >> >> On Sun, Jul 03, 2022 at 02:32:42AM -0600, Simon Glass wrote: >>> Hi, >>> >>> On Sun, 3 Jul 2022 at 02:25, Simon Glass wrote: The fdt_path_offset() function is slow since it must sca

Re: [PATCH] Revert "fdtdec: drop needlessly convoluted CONFIG_PHANDLE_CHECK_SEQ"

2022-07-05 Thread Simon Glass
Hi Tom, On Sun, 3 Jul 2022 at 06:43, Tom Rini wrote: > > On Sun, Jul 03, 2022 at 02:32:42AM -0600, Simon Glass wrote: > > Hi, > > > > On Sun, 3 Jul 2022 at 02:25, Simon Glass wrote: > > > > > > The fdt_path_offset() function is slow since it must scan the tree. > > > This substantial overhead no

Re: [PATCH] Revert "fdtdec: drop needlessly convoluted CONFIG_PHANDLE_CHECK_SEQ"

2022-07-03 Thread Tom Rini
On Sun, Jul 03, 2022 at 02:32:42AM -0600, Simon Glass wrote: > Hi, > > On Sun, 3 Jul 2022 at 02:25, Simon Glass wrote: > > > > The fdt_path_offset() function is slow since it must scan the tree. > > This substantial overhead now applies to all boards. > > > > The original code may not be ideal bu

Re: [PATCH] Revert "fdtdec: drop needlessly convoluted CONFIG_PHANDLE_CHECK_SEQ"

2022-07-03 Thread Simon Glass
Hi, On Sun, 3 Jul 2022 at 02:25, Simon Glass wrote: > > The fdt_path_offset() function is slow since it must scan the tree. > This substantial overhead now applies to all boards. > > The original code may not be ideal but it is fit for purpose and is only > needed on a few boards. > > We should r

[PATCH] Revert "fdtdec: drop needlessly convoluted CONFIG_PHANDLE_CHECK_SEQ"

2022-07-03 Thread Simon Glass
The fdt_path_offset() function is slow since it must scan the tree. This substantial overhead now applies to all boards. The original code may not be ideal but it is fit for purpose and is only needed on a few boards. We should revert this in time for the release. This reverts commit 26f981f295d