Re: [PATCH] Add support for SHA384 and SHA512

2020-06-12 Thread Tom Rini
On Thu, Apr 16, 2020 at 05:36:52PM +1200, Reuben Dowle wrote: > The current recommendation for best security practice from the US government > is to use SHA384 for TOP SECRET [1]. > > This patch adds support for SHA384 and SHA512 in the hash command, and also > allows FIT images to be hashed with

Re: [PATCH] Add support for SHA384 and SHA512

2020-06-05 Thread Tom Rini
On Fri, May 29, 2020 at 04:47:23PM +1200, Reuben Dowle wrote: > > Two general comments. First, please use CONFIG_IS_ENABLED() to test for > > the new symbols so that we won't have any growth in SPL if we have one > > of these enabled in the main binary but NOT SPL. > > It is not clear to me how

Re: [PATCH] Add support for SHA384 and SHA512

2020-05-28 Thread Reuben Dowle
> Two general comments. First, please use CONFIG_IS_ENABLED() to test for > the new symbols so that we won't have any growth in SPL if we have one > of these enabled in the main binary but NOT SPL. It is not clear to me how I should be using CONFIG_IS_ENABLED(). I have copied the pattern of macro

Re: [PATCH] Add support for SHA384 and SHA512

2020-04-27 Thread Reuben Dowle
On Sat, 25 Apr 2020 at 03:08, Tom Rini wrote: > > Two general comments. First, please use CONFIG_IS_ENABLED() to test for > the new symbols so that we won't have any growth in SPL if we have one > of these enabled in the main binary but NOT SPL. Second, please > make sure that all new files have

Re: [PATCH] Add support for SHA384 and SHA512

2020-04-24 Thread Tom Rini
On Fri, Apr 17, 2020 at 08:19:04AM +1200, Reuben Dowle wrote: > The current recommendation for best security practice from the US government > is to use SHA384 for TOP SECRET [1]. > > This patch adds support for SHA384 and SHA512 in the hash command, and also > allows FIT images to be hashed with

[PATCH] Add support for SHA384 and SHA512

2020-04-16 Thread Reuben Dowle
The current recommendation for best security practice from the US government is to use SHA384 for TOP SECRET [1]. This patch adds support for SHA384 and SHA512 in the hash command, and also allows FIT images to be hashed with these algorithms, and signed with sha384,rsa and sha512,rsa The

[PATCH] Add support for SHA384 and SHA512

2020-04-16 Thread Reuben Dowle
The current recommendation for best security practice from the US government is to use SHA384 for TOP SECRET [1]. This patch adds support for SHA384 and SHA512 in the hash command, and also allows FIT images to be hashed with these algorithms, and signed with sha384,rsa and sha512,rsa The