Re: Fwd: [PATCH] [RFC] cmd: i2c: fix default address len for DM_I2C

2022-08-18 Thread Nicolas IOOSS
Hello all, On Tue, Aug 16, 2022 at 1:47 PM Simon Glass wrote: > > Hi Tim, > > On Tue, 16 Aug 2022 at 13:50, Tim Harvey wrote: > > > > On Mon, Aug 15, 2022 at 3:16 PM Simon Glass wrote: > > > > > > Hi Tim, > > > > > > On Mon, 15 Aug 2022 at 11:48, Tim Harvey wrote: > > > > > > > > On Sat, Aug

Re: Fwd: [PATCH] [RFC] cmd: i2c: fix default address len for DM_I2C

2022-08-17 Thread Simon Glass
Hi Nicolas, On Wed, 17 Aug 2022 at 13:50, Nicolas IOOSS wrote: > > Hello all, > > On Tue, Aug 16, 2022 at 1:47 PM Simon Glass wrote: > > > > Hi Tim, > > > > On Tue, 16 Aug 2022 at 13:50, Tim Harvey wrote: > > > > > > On Mon, Aug 15, 2022 at 3:16 PM Simon Glass wrote: > > > > > > > > Hi Tim, >

Re: [PATCH] [RFC] cmd: i2c: fix default address len for DM_I2C

2022-08-16 Thread Simon Glass
Hi Tim, On Tue, 16 Aug 2022 at 13:50, Tim Harvey wrote: > > On Mon, Aug 15, 2022 at 3:16 PM Simon Glass wrote: > > > > Hi Tim, > > > > On Mon, 15 Aug 2022 at 11:48, Tim Harvey wrote: > > > > > > On Sat, Aug 13, 2022 at 7:59 AM Simon Glass wrote: > > > > > > > > Hi Tim, > > > > > > > > On Thu,

Re: [PATCH] [RFC] cmd: i2c: fix default address len for DM_I2C

2022-08-16 Thread Tim Harvey
On Mon, Aug 15, 2022 at 3:16 PM Simon Glass wrote: > > Hi Tim, > > On Mon, 15 Aug 2022 at 11:48, Tim Harvey wrote: > > > > On Sat, Aug 13, 2022 at 7:59 AM Simon Glass wrote: > > > > > > Hi Tim, > > > > > > On Thu, 11 Aug 2022 at 11:57, Tim Harvey wrote: > > > > > > > > According to the comment

Re: [PATCH] [RFC] cmd: i2c: fix default address len for DM_I2C

2022-08-15 Thread Simon Glass
Hi Tim, On Mon, 15 Aug 2022 at 11:48, Tim Harvey wrote: > > On Sat, Aug 13, 2022 at 7:59 AM Simon Glass wrote: > > > > Hi Tim, > > > > On Thu, 11 Aug 2022 at 11:57, Tim Harvey wrote: > > > > > > According to the comment block "The default {addr} parameter is one byte > > > (.1) which works well

Re: [PATCH] [RFC] cmd: i2c: fix default address len for DM_I2C

2022-08-15 Thread Tim Harvey
On Sat, Aug 13, 2022 at 7:59 AM Simon Glass wrote: > > Hi Tim, > > On Thu, 11 Aug 2022 at 11:57, Tim Harvey wrote: > > > > According to the comment block "The default {addr} parameter is one byte > > (.1) which works well for memories and registers with 8 bits of address > > space." > > > > While

Re: [PATCH] [RFC] cmd: i2c: fix default address len for DM_I2C

2022-08-13 Thread Simon Glass
Hi Tim, On Thu, 11 Aug 2022 at 11:57, Tim Harvey wrote: > > According to the comment block "The default {addr} parameter is one byte > (.1) which works well for memories and registers with 8 bits of address > space." > > While this is true for legacy I2C a default length of -1 is being passed > f

[PATCH] [RFC] cmd: i2c: fix default address len for DM_I2C

2022-08-11 Thread Tim Harvey
According to the comment block "The default {addr} parameter is one byte (.1) which works well for memories and registers with 8 bits of address space." While this is true for legacy I2C a default length of -1 is being passed for DM_I2C which results in a usage error. Restore the documented behav