Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-14 Thread Dragan Simic
On 2024-02-14 11:01, Shantur Rathore wrote: On Wed, Feb 14, 2024 at 9:56 AM Shantur Rathore wrote: On Wed, Feb 14, 2024 at 3:48 AM Dragan Simic wrote: > On 2024-02-14 04:18, Dragan Simic wrote: > > On 2024-02-14 03:04, Andre Przywara wrote: > >> On Mon, 12 Feb 2024 21:19:13 +0100 Marek Vasut

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-14 Thread Shantur Rathore
On Wed, Feb 14, 2024 at 9:56 AM Shantur Rathore wrote: > > On Wed, Feb 14, 2024 at 3:48 AM Dragan Simic wrote: > > > > Hello Shantur and Marek, > > > > On 2024-02-14 04:18, Dragan Simic wrote: > > > On 2024-02-14 03:04, Andre Przywara wrote: > > >> On Mon, 12 Feb 2024 21:19:13 +0100 Marek Vasut

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-14 Thread Shantur Rathore
On Wed, Feb 14, 2024 at 3:48 AM Dragan Simic wrote: > > Hello Shantur and Marek, > > On 2024-02-14 04:18, Dragan Simic wrote: > > On 2024-02-14 03:04, Andre Przywara wrote: > >> On Mon, 12 Feb 2024 21:19:13 +0100 Marek Vasut wrote: > >>> On 2/12/24 14:41, Shantur Rathore wrote: > >>> > On Mon, Fe

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-13 Thread Dragan Simic
Hello Shantur and Marek, On 2024-02-14 04:18, Dragan Simic wrote: On 2024-02-14 03:04, Andre Przywara wrote: On Mon, 12 Feb 2024 21:19:13 +0100 Marek Vasut wrote: On 2/12/24 14:41, Shantur Rathore wrote: > On Mon, Feb 12, 2024 at 1:40 PM Shantur Rathore wrote: >> On Sat, Feb 10, 2024 at 7:13

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-13 Thread Dragan Simic
Hello Andre, On 2024-02-14 03:04, Andre Przywara wrote: On Mon, 12 Feb 2024 21:19:13 +0100 Marek Vasut wrote: On 2/12/24 14:41, Shantur Rathore wrote: > On Mon, Feb 12, 2024 at 1:40 PM Shantur Rathore wrote: >> On Sat, Feb 10, 2024 at 7:13 AM Dragan Simic wrote: >>> On 2024-02-08 15:17, Drag

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-13 Thread Andre Przywara
On Mon, 12 Feb 2024 21:19:13 +0100 Marek Vasut wrote: > On 2/12/24 14:41, Shantur Rathore wrote: > > On Mon, Feb 12, 2024 at 1:40 PM Shantur Rathore wrote: > >> > >> Thanks Dragan, > >> > >> On Sat, Feb 10, 2024 at 7:13 AM Dragan Simic wrote: > >>> > >>> Hello Shantur, > >>> > >>> On 2024-0

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-13 Thread Marek Vasut
On 2/13/24 04:59, Dragan Simic wrote: On 2024-02-13 00:33, Marek Vasut wrote: On 2/12/24 22:10, Dragan Simic wrote: On 2024-02-12 21:19, Marek Vasut wrote: On 2/12/24 14:41, Shantur Rathore wrote: On Mon, Feb 12, 2024 at 1:40 PM Shantur Rathore wrote: On Sat, Feb 10, 2024 at 7:13 AM Dragan S

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-12 Thread Dragan Simic
On 2024-02-13 00:33, Marek Vasut wrote: On 2/12/24 22:10, Dragan Simic wrote: On 2024-02-12 21:19, Marek Vasut wrote: On 2/12/24 14:41, Shantur Rathore wrote: On Mon, Feb 12, 2024 at 1:40 PM Shantur Rathore wrote: On Sat, Feb 10, 2024 at 7:13 AM Dragan Simic wrote: On 2024-02-08 15:17, Dra

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-12 Thread Marek Vasut
On 2/12/24 22:10, Dragan Simic wrote: Hello Marek, Andre and Shantur, On 2024-02-12 21:19, Marek Vasut wrote: On 2/12/24 14:41, Shantur Rathore wrote: On Mon, Feb 12, 2024 at 1:40 PM Shantur Rathore wrote: On Sat, Feb 10, 2024 at 7:13 AM Dragan Simic wrote: On 2024-02-08 15:17, Dragan Simi

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-12 Thread Dragan Simic
Hello Marek, Andre and Shantur, On 2024-02-12 21:19, Marek Vasut wrote: On 2/12/24 14:41, Shantur Rathore wrote: On Mon, Feb 12, 2024 at 1:40 PM Shantur Rathore wrote: On Sat, Feb 10, 2024 at 7:13 AM Dragan Simic wrote: On 2024-02-08 15:17, Dragan Simic wrote: On 2024-02-08 15:10, Shantur

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-12 Thread Marek Vasut
On 2/12/24 14:41, Shantur Rathore wrote: On Mon, Feb 12, 2024 at 1:40 PM Shantur Rathore wrote: Thanks Dragan, On Sat, Feb 10, 2024 at 7:13 AM Dragan Simic wrote: Hello Shantur, On 2024-02-08 15:17, Dragan Simic wrote: On 2024-02-08 15:10, Shantur Rathore wrote: On Thu, Feb 8, 2024 at 1

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-12 Thread Dragan Simic
Hello Shantur, On 2024-02-12 14:40, Shantur Rathore wrote: On Sat, Feb 10, 2024 at 7:13 AM Dragan Simic wrote: On 2024-02-08 15:17, Dragan Simic wrote: > On 2024-02-08 15:10, Shantur Rathore wrote: >> On Thu, Feb 8, 2024 at 1:44 PM Dragan Simic >> wrote: >>> On 2024-02-08 14:33, Marek Vasut w

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-12 Thread Shantur Rathore
On Mon, Feb 12, 2024 at 1:40 PM Shantur Rathore wrote: > > Thanks Dragan, > > On Sat, Feb 10, 2024 at 7:13 AM Dragan Simic wrote: > > > > Hello Shantur, > > > > On 2024-02-08 15:17, Dragan Simic wrote: > > > On 2024-02-08 15:10, Shantur Rathore wrote: > > >> On Thu, Feb 8, 2024 at 1:44 PM Dragan

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-12 Thread Shantur Rathore
Thanks Dragan, On Sat, Feb 10, 2024 at 7:13 AM Dragan Simic wrote: > > Hello Shantur, > > On 2024-02-08 15:17, Dragan Simic wrote: > > On 2024-02-08 15:10, Shantur Rathore wrote: > >> On Thu, Feb 8, 2024 at 1:44 PM Dragan Simic > >> wrote: > >>> On 2024-02-08 14:33, Marek Vasut wrote: > >>> > On

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-09 Thread Dragan Simic
Hello Shantur, On 2024-02-08 15:17, Dragan Simic wrote: On 2024-02-08 15:10, Shantur Rathore wrote: On Thu, Feb 8, 2024 at 1:44 PM Dragan Simic wrote: On 2024-02-08 14:33, Marek Vasut wrote: > On 2/8/24 12:30, Shantur Rathore wrote: >> On Wed, Feb 7, 2024 at 1:07 PM Marek Vasut wrote: >>> On

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-08 Thread Dragan Simic
On 2024-02-08 15:10, Shantur Rathore wrote: On Thu, Feb 8, 2024 at 1:44 PM Dragan Simic wrote: On 2024-02-08 14:33, Marek Vasut wrote: > On 2/8/24 12:30, Shantur Rathore wrote: >> On Wed, Feb 7, 2024 at 1:07 PM Marek Vasut wrote: >>> On 2/7/24 11:23, Shantur Rathore wrote: USB 3.0 spec re

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-08 Thread Shantur Rathore
On Thu, Feb 8, 2024 at 1:44 PM Dragan Simic wrote: > > On 2024-02-08 14:33, Marek Vasut wrote: > > On 2/8/24 12:30, Shantur Rathore wrote: > >> On Wed, Feb 7, 2024 at 1:07 PM Marek Vasut wrote: > >>> On 2/7/24 11:23, Shantur Rathore wrote: > USB 3.0 spec requires hub to reset device while >

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-08 Thread Dragan Simic
On 2024-02-08 14:33, Marek Vasut wrote: On 2/8/24 12:30, Shantur Rathore wrote: On Wed, Feb 7, 2024 at 1:07 PM Marek Vasut wrote: On 2/7/24 11:23, Shantur Rathore wrote: USB 3.0 spec requires hub to reset device while enumeration. Some USB 2.0 hubs / devices don't handle this well and after i

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-08 Thread Marek Vasut
On 2/8/24 12:30, Shantur Rathore wrote: Hi Marek, On Wed, Feb 7, 2024 at 1:07 PM Marek Vasut wrote: On 2/7/24 11:23, Shantur Rathore wrote: USB 3.0 spec requires hub to reset device while enumeration. Some USB 2.0 hubs / devices don't handle this well and after implementation of reset some U

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-08 Thread Shantur Rathore
Hi Marek, On Wed, Feb 7, 2024 at 1:07 PM Marek Vasut wrote: > > On 2/7/24 11:23, Shantur Rathore wrote: > > USB 3.0 spec requires hub to reset device while > > enumeration. Some USB 2.0 hubs / devices don't > > handle this well and after implementation of > > reset some USB 2.0 disks weren't dete

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-07 Thread Dragan Simic
On 2024-02-07 14:14, Dragan Simic wrote: Hello Shantur, Please see my notes below. On 2024-02-07 11:23, Shantur Rathore wrote: USB 3.0 spec requires hub to reset device while enumeration. Some USB 2.0 hubs / devices don't handle this well and after implementation of reset some USB 2.0 disks we

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-07 Thread Dragan Simic
Hello Shantur, Please see my notes below. On 2024-02-07 11:23, Shantur Rathore wrote: USB 3.0 spec requires hub to reset device while enumeration. Some USB 2.0 hubs / devices don't handle this well and after implementation of reset some USB 2.0 disks weren't detected on Allwinner based boards.

Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-07 Thread Marek Vasut
On 2/7/24 11:23, Shantur Rathore wrote: USB 3.0 spec requires hub to reset device while enumeration. Some USB 2.0 hubs / devices don't handle this well and after implementation of reset some USB 2.0 disks weren't detected on Allwinner based boards. Resetting only when hub is USB 3.0 fixes it.

[FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-07 Thread Shantur Rathore
USB 3.0 spec requires hub to reset device while enumeration. Some USB 2.0 hubs / devices don't handle this well and after implementation of reset some USB 2.0 disks weren't detected on Allwinner based boards. Resetting only when hub is USB 3.0 fixes it. Tested-by: Andre Przywara Signed-off-by: