Re: [BUG] issues with new bootflow, uefi and virtio

2023-09-23 Thread Simon Glass
Hi Vincent, On Tue, 11 Apr 2023 at 06:00, Vincent Stehlé wrote: > > On Fri, Apr 07, 2023 at 05:31:06PM +1200, Simon Glass wrote: > .. > > > When combined with the patch from Mathew[1], it does indeed repair the > > > case of > > > efi boot with two virtio disks, specifically when the first virti

Re: [BUG] issues with new bootflow, uefi and virtio

2023-05-10 Thread Simon Glass
Hi Vincent, On Mon, 24 Apr 2023 at 13:44, Simon Glass wrote: > > Hi Vincent, > > On Tue, 11 Apr 2023 at 06:00, Vincent Stehlé wrote: > > > > On Fri, Apr 07, 2023 at 05:31:06PM +1200, Simon Glass wrote: > > .. > > > > When combined with the patch from Mathew[1], it does indeed repair the > > > >

Re: [BUG] issues with new bootflow, uefi and virtio

2023-04-24 Thread Simon Glass
Hi Vincent, On Tue, 11 Apr 2023 at 06:00, Vincent Stehlé wrote: > > On Fri, Apr 07, 2023 at 05:31:06PM +1200, Simon Glass wrote: > .. > > > When combined with the patch from Mathew[1], it does indeed repair the > > > case of > > > efi boot with two virtio disks, specifically when the first virti

Re: [BUG] issues with new bootflow, uefi and virtio

2023-04-11 Thread Vincent Stehlé
On Fri, Apr 07, 2023 at 05:31:06PM +1200, Simon Glass wrote: .. > > When combined with the patch from Mathew[1], it does indeed repair the case > > of > > efi boot with two virtio disks, specifically when the first virtio disk is > > the > > one we want to boot from. > > FWIW, the system will not

Re: [BUG] issues with new bootflow, uefi and virtio

2023-04-06 Thread Simon Glass
Hi Vincent, On Thu, 6 Apr 2023 at 22:05, Vincent Stehlé wrote: > > On Thu, Apr 06, 2023 at 06:38:16AM +1200, Simon Glass wrote: > (virtio device number 31 vs. blk index 0) > > This is strange. Can you try 'dm uclass' to see the sequence number > > for the virtio device? I would expect it to be 0,

Re: [BUG] issues with new bootflow, uefi and virtio

2023-04-06 Thread Simon Glass
Hi Mathew, On Thu, 6 Apr 2023 at 12:25, Mathew McBride wrote: > > Hi Vincent, > > On Thu, Apr 6, 2023, at 1:04 AM, Vincent Stehlé wrote: > > Hi, > > > > I am hitting an issue with the new bootflow when booting with UEFI from a > > virtio device on Qemu Arm. > > > > It seems the device number comp

Re: [BUG] issues with new bootflow, uefi and virtio

2023-04-06 Thread Vincent Stehlé
On Thu, Apr 06, 2023 at 06:38:16AM +1200, Simon Glass wrote: (virtio device number 31 vs. blk index 0) > This is strange. Can you try 'dm uclass' to see the sequence number > for the virtio device? I would expect it to be 0, but I might not > fully understand virtio. Hi Simon, Thank you for looki

Re: [BUG] issues with new bootflow, uefi and virtio

2023-04-06 Thread Vincent Stehlé
On Thu, Apr 06, 2023 at 10:25:15AM +1000, Mathew McBride wrote: .. > I came across the exact same issue a few days ago. Below is a patch which I > believe fixes the problem, by using the devnum of blk uclass (virtio 0) > instead of the sequence number of the parent udevice (e.g virtio-blk#35). Hi

Re: [BUG] issues with new bootflow, uefi and virtio

2023-04-05 Thread Mathew McBride
Hi Vincent, On Thu, Apr 6, 2023, at 1:04 AM, Vincent Stehlé wrote: > Hi, > > I am hitting an issue with the new bootflow when booting with UEFI from a > virtio device on Qemu Arm. > > It seems the device number computation in efiload_read_file() does not work > in the general virtio case, where

Re: [BUG] issues with new bootflow, uefi and virtio

2023-04-05 Thread Simon Glass
Hi Vincent, On Thu, 6 Apr 2023 at 03:05, Vincent Stehlé wrote: > > Hi, > > I am hitting an issue with the new bootflow when booting with UEFI from a > virtio device on Qemu Arm. > > It seems the device number computation in efiload_read_file() does not work > in the general virtio case, where it

[BUG] issues with new bootflow, uefi and virtio

2023-04-05 Thread Vincent Stehlé
Hi, I am hitting an issue with the new bootflow when booting with UEFI from a virtio device on Qemu Arm. It seems the device number computation in efiload_read_file() does not work in the general virtio case, where it will pick the virtio device number instead of the block device index. On Qemu a