[U-Boot] [PATCH] mflash: Initial mflash support

d SoC doesn't have IDE bus) This driver support mflash IO mode. Followings are brief descriptions about IO mode. 1. IO mode based on ATA protocol and uses some custom command. (read confirm, write confirm) 2. IO mode uses SRAM bus interface. Signed-off-by: unsik Kim --- This is all-in-one mf

Re: [U-Boot] [U-BOOT][PATCH 1/3] mflash : Fix some style issue

Hello? I attached "all-in-one" rebased, squashed patch for your request. Regards, unsik Kim >From 53292a06d57fcd93fa508c5c698bca5b60a19691 Mon Sep 17 00:00:00 2001 From: unsik Kim Date: Wed, 18 Feb 2009 14:31:49 +0900 Subject: [PATCH 09/13] Initial mflash support Mflash is

[U-Boot] [U-BOOT][PATCH 4/4] mflash : Support word unaligned access

Signed-off-by: unsik Kim --- drivers/block/mg_disk.c | 38 ++ drivers/block/mg_disk_prv.h |5 + 2 files changed, 31 insertions(+), 12 deletions(-) diff --git a/drivers/block/mg_disk.c b/drivers/block/mg_disk.c index 113aa79..b74307a 100644

[U-Boot] [U-BOOT][PATCH 3/4] mflash : Use common libata function

replace mg_ident_cpy to ata_id_c_string Signed-off-by: unsik Kim --- doc/README.mflash |1 + drivers/block/mg_disk.c | 67 -- 2 files changed, 13 insertions(+), 55 deletions(-) diff --git a/doc/README.mflash b/doc/README.mflash index

[U-Boot] [U-BOOT][PATCH 2/4] mflash : Fix uncorrect mask operation

Signed-off-by: unsik Kim --- drivers/block/mg_disk.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/block/mg_disk.c b/drivers/block/mg_disk.c index 26b6a80..1f9debe 100644 --- a/drivers/block/mg_disk.c +++ b/drivers/block/mg_disk.c @@ -385,7 +385,7

[U-Boot] [U-BOOT][PATCH 1/4] mflash : Change MG_BASE define to inline function

Signed-off-by: unsik Kim --- drivers/block/mg_disk.c | 45 - 1 files changed, 24 insertions(+), 21 deletions(-) diff --git a/drivers/block/mg_disk.c b/drivers/block/mg_disk.c index bbfeeda..26b6a80 100644 --- a/drivers/block/mg_disk.c +++ b

Re: [U-Boot] [PATCH 1/3] Initial mflash support

your thought exactly. If I remove mg_get_drv_data() default weak function and just add weak attribute to it's prototype, build works well but it's logically same as original one. User still don't get any information at build time. Do you want to just lea

[U-Boot] [U-BOOT][PATCH 3/3] mflash : Improve mg_disk_read(write) sector count calculation

Signed-off-by: unsik Kim --- drivers/block/mg_disk.c | 16 1 files changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/block/mg_disk.c b/drivers/block/mg_disk.c index 2eb461d..bbfeeda 100644 --- a/drivers/block/mg_disk.c +++ b/drivers/block/mg_disk.c @@ -382,12

[U-Boot] [U-BOOT][PATCH 2/3] mflash : Remove deprecated CONFIG_SYS_HZ value (not 1000), support code

Signed-off-by: unsik Kim --- drivers/block/mg_disk.c | 21 +++-- 1 files changed, 3 insertions(+), 18 deletions(-) diff --git a/drivers/block/mg_disk.c b/drivers/block/mg_disk.c index 9ae8889..2eb461d 100644 --- a/drivers/block/mg_disk.c +++ b/drivers/block/mg_disk.c

[U-Boot] [U-BOOT][PATCH 1/3] mflash : Fix some style issue

Signed-off-by: unsik Kim --- common/env_mgdisk.c |2 ++ drivers/block/mg_disk.c | 13 + 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/common/env_mgdisk.c b/common/env_mgdisk.c index 2b4949f..363ee68 100644 --- a/common/env_mgdisk.c +++ b/common

Re: [U-Boot] [PATCH 2/3] Change CONFIG_MG_DISK_RES unit to KB

This series of patches are logically same as my previous mails. Wolfgang Denx requested splitting. Please refer, <20090211213208.c53be832e...@gemini.denx.de> Regards, unsik Kim Jean-Christophe PLAGNIOL-VILLARD wrote: > On 20:06 Fri 13 Feb , unsik Kim wrote: >> Byte is too

Re: [U-Boot] [PATCH 1/3] Initial mflash support

ink changing MG_DBG to debug might confuse other driver's debug message. If u-boot policy only allow debug(x), I'll follow. >> +err = mg_do_read_sects(buff_ptr, sect_num, residue); >> +} >> + >> +return err; >> +} >> +/* must override this function */ >> +struct mg_drv_data * __attribute__((weak)) mg_get_drv_data (void) >> +{ >> +puts ("### WARNING ### port mg_get_drv_data function\n"); >> +return NULL; >> +} > please do an compile error not a run time error IMHO, compile error (or warning) is not a good choice for this case. Compile time error always generate error even though override function exist. Also mg_disk_init() function will generate run time error when weak function used. Typically, users will be read README.mflash that explains how to override this function and finally port appropriately. Regards, unsik Kim ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [U-BOOT][PATCH 2/3] Change CONFIG_MG_DISK_RES unit to KB

Byte is too small unit for CONFIG_MG_DISK_RES and also needs sector size alignment. Signed-off-by: unsik Kim --- doc/README.mflash | 10 +- drivers/block/mg_disk.c | 10 +++--- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/doc/README.mflash b/doc

[U-Boot] [U-BOOT][PATCH 1/3] Initial mflash support

d SoC doesn't have IDE bus) This driver support mflash IO mode. Followings are brief descriptions about IO mode. 1. IO mode based on ATA protocol and uses some custom command. (read confirm, write confirm) 2. IO mode uses SRAM bus interface. Signed-off-by: unsik Kim --- commo

[U-Boot] [U-BOOT][PATCH 3/3] Fix miscalculated total sectors

When using CONFIG_MG_DISK_RES, total sectors should be recalculated. Signed-off-by: unsik Kim --- drivers/block/mg_disk.c | 18 ++ 1 files changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/block/mg_disk.c b/drivers/block/mg_disk.c index e1b1a68..193a441 100644

[U-Boot] [U-BOOT][PATCH 0/3] mflash u-boot support

ignore all the mflash related previous patches. <57afda040901052341g3b00f741r445c0ce8d33b7...@mail.gmail.com> <57afda040902020032h760174adja5ecba853ef68...@mail.gmail.com> <57afda04090209l2bb9027bvbebf67795a7ad...@mail.gmail.com> Signed-off-by: uns

Re: [U-Boot] [PATCH] mflash u-boot support (a little change)

Hello? I fixed miscalculated total sectors when using reserve area feature. Also I changed CONFIG_MG_DISK_RES's unit to KB. (Byte is too small and also needs sector size alignment.) Any comments will be appreciated. Signed-off-by: unsik Kim --- common/Makefile |2 + c

Re: [U-Boot] [PATCH] mflash u-boot support

SYS_HZ is not 1000 (samsung s3c24xx, intel pxa25x, pxa27x) and get_timer() just return elapsed tick of OS timer. For the compatibility of these, I use #ifdef. Any comments, advice will be appreciated. Here is fixed patch. unsik Kim Signed-off-by: unsik Kim --- common/Makefile

[U-Boot] [PATCH] Fix ext2 non-working

Hello, all? Currently ext2ls, ext2load not working (I think sometimes it will work.) The reason is incorrect operations of ext2fs_read_inode and ext2fs_blockgroup. I fix miscalculated block number(blkno) and offset (blkoff), and some hard coded values. unsik Kim Signed-off-by: unsik Kim

[U-Boot] [PATCH] mflash u-boot support

ad confirm, write confirm) 2. IO mode uses SRAM bus interface. This driver tested some ARM platform. (pxa270, s3c2440, ...) Any comments, help would be very appreciated. ^^ unsik Kim Signed-off-by: unsik Kim --- 2 0 common/Makefile 83 0 common/cmd_mgdisk.c 2 1