Re: [PATCH] spi: cadence_qspi: Fix odd byte write issue in STIG mode

2025-07-02 Thread Sean Anderson
On 7/2/25 00:59, Venkatesh Yadav Abbarapu wrote: Starting from 'commit <8077d296adff> ("spi: cadence-quadspi: Use STIG mode for all ops with small payload") the utilization of STIG mode has been implemented for read and write operations involving less than 8 bytes of data. However, following thi

Re: [PATCH 1/1] doc: RISC-V supports semihosting

2025-05-08 Thread Sean Anderson
4a3-56231fc0ae28&rct=1746591449&auth=d807158c60b7d2502abde8a2fc01f40662980862-c560455b43c648ed3d71f92bb5fc9467eabb905a>`_ > and This link is dead. Can you update it to [1] while you're at it? Thanks. --Sean [1] https://github.com/ARM-software/abi-aa/blob/main/semihosting

Re: Invalid SPDX License Identifier for test/lib/strlcat.c

2025-03-01 Thread Sean Anderson
erik As noted in the comment, this is adapted from glibc. The referenced file is licensed LGPL 2.1+. So license in this file should really be whatever the compatible version of the GPL is (I guess 2.0+). --Sean

Re: [PATCH] spl: return kernel image header size in os boot

2025-02-24 Thread Sean Anderson
rn size; + return actread; } Reviewed-by: Sean Anderson

Re: [BUG report] spl: image size check fails in spl_load()

2025-02-20 Thread Sean Anderson
On 2/20/25 00:22, Anshul Dalal wrote: On Wed Feb 19, 2025 at 9:17 PM IST, Sean Anderson wrote: On 2/18/25 01:07, Anshul Dalal wrote: On Sat Feb 15, 2025 at 11:18 PM IST, Sean Anderson wrote: On 2/14/25 06:12, Anshul Dalal wrote: Hi all! I was trying to implement falcon boot on TI AM62x EVM

Re: [BUG report] spl: image size check fails in spl_load()

2025-02-19 Thread Sean Anderson
On 2/18/25 01:07, Anshul Dalal wrote: On Sat Feb 15, 2025 at 11:18 PM IST, Sean Anderson wrote: On 2/14/25 06:12, Anshul Dalal wrote: Hi all! I was trying to implement falcon boot on TI AM62x EVM with the kernel image on SD card's filesystem but the following check in `_spl_load` at `in

Re: [BUG report] spl: image size check fails in spl_load()

2025-02-15 Thread Sean Anderson
s could be to move the length check to spl_load_info->read. This would involve updating all the callers and callees. --Sean

Re: FIT signature security flay

2024-10-25 Thread Sean Anderson
c41-4950-4369-b35b-dfbad134e05e&auth=d807158c60b7d2502abde8a2fc01f40662980862-da2f573d80b6a54ab9f8699b0376fb4e503517ea > ] > > Hi Sean, > Thanks for replying. > Of course, I have public key embedded into u-boot dtb. > I see it with dtdiff utility clearly., that it has rsa co

Re: FIT signature security flay

2024-10-14 Thread Sean Anderson
Hi Lev, On 10/14/24 04:42, Lev R. Oshvang wrote: > Hi Sean, > > I am looking for help with Uboot FIT signatures problem > > > > I started to work with FIT image (u-boot 2024) and managed to sign > kernel and load this image with Uboot using 'require

Re: [PATCH v2 3/4] dm: core: migrate debug() messages to use dm_warn

2024-10-02 Thread Sean Anderson
t on boot times. A config going from "may print out a few more lines of extra info" to "firehose" is very surprising to users (as evidenced by Alexander's email). If you can't figure out which lines to disable, I recommend simply reverting the patch. --Sean

Re: [PATCH] spl: spl_load: fix comparison between negative error code and unsigned size

2024-09-10 Thread Sean Anderson
On 8/30/24 23:17, Daniel Palmer wrote: read could be a negative error value but size in spl_image is unsigned so when they are compared read is used as if it's a unsigned value and if it's negative it'll most likely be bigger than size and the result will be true and _spl_load() will return 0 to

Re: [PATCH v2] spl: ram: hide SPL_RAM_SUPPORT

2024-09-10 Thread Sean Anderson
y device support. The ROM code will load and execute Reviewed-by: Sean Anderson

Re: [PATCH] spl: ram: hide SPL_RAM_SUPPORT

2024-09-10 Thread Sean Anderson
depends on SPL_RAM_SUPPORT + select SPL_RAM_SUPPORT default y if MICROBLAZE || ARCH_SOCFPGA || ARCH_TEGRA || ARCH_ZYNQ help Enable booting of an image already loaded in RAM. The image has to I think SPL_DFU should also select SPL_RAM_SUPPORT --Sean

Re: [PATCH] spl: ram: fix build warning when neither RAM_DEVICE nor DFU are enabled

2024-09-09 Thread Sean Anderson
On 9/9/24 09:22, Jerome Forissier wrote: Fixes the following warning: common/spl/spl_ram.c:19:14: warning: ‘spl_ram_load_read’ defined but not used [-Wunused-function] 19 | static ulong spl_ram_load_read(struct spl_load_info *load, ulong sector, | ^ Do

[PATCH v2 2/2] arm: zynqmp: Enable non-invasive CCI-400 PMU debug

2024-09-05 Thread Sean Anderson
Set NIDEN, enabling non-invasive debug for the CCI-400 PMU. Otherwise, the PMU is effectively disabled. Signed-off-by: Sean Anderson Reviewed-by: Michal Simek --- (no changes since v1) arch/arm/mach-zynqmp/include/mach/hardware.h | 3 +++ board/xilinx/zynqmp/zynqmp.c | 4

[PATCH v2 1/2] zynqmp: Disable secure access for boot devices

2024-09-05 Thread Sean Anderson
Boot devices (QSPI, MMC, NAND, and Ethernet) use secure access for DMA by default. As this causes problems when using the SMMU [1], configure them for normal access instead. [1] https://support.xilinx.com/s/article/72164 Signed-off-by: Sean Anderson --- Changes in v2: - Don't set reserved

[PATCH v2 0/2] arm: zynqmp: Initialize some registers at boot

2024-09-05 Thread Sean Anderson
These patches are independent in intent, but they modify adjacent lines so I have sent them as a series. Changes in v2: - Don't set reserved bits in AXI_RPRTCN, since QSPI doesn't use ARPROT Sean Anderson (2): zynqmp: Disable secure access for boot devices arm: zynqmp: Enable no

Re: [PATCH 1/2] zynqmp: Disable secure access for boot devices

2024-09-03 Thread Sean Anderson
On 9/2/24 04:43, Michal Simek wrote: > > > On 8/13/24 00:07, Sean Anderson wrote: >> >> Boot devices (QSPI, MMC, NAND, and Ethernet) use secure access for DMA >> by default. As this causes problems when using the SMMU [1], configure >> them for norma

Re: Assistance with U-Boot Compilation Error

2024-08-26 Thread Sean Anderson
look forward to any advice you might offer Thanks in advance, Reyders PD: I wrote to you because I use the get_maintainer.pl script and they show these names. Please CC the U-Boot mailing list. --Sean

Re: [PATCH 09/21] test: Update NAND test to avoid extra macros

2024-08-17 Thread Sean Anderson
make sure both tests run even if one fails. They flashes have different sizes/geometries/ecc and it's definitely possible for some regression to happen for one but not the other. Having two test cases makes it easy to see this. --Sean

Re: [PATCH] spl: fix error handling of spl_fit_read

2024-08-17 Thread Sean Anderson
gt;read(info, offset, ALIGN(sizeof(*header), spl_get_bl_len(info)), header); Does [1] fix your problem? --Sean [1] https://lore.kernel.org/u-boot/20240731130913.487121-1-fvent...@comcast.net/

[PATCH v3] sandbox: Fix pinmux warnings with non-test devicetrees

2024-08-15 Thread Sean Anderson
avoid ENODEV errors. Then, convert the pin groups and functions to the new style, adding onewire group as well. Fixes: 7f0f1806e3a ("test: pinmux: Add test for pin muxing") Closes: https://source.denx.de/u-boot/u-boot/-/issues/2 Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- Chang

[PATCH v2] sandbox: Fix pinmux warnings with non-test devicetrees

2024-08-15 Thread Sean Anderson
ting Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- Changes in v2: - Only add the pinctrl node pre-relocation, as SPL/VPL try to run dtoc on all nodes included in their device trees. arch/sandbox/dts/sandbox.dtsi| 14 -- drivers/pinctrl/pinctrl-sandbox.c

[PATCH 2/2] arm: zynqmp: Enable non-invasive CCI-400 PMU debug

2024-08-12 Thread Sean Anderson
Set NIDEN, enabling non-invasive debug for the CCI-400 PMU. Otherwise, the PMU is effectively disabled. Signed-off-by: Sean Anderson --- arch/arm/mach-zynqmp/include/mach/hardware.h | 3 +++ board/xilinx/zynqmp/zynqmp.c | 4 2 files changed, 7 insertions(+) diff --git a

[PATCH 1/2] zynqmp: Disable secure access for boot devices

2024-08-12 Thread Sean Anderson
Boot devices (QSPI, MMC, NAND, and Ethernet) use secure access for DMA by default. As this causes problems when using the SMMU [1], configure them for normal access instead. [1] https://support.xilinx.com/s/article/72164 Signed-off-by: Sean Anderson --- arch/arm/mach-zynqmp/include/mach

[PATCH 0/2] arm: zynqmp: Initialize some registers at boot

2024-08-12 Thread Sean Anderson
These patches are independent in intent, but they modify adjacent lines so I have sent them as a series. Sean Anderson (2): zynqmp: Disable secure access for boot devices arm: zynqmp: Enable non-invasive CCI-400 PMU debug arch/arm/mach-zynqmp/include/mach/hardware.h | 5 + board/xilinx

[PATCH] pinmux: generic: Use ENOENT instead of ENOSYS

2024-08-10 Thread Sean Anderson
ENOSYS should only be used when a subsystem is completely absent. Convert its use in pinctrl-generic to ENOENT, which better reflects the error condition (that a function/group/pin is missing). Signed-off-by: Sean Anderson --- drivers/pinctrl/pinctrl-generic.c | 26

[PATCH] sandbox: Fix pinmux warnings with non-test devicetrees

2024-08-10 Thread Sean Anderson
avoid ENODEV errors. Then, convert the pin groups and functions to the new style, adding onewire group as well. Fixes: 7f0f1806e3a ("test: pinmux: Add test for pin muxing") Signed-off-by: Sean Anderson --- arch/sandbox/dts/sandbox.dtsi| 14 -- drivers/

Re: pinctrl warning on sandbox

2024-08-09 Thread Sean Anderson
Hi Simon, On 8/7/24 19:17, Simon Glass wrote: Hi Sean, I was looking at [1] and bisected the message to this commit: 7f0f1806e3a (refs/bisect/bad) test: pinmux: Add test for pin muxing I'm not quite sure what is going on, but could you please take a look? Regards, Simon [1]

Re: [PATCH v2] mmc: fix signed vs unsigned compare in read check in _spl_load()

2024-07-31 Thread Sean Anderson
ge_info *spl_image, read = info->read(info, offset, ALIGN(sizeof(*header), spl_get_bl_len(info)), header); - if (read < sizeof(*header)) + if (read < (int)sizeof(*header)) return -EIO; if (image_get_magic(header) == FDT_MAGIC) { Reviewed-by: Sean Anderson

Re: [PATCH v1] mmc: fix signed vs unsigned compare in read check in _spl_load()

2024-07-31 Thread Sean Anderson
(image_get_magic(header) == FDT_MAGIC) { Since read and int and sizeof(*header) < INT_MAX, I think the best solution is to cast the latter to an int. --Sean

Re: [PATCH 11/14] spl: mmc: Try to clean up raw-mode options

2024-07-20 Thread Sean Anderson
On 7/20/24 02:17, Simon Glass wrote: Make the raw-mode options depend on SPL_SYS_MMCSD_RAW_MODE in a more direct way. This makes it easier to understand the options with 'make menuconfig'. There are three different ways of specifying the offset: - sector offset - partition number - partition ty

Re: [PATCH 14/14] blk: Correct comment for blk_get_devnum_by_uclass_idname()

2024-07-20 Thread Sean Anderson
); /** * blk_dselect_hwpart() - select a hardware partition Reviewed-by: Sean Anderson

Re: [PATCH 13/14] spl: Create a function to init spl_load_info

2024-07-20 Thread Sean Anderson
On 7/20/24 02:17, Simon Glass wrote: Rather than having every caller set this up individually, create a common init function. This allows new fields to be added without the risk of them being left uninited. What is the code size impact of this? IIRC the reason why I didn't do this is to avoid

Re: [PATCH 12/14] spl: Use unified inline functions for spl_load_info

2024-07-20 Thread Sean Anderson
quot;); -} #endif +} /* * We need to know the position of U-Boot in memory so we can jump to it. We Reviewed-by: Sean Anderson

Re: [PATCH 10/14] spl: mmc: Adjust args of spl_mmc_find_device()

2024-07-20 Thread Sean Anderson
v); if (ret) return ret; Aside from the above, Reviewed-by: Sean Anderson

Re: [PATCH 09/14] spl: mmc: Handle error codes consistently

2024-07-20 Thread Sean Anderson
On 7/20/24 02:17, Simon Glass wrote: Use 'ret' as the return code, since it may not be an error and this is the common name in U-Boot. Make sure to return the error code when given, rather than transforming it into -1 (-EPERM). Does this transformation affect code size? Signed-off-by: Simon G

Re: [PATCH 08/14] spl: mmc: Drop checks for CONFIG_SPL_LIBCOMMON_SUPPORT

2024-07-20 Thread Sean Anderson
n err; } /* Fall through */ @@ -428,10 +412,8 @@ int spl_mmc_load(struct spl_image_info *spl_image, break; #endif -#ifdef CONFIG_SPL_LIBCOMMON_SUPPORT default: puts("spl: mmc: wrong boot mode\n"); -#endif } return err; Reviewed-by: Sean Anderson

Re: [PATCH 07/14] log: Avoid including function names by default

2024-07-20 Thread Sean Anderson
.."); ut_assert_console_end(); free(buf); Anyway, the rest looks fine. This probably breaks the use case of someone turning on function names at runtime, so maybe we will need to split this config if someone cares. --Sean

Re: [PATCH 06/14] mmc: Use logging instead of pr_err()

2024-07-20 Thread Sean Anderson
} } @@ -2975,7 +2976,7 @@ int mmc_start_init(struct mmc *mmc) if (no_card) { mmc->has_init = 0; #if !defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_LIBCOMMON_SUPPORT) - pr_err("MMC: no card present\n"); + log_err("MMC: no card present\n"); #endif return -ENOMEDIUM; } @@ -3104,7 +3105,7 @@ static int mmc_probe(struct bd_info *bis) uclass_foreach_dev(dev, uc) { ret = device_probe(dev); if (ret) - pr_err("%s - probe failed: %d\n", dev->name, ret); + log_err("%s - probe failed: %d\n", dev->name, ret); } return 0; Reviewed-by: Sean Anderson

Re: [PATCH 05/14] mmc: Use logging instead of printf()

2024-07-20 Thread Sean Anderson
On 7/20/24 02:16, Simon Glass wrote: The code makes quite a few uses of __func__ which puts the function name into the resulting SPL image. Use the log subsystem instead, to reduce size. The CONFIG_LOGF_FUNC option can be used to enable the function name. Signed-off-by: Simon Glass --- driv

Re: [PATCH 04/14] spl: Remove remaining #ifdef in spl_parse_image_header()

2024-07-20 Thread Sean Anderson
ethods +*/ nit: leave this comment as-is, since it is under 80 columns debug("Raw boot image support not enabled, proceeding to other boot methods\n"); return -EINVAL; -#endif + } return 0; } Reviewed-by: Sean Anderson

Re: [PATCH 03/14] spl: Remove some #ifdefs in spl_parse_image_header()

2024-07-20 Thread Sean Anderson
aw boot image support not enabled, proceeding to other boot methods\n"); return -EINVAL; #endif - } return 0; } Reviewed-by: Sean Anderson

Re: [PATCH 02/14] spl: Correct use of CMD_BOOTI and CMD_BOOTZ

2024-07-20 Thread Sean Anderson
} -#elif defined(CMD_BOOTZ) +#elif defined(CONFIG_CMD_BOOTZ) ulong start, end; if (!bootz_setup((ulong)header, &start, &end)) { Reviewed-by: Sean Anderson

Re: [PATCH v2 15/21] spl: Plumb in the Universal Payload handoff

2024-07-20 Thread Sean Anderson
On 7/20/24 08:36, Simon Glass wrote: Hi Sean, On Thu, 18 Jul 2024 at 14:54, Sean Anderson wrote: On 7/13/24 03:00, Simon Glass wrote: Specify the FIT and include information about each loaded image, as required by the UPL handoff. Write the UPL handoff into the bloblist before jumping to

Re: [PATCH v2 04/21] sandbox: Enable SPL_LOAD_BLOCK

2024-07-18 Thread Sean Anderson
On 7/18/24 09:28, Sean Anderson wrote: On 7/13/24 03:00, Simon Glass wrote: Enable this option for all sandbox boards so that the FIT-loading code can be used without generating an error about block devices not being supported. Signed-off-by: Simon Glass --- (no changes since v1)   common

Re: [PATCH v2 20/21] sandbox: Add an SPL loader for UPL

2024-07-18 Thread Sean Anderson
On 7/13/24 03:00, Simon Glass wrote: Add support for loading a UPL image from SPL. This uses the simple FIT implementation, but also loads the full FIT just to permit more testing. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/cpu/spl.c | 49 +

Re: [PATCH v2 03/21] test: Move some SPL-loading test-code into sandbox common

2024-07-18 Thread Sean Anderson
On 7/13/24 03:00, Simon Glass wrote: This code is useful for loading an image in sandbox_spl so move it into a place where it can be called as needed. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/cpu/spl.c | 67 ++ arch/sandbox/i

Re: [PATCH v2 15/21] spl: Plumb in the Universal Payload handoff

2024-07-18 Thread Sean Anderson
On 7/13/24 03:00, Simon Glass wrote: Specify the FIT and include information about each loaded image, as required by the UPL handoff. Write the UPL handoff into the bloblist before jumping to the next phase. Control this using a runtime flag to avoid conflicting with other handoff mechanisms.

Re: [PATCH v2 04/21] sandbox: Enable SPL_LOAD_BLOCK

2024-07-18 Thread Sean Anderson
loading images from block devices. This adds a bl_len member to struct spl_load_info. NACK. Enable one of the many configs which select this one instead. --Sean

Re: [PATCH] ext4: Improve feature checking

2024-06-30 Thread Sean Anderson
On 6/30/24 20:23, Sean Anderson wrote: On 6/30/24 17:25, Richard Weinberger wrote: Evaluate the filesystem incompat and ro_compat bit fields to judge whether the filesystem can be read or written. For the read side only a scary warning is shown so far. I'd love to about mounting too, but I

Re: [PATCH] ext4: Improve feature checking

2024-06-30 Thread Sean Anderson
| EXT4_FEATURE_RO_COMPAT_HUGE_FILE \ + | EXT4_FEATURE_RO_COMPAT_DIR_NLINK \ + | EXT4_FEATURE_RO_COMPAT_EXTRA_ISIZE \ + ) ditto #define EXT4_BG_INODE_UNINIT 0x0001 #define EXT4_BG_BLOCK_UNINIT 0x0002 #define EXT4_BG_INODE_ZEROED 0x0004 Anyway, the substance of this patch is good. Just needs a little cosmetic cleanup. --Sean

Re: silent u-boot not working

2024-06-13 Thread Sean Anderson
rking. > > The text and logo is still present during boot, what am I doing wrong > here? I implemented a silent console recently. Here are the steps I took: - Define CONFIG_DISABLE_CONSOLE - set silent=y in the default environment (CONFIG_EXTRA_ENV_SETTINGS) You can still enable the console by pressing any key at the (invisible) prompt. Let me know if that works for you. --Sean

[PATCH v8 3/3] net: bootp: add config option BOOTP_RANDOM_XID

2024-05-08 Thread Sean Edmond
The new config option BOOTP_RANDOM_XID will randomize the transaction ID for each new BOOT/DHCPv4 exchange. Signed-off-by: Sean Edmond Reviewed-by: Tom Rini --- (no changes since v5) Changes in v5: - fix depends for BOOTP_RANDOM_XID: "depends on CMD_BOOTP && (LIB_RAND |

[PATCH v8 2/3] net: bootp: BOOTP/DHCPv4 retransmission improvements

2024-05-08 Thread Sean Edmond
rval to be configurable using the environment variable "bootpretransmitperiodinit". Also, on a retransmission it is not expected for the transaction ID to change (only the 'secs' field should be updated). Let's save the transaction ID and use the same transaction ID for each BOOTP/DH

[PATCH v8 1/3] net: Enhancements for dhcp option 209

2024-05-08 Thread Sean Edmond
- Enable option 209 by default - Set pxelinux_configfile to NULL to avoid potential double free - change hardcoded 209 to a define Signed-off-by: Sean Edmond --- (no changes since v7) Changes in v7: - Reword this commit Changes in v6: - Reword this commit Changes in v4: - rebase master and

[PATCH v8 0/3] BOOTP/DHCPv4 enhancements

2024-05-08 Thread Sean Edmond
to retransmission timeout - Add depends for BOOTP_RANDOM_XID Changes in v2: - use env_get_ulong() to get environment variables Sean Edmond (3): net: Enhancements for dhcp option 209 net: bootp: BOOTP/DHCPv4 retransmission improvements net: bootp: add config option BOOTP_RANDOM_XID c

Re: [PATCH] Fix neighbor discovery ethernet address saving

2024-05-07 Thread Sean Edmond
ed net_server_ethaddr (and it's checking to make sure that net_nd_packet_mac isn't NULL before copying). Also, the current code serves no purpose.  The current code is, "if net_nd_packet_mac is NULL, set it to stack variable neigh_eth_addr, then set net_nd_packet_mac to NULL when there

Re: [PATCH 118/149] board: sipeed: Remove and add needed includes

2024-04-30 Thread Sean Anderson
On 4/30/24 22:42, Tom Rini wrote: Remove from this board vendor directory and when needed add missing include files directly. Signed-off-by: Tom Rini --- Cc: Sean Anderson --- board/sipeed/maix/maix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/sipeed/maix

[PATCH v6 3/3] net: bootp: add config option BOOTP_RANDOM_XID

2024-04-29 Thread Sean Edmond
The new config option BOOTP_RANDOM_XID will randomize the transaction ID for each new BOOT/DHCPv4 exchange. Signed-off-by: Sean Edmond Reviewed-by: Tom Rini --- (no changes since v5) Changes in v5: - fix depends for BOOTP_RANDOM_XID: "depends on CMD_BOOTP && (LIB_RAND |

[PATCH v6 2/3] net: bootp: BOOTP/DHCPv4 retransmission improvements

2024-04-29 Thread Sean Edmond
rval to be configurable using the environment variable "bootpretransmitperiodinit". Also, on a retransmission it is not expected for the transaction ID to change (only the 'secs' field should be updated). Let's save the transaction ID and use the same transaction ID for each BOOTP/DH

[PATCH v6 1/3] net: Enhancements for dhcp option 209

2024-04-29 Thread Sean Edmond
- Enable option 209 by default - Set pxelinux_configfile to NULL to avoid potential double free - change hardcoded 209 to a define Signed-off-by: Sean Edmond --- Changes in v7: - Reword this commit Changes in v6: - Reword this commit Changes in v4: - rebase master and resolve conflicts

[PATCH v6 0/3] BOOTP/DHCPv4 enhancements

2024-04-29 Thread Sean Edmond
; for "config CMD_BOOTP" (retransmission improvements require rand()) Changes in v3: - add define for option 209 and rfc5071 reference - Set RETRANSMIT_PERIOD_MAX_MS=6 - Add randomization factor to retransmission timeout - Add depends for BOOTP_RANDOM_XID Changes in v2: -

Re: [PATCH v2 01/23] clk: rockchip: rk356x: Add CLK_USB3OTGx_REF support

2024-04-18 Thread Sean Anderson
-by: Sean Anderson

Re: [PATCH v2 02/23] clk: rockchip: rk3588: Add REF_CLK_USB3OTGx support

2024-04-18 Thread Sean Anderson
B3OTG1: + case REF_CLK_USB3OTG2: case TMCLK_EMMC: case TCLK_WDT0: ret = OSC_HZ; Acked-by: Sean Anderson

[PATCH 3/3] patman: Add a tag for when a patch gets added to a series

2024-04-18 Thread Sean Anderson
y just noise in most series, but they may be useful for treewide series to distinguish 'gpio: frobnicate' from 'reset: frobnicate', so I've left them in. Suggestions for the above appreciated. Suggested-by: Douglas Anderson Signed-off-by: Sean Anderson --- tools/pa

[PATCH 2/3] patman: Add Commit-cc as an alias for Patch-cc

2024-04-18 Thread Sean Anderson
Most tags referring to commits (or patches) are named Commit-something. The exception is Patch-cc. Add a Commit-cc alias so we can use whichever one is convenient. Signed-off-by: Sean Anderson --- tools/patman/func_test.py| 5 - tools/patman

[PATCH 1/3] patman: Fix tests if add_maintainers is set to False

2024-04-18 Thread Sean Anderson
intainer-script' argument") Signed-off-by: Sean Anderson --- tools/patman/func_test.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/patman/func_test.py b/tools/patman/func_test.py index e3918497cf4..9c016fb5e9a 100644 --- a/tools/patman/func_test.py +++ b/

[PATCH 0/3] patman: A fix and some new tags

2024-04-18 Thread Sean Anderson
This series has a fix along with a couple of convenient tags. Sean Anderson (3): patman: Fix tests if add_maintainers is set to False patman: Add Commit-cc as an alias for Patch-cc patman: Add a tag for when a patch gets added to a series tools/patman/func_test.py

Re: [PATCH] mmc: sdhci: programmable clock calculation needs multiplier +1

2024-04-15 Thread Sean Anderson
therwise the actual clock > +* multiplier is one more than the value of Clock Multiplier > +* in the Capabilities Register. > +*/ > + if (host->clk_mul) > + host->clk_mul += 1; > } > > if (host->max_clk == 0) { > -- > 2.43.2 > Reviewed-by: Sean Anderson

Re: [PATCH 1/1] clk: sifive: append missing \n to messages

2024-04-11 Thread Sean Anderson
On 4/11/24 04:37, Heinrich Schuchardt wrote: On 11.04.24 05:13, Sean Anderson wrote: On 2/16/24 11:35, Heinrich Schuchardt wrote: If multiple messages are written, line-feeds improve the readability. Fixes: c40b6df87fc0 ("clk: Add SiFive FU540 PRCI clock driver") Signed-off-by

Re: [PATCH] clk: imx8mp: add pwm clocks support

2024-04-10 Thread Sean Anderson
On 4/10/24 23:18, Sean Anderson wrote: On 3/10/23 10:15, Tommaso Merciai wrote: Add clocks support for the PWM controllers. This is ported from Linux v6.3.0-rc1 Signed-off-by: Tommaso Merciai ---   drivers/clk/imx/clk-imx8mp.c | 24   1 file changed, 24 insertions

Re: [PATCH] clk: imx8mp: add pwm clocks support

2024-04-10 Thread Sean Anderson
uot;, base + 0x4190, 0)); clk_dm(IMX8MP_CLK_I2C4_ROOT, imx_clk_gate4("i2c4_root_clk", "i2c4", base + 0x41a0, 0)); + clk_dm(IMX8MP_CLK_PWM1_ROOT, imx_clk_gate4("pwm1_root_clk", "pwm1", base + 0x4280, 0)); + clk_dm(IMX8MP_CLK_PWM2_ROOT, imx_clk_gate4("pwm2_root_clk", "pwm2", base + 0x4290, 0)); + clk_dm(IMX8MP_CLK_PWM3_ROOT, imx_clk_gate4("pwm3_root_clk", "pwm3", base + 0x42a0, 0)); + clk_dm(IMX8MP_CLK_PWM4_ROOT, imx_clk_gate4("pwm4_root_clk", "pwm4", base + 0x42b0, 0)); clk_dm(IMX8MP_CLK_QSPI_ROOT, imx_clk_gate4("qspi_root_clk", "qspi", base + 0x42f0, 0)); clk_dm(IMX8MP_CLK_I2C5_ROOT, imx_clk_gate2("i2c5_root_clk", "i2c5", base + 0x4330, 0)); clk_dm(IMX8MP_CLK_I2C6_ROOT, imx_clk_gate2("i2c6_root_clk", "i2c6", base + 0x4340, 0)); Acked-by: Sean Anderson But I would like to see a RB from one of the i.MX maintainers (CC'd).

Re: [PATCH 1/1] clk: sifive: avoid declaring static variables in includes

2024-04-10 Thread Sean Anderson
,4 +320,8 @@ unsigned long sifive_prci_hfpclkplldiv_recalc_rate(struct __prci_clock *pc, int sifive_prci_clock_enable(struct __prci_clock *pc, bool enable); +/* Clock driver data */ +extern const struct prci_clk_desc prci_clk_fu540; +extern const struct prci_clk_desc prci_clk_fu740; + #endif /* __SIFIVE_CLK_SIFIVE_PRCI_H */ How does this affect SPL size? --Sean

Re: [PATCH] clk: sifive: check wrpll_configure_for_rate() return value

2024-04-10 Thread Sean Anderson
_clock *pc, memcpy(&c, &pwd->c, sizeof(c)); - wrpll_configure_for_rate(&c, rate, *parent_rate); + r = wrpll_configure_for_rate(&c, rate, *parent_rate); + if (r) + return r; return wrpll_calc_output_rate(&c, *parent_rate); } Reviewed-by: Sean Anderson

Re: [PATCH 1/1] clk: sifive: append missing \n to messages

2024-04-10 Thread Sean Anderson
u64 n; if (c->flags & WRPLL_FLAGS_EXT_FEEDBACK_MASK) { - WARN(1, "external feedback mode not yet supported"); + WARN(1, "external feedback mode not yet supported\n"); return ULONG_MAX; } Reviewed-by: Sean Anderson But maybe these should be dev_dbg?

Re: [PATCH] clk: Fix error message in clk_get_bulk

2024-04-10 Thread Sean Anderson
release all clocks for %p\n", + debug("%s: could not release all clocks for %p\n", __func__, dev); return ret; Reviewed-by: Sean Anderson

Re: [PATCH v3] clk: set initial best mux parent to current parent with CLK_MUX_ROUND_CLOSEST

2024-04-10 Thread Sean Anderson
est or some other scheme. [1] has the current recommendation, which is to punt and let the caller use round_rate if they actually care. --Sean [1] https://source.denx.de/u-boot/custodians/u-boot-clk/-/blob/a8dc4965f09d28a59c156437673ddb66860c847e/include/clk-uclass.h#L143

Re: [PATCH] clk: Propagate clk_set_rate() if CLK_SET_PARENT_RATE present

2024-04-10 Thread Sean Anderson
clk = parent; + ops = clk_dev_ops(clk->dev); + } /* get private clock struct used for cache */ clk_get_priv(clk, &clkp); Can you give an example of where this is needed? --Sean

Re: [PATCH 1/1] sandbox: use sane access rights for files

2024-04-10 Thread Sean Anderson
size) < 0) return -EIO; close(fd); - if (chmod(fname, 0777)) + if (chmod(fname, 0755)) return -ENOEXEC; return 0; Reviewed-by: Sean Anderson

Re: [PATCH 1/1] sandbox: don't call os_close with invalid file descriptor

2024-04-10 Thread Sean Anderson
, OS_O_RDONLY); if (fd < 0) { printf("Cannot open file '%s'\n", fname); - goto err; + return -EIO; } size = os_filesize(fd); if (size < 0) { Fixes: 566bf3a8698 ("sandbox: Add a function to read

Re: [PATCH 1/2] dm: core: add support for fallback drivers

2024-04-10 Thread Sean Anderson
ed to switch over to using a real driver. --Sean

Re: [RFC PATCH v1 1/1] mmc: snps_sdhci: Add sdhci driver support for TH1520 SoC

2024-04-02 Thread Sean Anderson
er on Alibaba TH1520 SoC. > + This is a highly configurable and programmable, high performance > + Mobile Storage Host Controller (MSHC) with AXI as the bus interface > + for data transfer. > + > + If unsure, say N. > + Why not use MMC_DW? --Sean [Embedded World 2024, SECO SpA]<https://www.messe-ticket.de/Nuernberg/embeddedworld2024/Register/ew24517689>

Re: [PATCH] arm64: zynqmp: Also support JTAG as alternative boot mode

2024-03-22 Thread Sean Anderson
On 3/22/24 07:53, Michal Simek wrote: > > > On 3/21/24 17:20, Sean Anderson wrote: >> On 3/20/24 07:18, Michal Simek wrote: >>> if (reg >> BOOT_MODE_ALT_SHIFT) condition rules out alternative jtag boot >>> mode which is 0. When 0 was used origin(HW) boo

Re: [PATCH] arm64: zynqmp: Also support JTAG as alternative boot mode

2024-03-21 Thread Sean Anderson
_ALT_SHIFT) > reg >>= BOOT_MODE_ALT_SHIFT; > +#endif > > bootmode = reg & BOOT_MODES_MASK; > Looks fine; can we change this to if (IS_ENABLED(CONFIG_SPL_ZYNQMP_ALT_BOOTMODE_ENABLED)) { ... } else { ... } ? --Sean

Re: [PATCH 1/2] clk: clk-imx8qxp: Add LPUART IPG entries

2024-03-20 Thread Sean Anderson
On 3/19/24 15:04, Tom Rini wrote: On Mon, Mar 18, 2024 at 09:14:53PM -0300, Fabio Estevam wrote: Hi Tom and Sean, On Fri, Mar 8, 2024 at 5:13 PM Fabio Estevam wrote: Since commit cc7df0b9e8bc ("serial: lpuart: Enable IPG clock") the colibri-imx8qxp board no longer boots. The reas

Re: [PATCH] clk: Propagate clk_set_rate() if CLK_SET_PARENT_RATE present

2024-03-20 Thread Sean Anderson
e the first .set_rate capable clock is found, which is usually enough to handle most cases. Signed-off-by: Sam Protsenko --- Hi Lukasz, Sean, Tom, If this patch looks good to you and there are no outstanding comments, can you please apply it? It's needed as a part of eMMC enablement for E850-96

Re: [PATCH] cmd: bootm: add ELF file support

2024-03-19 Thread Sean Anderson
ot;elf" image type for booting using bootm command. Why not use objcopy to create a binary? --Sean > Signed-off-by: Maxim Moskalets > --- > boot/bootm_os.c | 21 + > boot/image-fit.c | 3 ++- > boot/image.c | 3 +++ > include/image.h | 1 + >

Re: [PATCH v2] cmd: nand: Add support to print the manufacturer, model and size

2024-03-18 Thread Sean Anderson
uot; OOB size %8d b\n", mtd->oobsize); printf(" Erase size%8d b\n", mtd->erasesize); Can you refactor the logic out of the end of nand_detect as a separate function and use that instead? That will cover more cases (e.g. JEDEC). --Sean

Re: [PATCH v5] misc: fs-loader: Use fw_storage_interface instead of storage_interface

2024-02-27 Thread Sean Anderson
update the FS Loader documentation accordingly. Signed-off-by: MD Danish Anwar --- Hi Tom / Sean, can you please pick this patch if there is no pending comments to address. Sorry, I forgot to respond to this earlier. To be honest, I'm not really convinced. We have plenty of environm

Re: [PATCH] clk: Revise help text for clk_get_parent_rate()

2024-02-23 Thread Sean Anderson
parent of current clock rate. + * clk_get_parent_rate() - Get rate of current clock's parent. * @clk: A clock struct that was previously successfully requested by *clk_request/get_by_*(). * base-commit: 7bb761c42d75b2ebacc7190a76cc5385cbba1045 Reviewed-by: Sean Anderson

Re: [PATCH] Check curve_name for null to avoid crash

2024-02-22 Thread Sean Anderson
ey. Likely not an ecdsa key.\n"); + return -ENOMSG; + } + key->size_bits = ecdsa_key_size(key->curve_name); if (key->size_bits == 0) { debug("Unknown ECDSA curve '%s'", key->curve_name); Reviewed-by: Sean Anderson

[RESEND PATCH v2] arm64: zynqmp: Support semihosting boot method

2024-02-22 Thread Sean Anderson
on't break compatibility with existing debuggers that don't expect us to hit semihosting breakpoints. Signed-off-by: Sean Anderson --- I'm resending this from my linux.dev email as my regular email is mangling my patches. Changes in v2: - Fix typo in subject arch/arm/mach-zynqmp/spl.

Re: [PATCH v2] arm64: zynqmp: Support semihosting boot method

2024-02-22 Thread Sean Anderson
On 2/22/24 14:36, Fabio Estevam wrote: > On Thu, Feb 22, 2024 at 1:53 PM Sean Anderson wrote: >> >> From: Sean Anderson > ... >> Signed-off-by: Sean Anderson >> --- >> I'm resending this from my linux.dev email as my regular email is >> mangling m

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-22 Thread Sean Anderson
On 2/22/24 05:34, Michal Simek wrote: > > > On 2/20/24 20:30, Sean Anderson wrote: >> On 2/20/24 14:18, Michal Simek wrote: >>> >>> >>> On 2/20/24 19:43, Sean Anderson wrote: >>>> On 2/20/24 13:24, Michal Simek wrote: >>>>> >&

[PATCH v2] arm64: zynqmp: Support semihosting boot method

2024-02-22 Thread Sean Anderson
From: Sean Anderson Currently, when we boot from JTAG we try to boot U-Boot from RAM. However, this is a bit tricky to time, since the debugger has to wait for SPL to initialize RAM before it can load U-Boot. This can result in long waits, since occasionally initializing RAM (and other things in

Re: [PATCH] ecdsa: Avoid null pointer crash in ecdsa-verify due to absent property

2024-02-21 Thread Sean Anderson
n ecdsa key.\n"); this should probably be a debug (like the below message) + return -ENOMSG; + } + and it looks like something ate your indentation --Sean key->size_bits = ecdsa_key_size(key->curve_name); if (key->size_bits == 0) { debug("Unknown ECDSA curve '%s'", key->curve_name); -- 2.39.3 (Apple Git-145)

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-20 Thread Sean Anderson
On 2/20/24 14:18, Michal Simek wrote: > > > On 2/20/24 19:43, Sean Anderson wrote: >> On 2/20/24 13:24, Michal Simek wrote: >>> >>> >>> On 2/16/24 17:09, Sean Anderson wrote: >>>> On 2/16/24 11:03, Sean Anderson wrote: >>>>> On

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-20 Thread Sean Anderson
On 2/20/24 13:24, Michal Simek wrote: > > > On 2/16/24 17:09, Sean Anderson wrote: >> On 2/16/24 11:03, Sean Anderson wrote: >>> On 2/16/24 10:06, Michal Simek wrote: >>>> >>>> >>>> On 2/16/24 14:48, Michal Simek wrote: >>>>&

Re: HABv4 with SPL and u-boot-dtb.img on i.MX6

2024-02-20 Thread Sean Anderson
no effect. I suggest creating your FIT manually (e.g. -f u-boot.its instead of -f auto). You should be able to specify the hashes manually that way. > I also try to use image format and force the HAB to verify the whole > u-boot-dtb.img file by patching the FIT image size: > > image_size=$(stat -tc %s u-boot-dtb.img) > printf "0004: %08x" "$image_size" | xxd -r - u-boot-dtb.img > > SPL starts, authentication looks fine but the boot fails. > Is there any chance to make it work or is it insane to try to use this format? I have always just used verified boot for U-Boot and the kernel, and only used vendor-specific stuff for SPL. --Sean [1] https://docs.u-boot.org/en/latest/usage/fit/verified-boot.html [2] https://docs.u-boot.org/en/latest/usage/fit/source_file_format.html [Embedded World 2024, SECO SpA]<https://www.messe-ticket.de/Nuernberg/embeddedworld2024/Register/ew24517689>

  1   2   3   4   5   6   7   8   9   10   >