[PATCH v2] bootm: Fix bmi->images pointer not initialized in some cases

2025-05-20 Thread Benjamin ROBIN
cture. So, to fix this issue, just do the assignment unconditionally. Fixes: c2211ff65136 ("bootm: Add more fields to bootm_info") Signed-off-by: Benjamin ROBIN --- boot/bootm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/boot/bootm.c b/boot/bootm.c index f6aa32

Re: [PATCH] bootm: Fix bootz, bmi->images pointer was uninitialized

2025-05-20 Thread Benjamin ROBIN
Le Mon, May 19, 2025 at 03:06:08PM -0600, Tom Rini a écrit : > Good catch. This should also get a: > Fixes: c2211ff65136 ("bootm: Add more fields to bootm_info") Thank you for the review. I am preparing a v2 of this patch. > And after reading the code and grepping around more, I think we should >

[PATCH] bootm: Fix bootz, bmi->images pointer was uninitialized

2025-05-19 Thread Benjamin ROBIN
: Benjamin ROBIN --- boot/bootm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/boot/bootm.c b/boot/bootm.c index f6aa32746b7e..f6fddc151809 100644 --- a/boot/bootm.c +++ b/boot/bootm.c @@ -1169,7 +1169,7 @@ void bootm_init(struct bootm_info *bmi) { memset(bmi, '\0&

[PATCH] env: Fix network support when CONFIG_NET_LWIP is set

2025-05-17 Thread Benjamin ROBIN
When lwIP (CONFIG_NET_LWIP) is used instead of legacy stack (CONFIG_NET), environment flags support associated with network was not built: restore support of "i" and "m" environment flags. Signed-off-by: Benjamin ROBIN --- env/flags.c| 10 +- include

Re: [PATCH 00/17] video: dw_hdmi: Support Vendor PHY

2023-12-18 Thread Robin Murphy
l think that doing the full rk_iommu_disable() upon runtime suspend is wrong, but that's more of a thing which confounds the underlying issue here, rather than being the problem in itself. Thanks, Robin.

Re: [PATCH 3/5] armv8: fsl-layerscape: create bypass smmu mapping for MC

2023-09-06 Thread Robin Murphy
On 2023-09-06 19:10, Laurentiu Tudor wrote: On 9/6/2023 8:21 PM, Robin Murphy wrote: On 2023-09-06 17:01, Laurentiu Tudor wrote: MC being a plain DMA master as any other device in the SoC and being live at OS boot time, as soon as the SMMU is probed it will immediately start triggering

Re: [PATCH 3/5] armv8: fsl-layerscape: create bypass smmu mapping for MC

2023-09-06 Thread Robin Murphy
e for upholding, is the reserved memory regions from patch #2. For instance, if the OS is Linux, literally the first thing arm_smmu_device_reset() does is rewrite all the S2CRs and SMRs without so much as looking. Thanks, Robin. Signed-off-by: Laurentiu Tudor --- arch/arm/cpu/armv8/fsl-layer

Re: [PATCH 2/2] doc: add Arm Juno board documentation

2021-12-15 Thread Robin Murphy
nux). Also I believe the stock setup assumes DTBs in \SOFTWARE, rather than the root directory. At least that's how my r2 here seems to be (not that I've ever actually used it without loading a custom one from GRUB...) Thanks, Robin. +partition. U-Boot picks its control DTB from there,

Re: [PATCH] rockchip: rk3288: Add OF board setup

2020-07-03 Thread Robin Murphy
On 2020-07-03 11:10, Jagan Teki wrote: On Thu, Jul 2, 2020 at 7:26 PM Robin Murphy wrote: On 2020-07-02 09:48, Jagan Teki wrote: The new rk3288 revision rk3288w has some changes with respect to legacy rk3288 like hclk_vio and usb host0 ohci. In order to work these on the same in Linux

Re: [PATCH] rockchip: rk3288: Add OF board setup

2020-07-02 Thread Robin Murphy
replacing the entire top-level compatible property? i.e. from: compatible = "vendor,board\0rockchip,rk3288"; to just: compatible = "rockchip,rk3288w"; If so, that's a bit of a problem for various drivers that care about the actual board compatible rath

Re: [PATCH v2] mmc: sdhci: Fix HISPD bit handling

2020-06-09 Thread Robin Murphy
if (!(host->quirks & SDHCI_QUIRK_NO_HISPD_BIT) || Should that be "&&" rather than "||"? Otherwise this will always evaluate to true unless *both* quirks are set, which isn't equivalent to the check being removed above. Robin. +

Re: [PATCH 5/8] pci: Add Rockchip PCIe controller driver

2020-04-27 Thread Robin Murphy
tely not be part of the board at all, depending on whether it implements a full-size slot, a mini-PCI/M.2 socket, a hard-wired endpoint chip, or just the data and clock signal pairs exposed on some non-standard connector. Robin.

Re: [PATCH 0/2] Reading size-cells and address-cells from a node should walk up the

2020-04-08 Thread Robin Randhawa
Hi Matthias. Thanks for this. I can confirm that this fixes the reported problem. You have my Tested-By. FWIW, the changes look fine to me too. Cheers, Robin

Re: Bug: qemu_arm64: Cannot access the second flash bank

2020-01-09 Thread Robin Randhawa
also does not specify #size-cells before making the assumption that the value 1 is to be used ? Thanks, Robin

Re: Bug: qemu_arm64: Cannot access the second flash bank

2020-01-09 Thread Robin Randhawa
boot platform target for which I used qemu_arm64_defconfig [1]. Let me know if you need more info. Cheers, Robin [1]: https://github.com/u-boot/u-boot/blob/master/configs/qemu_arm64_defconfig

Bug: qemu_arm64: Cannot access the second flash bank

2020-01-01 Thread Robin Randhawa
f=pflash,format=raw,index=0,file=flash0-with-uboot.img -drive if=pflash,format=raw,index=1,file=flash1.img I'm happy to help test any fixes if and as needed. Cheers, Robin

Re: [U-Boot] [PATCH v3 5/5] doc: boards: Add rockchip documentation

2019-10-18 Thread Robin Murphy
git clone https://github.com/ARM-software/arm-trusted-firmware.git Nit: it's probably worth updating that to https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git Robin. +cd arm-trusted-firmware +make realclean +make CROSS_COMPILE=aarch64-linux-gnu- PLAT=rk3

Re: [U-Boot] [RESEND PATCH v7 05/11] rockchip: dts: rk3399: nanopi4: Use CD pin as RK_FUNC_1

2019-05-08 Thread Robin Murphy
amp;sdmmc_bus4 &sdmmc_clk &sdmmc_cmd &sdmmc_cd>; +}; I suppose you could also delete the "cd-gpios" property to make it really clear what this override is for (and save a few bytes if it's going to be ignored anyway). Robin. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 08/14] rockchip: dts: rk3399: nanopi4: Use CD pin as RK_FUNC_1

2019-04-17 Thread Robin Murphy
e should be fine for U-Boot as long as it never turns off PD_SD itself. Robin. Signed-off-by: Jagan Teki --- arch/arm/dts/rk3399-nanopi4.dtsi | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/arch/arm/dts/rk3399-nanopi4.dtsi b/arch/arm/dts/rk3399-nanopi4.dtsi index d3

Re: [U-Boot] Unable to saveenv to MMC

2018-12-19 Thread Robin Polak
Thank you for the clarification. I've correct my issue by partitioning the MMC storage and formatting the partition FAT. Then burning the U-Boot Image to 8K in on the raw media. On Tue, Dec 18, 2018 at 12:48 AM Heinrich Schuchardt wrote: > On 12/6/18 7:12 PM, Robin Polak wrote: &

Re: [U-Boot] Unable to saveenv to MMC

2018-12-17 Thread Robin Polak
The output I'm getting is: => ls mmc 0:0 ** Unrecognized filesystem type ** On Sun, Dec 9, 2018 at 1:43 AM wrote: > just try the ls-command i wrote in uboot-console ;) > > > Gesendet: Sonntag, 09. Dezember 2018 um 04:20 Uhr > Von: "Robin Polak" > An:

Re: [U-Boot] Unable to saveenv to MMC

2018-12-08 Thread Robin Polak
How would I go about validating whether I can access the partition from u-boot? On Fri, Dec 7, 2018 at 1:47 AM Frank Wunderlich wrote: > can you try to access the partiton from uboot? > > ls mmc 0:0 > > regards Frank > > > Von: "Robin Polak" > > I&#x

[U-Boot] Unable to saveenv to MMC

2018-12-06 Thread Robin Polak
nd Hit any key to stop autoboot: 0 => saveenv Saving Environment to FAT... Unable to use mmc 0:0... Failed (1) Thank you for any light that may be shed upon this error. -- -- Robin Polak ro...@robinpolak.com 917-494-2080 ___ U-Boot mailin

Re: [U-Boot] [PATCH] efi_loader: Fix crash on 32-bit systems

2016-09-14 Thread Robin Randhawa
t spot another instance of a mismatch. Ideally it would be neat to have an automated way to check for these things - maybe Coccinelle or something. > For this change however, the fix is already correct: > > Reviewed-by: Alexander Graf Thanks, Robin ___

[U-Boot] [PATCH] efi_loader: Fix crash on 32-bit systems

2016-09-13 Thread Robin Randhawa
t cast to ensure the correct outcome, irrespective of the system's native word size. This was observed when bootefi'ing the EFI instance of FreeBSD's first stage bootstrap (boot1.efi) on a 32-bit ARM platform (Qemu VExpress + Cortex-a9). Signed-off-by: Robin Randhawa --- lib/efi_lo

Re: [U-Boot] [PATCH 07/12] imx:mx6 Support LDO bypass

2015-02-13 Thread Robin Gong
On Thu, Feb 12, 2015 at 04:08:51PM -0800, Tim Harvey wrote: > On Wed, Feb 11, 2015 at 7:47 AM, Tim Harvey wrote: > > On Wed, Feb 11, 2015 at 2:49 AM, Robin Gong wrote: > > > >>> > >>> This is very board dependent. Here you are referring to a board that >

Re: [U-Boot] [PATCH 07/12] imx:mx6 Support LDO bypass

2015-02-13 Thread Robin Gong
On Wed, Feb 11, 2015 at 07:47:57AM -0800, Tim Harvey wrote: > On Wed, Feb 11, 2015 at 2:49 AM, Robin Gong wrote: > > >> > >> This is very board dependent. Here you are referring to a board that > >> has a reset input to the PMIC's from the IMX6's wat

Re: [U-Boot] [PATCH 07/12] imx:mx6 Support LDO bypass

2015-02-12 Thread Robin Gong
On Tue, Feb 10, 2015 at 06:33:38AM -0800, Tim Harvey wrote: > On Fri, Jan 9, 2015 at 12:59 AM, Peng Fan wrote: > > The basic graph for voltage input is: > >VDDARM_IN ---> LDO_DIG(ARM) ---> VDD_ARM_CAP > >VDDSOC_IN ---> LDO_DIG(SOC) ---> VDD_SOC_CAP > > > > Hi Peng, > > Glad to see someon

[U-Boot] help on adding bootelf to u-boot

2013-10-16 Thread Robin Fernandes
hi sir/madam I am trying to run bootelf command from u-boot. But the command is not inbuilt in it. So could you please let me know what is the procedure to compile.. -- Thanks and Regards *Robin Fernandes* Global Edge Software Ltd. Bangalore, India Tel : _+91 88 6164 8965_ Web

Re: [U-Boot] [PATCH] net/dns.c: Fix endian conversion for big-endian in dns command

2011-10-16 Thread Robin Getz
ents, which isn't captured in the change log? Otherwise, Ack from me. > Signed-off-by: Bernhard Kaindl > Cc: Pieter Voorthuijsen > Cc: Robin Getz > --- > net/dns.c | 20 > 1 files changed, 8 insertions(+), 12 deletions(-) > > diff --git a/net

Re: [U-Boot] standalone application export eth_receive: undefined index

2011-08-26 Thread Robin Theunis
#x27; make: *** [u-boot] Fout 1 I know it is just some small switch somewhere but I don't see where I can find it. Thanks a lot Robin Theunis 2011/8/26 Wolfgang Denk : > Dear Robin Theunis, > > please keep the ML on Cc: > > In message > you > wrote: >> >

[U-Boot] standalone application export eth_receive: undefined index

2011-08-25 Thread Robin Theunis
AT91RM9200, 16MB sdram, 16MB flash. If I comment out the switches in the net/eth.c net/net.c and include/net.h. It could work. I exported also eth_send. This function doesn't give me any problems when compiling the application. Is this a dummy problem? Or something else? Thanks Robin Th

Re: [U-Boot] [PATCH] integratorap: remove hardcoded 32MB memory cmdline

2011-07-15 Thread Philippe Robin
Hi Linus, Wolfgang, On Fri, Jul 15, 2011 at 11:34 AM, Linus Walleij wrote: >> On Thu, Jul 14, 2011 at 8:03 PM, Linus Walleij wrote: >> > On Thu, Jul 14, 2011 at 1:44 PM, Wolfgang Denk wrote: >> > >> >>> --- a/include/configs/integratorap.h >> >>> +++ b/include/configs/integratorap.h >> >> >> >>

Re: [U-Boot] spi utility command support

2010-07-28 Thread Robin Getz
On Wed 28 Jul 2010 10:01, shashikiran.bevenka...@wipro.com pondered: [snip] > The information contained in this electronic message and any attachments > to this message are intended for the exclusive use of the addressee(s) > and may contain proprietary, confidential or privileged information. If

[U-Boot] Uboot application problem

2010-04-27 Thread robin
its using uboot's stack area not the one defined by my application. what is causing this behavior and how to resolve it ? Regards, Robin = OUTPUT_FORMAT("elf32-littlearm", "elf32-littlearm", "elf32-littlearm") O

[U-Boot] Uboot application problem

2010-04-26 Thread robin
its using uboot's stack area not the one defined by my application. what is causing this behavior and how to resolve it ? Regards, Robin = OUTPUT_FORMAT("elf32-littlearm", "elf32-littlearm", "elf32-littlearm") O

[U-Boot] [Patch] ./net/net.c - make Microsoft dns servers happy with random_port() numbers

2010-03-08 Thread Robin Getz
y ensuring the random port number is less than 17500. Signed-off-by: Robin Getz --- net/net.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/net.c b/net/net.c index 595abd9..98d58e5 100644 --- a/net/net.c +++ b/net/net.c @@ -1872,11 +1872,13 @@ void copy_file

Re: [U-Boot] About GPL

2009-12-18 Thread Robin Getz
On Wed 16 Dec 2009 21:55, Rob Westfall pondered: > Where exactly is the line for what you have to provide vs what you > don't have to provide? > > We are building boards that are based on a standard board, but we have > obviously had to modify include/config/ to setup for our > hardware and create

Re: [U-Boot] Uboot hangs on "starting kernel..."

2009-12-10 Thread Robin Randhawa
ikely be a kernel misconfiguration issue but you'll get the idea one hopes. Cheers, Robin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] Add debug message for Blackfin Ethernet Rx function.

2009-08-24 Thread Robin Getz
Add a simple print for the Blackfin's Ethernet Rx function, so we can debug incomming Ethernet functions easier. Signed-off-by: Robin Getz --- drivers/net/bfin_mac.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c

[U-Boot] [PATCH] Add Transfer Size Option to tftp

2009-08-20 Thread Robin Getz
chars) are printed. one hash mark == 2% of the file downloaded. - if it doesn't receive the file size (the server doesn't support RFC 2349, prints standard hash marks (one mark for each UDP frame). Signed-off-by: Robin Getz --- net/tftp.c | 42 +++

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-17 Thread Robin Getz
On Mon 17 Aug 2009 16:20, Wolfgang Denk pondered: > Dear Robin Getz, > > In message <200908171555.31016.rg...@blackfin.uclinux.org> you wrote: > > > > > Why static int? This gives a random init value for the second and each > > > following TFTP transfers. &

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-17 Thread Robin Getz
On Mon 17 Aug 2009 15:05, Wolfgang Denk pondered: > Dear Robin Getz, > > In message <200908171315.40365.rg...@blackfin.uclinux.org> you wrote: > > > > Comments welcome... > > I guess the code is largely untested? I tested it on a single machine. > &g

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-17 Thread Robin Getz
On Sat 8 Aug 2009 05:50, Ben Warren pondered: > Allesandro, > > Alessandro Rubini wrote: > > I finally fixed the defrag code, testing with NFS as well. > > Didn't take performance figures, tough, for lack of time. > > > > I wanted to do "config + environment" for the NFS case, like tftp, but > > d

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-17 Thread Robin Getz
On Thu 13 Aug 2009 18:01, Wolfgang Denk pondered: > Dear Robin Getz, > In message <200908131747.20194.rg...@blackfin.uclinux.org> you wrote: > > The better thing to do (IMHO) - would be to print out the proper number of > > hashes, depending on the size of the file (and i

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-13 Thread Robin Getz
On Wed 12 Aug 2009 17:30, Wolfgang Denk pondered: > Dear Ben Warren, > > In message <4a832bce.9060...@gmail.com> you wrote: > > > > Sure, if you don't mind re-compiling. I think it might be an > > opt-outable message via puts_quiet() > > It seems we start having a mess here, with features bound

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-13 Thread Robin Getz
On Wed 12 Aug 2009 16:04, Wolfgang Denk pondered: > Dear Robin Getz, > > In message <200908121148.16431.rg...@blackfin.uclinux.org> you wrote: > > > > Some info for the docs, when I was troubleshooting a Ubuntu 9.04 > install. > > Good info, but bad format. C

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-12 Thread Robin Getz
On Wed 12 Aug 2009 16:05, Ben Warren pondered: > Hi Robin, > > Robin Getz wrote: > > On Mon 10 Aug 2009 15:57, Ben Warren pondered: > > > >> Robin Getz wrote: > >> > >>> Thanks to Alessandro for putting it together. > >>>

Re: [U-Boot] [PATCH] Make TFTP Quiet

2009-08-12 Thread Robin Getz
On Wed 12 Aug 2009 15:48, Scott Wood pondered: > On Wed, Aug 12, 2009 at 12:02:33PM +0200, Detlev Zundel wrote: > > Hi Timur, > > > > >> +#ifdef CONFIG_TFTP_QUIET > > >> +#define puts_quiet(fmt) > > >> +#else > > >> +#define puts_quiet(fmt)                puts(fmt); > > >> +#endif > > > > > > This

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-12 Thread Robin Getz
On Mon 10 Aug 2009 15:57, Ben Warren pondered: > Robin Getz wrote: > > Thanks to Alessandro for putting it together. > > > > Feel free to add my Signed-off (once the docs have been updated > > explaining what this is all for). > > > > > I'll do

Re: [U-Boot] [PATCH] Add md5sum and sha1 commands...

2009-08-12 Thread Robin Getz
On Mon 27 Jul 2009 00:07, Robin Getz pondered: > From: Robin Getz > > Now that we have sha1 and md5 in lib_generic, allow people to use them > on the command line, for checking downloaded files > > Signed-off-by: Robin Getz > > README |4 ++ &g

Re: [U-Boot] http client?

2009-08-12 Thread Robin Getz
On Wed 22 Jul 2009 10:04, jeffery palmer pondered: > We are looking for an http client now as well. Our major issue > revolves around the download times for tftp. > > Can Volkmar Uhlig kindly provide the patches? > > Our units automically update themselves inside of uboot giving us the > most

Re: [U-Boot] [PATCH] Add md5sum and sha1 commands...

2009-08-12 Thread Robin Getz
On Tue 11 Aug 2009 15:21, Wolfgang Denk pondered: > Dear Robin Getz, > > In message <200908111357.25007.rg...@blackfin.uclinux.org> you wrote: > > > > > Now that we have sha1 and md5 in lib_generic, allow people to use them > > > on the comm

Re: [U-Boot] [PATCH] Make TFTP Quiet

2009-08-10 Thread Robin Getz
On Mon 10 Aug 2009 16:55, Timur Tabi pondered: > On Mon, Aug 10, 2009 at 3:26 PM, Robin Getz wrote: > > --- a/net/tftp.c > > +++ b/net/tftp.c > > @@ -22,6 +22,16 @@ > >                                        /* (for checking the image size)     > >    */ >

[U-Boot] [PATCH] Make TFTP Quiet

2009-08-10 Thread Robin Getz
>From bca49fb5e3045bc175e924999a4015804c39c5c6 Mon Sep 17 00:00:00 2001 From: Robin Getz I was using this when I was looking at some other recent tftp performance, and thought I would share. I really don't think it belongs, as it is (a) trivial and (b) mostly debug... (but I'm tr

Re: [U-Boot] [PATCH 0/4] Network defrag

2009-08-10 Thread Robin Getz
f (once the docs have been updated explaining what this is all for). -Robin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] minor debug cleanups in ./net

2009-08-06 Thread Robin Getz
On Thu 6 Aug 2009 15:40, Wolfgang Denk pondered: > Dear Robin Getz, > > In message <200908061427.10961.rg...@blackfin.uclinux.org> you wrote: > > On Thu 23 Jul 2009 03:01, Robin Getz pondered: > > > OK - this is on > > > > > > git remote -

Re: [U-Boot] minor debug cleanups in ./net

2009-08-06 Thread Robin Getz
On Thu 23 Jul 2009 03:01, Robin Getz pondered: > OK - this is on > > git remote -v > origin git://git.denx.de/u-boot-net.git > > git log --max-count=1 > commit 97cfe86163505ea18e7ff7b71e78df5bb03dad57 > > (Is there a better way to tell if git is up to date?) Was t

Re: [U-Boot] [PATCH 1/3] net: defragment IP packets

2009-08-05 Thread Robin Getz
On Fri 31 Jul 2009 03:46, Alessandro Rubini pondered: > Thanks for your comments. > > >> +#ifndef CONFIG_TFTP_MAXBLOCK > >> +#define CONFIG_TFTP_MAXBLOCK 16384 > > > > It is more than tftp - nfs could also use the same. > > Yes, I know. But most users are tftp ones. And if you want an even > num

Re: [U-Boot] [PATCH 1/3] net: defragment IP packets

2009-07-31 Thread Robin Getz
On Fri 31 Jul 2009 03:46, Alessandro Rubini pondered: > > For some reason - why I'm ping flooding when tftping a large file (with > > large tftp block size) - things hang. If I set the block size to under > > the MTU - it works fine. Do you get the same? > > Didn't try, and I can't do that today.

Re: [U-Boot] [PATCH 1/3] net: defragment IP packets

2009-07-31 Thread Robin Getz
; going to be too complex. It could work well, however, as a faster > tool for the interactive developer. I don't want something that is secure - security is beyond tftp's ability. For that -- you need to boot an OS and use https or sftp. All I'm asking for is something robust... :) -Robin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/3] net: defragment IP packets

2009-07-31 Thread Robin Getz
timeout on the first packet. Up to you if you want to handle this or not... All that should be needed is just to clear things in the start of NetLoop() (before eth_init) - there are a few things in there for CONFIG_NET_MULTI already, so I don't think that is a big deal... (That bec

Re: [U-Boot] [PATCH 1/3] net: defragment IP packets

2009-07-31 Thread Robin Getz
On Fri 31 Jul 2009 03:46, Alessandro Rubini pondered: > > For some reason - why I'm ping flooding when tftping a large file > > (with large tftp block size) - things hang. If I set the block size > > to under the MTU - it works fine. Do you get the same? > > Didn't try, and I can't do that today

Re: [U-Boot] [RFC 0/3] uboot-doc User's Manual Generation Tool

2009-07-30 Thread Robin Getz
On Thu 30 Jul 2009 15:55, Wolfgang Denk pondered: > Dear Robin Getz, > > In message <200907301550.40651.rg...@blackfin.uclinux.org> you wrote: > > > > I assume - no Invariant Sections, no Front-Cover Texts, and no Back-Cover > > Texts? or did you desire someth

Re: [U-Boot] [PATCH 1/3] net: defragment IP packets

2009-07-30 Thread Robin Getz
). > > The code includes a number of suggestions by Robin Getz. > > Signed-off-by: Alessandro Rubini > --- > net/net.c | 172 > +++-- > 1 files changed, 167 insertions(+), 5 deletions(-) > > diff --git a/net/net.c b/

Re: [U-Boot] [RFC 0/3] uboot-doc User's Manual Generation Tool

2009-07-30 Thread Robin Getz
On Thu 30 Jul 2009 14:45, Wolfgang DenkVersion 1.3 pondered: > Hi, > > In message Detlev Zundel wrote: > ... > > > Not meaning to interpret licensing, but to me that means I > > > can't copy/paste sections into end product documentation, and ship > > > the product for a fee... > > > > That's h

Re: [U-Boot] [RFC 0/3] uboot-doc User's Manual Generation Tool

2009-07-28 Thread Robin Getz
On Tue 28 Jul 2009 17:27, Wolfgang Denk pondered: > Dear John, > > in message <1248813631.3915.102.ca...@johns> you wrote: > > > > It seems to me that DUTS is designed to test U-Boot and also automates > > the running of commands whose output can be put online in the DULG. I > > Correct. And the

Re: [U-Boot] [PATCH][Net] Convert SMC91111 Ethernet driver toCONFIG_NET_MULTI API

2009-07-27 Thread Robin Getz
On Mon 27 Jul 2009 18:17, Ben Warren pondered: > I actually like to have them in the board C code.  To the casual > observer, it is obvious that certain ethernet controllers are optional, > whereas if all they see is a string of initialization functions for > different chips they might say, "WTF

Re: [U-Boot] [PATCH][Net] Convert SMC91111 Ethernet driver to CONFIG_NET_MULTI API

2009-07-27 Thread Robin Getz
On Mon 27 Jul 2009 17:47, Ben Warren pondered: > Ben Warren wrote: > > All in-tree boards that use this controller have CONFIG_NET_MULTI > > added > > Also: > > - changed CONFIG_DRIVER_SMC9 to CONFIG_SMC9 > > - cleaned up line lengths > > - modified all boards that override weak funct

Re: [U-Boot] [PATCH][Net] Convert SMC91111 Ethernet driver to CONFIG_NET_MULTI API

2009-07-27 Thread Robin Getz
On Mon 27 Jul 2009 17:47, Ben Warren pondered: > Ben Warren wrote: > > All in-tree boards that use this controller have CONFIG_NET_MULTI > > added > > Also: > > - changed CONFIG_DRIVER_SMC9 to CONFIG_SMC9 > > - cleaned up line lengths > > - modified all boards that override weak funct

Re: [U-Boot] [PATCH][Net] Convert SMC91111 Ethernet driver toCONFIG_NET_MULTI API

2009-07-27 Thread Robin Getz
ase_addr) 0 #endif that would remove all the "ifdef CONFIG_SMC9" in all the board files... also would not be required to set the initial value anymore either... -Robin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH/RFC] net: defragment IP packets

2009-07-27 Thread Robin Getz
On Mon 27 Jul 2009 08:13, Alessandro Rubini pondered: > Thanks for your comments. > > > Should have a CONFIG_ something - to make this conditional. > > This has been asked by Ben too. Will do, although I'm not very happy > about all those conditionals for every few lines of code. There are 22,25

Re: [U-Boot] [PATCH/RFC] net: defragment IP packets

2009-07-27 Thread Robin Getz
On Mon 27 Jul 2009 08:41, Wolfgang Denk pondered: > Dear Robin Getz, > > In message <200907262059.34188.rg...@blackfin.uclinux.org> you wrote: > > > ... > > and I was doing md5 or sha1 on things to make sure that things came over > > properly... > > Ar

Re: [U-Boot] [PATCH/RFC] net: defragment IP packets

2009-07-27 Thread Robin Getz
On Mon 27 Jul 2009 01:08, Ben Warren pondered: > Hi Guys, > > This is great work. Thanks! If you follow these guidelines, I'll pull > it into the net repo: > > 1. Configurable block size (via a well-named CONFIG). Choose a good >default value. > 2. Handle out-of-order fragments, and some

Re: [U-Boot] [PATCH/RFC] net: defragment IP packets

2009-07-27 Thread Robin Getz
eassembly buffer before you do the memcpy(). Setting the tftp block size to 16384 is bad if the buffer is also set to 16384.. (since it has the IP header on it)... -Robin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] Add md5sum and sha1 commands...

2009-07-26 Thread Robin Getz
From: Robin Getz Now that we have sha1 and md5 in lib_generic, allow people to use them on the command line, for checking downloaded files Signed-off-by: Robin Getz README |4 ++ common/cmd_mem.c | 68 + 2 files changed, 72

Re: [U-Boot] [PATCH 1/2 V3] new video driver for bus vcxkframebuffers

2009-07-26 Thread Robin Getz
On Sun 26 Jul 2009 07:46, Anatolij Gustschin pondered: > Jens Scharsig wrote: > > This patch adds a new video driver > > > > * adds common bus_vcxk framebuffer driver > > > > Signed-off-by: Jens Scharsig > > Applied to u-boot-video. Thanks! Note that I had to fix lots > of style issues before

Re: [U-Boot] [PATCH/RFC] net: defragment IP packets

2009-07-26 Thread Robin Getz
@@ TftpStart (void) #ifdef CONFIG_TFTP_PORT char *ep; /* Environment pointer */ #endif TftpServerIP = NetServerIP; +#ifdef CONFIG_NET_FRAGMENT + { + char *tmp; + tmp = getenv("tftpblocksize") ; + if (tmp) +

Re: [U-Boot] [PATCH/RFC] net: defragment IP packets

2009-07-26 Thread Robin Getz
eth0 root netem reorder 50% delay 10ms > > Thanks a lot, I was missing that. http://www.linuxfoundation.org/en/Net:Netem#Packet_re-ordering Some of the examples do not work, and the tc errors are pretty much meaningless - the man page is pretty thin, but the command line "tc qdisc chang

Re: [U-Boot] [PATCH/RFC] net: defragment IP packets

2009-07-25 Thread Robin Getz
On Sat 25 Jul 2009 22:02, Jerry Van Baren pondered: > Robin Getz wrote: > > On Fri 24 Jul 2009 04:04, Alessandro Rubini pondered: > >> This patch add a quick and dirty defrag step in IP reception. > > I needed to modify your patch a little bit to get it working on my &

Re: [U-Boot] Add md5sum and sha1 commands...

2009-07-25 Thread Robin Getz
On Sat 25 Jul 2009 22:49, Mike Frysinger pondered: > On Saturday 25 July 2009 16:07:49 Robin Getz wrote: > > --- a/common/cmd_mem.c > > +++ b/common/cmd_mem.c > > @@ -34,6 +34,14 @@ > > #endif > > #include > > > > +#ifdef CONFIG_CMD_MD5SUM

Re: [U-Boot] [PATCH/RFC] net: defragment IP packets

2009-07-25 Thread Robin Getz
be more dramatic... I needed to modify your patch a little bit to get it working on my platform. If Ben/Wolfgang are interested in taking this - I'll fix up my mods, and send it back. -Robin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] Add md5sum and sha1 commands...

2009-07-25 Thread Robin Getz
From: Robin Getz Now that we have sha1 and md5 in lib_generic, allow people to use them on the command line, for checking downloaded files Signed-off-by: Robin Getz README |4 ++ common/cmd_mem.c | 73 + 2 files changed, 77

Re: [U-Boot] http client?

2009-07-24 Thread Robin Getz
On Fri 24 Jul 2009 04:11, Alessandro Rubini pondered: > BTW: you (Jeffery) told you tried a blocksize of 16k, but how could > it work if u-boot refuses fragments? Did you add defragmenting > to the code first? I believe it depends on if it your host has gig support (for jumbo frames) Most Gig hos

Re: [U-Boot] minor debug cleanups in ./net

2009-07-22 Thread Robin Getz
On Thu 23 Jul 2009 02:27, Ben Warren pondered: > Robin, > > This won't apply: > > bwar...@bwarren-bldsrv:~/src/u-boot-net$ git am -s --whitespace=strip > ~/h_drive/patches/minor\ debug\ cleanups\ in\ ._net.eml > Applying minor debug cleanups in ./net > fatal: pat

[U-Boot] minor debug cleanups in ./net

2009-07-22 Thread Robin Getz
From: Robin Getz Minor ./net cleanups - no functional changes - change #ifdef DEBUG printf(); #endif to just debug() - changed __FUNCTION__ to __func__ - got rid of extra whitespace between function and opening brace - removed unnecessary braces on if statements gcc dead code elimination

Re: [U-Boot] http client?

2009-07-22 Thread Robin Getz
> } > > I don't think it's worth adding. This is based on ... ? If it reduces download time by 1/2 (1432 byte block size == 13.70 seconds, 4096 byte block size == 6.85 seconds) it might be worth the complexity... At least wor

Re: [U-Boot] http client?

2009-07-22 Thread Robin Getz
On Wed 22 Jul 2009 16:53, Ben Warren pondered: > Robin Getz wrote: > > I see: > > > > #define TFTP_MTU_BLOCKSIZE 1468blksize > > static unsigned short TftpBlkSizeOption=TFTP_MTU_BLOCKSIZE; > > > > /* try for more effic. blk size */ > &g

Re: [U-Boot] http client?

2009-07-22 Thread Robin Getz
On Wed 22 Jul 2009 16:32, Ben Warren pondered:> Robin Getz wrote: > > On Wed 22 Jul 2009 10:04, jeffery palmer pondered: > > > >> We are looking for an http client now as well. Our major issue revolves > >> > > around the download times for tft

Re: [U-Boot] [PATCH] Less verbose output when loading vxworks 6.x images

2009-07-22 Thread Robin Getz
On Wed 22 Jul 2009 15:32, Niklaus Giger pondered: > Loading vxWorks 5.x images resulted just into 3 or 4 lines of output. > With vxWorks 6.x and the new GCC it emits about 30 lines, which is > far too noisy in my opinion. > > Signed-off-by: Niklaus Giger > --- > common/cmd_elf.c |2 ++ > 1 f

Re: [U-Boot] http client?

2009-07-22 Thread Robin Getz
On Wed 22 Jul 2009 10:04, jeffery palmer pondered: > We are looking for an http client now as well. Our major issue revolves around the download times for tftp. > > Can Volkmar Uhlig kindly provide the patches? > > Our units automically update themselves inside of uboot giving us the most > co

Re: [U-Boot] http client?

2009-07-22 Thread Robin Getz
On Tue 21 Jul 2009 17:09, Wolfgang Denk pondered: > Dear Robin Getz, > > In message <200907211400.21275.rg...@blackfin.uclinux.org> you wrote: > > > > > I know there have been discussions about adding wget to U-Boot, > > > which I agree is not something tha

Re: [U-Boot] http client?

2009-07-21 Thread Robin Getz
Sorry - first time I sent this -- I forgot to cc the list... On Tue 21 Jul 2009 12:37, Robin Getz pondered: > redboot supports (and has since 2002) a mini-http client: > > This is just a transfer data via the network using HTTP protocol, no > better or worse than tftp. (no https,

Re: [U-Boot] [PATCH] - save the server's mac address...

2009-07-21 Thread Robin Getz
On Tue 21 Jul 2009 02:37, Ben Warren pondered: > Can you please re-submit using git tools? From: Robin Getz Linux's netconsole works much better when you can pass it the MAC address of the server. (otherwise it just uses broadcast, which everyone else on my network complains about :

Re: [U-Boot] [RFC] CONFIG naming convetion

2009-07-21 Thread Robin Getz
On Mon 20 Jul 2009 16:33, Wolfgang Denk pondered: > Dear Robin Getz, [snip] > You seem to live on a different planet than me. That is a well though out point. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] v3 - add dns

2009-07-20 Thread Robin Getz
ean up style issues - remove packet from stack - cleaned up some comments - failure returns much faster (if server responds, don't wait for timeout) - use built in functions (memcpy) rather than byte copy. Signed-off-by: Robin Getz Signed-off-by: Pieter Voorthuijsen common/cmd_net.

Re: [U-Boot] [RFC] CONFIG naming convetion

2009-07-19 Thread Robin Getz
On Sat 18 Jul 2009 18:25, Wolfgang Denk pondered: > > > > I guess we could back up a step and look at the users, and defined things > > as things that should be changed by: > >  - arch maintainers (Core/CPU specific) > >  - SoC maintainer (SoC specific) > >  - Board maintainer (PCB specific) >

Re: [U-Boot] [PATCH] - add dns

2009-07-19 Thread Robin Getz
On Sat 18 Jul 2009 21:15, Mike Frysinger pondered: > On Saturday 18 July 2009 20:27:00 Robin Getz wrote: > > On Sat 18 Jul 2009 18:11, Mike Frysinger pondered: > > > keep the modulus something with only 1 bit set so gcc will optimize into > > > a simple and operation. p

Re: [U-Boot] [PATCH] - add dns

2009-07-19 Thread Robin Getz
On Sun 19 Jul 2009 03:48, Wolfgang Denk pondered: > Dear Robin Getz, > In message <200907172120.50413.rg...@blackfin.uclinux.org> you wrote: > > On Fri 17 Jul 2009 16:55, Wolfgang Denk pondered: > > > Please keep list sorted. > > > > sorted how? What we h

Re: [U-Boot] [PATCH] - add dns

2009-07-18 Thread Robin Getz
On Sat 18 Jul 2009 18:11, Mike Frysinger pondered: > On Saturday 18 July 2009 01:14:25 Robin Getz wrote: > > + DnsOurPort = 1 + (get_timer(0) % 4096); > > 4096 port range seems kind of small. i dont think the requests really need > to > be greater than 1. not s

  1   2   >