Re: [PATCH] efi_loader: remove comparisons to string literals from runtime

2025-02-11 Thread Ilias Apalodimas
On Tue, 11 Feb 2025 at 11:01, Mark Kettenis wrote: > > > From: Ilias Apalodimas > > Date: Tue, 11 Feb 2025 10:50:01 + > > > > Hi Mark, > > > > On Tue, 11 Feb 2025 at 10:17, Mark Kettenis wrote: > > > > > > > From: Ilias Apalo

Re: [PATCH] efi_loader: remove comparisons to string literals from runtime

2025-02-11 Thread Ilias Apalodimas
Hi Mark, On Tue, 11 Feb 2025 at 10:17, Mark Kettenis wrote: > > > From: Ilias Apalodimas > > > > On EFI runtime services, we manage to preserve string literals > > by placing the .efi_runtime section just before .data and preserving > > it when fixing

[PATCH] efi_loader: remove comparisons to string literals from runtime

2025-02-11 Thread Ilias Apalodimas
.text and .runtime sections. So let's define the strings we used to compare in the stack for runtime services Signed-off-by: Ilias Apalodimas --- lib/efi_loader/efi_var_mem.c | 3 ++- lib/efi_loader/efi_variable_tee.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --

Re: (subset) [PATCH 0/8] Reverts and fixes for board failures

2025-02-10 Thread Ilias Apalodimas
On Mon, 10 Feb 2025 at 20:38, Tom Rini wrote: > > On Sun, 01 Dec 2024 07:42:28 -0700, Simon Glass wrote: > > > This series collects together a set of reverts and fixes to get most of > > the boards in the sjg lab running again. > > > > Unfortunately three of them have developed a failure which req

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-06 Thread Ilias Apalodimas
Hi Simon, On Thu, 6 Feb 2025 at 17:48, Simon Glass wrote: > > Hi Ilias, > > On Thu, 6 Feb 2025 at 08:16, Ilias Apalodimas > wrote: > > > > On Thu, 6 Feb 2025 at 14:58, Simon Glass wrote: > > > > > > Hi Ilias, > > > > >

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-06 Thread Ilias Apalodimas
On Thu, 6 Feb 2025 at 14:58, Simon Glass wrote: > > Hi Ilias, > > On Thu, 6 Feb 2025 at 05:52, Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > On Thu, 6 Feb 2025 at 14:30, Simon Glass wrote: > > > > > > Hi Ilias, > > >

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-06 Thread Ilias Apalodimas
Hi Simon, On Thu, 6 Feb 2025 at 14:30, Simon Glass wrote: > > Hi Ilias, > > On Wed, 5 Feb 2025 at 09:54, Ilias Apalodimas > wrote: > > > > Hi Heinrich, > > > > On Wed, 5 Feb 2025 at 18:48, Heinrich Schuchardt wrote: > > > > > > On 2/5/2

Re: [PATCH v1 2/6] doc: update meminfo with arch specific information

2025-02-06 Thread Ilias Apalodimas
Hi Simon On Thu, 6 Feb 2025 at 14:31, Simon Glass wrote: > > Hi Ilias, > > On Wed, 5 Feb 2025 at 00:17, Ilias Apalodimas > wrote: > > > > Since we added support in meminfo to dump live page tables, describe > > the only working architecture for now

Re: [RFC PATCH 0/4] Fix page permission on arm64 architectures

2025-02-06 Thread Ilias Apalodimas
Hi Simon, On Thu, 6 Feb 2025 at 14:33, Simon Glass wrote: > > Hi Ilias, > > On Thu, 30 Jan 2025 at 00:21, Ilias Apalodimas > wrote: > > > > U-Boot maps all pages as RWX. Sadly it's not not 1990 anymore and we are > > better off mapping binaries with

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-06 Thread Ilias Apalodimas
Hi Heinrich, [...] > > > +++ b/arch/arm/lib/cache.c > > > @@ -170,3 +170,5 @@ __weak int arm_reserve_mmu(void) > > > > > > return 0; > > > } > > > + > > > +void __weak pgprot_set_attrs(phys_addr_t addr, size_t size, u64 perm) {} > > > > I would prefer if the weak function would return -EN

[PATCH] tpm: unconstify tpm_tis_chip_data

2025-02-06 Thread Ilias Apalodimas
The struct contains an iomem pointer that we later remap and update. Remove const from the struct definition. Signed-off-by: Ilias Apalodimas --- drivers/tpm/tpm2_tis_mmio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tpm/tpm2_tis_mmio.c b/drivers/tpm

Re: [PATCH v1 3/6] arm: Prepare linker scripts for memory permissions

2025-02-05 Thread Ilias Apalodimas
On Wed, 5 Feb 2025 at 21:25, Tom Rini wrote: > > On Wed, Feb 05, 2025 at 09:18:50PM +0200, Ilias Apalodimas wrote: > > Hi Tom, > > > > On Wed, 5 Feb 2025 at 19:33, Tom Rini wrote: > > > > > > On Wed, Feb 05, 2025 at 09:16:47AM +0200, Ilias Apalodimas

Re: [PATCH v1 3/6] arm: Prepare linker scripts for memory permissions

2025-02-05 Thread Ilias Apalodimas
Hi Tom, On Wed, 5 Feb 2025 at 19:33, Tom Rini wrote: > > On Wed, Feb 05, 2025 at 09:16:47AM +0200, Ilias Apalodimas wrote: > > > Upcoming patches are switching the memory mappings to RW, RO, RX > > after the U-Boot binary and its data are relocated. Add > > annotatio

Re: [PATCH v1 2/6] doc: update meminfo with arch specific information

2025-02-05 Thread Ilias Apalodimas
Hi Tom, On Wed, 5 Feb 2025 at 19:22, Tom Rini wrote: > > On Wed, Feb 05, 2025 at 09:16:46AM +0200, Ilias Apalodimas wrote: > > > Since we added support in meminfo to dump live page tables, describe > > the only working architecture for now (aarch64) and add links to public

Re: [PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-05 Thread Ilias Apalodimas
Hi Heinrich, On Wed, 5 Feb 2025 at 18:48, Heinrich Schuchardt wrote: > > On 2/5/25 08:16, Ilias Apalodimas wrote: > > For armv8 we are adding proper page permissions for the relocated U-Boot > > binary. Add a weak function that can be used across architectures to change > &

Re: [PATCH v1 3/6] arm: Prepare linker scripts for memory permissions

2025-02-05 Thread Ilias Apalodimas
Hi Richard, On Wed, 5 Feb 2025 at 19:23, Richard Henderson wrote: > > On 2/4/25 23:16, Ilias Apalodimas wrote: > > @@ -98,18 +101,20 @@ SECTIONS > > } > > #endif > > > > - . = ALIGN(8); > > - .rodata : { *(SORT_BY_ALIGNMENT(SORT_BY_NAME(

Re: [PATCH v1 6/6] arm64: Enable RW, RX and RO mappings for the relocated binary

2025-02-05 Thread Ilias Apalodimas
Hi Jerome, On Wed, 5 Feb 2025 at 11:57, Jerome Forissier wrote: > > > > On 2/5/25 08:16, Ilias Apalodimas wrote: > > Now that we have everything in place switch the page permissions for > > .rodata, .text and .data just after we relocate everything in top of the > >

Re: [PATCH v1 3/6] arm: Prepare linker scripts for memory permissions

2025-02-05 Thread Ilias Apalodimas
On Wed, 5 Feb 2025 at 14:42, Michal Simek wrote: > > Hi, > > On 2/5/25 09:22, Ilias Apalodimas wrote: > > I'm just replying to myself here but I'll send a v2 when the patches > > are reviewed. > > > > I can add the linker under an ifdef, so u-boot siz

Re: [PATCH v1 1/6] meminfo: add memory details for armv8

2025-02-05 Thread Ilias Apalodimas
On Wed, 5 Feb 2025 at 11:27, Jerome Forissier wrote: > > > > On 2/5/25 08:16, Ilias Apalodimas wrote: > > Upcoming patches are mapping memory with RO, RW^X etc permsissions. > > Fix the meminfo command to display them properly > > > > Acked-by: Jerome

Re: [PATCH v1 3/6] arm: Prepare linker scripts for memory permissions

2025-02-05 Thread Ilias Apalodimas
I'm just replying to myself here but I'll send a v2 when the patches are reviewed. I can add the linker under an ifdef, so u-boot size won't change unless a Kconfig options is selected /Ilias On Wed, 5 Feb 2025 at 09:17, Ilias Apalodimas wrote: > > Upcoming patches are

[PATCH v1 5/6] treewide: Add a function to change page permissions

2025-02-05 Thread Ilias Apalodimas
For armv8 we are adding proper page permissions for the relocated U-Boot binary. Add a weak function that can be used across architectures to change the page permissions Signed-off-by: Ilias Apalodimas --- arch/arc/lib/cache.c | 2 ++ arch/arm/cpu/arm926ejs/cache.c | 2 ++ arch/arm

[PATCH v1 6/6] arm64: Enable RW, RX and RO mappings for the relocated binary

2025-02-05 Thread Ilias Apalodimas
them to RX initially but remap them as RWX right before ExitBootServices. Link: https://lore.kernel.org/u-boot/20250129-rockchip-pinctrl-const-v1-0-450ccdadf...@cherry.de/ Link: https://lore.kernel.org/u-boot/20250130133646.2177194-1-andre.przyw...@arm.com/ Signed-off-by: Ilias Apalodimas --- comm

[PATCH v1 4/6] arm64: mmu_change_region_attr() add an option not to break PTEs

2025-02-05 Thread Ilias Apalodimas
-off-by: Ilias Apalodimas --- arch/arm/cpu/armv8/cache_v8.c | 6 +- arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 10 +- arch/arm/include/asm/system.h | 11 ++- arch/arm/mach-snapdragon/board.c| 2 +- 4 files changed, 21 insertions(+), 8 deletions

[PATCH v1 2/6] doc: update meminfo with arch specific information

2025-02-05 Thread Ilias Apalodimas
Since we added support in meminfo to dump live page tables, describe the only working architecture for now (aarch64) and add links to public documentation for further reading. Signed-off-by: Ilias Apalodimas --- doc/usage/cmd/meminfo.rst | 71 +-- 1 file

[PATCH v1 3/6] arm: Prepare linker scripts for memory permissions

2025-02-05 Thread Ilias Apalodimas
_NONE are emitted as well if we page align the section. Keep it out for now and we can fix it in future patches. Acked-by: Jerome Forissier Signed-off-by: Ilias Apalodimas --- arch/arm/cpu/armv8/u-boot.lds | 29 + include/asm-generic/sections.h | 2 ++ 2 files change

[PATCH v1 1/6] meminfo: add memory details for armv8

2025-02-05 Thread Ilias Apalodimas
Upcoming patches are mapping memory with RO, RW^X etc permsissions. Fix the meminfo command to display them properly Acked-by: Jerome Forissier Signed-off-by: Ilias Apalodimas --- arch/arm/cpu/armv8/cache_v8.c| 26 +++--- arch/arm/include/asm/armv8/mmu.h | 2 ++ cmd

[PATCH v1 0/6] Fix page permission on arm64 architectures

2025-02-05 Thread Ilias Apalodimas
n in 'meminfo' command patch #3 prepares linker scripts, aligns sections in page boundaries etc patch #4 prepares an internal function to change the PTEs patch #5 adds function definitions & stubs for all archs patch #6 wires up the changes in U-Boot after it relocates [0] https://lore

Re: [PATCH 1/2] efi_firmware: set EFI capsule dfu_alt_info env explicitly

2025-02-05 Thread Ilias Apalodimas
Hi Jonathan, On Mon, 3 Feb 2025 at 23:54, Jonathan Humphreys wrote: > > The current implementation of EFI capsule update uses set_dfu_alt_info() to > set the dfu_alt_info environment variable with the settings it requires. > However, set_dfu_alt_info() is doing this for all DFU operations, even >

Re: [PATCH 00/21] EFI driver to support multiple network interfaces

2025-02-04 Thread Ilias Apalodimas
On Tue, 4 Feb 2025 at 15:28, Adriano Córdova wrote: > > > > El mar, 4 feb 2025 a las 6:37, Ilias Apalodimas > () escribió: >> >> Hi Adriano, >> >> >> On Wed, 22 Jan 2025 at 19:09, Adriano Cordova wrote: >> > >> > This seri

Re: [PATCH] net: Kconfig: depend on DM_RNG for WGET_HTTPS

2025-02-04 Thread Ilias Apalodimas
gested-by: Michal Simek > Co-developed-by: Ilias Apalodimas > Signed-off-by: Ilias Apalodimas > Signed-off-by: Jerome Forissier > --- > cmd/Kconfig | 1 + > net/lwip/wget.c | 10 +++--- > 2 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/cmd/Kcon

Re: [PATCH] dfu: Prevent set_dfu_alt_info() from overwriting a previous value

2025-02-04 Thread Ilias Apalodimas
Hi Jon, On Mon, 3 Feb 2025 at 23:38, Jon Humphreys wrote: > > Ilias Apalodimas writes: > > > Hi Jon, > > > > On Fri, 17 Jan 2025 at 00:02, Jon Humphreys wrote: > >> > >> Sughosh Ganu writes: > >> > >> > On Thu, 16 Jan 2025 a

Re: [PATCH 6/6] efi_loader: support file rename in SetInfo()

2025-02-04 Thread Ilias Apalodimas
Hi Gabriel On Wed, 22 Jan 2025 at 07:34, Gabriel Dalimonte wrote: > > Following the UEFI specification. The specification did not seem to > delineate if file_name was explicitly a file name only, or could > include paths to move the file to a different directory. The more > generous interpretatio

Re: [RFC PATCH 0/4] Fix page permission on arm64 architectures

2025-02-04 Thread Ilias Apalodimas
Hi Love, On Tue, 4 Feb 2025 at 13:53, Love Kumar wrote: > > Hi Ilias, > > > On 30/01/25 12:50 pm, Ilias Apalodimas wrote: > > U-Boot maps all pages as RWX. Sadly it's not not 1990 anymore and we are > > better off mapping binaries with proper permissions. > &g

Re: [PATCH 00/21] EFI driver to support multiple network interfaces

2025-02-04 Thread Ilias Apalodimas
Hi Adriano, On Wed, 22 Jan 2025 at 19:09, Adriano Cordova wrote: > > This series introduces an EFI driver to manage EFI net objects. The main > functionalities implemented here are the following: > - Support multiple efi_net_obj > - Manage efi_net_obj with EFI driver > -

Re: [PATCH 02/21] efi_loader: expose symbols to be used by the EFI network stack

2025-02-04 Thread Ilias Apalodimas
On Wed, 22 Jan 2025 at 19:09, Adriano Cordova wrote: > > The following symbols are exposed: > - efi_reinstall_protocol_interface > This is done so that the device path protocol interface > of the network device can be changed internally by u-boot >

Re: [PATCH 05/21] efi_loader: efi_device_path: Let network device paths receive the net udevice as an argument

2025-02-04 Thread Ilias Apalodimas
On Wed, 22 Jan 2025 at 19:09, Adriano Cordova wrote: > > Support setting the device path with efi_dp_from_eth, efi_dp_from_ipv4, > and efi_dp_from_http to an ethernet device other than the current > ethernet udevice. Calling eth_dp_from_eth with eth_get_dev() as the > argument recovers the pevious

Re: [PATCH 04/21] efi_loader: efi_net: Add efi_net_do_start() to efi_net.c

2025-02-04 Thread Ilias Apalodimas
Ok ignore my comments on patch#2. This explains what that patch is trying to do. I think doing the alternative of what you proposed in #2 is cleaner. Can't we add an EFI event that triggers and updates whatever it needs to on IP address changes? Thanks /Ilias On Wed, 22 Jan 2025 at 19:09, Adrian

Re: [PATCH 03/21] efi_loader: efi_setup: Add efi_start_obj_list() to efi_setup.c

2025-02-04 Thread Ilias Apalodimas
Hi Adriano, On Wed, 22 Jan 2025 at 19:09, Adriano Cordova wrote: > > The coomand bootefi calls efi_init_obj_list to do the efi set up > before launching an .efi payload, but efi_init_obj_list is called > only once. There are some initializations which depend on the > environment and should be don

Re: [PATCH v2 3/3] mbedtls: refactor mbedtls build for XPL

2025-02-04 Thread Ilias Apalodimas
MBEDTLS_LIB_DIR)/x509.o > -mbedtls_lib_x509-$(CONFIG_$(SPL_)ASN1_DECODER_MBEDTLS) += \ > +mbedtls_lib_x509-$(CONFIG_$(XPL_)ASN1_DECODER_MBEDTLS) += \ > $(MBEDTLS_LIB_DIR)/asn1parse.o \ > $(MBEDTLS_LIB_DIR)/asn1write.o \ > $(MBEDTLS_LIB_DIR)/oid.o > -mbedtls_lib_x509-$(CONFIG_$(SPL_)RSA_PUBLIC_KEY_PARSER_MBEDTLS) += \ > +mbedtls_lib_x509-$(CONFIG_$(XPL_)RSA_PUBLIC_KEY_PARSER_MBEDTLS) += \ > $(MBEDTLS_LIB_DIR)/bignum.o \ > $(MBEDTLS_LIB_DIR)/bignum_core.o \ > $(MBEDTLS_LIB_DIR)/rsa.o \ > $(MBEDTLS_LIB_DIR)/rsa_alt_helpers.o > -mbedtls_lib_x509-$(CONFIG_$(SPL_)ASYMMETRIC_PUBLIC_KEY_MBEDTLS) += \ > +mbedtls_lib_x509-$(CONFIG_$(XPL_)ASYMMETRIC_PUBLIC_KEY_MBEDTLS) += \ > $(MBEDTLS_LIB_DIR)/pk.o \ > $(MBEDTLS_LIB_DIR)/pk_wrap.o \ > $(MBEDTLS_LIB_DIR)/pkparse.o > -mbedtls_lib_x509-$(CONFIG_$(SPL_)X509_CERTIFICATE_PARSER_MBEDTLS) += \ > +mbedtls_lib_x509-$(CONFIG_$(XPL_)X509_CERTIFICATE_PARSER_MBEDTLS) += \ > $(MBEDTLS_LIB_DIR)/x509_crl.o \ > $(MBEDTLS_LIB_DIR)/x509_crt.o > -mbedtls_lib_x509-$(CONFIG_$(SPL_)PKCS7_MESSAGE_PARSER_MBEDTLS) += \ > +mbedtls_lib_x509-$(CONFIG_$(XPL_)PKCS7_MESSAGE_PARSER_MBEDTLS) += \ > $(MBEDTLS_LIB_DIR)/pkcs7.o > > #mbedTLS TLS support > -obj-$(CONFIG_MBEDTLS_LIB_TLS) += mbedtls_lib_tls.o > +obj-$(CONFIG_$(XPL_)MBEDTLS_LIB_TLS) += mbedtls_lib_tls.o > mbedtls_lib_tls-y := \ > $(MBEDTLS_LIB_DIR)/mps_reader.o \ > $(MBEDTLS_LIB_DIR)/mps_trace.o \ > diff --git a/lib/mbedtls/mbedtls_def_config.h > b/lib/mbedtls/mbedtls_def_config.h > index fd440c392f9..dda3f4dd6e4 100644 > --- a/lib/mbedtls/mbedtls_def_config.h > +++ b/lib/mbedtls/mbedtls_def_config.h > @@ -11,12 +11,12 @@ > * Author: Raymond Mao > */ > > -#if defined CONFIG_MBEDTLS_LIB > +#if CONFIG_IS_ENABLED(MBEDTLS_LIB) > > #if CONFIG_IS_ENABLED(MD5) > #define MBEDTLS_MD_C > #define MBEDTLS_MD5_C > -#if defined CONFIG_MBEDTLS_LIB_CRYPTO_ALT > +#if CONFIG_IS_ENABLED(MBEDTLS_LIB_HASHING_ALT) > #define MBEDTLS_MD5_ALT > #endif > #endif > @@ -24,7 +24,7 @@ > #if CONFIG_IS_ENABLED(SHA1) > #define MBEDTLS_MD_C > #define MBEDTLS_SHA1_C > -#if defined CONFIG_MBEDTLS_LIB_CRYPTO_ALT > +#if CONFIG_IS_ENABLED(MBEDTLS_LIB_HASHING_ALT) > #define MBEDTLS_SHA1_ALT > #endif > #endif > @@ -32,7 +32,7 @@ > #if CONFIG_IS_ENABLED(SHA256) > #define MBEDTLS_MD_C > #define MBEDTLS_SHA256_C > -#if defined CONFIG_MBEDTLS_LIB_CRYPTO_ALT > +#if CONFIG_IS_ENABLED(MBEDTLS_LIB_HASHING_ALT) > #define MBEDTLS_SHA256_ALT > #endif > #if CONFIG_IS_ENABLED(SHA256_SMALLER) > @@ -48,7 +48,7 @@ > #if CONFIG_IS_ENABLED(SHA512) > #define MBEDTLS_MD_C > #define MBEDTLS_SHA512_C > -#if defined CONFIG_MBEDTLS_LIB_CRYPTO_ALT > +#if CONFIG_IS_ENABLED(MBEDTLS_LIB_HASHING_ALT) > #define MBEDTLS_SHA512_ALT > #endif > #if CONFIG_IS_ENABLED(SHA512_SMALLER) > @@ -60,7 +60,7 @@ > #define MBEDTLS_HKDF_C > #endif > > -#if defined CONFIG_MBEDTLS_LIB_X509 > +#if CONFIG_IS_ENABLED(MBEDTLS_LIB_X509) > > #if CONFIG_IS_ENABLED(X509_CERTIFICATE_PARSER) > #define MBEDTLS_X509_USE_C > @@ -89,9 +89,9 @@ > #define MBEDTLS_ASN1_WRITE_C > #endif > > -#endif /* #if defined CONFIG_MBEDTLS_LIB_X509 */ > +#endif /* #if CONFIG_IS_ENABLED(MBEDTLS_LIB_X509) */ > > -#if IS_ENABLED(CONFIG_MBEDTLS_LIB_TLS) > +#if CONFIG_IS_ENABLED(MBEDTLS_LIB_TLS) > #include "rtc.h" > > /* Generic options */ > @@ -106,25 +106,36 @@ > #define MBEDTLS_ENTROPY_C > #define MBEDTLS_NO_PLATFORM_ENTROPY > #define MBEDTLS_SSL_PROTO_TLS1_2 > +#if CONFIG_IS_ENABLED(X509_CERTIFICATE_PARSER) > #define MBEDTLS_SSL_SERVER_NAME_INDICATION > +#endif > #define MBEDTLS_KEY_EXCHANGE_PSK_ENABLED > > /* RSA */ > +#if CONFIG_IS_ENABLED(X509_CERTIFICATE_PARSER) && \ > + CONFIG_IS_ENABLED(RSA_PUBLIC_KEY_PARSER) > #define MBEDTLS_KEY_EXCHANGE_RSA_ENABLED > #define MBEDTLS_KEY_EXCHANGE_ECDHE_RSA_ENABLED > #define MBEDTLS_KEY_EXCHANGE_ECDH_RSA_ENABLED > +#endif > #define MBEDTLS_GCM_C > > /* ECDSA */ > +#if CONFIG_IS_ENABLED(ASN1_DECODER) > #define MBEDTLS_ECDSA_C > +#define MBEDTLS_ECP_C > #define MBEDTLS_ECDH_C > +#endif > #define MBEDTLS_ECDSA_DETERMINISTIC > #define MBEDTLS_HMAC_DRBG_C > -#define MBEDTLS_KEY_EXCHANGE_ECDHE_ECDSA_ENABLED > -#define MBEDTLS_KEY_EXCHANGE_ECDH_ECDSA_ENABLED > + > #define MBEDTLS_CAN_ECDH > #define MBEDTLS_PK_CAN_ECDSA_SIGN > -#define MBEDTLS_ECP_C > +#if CONFIG_IS_ENABLED(X509_CERTIFICATE_PARSER) > +#define MBEDTLS_KEY_EXCHANGE_ECDH_ECDSA_ENABLED > +#define MBEDTLS_KEY_EXCHANGE_ECDHE_ECDSA_ENABLED > +#endif > + > #define MBEDTLS_ECP_DP_SECP256K1_ENABLED > #define MBEDTLS_ECP_DP_SECP192R1_ENABLED > #define MBEDTLS_ECP_DP_SECP224R1_ENABLED > @@ -138,6 +149,6 @@ > #define MBEDTLS_ECP_DP_BP384R1_ENABLED > #define MBEDTLS_ECP_DP_BP512R1_ENABLED > > -#endif /* #if defined CONFIG_MBEDTLS_LIB_TLS */ > +#endif /* #if CONFIG_IS_ENABLED(MBEDTLS_LIB_TLS) */ > > -#endif /* #if defined CONFIG_MBEDTLS_LIB */ > +#endif /* #if CONFIG_IS_ENABLED(MBEDTLS_LIB) */ > -- > 2.25.1 > Acked-by: Ilias Apalodimas

Re: [PATCH v2 1/3] mbedtls: fix incorrect kconfig dependencies on mbedtls

2025-02-04 Thread Ilias Apalodimas
LS_LIB_TLS > depends on ASYMMETRIC_PUBLIC_KEY_MBEDTLS > depends on ASN1_DECODER_MBEDTLS > depends on ASYMMETRIC_PUBLIC_KEY_MBEDTLS > - depends on MBEDTLS_LIB_CRYPTO > + depends on MBEDTLS_LIB > help > Enable MbedTLS TLS library. Required for HTTPs support > in wget > -- > 2.25.1 > Reviewed-by: Ilias Apalodimas

Re: [PATCH v3 3/4] test: unit tests for strstr() and strnstr()

2025-02-04 Thread Ilias Apalodimas
On Mon, 3 Feb 2025 at 11:12, Heinrich Schuchardt wrote: > > Add unit tests for the library functions. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Ilias Apalodimas > --- > v3: > no change > v2: > no change > --- > lib/string.c

Re: [PATCH v3 4/4] net: use strnstr() for lwip_strnstr()

2025-02-04 Thread Ilias Apalodimas
e LWIP_ERR_T int > #define LWIP_CONST_CAST(target_type, val) ((target_type)((uintptr_t)val)) > -- > 2.47.1 > Reviewed-by: Ilias Apalodimas

Re: [PATCH v3 2/4] lib: implement strnstr()

2025-02-04 Thread Ilias Apalodimas
ed > + * @s2:string to search for > + * @len: maximum number of characters in s2 to consider > + * > + * Return: pointer to the first occurrence or NULL > + */ > +char *strstr(const char *s1, const char *s2) > +{ > + return strnstr(s1, s2, SIZE_MAX); > +} > +#endif > + > #ifndef __HAVE_ARCH_MEMCHR > /** > * memchr - Find a character in an area of memory. > -- > 2.47.1 > Reviewed-by: Ilias Apalodimas

Re: [PATCH] net: Kconfig: Select DM_RNG for LWIP

2025-02-03 Thread Ilias Apalodimas
On Mon, 3 Feb 2025 at 17:23, Michal Simek wrote: > > > > On 2/3/25 16:13, Ilias Apalodimas wrote: > > Thanks Michal > > > > On Mon, 3 Feb 2025 at 17:03, Michal Simek wrote: > >> > >> LWIP wget.c/mbedtls_hardware_poll() is calling dm_rng_read() but

Re: [PATCH] net: Kconfig: Select DM_RNG for LWIP

2025-02-03 Thread Ilias Apalodimas
Thanks Michal On Mon, 3 Feb 2025 at 17:03, Michal Simek wrote: > > LWIP wget.c/mbedtls_hardware_poll() is calling dm_rng_read() but dependency > is not recorded anywhere that's why select DM_RNG when LWIP stack i used. > > Signed-off-by: Michal Simek > --- > > net/Kconfig | 1 + > 1 file change

Re: [PATCH] env: fat: Avoid writing to read-only location

2025-02-03 Thread Ilias Apalodimas
; - } > + /* reserve one more char for the manipulation below */ > + static char part_str[] = CONFIG_ENV_FAT_DEVICE_AND_PART "\0"; > + > + if (!strcmp(CONFIG_ENV_FAT_INTERFACE, "mmc") && part_str[0] == ':') { > + part_str[0] = '0' + mmc_get_env_dev(); > + strcpy(&part_str[1], CONFIG_ENV_FAT_DEVICE_AND_PART); > } > > return part_str; > -- > 2.25.1 > Acked-by: Ilias Apalodimas

Re: [PATCH 00/14] pinctrl: rockchip: fix editing const struct + constify rockchip_pin_ctrl

2025-01-31 Thread Ilias Apalodimas
ntin Schulz wrote: > >>> While testing some WIP work done by Ilias Apalodimas on guaranteeing > >>> read-only memory areas truly are handled as read-only[1], my RK3588 > >>> Tiger couldn't reach U-Boot CLI anymore because of the pinctrl driver > >>

Re: [PATCH 3/3] mbedtls: refactor mbedtls build for XPL

2025-01-31 Thread Ilias Apalodimas
Hi Raymond, Tom This config seems reasonable to me and we can now build a combination of SPL + older crypto + mbedTLS for u-boot proper which was always the goal. I do still think the naming is a bit confusing. On Mon, 27 Jan 2025 at 17:17, Raymond Mao wrote: > > Refactor the entire kconfig pag

Re: [PATCH 2/3] mbedtls: access mbedtls private members in mscode and pkcs7 parser

2025-01-31 Thread Ilias Apalodimas
hich are defined > + * as private in MbedTLS context. > + * E.g: x509_internal.h, mbedtls_sha256_context and mbedtls_sha1_context. > + * MBEDTLS_ALLOW_PRIVATE_ACCESS needs to be enabled to allow the external > + * access, but directly including is not > + * allowed, since this will include and break the sandbox test. > + */ > +#define MBEDTLS_ALLOW_PRIVATE_ACCESS > + > +#endif /* _MBEDTLS_OPT_H */ > -- > 2.25.1 > Acked-by: Ilias Apalodimas

Re: [PATCH 1/3] mbedtls: fix incorrect kconfig dependencies on mbedtls

2025-01-31 Thread Ilias Apalodimas
Hi Raymond On Mon, 27 Jan 2025 at 17:17, Raymond Mao wrote: > > Currently building with WGET_HTTPS,NET_LWIP and MBEDTLS_LIB failed > due to a few incorrect kconfig dependencies. > Fix these and clarify what is the purpose of MBEDTLS_LIB_CRYPTO_ALT. > > Signed-off-by: Raymond Mao > --- > cmd/Kco

Re: [PATCH] xilinx: Enable MBEDTLS/LWIP/WGET and WGET_HTTPS

2025-01-30 Thread Ilias Apalodimas
IS_IN_SPI_FLASH=y > CONFIG_SYS_REDUNDAND_ENVIRONMENT=y > CONFIG_ENV_FAT_DEVICE_AND_PART=":auto" > CONFIG_SYS_RELOC_GD_ENV_ADDR=y > -CONFIG_NETCONSOLE=y > -CONFIG_SYS_FAULT_ECHO_LINK_DOWN=y > +CONFIG_NET_LWIP=y > CONFIG_NET_RANDOM_ETHADDR=y > CONFIG_SPL_DM_SEQ_ALIAS=y > CONFIG_SIMPLE_PM_BUS=y > @@ -132,7 +125,6 @@ CONFIG_SATA_CEVA=y > CONFIG_BUTTON=y > CONFIG_BUTTON_GPIO=y > CONFIG_CLK_ZYNQMP=y > -CONFIG_DFU_TFTP=y > CONFIG_DFU_TIMEOUT=y > CONFIG_DFU_MMC=y > CONFIG_DFU_MTD=y > @@ -140,10 +132,6 @@ CONFIG_DFU_NAND=y > CONFIG_DFU_RAM=y > CONFIG_DFU_SF=y > CONFIG_SYS_DFU_DATA_BUF_SIZE=0x180 > -CONFIG_USB_FUNCTION_FASTBOOT=y > -CONFIG_FASTBOOT_FLASH=y > -CONFIG_FASTBOOT_FLASH_MMC_DEV=0 > -CONFIG_FASTBOOT_CMD_OEM_FORMAT=y > CONFIG_ARM_FFA_TRANSPORT=y > CONFIG_FPGA_XILINX=y > CONFIG_FPGA_ZYNQMPPL=y > @@ -247,6 +235,7 @@ CONFIG_VIRTIO_BLK=y > # CONFIG_BINMAN_FDT is not set > CONFIG_BINMAN_DTB="./arch/arm/dts/zynqmp-binman.dtb" > CONFIG_PANIC_HANG=y > +CONFIG_MBEDTLS_LIB=y > CONFIG_TPM=y > CONFIG_SPL_GZIP=y > CONFIG_TOOLS_MKFWUMDATA=y > -- > 2.43.0 > Thanks this helps! Acked-by: Ilias Apalodimas

Re: [RFC PATCH 1/4] meminfo: add memory details for armv8

2025-01-30 Thread Ilias Apalodimas
HI Heinrich On Thu, 30 Jan 2025 at 12:01, Heinrich Schuchardt wrote: > > On 1/30/25 07:20, Ilias Apalodimas wrote: > > Upcoming patches are mapping memory with RO, RW^X etc permsissions. > > Fix the meminfo command to display them properly > > > > S

Re: [RFC PATCH 3/4] arm64: mmu_change_region_attr() add an option not to break PTEs

2025-01-30 Thread Ilias Apalodimas
On Thu, 30 Jan 2025 at 12:13, Heinrich Schuchardt wrote: > > On 1/30/25 07:20, Ilias Apalodimas wrote: > > The ARM ARM on section 8.17.1 describes the cases where > > break-before-make is required when changing live page tables. > > Since we can use this function

Re: [RFC PATCH 2/4] arm: Prepare linker scripts for memory permissions

2025-01-30 Thread Ilias Apalodimas
Hi Heinrich On Thu, 30 Jan 2025 at 12:08, Heinrich Schuchardt wrote: > > On 1/30/25 07:20, Ilias Apalodimas wrote: > > Upcoming patches are switching the memory mappings to RW, RO, RW^X page > > RWX, RO, RW? RW, RX, RO :) > > > permissions after the U-Boot binary

Re: [RFC PATCH 4/4] arm64: Change mapping for data/rodata/text

2025-01-30 Thread Ilias Apalodimas
Hi Heinrich, On Thu, 30 Jan 2025 at 12:24, Heinrich Schuchardt wrote: > > On 1/30/25 07:20, Ilias Apalodimas wrote: > > Now that we have everything in place switch the page permissions for > > .rodata, .text and .data just after we relocate everything in top of the > > RA

Re: [RFC PATCH 3/4] arm64: mmu_change_region_attr() add an option not to break PTEs

2025-01-30 Thread Ilias Apalodimas
Hi Jerome, On Thu, 30 Jan 2025 at 11:11, Jerome Forissier wrote: > > Hi Ilias, > > On 1/30/25 08:20, Ilias Apalodimas wrote: > > The ARM ARM on section 8.17.1 describes the cases where > > break-before-make is required when changing live page tables. > > Since we

Re: [RFC PATCH 2/4] arm: Prepare linker scripts for memory permissions

2025-01-30 Thread Ilias Apalodimas
On Thu, 30 Jan 2025 at 11:09, Jerome Forissier wrote: > > Hi Ilias, > > On 1/30/25 08:20, Ilias Apalodimas wrote: > > Upcoming patches are switching the memory mappings to RW, RO, RW^X page > > permissions after the U-Boot binary and its data are relocated. Add >

Re: [RFC PATCH 1/4] meminfo: add memory details for armv8

2025-01-30 Thread Ilias Apalodimas
Hi Jerome, On Thu, 30 Jan 2025 at 11:09, Jerome Forissier wrote: > > Hi Ilias, > > On 1/30/25 08:20, Ilias Apalodimas wrote: > > Upcoming patches are mapping memory with RO, RW^X etc permsissions. > > Fix the meminfo command to display them properly > > >

[RFC PATCH 4/4] arm64: Change mapping for data/rodata/text

2025-01-29 Thread Ilias Apalodimas
Now that we have everything in place switch the page permissions for .rodata, .text and .data just after we relocate everything in top of the RAM. Signed-off-by: Ilias Apalodimas --- common/board_r.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/common/board_r.c b/common/board_r.c

[RFC PATCH 3/4] arm64: mmu_change_region_attr() add an option not to break PTEs

2025-01-29 Thread Ilias Apalodimas
the attributes of normal memory without breaking the pages tables first Signed-off-by: Ilias Apalodimas --- arch/arm/cpu/armv8/cache_v8.c | 27 - arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 10 - arch/arm/include/asm/system.h | 3 ++- arch/arm

[RFC PATCH 1/4] meminfo: add memory details for armv8

2025-01-29 Thread Ilias Apalodimas
Upcoming patches are mapping memory with RO, RW^X etc permsissions. Fix the meminfo command to display them properly Signed-off-by: Ilias Apalodimas --- arch/arm/cpu/armv8/cache_v8.c| 18 +- arch/arm/include/asm/armv8/mmu.h | 2 ++ cmd/meminfo.c| 5

[RFC PATCH 2/4] arm: Prepare linker scripts for memory permissions

2025-01-29 Thread Ilias Apalodimas
Upcoming patches are switching the memory mappings to RW, RO, RW^X page permissions after the U-Boot binary and its data are relocated. Add annotations in the linker scripts to and mark text, data, rodata etc sections and align them to a page boundary Signed-off-by: Ilias Apalodimas

[RFC PATCH 0/4] Fix page permission on arm64 architectures

2025-01-29 Thread Ilias Apalodimas
GnRnE | Non-shareable [0x23ffe4000] | Table | | [0x80 - 0x100] | Block | RW | Device-nGnRnE | Non-shareable [0] https://lore.kernel.org/u-boot/20250129-rockchip-pinctrl-const-v1-0-450ccdadf...@cherry.de/ [1] https://source.denx.de/u-boot/cust

Pull request for tpm-master-28012025

2025-01-29 Thread Ilias Apalodimas
The following changes since commit a517796cfa5d8f4ca2f0c11c78c24a08a102c047: Prepare v2025.04-rc1 (2025-01-27 16:38:46 -0600) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-tpm/ tags/tpm-master-28012025 for you to fetch changes up to 8895ff8ae2186b53

Re: [PATCH v7 3/3] tpm: get tpm event log from bloblist

2025-01-27 Thread Ilias Apalodimas
0, &args)) > - return -ENODEV; > + return 0; > + } > > - a = ofnode_get_addr_size(args.node, "reg", &s); > - if (a == FDT_ADDR_T_NONE) > - return -ENOMEM; > + if (dev_read_phandle_with_args(dev, "memory-region", NULL, 0, 0, > &args)) > + return -ENODEV; > > - *addr = map_physmem(a, s, MAP_NOCACHE); > - *size = (u32)s; > - } > + a = ofnode_get_addr_size(args.node, "reg", &s); > + if (a == FDT_ADDR_T_NONE) > + return -ENOMEM; > + > + *addr = map_physmem(a, s, MAP_NOCACHE); > + *size = (u32)s; > > return 0; > } > -- > 2.25.1 > Reviewed-by: Ilias Apalodimas

Re: [PATCH v3 3/6] tpm: add wrapper and helper APIs for PCR allocate

2025-01-27 Thread Ilias Apalodimas
mode = TPM2_SU_CLEAR */ > + return tpm2_startup(dev, false, TPM2_SU_CLEAR); > +} > + > +int tpm2_activate_banks(struct udevice *dev, u32 log_active) > +{ > + u32 algo_mask = 0; > + int rc; > + > + rc = tpm2_scan_masks(dev, log_active, &algo_mask); > + if (rc) > + return rc; > + > + if (algo_mask) { > + if (!IS_ENABLED(CONFIG_TPM_PCR_ALLOCATE)) > + return -1; > + > + rc = tpm2_pcr_allocate(dev, algo_mask); > + if (rc) > + return rc; > + > + log_info("PCR allocate done, shutdown TPM and reboot\n"); > + do_reset(NULL, 0, 0, NULL); > + log_err("reset does not work!\n"); > + return -1; > + } > + > + return 0; > +} > + > u32 tpm2_startup(struct udevice *dev, bool bon, enum tpm2_startup_types mode) > { > int op = bon ? TPM2_CC_STARTUP : TPM2_CC_SHUTDOWN; > -- > 2.25.1 > Reviewed-by: Ilias Apalodimas

Re: [PATCH v3 5/6] tpm: PCR allocate during PCR extend to disable the unsupported algorithms

2025-01-27 Thread Ilias Apalodimas
On Mon, 27 Jan 2025 at 16:59, Raymond Mao wrote: > > During PCR extend process, if any unsupported algorithms are active, > try to use PCR allocate to inactivate them. > > Signed-off-by: Raymond Mao > Acked-by: Ilias Apalodimas > --- > changes in v2 > - None. > ch

Re: [PATCH v3 0/5] Add pmem node for preserving distro ISO's

2025-01-27 Thread Ilias Apalodimas
Hi Sughosh, On Mon, 27 Jan 2025 at 08:47, Sughosh Ganu wrote: > > On Fri, 24 Jan 2025 at 17:10, Ilias Apalodimas > wrote: > > > > Heinrich, Tobias > > > > There's a slight problem that I forgot when commenting v2. > > > > Heinrich's id

Re: [PATCH v3 0/5] Add pmem node for preserving distro ISO's

2025-01-24 Thread Ilias Apalodimas
ture. This has been changed, based on a review > comment from Heinrich to instead be done by looping through the memory > based blkmamp devices. > > Changes since V2: > * Fix a checkpatch error for putting a blank line after a function > * Use blkmap device based scanning

Re: [PATCH v6 3/3] tpm: get tpm event log from bloblist

2025-01-23 Thread Ilias Apalodimas
On Thu, 23 Jan 2025 at 17:51, Raymond Mao wrote: > > Hi Ilias, > > On Thu, 23 Jan 2025 at 02:00, Ilias Apalodimas > wrote: >> >> Hi Raymond >> >> On Fri, 17 Jan 2025 at 18:36, Raymond Mao wrote: >> > >> > Get tpm event log from blobli

Re: [PATCH v6 3/3] tpm: get tpm event log from bloblist

2025-01-22 Thread Ilias Apalodimas
Hi Raymond On Fri, 17 Jan 2025 at 18:36, Raymond Mao wrote: > > Get tpm event log from bloblist instead of FDT when bloblist is > enabled and valid from previous boot stage. > > Signed-off-by: Raymond Mao > --- > Changes in v2 > - Remove patch dependency. > - Remove the fallback to FDT when BLOB

Re: [PATCH v2 3/6] tpm: add wrapper and helper APIs for PCR allocate

2025-01-22 Thread Ilias Apalodimas
Hi Raymond, On Fri, 17 Jan 2025 at 18:40, Raymond Mao wrote: > > Add PCR allocate wrapper APIs for using in tcg2 protocol. > The wrapper proceeds a PCR allocate command, followed by a > shutdown command. > A system boot is required after two commands since TPM device needs > a HW reset to activa

Re: [PATCH 2/6] tmp: add TPM2_PCR_Allocate command

2025-01-22 Thread Ilias Apalodimas
Hi Simon, On Sat, 18 Jan 2025 at 06:31, Simon Glass wrote: > > Hi Raymond, > > On Wed, 15 Jan 2025 at 13:02, Raymond Mao wrote: > > > > TPM2_PCR_Allocate command is required to re-configurate a TPM device > > to enable or disable algorithms in run-time, thus this patch introduces > > the impleme

Re: [PATCH v2 2/6] tpm: add TPM2_PCR_Allocate command

2025-01-22 Thread Ilias Apalodimas
pcr->count)) > + return TPM_LIB_ERROR; > + > + offset += sizeof(pcr->count); > + > + /* Pack each tpms_pcr_selection */ > + for (i = 0; i < pcr->count; i++) { > + struct tpms_pcr_selection *sel = &pcr->selection[i]; > + > + /* Pack hash (16-bit) */ > + if (pack_byte_string(command_v2, sizeof(command_v2), "w", > offset, > +sel->hash)) > + return TPM_LIB_ERROR; > + > + offset += sizeof(sel->hash); > + > + /* Pack size_of_select (8-bit) */ > + if (pack_byte_string(command_v2, sizeof(command_v2), "b", > offset, > +sel->size_of_select)) > + return TPM_LIB_ERROR; > + > + offset += sizeof(sel->size_of_select); > + > + /* Pack pcr_select array */ > + if (pack_byte_string(command_v2, sizeof(command_v2), "s", > offset, > +sel->pcr_select, sel->size_of_select)) > + return TPM_LIB_ERROR; > + > + offset += sel->size_of_select; > + } > + > + ret = tpm_sendrecv_command(dev, command_v2, response, &response_len); > + if (!ret) > + tpm_init(dev); > + > + return ret; > +} > + > static int tpm2_get_num_pcr(struct udevice *dev, u32 *num_pcr) > { > u8 response[(sizeof(struct tpms_capability_data) - > -- > 2.25.1 > Acked-by: Ilias Apalodimas

Re: [PATCH v2 5/6] tpm: PCR allocate during PCR extend to disable the unsupported algorithms

2025-01-22 Thread Ilias Apalodimas
return -EINVAL; > } > /* > * Fill the command structure starting from the first buffer: > -- > 2.25.1 > Reviewed-by: Ilias Apalodimas

Re: [PATCH v3 4/5] blkmap: store type of blkmap device in corresponding structure

2025-01-21 Thread Ilias Apalodimas
On Tue, 21 Jan 2025 at 18:02, Sughosh Ganu wrote: > > On Tue, 21 Jan 2025 at 21:25, Ilias Apalodimas > wrote: > > > > Hi Sughosh > > > > On Mon, 20 Jan 2025 at 12:51, Sughosh Ganu wrote: > > > > > > Add information about the type of blkmap d

Re: [PATCH v3 4/5] blkmap: store type of blkmap device in corresponding structure

2025-01-21 Thread Ilias Apalodimas
Hi Sughosh On Mon, 20 Jan 2025 at 12:51, Sughosh Ganu wrote: > > Add information about the type of blkmap device in the blkmap > structure. Currently, the blkmap device is used for mapping to either > a memory based block device, or another block device (linear > mapping). Put information in the

Re: [PATCH 1/1] efi_loader: reduce UEFI size if HAS_BOARD_SIZE_LIMIT=y

2025-01-20 Thread Ilias Apalodimas
lect this option to enable correct handling of the capitalization > of > Unicode codepoints in the range 0x-0x. If this option is not > -- > 2.47.1 > Reviewed-by: Ilias Apalodimas

Re: [PATCH v5 3/3] tpm: get tpm event log from bloblist

2025-01-18 Thread Ilias Apalodimas
On Sat, 18 Jan 2025 at 06:31, Simon Glass wrote: > > Hi Ilias, > > On Thu, 16 Jan 2025 at 07:35, Ilias Apalodimas > wrote: > > > > On Wed, 15 Jan 2025 at 03:17, Simon Glass wrote: > > > > > > Hi Raymond, > > > > > > On Tue, 14

Re: [PATCH] dfu: Prevent set_dfu_alt_info() from overwriting a previous value

2025-01-17 Thread Ilias Apalodimas
Hi Jon, On Fri, 17 Jan 2025 at 00:02, Jon Humphreys wrote: > > Sughosh Ganu writes: > > > On Thu, 16 Jan 2025 at 14:07, Mattijs Korpershoek > > wrote: > >> > >> Hi Jon, > >> > >> Sorry for the (very) late reply. I had some long holidays in between and > >> since this is a difficult topic for me

Re: [PATCH 4/8] efi_loader: Correct bounce-buffer setup

2025-01-17 Thread Ilias Apalodimas
Hi Simon, Is this patch for -master of your tree? On Mon, 6 Jan 2025 at 16:48, Simon Glass wrote: > > This should set the bounce buffer to a pointer, not an address. Fix it. > > Signed-off-by: Simon Glass > --- > > lib/efi_loader/efi_memory.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 dele

Re: [PATCH 1/1] efi_loader: use LOGC_EFI consistently

2025-01-17 Thread Ilias Apalodimas
b/efi_loader/efi_var_common.c > @@ -5,6 +5,8 @@ > * Copyright (c) 2020 Linaro Limited, Author: AKASHI Takahiro > */ > > +#define LOG_CATEGORY LOGC_EFI > + > #include > #include > #include > diff --git a/lib/efi_loader/efi_var_mem.c b/lib/efi_loader/efi_var_mem.c > index 139e16aad7c..b265d95dd6b 100644 > --- a/lib/efi_loader/efi_var_mem.c > +++ b/lib/efi_loader/efi_var_mem.c > @@ -5,6 +5,8 @@ > * Copyright (c) 2020, Heinrich Schuchardt > */ > > +#define LOG_CATEGORY LOGC_EFI > + > #include > #include > #include > diff --git a/lib/efi_loader/efi_variable_tee.c > b/lib/efi_loader/efi_variable_tee.c > index 8b6b0a39086..0d090d051dd 100644 > --- a/lib/efi_loader/efi_variable_tee.c > +++ b/lib/efi_loader/efi_variable_tee.c > @@ -10,6 +10,8 @@ > *Abdellatif El Khlifi > */ > > +#define LOG_CATEGORY LOGC_EFI > + > #if CONFIG_IS_ENABLED(ARM_FFA_TRANSPORT) > #include > #endif > diff --git a/lib/efi_loader/efi_watchdog.c b/lib/efi_loader/efi_watchdog.c > index f5fb9117717..c21d8086074 100644 > --- a/lib/efi_loader/efi_watchdog.c > +++ b/lib/efi_loader/efi_watchdog.c > @@ -5,6 +5,8 @@ > * Copyright (c) 2017 Heinrich Schuchardt > */ > > +#define LOG_CATEGORY LOGC_EFI > + > #include > > /* Conversion factor from seconds to multiples of 100ns */ > -- > 2.47.1 > Reviewed-by: Ilias Apalodimas

Re: [PATCH v2 5/5] efi_loader: use include in ARM EFI linker script

2025-01-17 Thread Ilias Apalodimas
and added to the .reloc > -* section. > -*/ > - *(.rel.dyn) > - *(.rel.plt) > - *(.rel.got) > - *(.rel.data) > - *(.rel.data*) > - *(.rel.reloc) > - *(.eh_frame) > - *(.note.GNU-stack) > - *(.dynsym) > - *(.dynstr) > - *(.note.gnu.build-id) > - *(.comment) > - } > -} > +INCLUDE lib/efi_loader/elf_efi.ldsi > -- > 2.47.1 > Reviewed-by: Ilias Apalodimas

Re: [PATCH v2 4/5] efi_loader: correct SizeOfCode, SizeOfInitializedData

2025-01-17 Thread Ilias Apalodimas
/* SizeOfInitializedData */ > + .long _etext - _start /* SizeOfCode */ > + .long _data_size /* SizeOfInitializedData */ > .long 0 /* SizeOfUninitializedData */ > .long _start - ImageBase /* AddressOfEntryPoint */ > .long _start - ImageBase /* BaseOfCode */ > -- > 2.47.1 > Reviewed-by: Ilias Apalodimas

Re: [PATCH 3/7] configs: e850-96: Enable more EFI features

2025-01-16 Thread Ilias Apalodimas
G_CLK_EXYNOS850=y > CONFIG_SUPPORT_EMMC_BOOT=y > CONFIG_MMC_DW=y > +CONFIG_DM_RTC=y > +CONFIG_RTC_EMULATION=y > CONFIG_SOC_SAMSUNG=y > CONFIG_EXYNOS_PMU=y > CONFIG_EXYNOS_USI=y > -- > 2.39.5 > Up to you, but I'd remove CONFIG_CMD_BOOTEFI_SELFTEST in any case Reviewed-by: Ilias Apalodimas

Re: [PATCH] bloblist: Drop BSD license

2025-01-16 Thread Ilias Apalodimas
On Wed, 15 Jan 2025 at 03:18, Simon Glass wrote: > > Hi Ilias, > > On Tue, 14 Jan 2025 at 12:34, Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > On Tue, 14 Jan 2025 at 15:15, Simon Glass wrote: > > > > > > Hi Ilias, > > >

Re: [PATCH 2/6] tmp: add TPM2_PCR_Allocate command

2025-01-16 Thread Ilias Apalodimas
On Thu, 16 Jan 2025 at 20:14, Raymond Mao wrote: > > Hi Ilias, > > On Thu, 16 Jan 2025 at 07:37, Ilias Apalodimas > wrote: >> >> Hi Raymond, >> >> On Wed, 15 Jan 2025 at 22:02, Raymond Mao wrote: >> > >> > TPM2_PCR_Allocate command is

Re: [PATCH 1/1] Makefile: let clean remove capsule_in.capsule*.efi-capsule

2025-01-16 Thread Ilias Apalodimas
# Directories & files removed with 'make mrproper' > MRPROPER_DIRS += include/config include/generated spl tpl vpl \ > -- > 2.47.1 > Reviewed-by: Ilias Apalodimas

Re: [PATCH v5 3/3] tpm: get tpm event log from bloblist

2025-01-16 Thread Ilias Apalodimas
On Wed, 15 Jan 2025 at 03:17, Simon Glass wrote: > > Hi Raymond, > > On Tue, 14 Jan 2025 at 08:20, Raymond Mao wrote: > > > > Get tpm event log from bloblist instead of FDT when bloblist is > > enabled and valid from previous boot stage. > > > > As a fallback, when no event log from previous stag

Re: [PATCH v5 2/3] tcg2: decouple eventlog size from efi

2025-01-16 Thread Ilias Apalodimas
log.buffer, 0xff, CONFIG_TPM2_EVENT_LOG_SIZE); > > /* > * The log header is defined to be in SHA1 event log entry format. > @@ -939,7 +940,7 @@ static efi_status_t efi_init_event_log(void) > * platforms can use different ways to do so. > */ > elog.log = event_log.buffer; > - elog.log_size = TPM2_EVENT_LOG_SIZE; > + elog.log_size = CONFIG_TPM2_EVENT_LOG_SIZE; > rc = tcg2_log_prepare_buffer(dev, &elog, false); > if (rc) { > ret = (rc == -ENOBUFS) ? EFI_BUFFER_TOO_SMALL : > EFI_DEVICE_ERROR; > -- > 2.25.1 > Reviewed-by: Ilias Apalodimas

Re: [PATCH 6/6] board: qemu-arm: select TPM_PCR_ALLOCATE

2025-01-16 Thread Ilias Apalodimas
STING=y > CONFIG_MBEDTLS_LIB=y > CONFIG_TPM=y > CONFIG_GENERATE_SMBIOS_TABLE_VERBOSE=y > +CONFIG_TPM_PCR_ALLOCATE=y > -- > 2.25.1 > Reviewed-by: Ilias Apalodimas

Re: [PATCH 4/6] tpm: add PCR allocate into the eventlog handling

2025-01-16 Thread Ilias Apalodimas
goto pcr_allocate; > if (rc) > return rc; > } > @@ -617,6 +594,11 @@ int tcg2_log_prepare_buffer(struct udevice *dev, struct > tcg2_event_log *elog, > elog->found = log.found; > } > > +pcr_allocate: > + rc = tpm2_pcr_allocate(dev, log_active); > + if (rc) > + return rc; > + > if (elog->found) > return 0; > > -- > 2.25.1 > With the naming changes on patch #3 Reviewed-by: Ilias Apalodimas

Re: [PATCH 3/6] tpm: add wrapper and helper APIs for PCR allocate

2025-01-16 Thread Ilias Apalodimas
On Wed, 15 Jan 2025 at 22:02, Raymond Mao wrote: > > Add PCR allocate wrapper APIs for using in tcg2 protocol. > The wrapper proceeds a PCR allocate command, followed by a > shutdown command. We have lib/tpm_tcg2.c does any of the functions belong to that file? Unless we expect the non-TCG versio

Re: [PATCH 2/6] tmp: add TPM2_PCR_Allocate command

2025-01-16 Thread Ilias Apalodimas
Hi Raymond, On Wed, 15 Jan 2025 at 22:02, Raymond Mao wrote: > > TPM2_PCR_Allocate command is required to re-configurate reconfigure > a TPM device > to enable or disable algorithms in run-time, thus this patch introduces > the implementation of PCR allocate APIs and adds related cmd functions

Re: [PATCH 1/6] tpm: add TPM2_Shutdown command

2025-01-16 Thread Ilias Apalodimas
e *dev, enum > tpm_startup_type mode) > case TPM_ST_DEACTIVATED: > return -EINVAL; > } > - return tpm2_startup(dev, type); > + return tpm2_startup(dev, true, type); > } else { > return -ENOSYS; > } > @@ -60,7 +60,7 @@ u32 tpm_resume(struct udevice *dev) > if (tpm_is_v1(dev)) > return tpm1_startup(dev, TPM_ST_STATE); > else if (tpm_is_v2(dev)) > - return tpm2_startup(dev, TPM2_SU_STATE); > + return tpm2_startup(dev, true, TPM2_SU_STATE); > else > return -ENOSYS; > } > -- > 2.25.1 > Reviewed-by: Ilias Apalodimas

Re: [PATCH] dfu: Prevent set_dfu_alt_info() from overwriting a previous value

2025-01-16 Thread Ilias Apalodimas
Hi Mattijs, On Thu, 16 Jan 2025 at 10:37, Mattijs Korpershoek wrote: > > Hi Jon, > > Sorry for the (very) late reply. I had some long holidays in between and > since this is a difficult topic for me, I kept pushing this to the end > of my backlog. > > On mer., déc. 18, 2024 at 17:09, Jon Humphrey

Re: [PATCH 4/4] efi_loader: use include in ARM EFI linker script

2025-01-15 Thread Ilias Apalodimas
On Wed, 15 Jan 2025 at 10:53, Heinrich Schuchardt wrote: > > On 15.01.25 09:06, Ilias Apalodimas wrote: > > Hi Heinrich > > > > > > On Tue, 14 Jan 2025 at 12:30, Heinrich Schuchardt > > wrote: > >> > >> Use the same include as arm64 for the

Re: [PATCH 4/4] efi_loader: use include in ARM EFI linker script

2025-01-15 Thread Ilias Apalodimas
Hi Heinrich On Tue, 14 Jan 2025 at 12:30, Heinrich Schuchardt wrote: > > Use the same include as arm64 for the linker script. > > Adjust the 32-bit ARM PE-COFF header accordingly and harmonize it with the > 64-bit ARM header. > > Signed-off-by: Heinrich Schuchardt > --- > arch/arm/lib/crt0_arm

Re: [PATCH 3/4] efi_loader: use INCLUDE in EFI linker scripts

2025-01-15 Thread Ilias Apalodimas
ta) > + *(.data1) > + *(.data.*) > + *(.got.plt) > + *(.got) > + > + /* > +* The EFI loader doesn't seem to like a .bss section, so we > +* stick it all into .data: > +*/ > + . = ALIGN(16); > + _bss = .; > + *(.sbss) > + *(.scommon) > + *(.dynbss) > + *(.bss) > + *(.bss.*) > + *(COMMON) > + . = ALIGN(512); > + _bss_end = .; > + _edata = .; > + } :data > + _data_size = _edata - _data; > + > + . = ALIGN(4096); > + .dynsym : { *(.dynsym) } > + . = ALIGN(4096); > + .dynstr : { *(.dynstr) } > + . = ALIGN(4096); > + .note.gnu.build-id : { *(.note.gnu.build-id) } > + /DISCARD/ : { > + *(.rel.reloc) > + *(.eh_frame) > + *(.note.GNU-stack) > + } > + .comment 0 : { *(.comment) } > +} > -- > 2.47.1 > Reviewed-by: Ilias Apalodimas

Re: [PATCH 2/4] scripts/Makefile.lib: add -L option to LD command for EFI binaries

2025-01-15 Thread Ilias Apalodimas
/lib/$(EFI_LDS) > > $(obj)/efi_crt0.o: $(srctree)/arch/$(ARCH)/lib/$(EFI_CRT0:.o=.S) FORCE > $(call if_changed_dep,as_o_S) > -- > 2.47.1 > Reviewed-by: Ilias Apalodimas

  1   2   3   4   5   6   7   8   9   10   >