Re: [U-Boot] [PATCH 2/2] ARM: sunxi: add support for Sinlinx SinA83T

2017-06-09 Thread Ziping Chen
3.dtsi". I would like to say that it is important to keep the consistency of U-Boot's and Linux's DT. And I am very glam to help for these works. Thanks Ziping Chen On Jun 10, 2017 12:51 AM, "Maxime Ripard" wrote: > Hi, > > On Fri, Jun 09, 2017 at 09:24:19PM

[U-Boot] [PATCH 2/2] ARM: sunxi: add support for Sinlinx SinA83T

2017-06-09 Thread Ziping Chen
From: Ziping Chen The SinA83T is an A83T core/daughter board combo from Sinlinx. Add support for it. Signed-off-by: Ziping Chen --- arch/arm/dts/Makefile | 3 +- arch/arm/dts/sun8i-a83t-sinlinx-sina83t.dts | 107 board/sunxi/MAINTAINERS

[U-Boot] [PATCH 1/2] dt: sun8i: Perfect r_pio node of the A83T

2017-06-09 Thread Ziping Chen
From: Ziping Chen Perfect `r_pio` node of the A83T based on `pio` node. Signed-off-by: Ziping Chen --- arch/arm/dts/sun8i-a83t.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/dts/sun8i-a83t.dtsi b/arch/arm/dts/sun8i-a83t.dtsi index 0fe73e173f..128fe954c4 100644 --- a

Re: [U-Boot] [PATCH v2 5/9] dm: led: Add support for getting the state of an LED

2017-04-12 Thread Ziping Chen
ut_assertok(led_set_state(dev, LEDST_ON)); > ut_asserteq(1, sandbox_gpio_get_value(gpio, offset)); > + ut_asserteq(LEDST_ON, led_get_state(dev)); > > ut_assertok(led_set_state(dev, LEDST_OFF)); > ut_asserteq(0, sandbox_gpio_get_value(gpio, offset)); > + ut_asserteq(LEDST_OFF, led_get_state(dev)); > > return 0; > } > -- > 2.12.2.715.g7642488e1d-goog > > Reviewed-by: Ziping Chen ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 9/9] dm: led: Add a new 'led' command

2017-04-12 Thread Ziping Chen
gt; + ret = led_set_period(dev, freq_ms); > + if (!ret) > + ret = led_set_state(dev, LEDST_BLINK); > + break; > +#endif > + case LEDST_COUNT: > + printf("LED '%s': ", led_label); &g

Re: [U-Boot] [PATCH v2 7/9] dm: led: Add support for blinking LEDs

2017-04-12 Thread Ziping Chen
* not supported by the GPIO LED driver. > + */ > + ut_assertok(uclass_get_device(UCLASS_LED, 1, &dev)); > + ut_assertok(uclass_get_device(UCLASS_GPIO, 1, &gpio)); > + ut_asserteq(0, sandbox_gpio_get_value(gpio, offset)); > + ut_asserteq(-ENOSYS, led_set_state(dev, LEDST_BLINK)); > + ut_asserteq(0, sandbox_gpio_get_value(gpio, offset)); > + ut_asserteq(LEDST_OFF, led_get_state(dev)); > + ut_asserteq(-ENOSYS, led_set_period(dev, 100)); > + > + return 0; > +} > +DM_TEST(dm_test_led_blink, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT); > +#endif > -- > 2.12.2.715.g7642488e1d-goog > > Reviewed-by: Ziping Chen ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 8/9] led: Mark existing driver as legacy

2017-04-12 Thread Ziping Chen
_BOOT_CMD( > - led, 4, 1, do_led, > + led, 4, 1, do_legacy_led, > "[" > #ifdef CONFIG_LED_STATUS_BOARD_SPECIFIC > #ifdef CONFIG_LED_STATUS0 > -- > 2.12.2.715.g7642488e1d-goog > > Reviewed-by: Ziping Chen ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 6/9] dm: led: Support toggling LEDs

2017-04-12 Thread Ziping Chen
); > + ut_asserteq(LEDST_OFF, led_get_state(dev)); > + > + return 0; > +} > +DM_TEST(dm_test_led_toggle, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT); > + > /* Test obtaining an LED by label */ > static int dm_test_led_label(struct unit_test_state *uts) > { > -- > 2.12.2.715.g7642488e1d-goog > > Reviewed-by: Ziping Chen ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 4/9] dm: led: Adjust the LED uclass

2017-04-12 Thread Ziping Chen
) > ut_assertok(uclass_get_device(UCLASS_LED, 1, &dev)); > ut_assertok(uclass_get_device(UCLASS_GPIO, 1, &gpio)); > ut_asserteq(0, sandbox_gpio_get_value(gpio, offset)); > - led_set_on(dev, 1); > + ut_assertok(led_set_state(dev, LEDST_ON)); >

Re: [U-Boot] [PATCH v2 3/9] dm: led: Rename struct led_uclass_plat

2017-04-12 Thread Ziping Chen
9,11 @@ > #define __LED_H > > /** > - * struct led_uclass_plat - Platform data the uclass stores about each > device > + * struct led_uc_plat - Platform data the uclass stores about each device > * > * @label: LED label > */ > -struct led_uclass_plat { > +struct led_uc_plat { > const char *label; > }; > > -- > 2.12.2.715.g7642488e1d-goog > > Reviewed-by: Ziping Chen ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 2/9] dm: led: Add a missing blank line in the Kconfig file

2017-04-12 Thread Ziping Chen
Ds in SPL, > enable this option. You will need to enable device tree in SPL > for this to work. > + > config LED_GPIO > bool "LED support for GPIO-connected LEDs" > depends on LED && DM_GPIO > -- > 2.12.2.715.g7642488

Re: [U-Boot] [PATCH v2 1/9] sandbox: Add some test LEDs

2017-04-12 Thread Ziping Chen
atible = "sandbox,pci"; > device_type = "pci"; > diff --git a/cmd/led.c b/cmd/legacy_led.c > similarity index 100% > rename from cmd/led.c > rename to cmd/legacy_led.c > -- > 2.12.2.715.g7642488e1d-goog > > Reviewed-by: Ziping Chen ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 0/9] dm: led: Expand the LED interface and add a command

2017-04-12 Thread Ziping Chen
dm/led.c | 56 - > 13 files changed, 517 insertions(+), 173 deletions(-) > create mode 100644 cmd/legacy_led.c > > -- > 2.12.2.715.g7642488e1d-goog > > Reviewed-by: Ziping Chen ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 5/6] cmd: led: add DM-based implementation

2017-04-10 Thread Ziping Chen
This illustrates the vitality of the developer. I'll work much harder. :-) Regards, Ziping Chen 2017-04-10 3:27 GMT+08:00 Simon Glass : > Hi, > > On 5 April 2017 at 07:24, Ziping Chen wrote: > > > > > > 2017-04-01 12:22 GMT+08:00 Simon Glass : > >> >

Re: [U-Boot] [PATCH 5/6] cmd: led: add DM-based implementation

2017-04-05 Thread Ziping Chen
2017-04-01 12:22 GMT+08:00 Simon Glass : > Hi, > > On 27 March 2017 at 08:38, wrote: > > From: Ziping Chen > > > > Currently the "led" command only supports the old API without DM. > > > > Add DM-based implementation of this command. > >

Re: [U-Boot] [PATCH 1/6] led: add get_status support for DM LED support

2017-04-05 Thread Ziping Chen
2017-04-01 12:23 GMT+08:00 Simon Glass : > Hi, > > On 27 March 2017 at 08:38, wrote: > > From: Ziping Chen > > > > Sometimes we need to read back the status of a LED. > > > > Add a led_get_status function for DM LED support, and add a get_status > &