Thanks for the review, Mike.
>> Please note, after applying this patch, those architectures, which
>> already enabled KGDB support, have to create a new asm/kgdb.h and
>> define the length of the break instruction (BREAK_INSTR_SIZE) in that
>> file.
>
> i dont think breaking build is a good idea.
This patchset adds KGDB support for ARM platforms.
Since the KGDB support for ARM is through the undef instruction handler,
we need to add code to the startup file to restore the user context after
exception. Unfortunately, each ARM variant has his own start.S, so please
reference the patch desig
Signed-off-by: Tonny Tzeng
---
arch/arm/lib/board.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
index f5660a9..f2b028c 100644
--- a/arch/arm/lib/board.c
+++ b/arch/arm/lib/board.c
@@ -381,6 +381,10 @@ void start_armboot
Signed-off-by: Tonny Tzeng
---
arch/arm/cpu/arm720t/start.S |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/arch/arm/cpu/arm720t/start.S b/arch/arm/cpu/arm720t/start.S
index 90b7240..fd06298 100644
--- a/arch/arm/cpu/arm720t/start.S
+++ b/arch/arm/cpu/arm720t
Signed-off-by: Tonny Tzeng
---
arch/arm/include/asm/kgdb.h | 66 +++
arch/arm/lib/Makefile |1 +
arch/arm/lib/kgdb.c | 194 +++
3 files changed, 261 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/include/asm
Signed-off-by: Tonny Tzeng
---
arch/arm/lib/interrupts.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/arch/arm/lib/interrupts.c b/arch/arm/lib/interrupts.c
index 1f2b815..6ee4309 100644
--- a/arch/arm/lib/interrupts.c
+++ b/arch/arm/lib/interrupts.c
@@ -37,6
Please note, after applying this patch, those architectures, which
already enabled KGDB support, have to create a new asm/kgdb.h and
define the length of the break instruction (BREAK_INSTR_SIZE) in that
file.
Signed-off-by: Tonny Tzeng
---
common
Mike, thanks for your review. Here need your further clarifications,
thanks in advance.
On Fri, Apr 9, 2010 at 5:36 AM, Mike Frysinger wrote:
> On Thursday 08 April 2010 05:40:02 Tonny Tzeng wrote:
>> --- a/common/kgdb.c
>> +++ b/common/kgdb.c
>> @@ -220,6 +220,29 @@ hex
These patches add kgdb support for ARM platforms.
The add and invocation of the bad_restore_user_regs macro in
cpu/arm720t/start.S should be made to other cpu/arm*/start.S
files as well.
Signed-off-by: Tonny Tzeng
---
common/kgdb.c | 30 ++
cpu/arm720t/start.S | 7
These patches add kgdb support for ARM platforms.
The add and invocation of the bad_restore_user_regs macro in
cpu/arm720t/start.S should be made to other cpu/arm*/start.S
files as well.
Signed-off-by: Tonny Tzeng
---
common/kgdb.c | 30 ++
cpu/arm720t/start.S|7
10 matches
Mail list logo