Re: [U-Boot] [RFC 1/6] odroid: exynos: USB initialization on the U3/X2

semi-working, it is more by chance than anything else. I feel sorry for Krzysztof (and others), who, with the patience of a monk to say the least, has to deal with this time and time again. - Tobias Anand Moon wrote: > From: Tobias Jakobi > > Rename board_usb_init() to exynos_usb_

[U-Boot] [PATCH v3 3/4] exynos: be more verbose in process_nodes()

In case sdhci_get_config() or do_sdhci_init() fail, show the error code that was returned. Acked-by: Przemyslaw Marczak Signed-off-by: Tobias Jakobi --- drivers/mmc/s5p_sdhci.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/s5p_sdhci.c b/drivers

[U-Boot] [PATCH v3 2/4] exynos: Fix passing of errors in exynos_mmc_init()

available nodes. Acked-by: Przemyslaw Marczak Signed-off-by: Tobias Jakobi --- drivers/mmc/s5p_sdhci.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c index 911e7a8..bd9e014 100644 --- a/drivers/mmc/s5p_sdhci.c

[U-Boot] [PATCH v3 4/4] exynos: more debug and cleanup in do_sdhci_init()

Add more debug printfs in do_sdhci_init() for calls that can potentially fail. Acked-by: Przemyslaw Marczak Signed-off-by: Tobias Jakobi --- drivers/mmc/s5p_sdhci.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc

[U-Boot] [PATCH v3 1/4] exynos: Properly zero initialize host in s5p_sdhci_init()

This makes sure that setting the host_caps in s5p_sdhci_core_init() doesn't operate on potentially uninitialized memory. Acked-by: Lukasz Majewski Signed-off-by: Tobias Jakobi --- drivers/mmc/s5p_sdhci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

[U-Boot] [PATCH v2 1/4] exynos: Properly initialize host_caps in s5p_sdhci_core_init()

The sdhci_host struct is allocated in s5p_sdhci_init() but the fields are not initialized. Acked-by: Lukasz Majewski Signed-off-by: Tobias Jakobi --- drivers/mmc/s5p_sdhci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c index 4db51d6

[U-Boot] [PATCH v2 4/4] exynos: more debug and cleanup in do_sdhci_init()

Add more debug printfs in do_sdhci_init() for calls that can potentially fail. Signed-off-by: Tobias Jakobi --- drivers/mmc/s5p_sdhci.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c index b60bc23

[U-Boot] [PATCH v2 3/4] exynos: be more verbose in process_nodes()

In case sdhci_get_config() or do_sdhci_init() fail, show the error code that was returned. Signed-off-by: Tobias Jakobi --- drivers/mmc/s5p_sdhci.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c index b461fde

[U-Boot] [PATCH v2 2/4] exynos: Fix passing of errors in exynos_mmc_init()

available nodes. Signed-off-by: Tobias Jakobi --- drivers/mmc/s5p_sdhci.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c index e9c43a9..b461fde 100644 --- a/drivers/mmc/s5p_sdhci.c +++ b/drivers/mmc/s5p_sdhci.c

Re: [U-Boot] [PATCH 4/4] exynos: fix and cleanup do_sdhci_init()

_get_value() returns >>>>> one when a card is detected. All other values (zero when there >>>>> is no card, or negative values for the internal errors) indicate >>>>> failure. >>>>> >>>>> Signed-off-by: Tobias Jakobi >&g

Re: [U-Boot] [PATCH 0/4] Fix operation on Odroid devices

Hello Jaehoon, Jaehoon Chung wrote: > Dear, Tobias. > > On 09/21/2015 06:34 PM, Tobias Jakobi wrote: >> Hello, >> >> Jaehoon Chung wrote: >>> Hi, >>> >>> On 09/21/2015 08:18 AM, Tobias Jakobi wrote: >>>> Hello, >>

Re: [U-Boot] [PATCH 0/4] Fix operation on Odroid devices

Forgot to ask this: What about the first three patches? - Tobias ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 0/4] Fix operation on Odroid devices

Hello, Jaehoon Chung wrote: > Hi, > > On 09/21/2015 08:18 AM, Tobias Jakobi wrote: >> Hello, >> >> currently operation on Exynos4412-based Odroid devices is broken. >> >> The bootloader stops with this message: >> Card did not respond to voltage se

[U-Boot] [PATCH 3/4] exynos: be more verbose in process_nodes()

In case sdhci_get_config() or do_sdhci_init() fail, show the error code that was returned. Signed-off-by: Tobias Jakobi --- drivers/mmc/s5p_sdhci.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c index bc2102a

[U-Boot] [PATCH 4/4] exynos: fix and cleanup do_sdhci_init()

The CD check is currently inverted. dm_gpio_get_value() returns one when a card is detected. All other values (zero when there is no card, or negative values for the internal errors) indicate failure. Signed-off-by: Tobias Jakobi --- drivers/mmc/s5p_sdhci.c | 20 +++- 1 file

[U-Boot] [PATCH 0/4] Fix operation on Odroid devices

, which is an inverted card detection check. Thanks goes to Marek Vasut and Sjoerd Simons who helped me on IRC to get this triaged. With best wishes, Tobias Tobias Jakobi (4): exynos: Properly initialize host_caps in s5p_sdhci_core_init() exynos: Fix passing of errors in exynos_mmc_init

[U-Boot] [PATCH 2/4] exynos: Fix passing of errors in exynos_mmc_init()

exynos_mmc_init() always returns zero, so for the caller it looks like it never fails. Correct this by returning the error code of process_nodes(). For process_nodes() do something similar and return early when do_sdhci_init() fails. Signed-off-by: Tobias Jakobi --- drivers/mmc/s5p_sdhci.c

[U-Boot] [PATCH 1/4] exynos: Properly initialize host_caps in s5p_sdhci_core_init()

The sdhci_host struct is allocated in s5p_sdhci_init() but the fields are not initialized. Signed-off-by: Tobias Jakobi --- drivers/mmc/s5p_sdhci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c index 4db51d6..e9c43a9 100644 --- a/drivers

Re: [U-Boot] [PATCH] odroid: update link to X2/U3 proprietary binaries

Hello! Przemyslaw Marczak wrote: > I checked the old link, and it is fine. > So maybe the link was dead only for a while? > Please add an alternative instead of removing the working one. Hmm, I just checked the link and like the last time I tried it, it doesn't work. ~ $ curl "http://dev.odroid.c

Re: [U-Boot] [PATCH] odroid: update link to X2/U3 proprietary binaries

Hello! On 2015-02-04 11:42, Albert ARIBAUD wrote: Hello Tobias, You should use git send-email (or better yet, patman) for sending patches; this one was attached instead of inline. Sorry, I normally do that, but I didn't have access to my Odroid system when I sent the patch. That being said

[U-Boot] [PATCH] odroid: update link to X2/U3 proprietary binaries

>From f12af0fe43378f945de3eaa5acbca4e0a4d711b8 Mon Sep 17 00:00:00 2001 From: Tobias Jakobi Date: Sun, 1 Feb 2015 19:47:50 +0100 Subject: odroid: update link to X2/U3 proprietary binaries The old link was dead. Link to the Github repository which is probably a more long-term solution. ---