Hi,
On Tue, Jul 15, 2025 at 08:26:27PM +0200, Jonas Karlman wrote:
> On 7/15/2025 6:48 PM, Sebastian Reichel wrote:
> > On Mon, Jul 14, 2025 at 10:34:01PM +, Jonas Karlman wrote:
> >> Include FDTs for both ROCK 5B and 5B+ in the FIT and add board
> >> selection co
Hello Jonas,
On Mon, Jul 14, 2025 at 10:34:01PM +, Jonas Karlman wrote:
> Include FDTs for both ROCK 5B and 5B+ in the FIT and add board
> selection code to load the 5B+ FDT when the ADC channel 5 value is
> close to 4095.
The Rock 5B uses the same channel and starts with 0V for revision A
an
e read_poll_timeout() would return in timeout and the
> negociation would fail.
>
> Fixes: 1db4c0ac77e ("usb: tcpm: add core framework")
> Signed-off-by: Neil Armstrong
> ---
Good catch!
Reviewed-by: Sebastian Reichel
Greetings,
-- Sebastian
> drivers/usb/tcpm/tcpm.c | 2
Hi,
On Tue, Mar 04, 2025 at 10:35:03AM +0530, Anand Moon wrote:
> However, I have a question regarding the Type-C controller's
> connection to the PMIC via I2C. I didn't see a corresponding
> controller node in the device tree source (dts) file that would
> support this function.
>
> I feel this
Hi Anand,
On Mon, Mar 03, 2025 at 01:08:24PM +0530, Anand Moon wrote:
> On Sat, 1 Mar 2025 at 23:41, Peter Robinson wrote:
> > On Thu, 27 Feb 2025 at 06:01, Anand Moon wrote:
> >> On Thu, 27 Feb 2025 at 00:15, Sebastian Reichel
> >> wrote:
> >> >
>
, that I recently added the same workaround to the Linux kernel
with a slightly different rationale (since it needs to take over from
U-Boot).
Fixes: 1db4c0ac77e3 ("usb: tcpm: add core framework")
Signed-off-by: Sebastian Reichel
---
drivers/usb/tcpm/tcpm-internal.h | 1 +
drivers/usb/t
other
50ms after reaching the ready state.
Fixes: 1db4c0ac77e3 ("usb: tcpm: add core framework")
Signed-off-by: Sebastian Reichel
---
drivers/usb/tcpm/tcpm.c | 31 ++-
1 file changed, 26 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/tcpm/tcpm.c b/dri
which device triggered
the hard reset.
Fixes: 1db4c0ac77e3 ("usb: tcpm: add core framework")
Signed-off-by: Sebastian Reichel
---
drivers/usb/tcpm/tcpm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/tcpm/tcpm.c b/drivers/usb/tcpm/tcpm.c
index 786d92fa4c6f..909fe2ef4f
once proper support is added we can use the data
role swap request to get the desired data direction after the initial
negotiation completed.
Fixes: 1db4c0ac77e3 ("usb: tcpm: add core framework")
Signed-off-by: Sebastian Reichel
---
drivers/usb/tcpm/tcpm.c | 30 +++
tings,
-- Sebastian
Sebastian Reichel (4):
usb: tcpm: improve handling of some power-supplies
usb: tcpm: avoid resets for missing source capability messages
usb: tcpm: print error on hard reset
usb: tcpm: improve data role mismatch error recovery
drivers/usb/tcpm/tcpm-internal.h
Hi,
On Fri, Nov 01, 2024 at 01:34:52PM +0300, biguncle...@gmail.com wrote:
> From: Maksim Kiselev
>
> PU\PD resistors on CC lines must be configured before running the TCPM
> state machine.
>
> Also, when the Type-C port acts as a host (SRC), the VBUS sould be enabled
> only after the toggling
Hi,
On Fri, Nov 01, 2024 at 01:34:51PM +0300, biguncle...@gmail.com wrote:
> From: Maksim Kiselev
>
> Add support for VBUS supply regulator.
>
> When our type-c port acts as a host(SRC), this regulator
> used for control VBUS supply.
>
> Signed-off-by: Maksim Kiselev
> ---
> drivers/usb/tcpm
Hi,
On Fri, Nov 01, 2024 at 01:34:50PM +0300, biguncle...@gmail.com wrote:
> From: Maksim Kiselev
>
> Add newline character in dev_dbg end.
>
> Signed-off-by: Maksim Kiselev
> ---
Acked-by: Sebastian Reichel
-- Sebastian
> drivers/usb/tcpm/fusb302.c | 6 +++---
Hi,
On Thu, Oct 31, 2024 at 08:17:32PM +0100, Jonas Karlman wrote:
> On 2024-10-31 19:15, Eugen Hristev wrote:
> > On 10/31/24 20:01, Sebastian Reichel wrote:
> >> PCI enumeration is required to detect the onboard Ethernet device.
> >>
> >&
, that I recently added the same workaround to the Linux kernel
with a slightly different rationale (since it needs to take over from
U-Boot).
Fixes: 1db4c0ac77e3 ("usb: tcpm: add core framework")
Signed-off-by: Sebastian Reichel
---
drivers/usb/tcpm/tcpm-internal.h | 1 +
drivers/usb/t
PCI enumeration is required to detect the onboard Ethernet device.
Signed-off-by: Sebastian Reichel
---
configs/rock5b-rk3588_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig
index c54e13e8732c..e5b9f7d326b4 100644
other
50ms after reaching the ready state.
Fixes: 1db4c0ac77e3 ("usb: tcpm: add core framework")
Signed-off-by: Sebastian Reichel
---
drivers/usb/tcpm/tcpm.c | 31 ++-
1 file changed, 26 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/tcpm/tcpm.c b/dri
which device triggered
the hard reset.
Fixes: 1db4c0ac77e3 ("usb: tcpm: add core framework")
Signed-off-by: Sebastian Reichel
---
drivers/usb/tcpm/tcpm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/tcpm/tcpm.c b/drivers/usb/tcpm/tcpm.c
index 786d92fa4c6f..909fe2ef4f
once proper support is added we can use the data
role swap request to get the desired data direction after the initial
negotiation completed.
Fixes: 1db4c0ac77e3 ("usb: tcpm: add core framework")
Signed-off-by: Sebastian Reichel
---
drivers/usb/tcpm/tcpm.c | 30 +++
understanding
why their boards reset themself in case there are more problems. I've
recently added the same print to the kernel TCPM code.
Greetings,
-- Sebastian
Sebastian Reichel (4):
usb: tcpm: improve handling of some power-supplies
usb: tcpm: avoid resets for missing source capability messages
onas Karlman
Signed-off-by: Sebastian Reichel
---
Makefile |1 +
cmd/Kconfig |7 +
cmd/Makefile |1 +
cmd/tcpm.c | 136 ++
doc/usage/cmd/tcpm.rst | 66 +
doc/usage/index.rst
ated USB PD. Currently existing upstream kernel DTs do
not yet have the USB-C controller at all, so we ignore any
failures.
Reviewed-by: Kever Yang
Tested-by: Soeren Moch
Tested-by: Anand Moon
Reviewed-by: Jonas Karlman
Signed-off-by: Sebastian Reichel
---
board/radxa/rock5b-rk3588/Makefil
Add new section for USB TypeC Port Manager (TCPM) support, which
is needed to figure out cable orientation of USB-C plus and to do
USB PD communication.
Signed-off-by: Sebastian Reichel
---
MAINTAINERS | 9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
Now that all code has been prepared update the default configuration to
make use of it.
Reviewed-by: Kever Yang
Tested-by: Soeren Moch
Tested-by: Anand Moon
Reviewed-by: Jonas Karlman
Signed-off-by: Sebastian Reichel
---
configs/rock5b-rk3588_defconfig | 4
1 file changed, 4 insertions
vent() to avoid forward defintion
* fusb302: drop probe function
* fusb302: drop unused LOG_BUFFER defines
* roughly 20% of all lines of the series changed between v1 and v2, so
I did not collect the Tested-by from Soeren Moch
Greetings,
-- Sebastian
Sebastian Reichel (6):
usb: tcpm: add
lt with
early USB-PD initialization. Until the Kernel DT has the node, let's
add it in U-Boot to get things going.
Reviewed-by: Kever Yang
Tested-by: Soeren Moch
Tested-by: Anand Moon
Reviewed-by: Jonas Karlman
Signed-off-by: Sebastian Reichel
---
arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 28 +++
: Anand Moon
Reviewed-by: Jonas Karlman
Signed-off-by: Sebastian Reichel
---
drivers/usb/tcpm/Kconfig |8 +
drivers/usb/tcpm/Makefile |1 +
drivers/usb/tcpm/fusb302.c | 1323
drivers/usb/tcpm/fusb302_reg.h | 177 +
4 files changed, 1509
Hi Jonas,
On Wed, Sep 18, 2024 at 09:56:35AM GMT, Jonas Karlman wrote:
> On 2024-09-05 17:08, Sebastian Reichel wrote:
> > On ROCK 5B power is usually supplied via it's USB-C port. This port has the
> > data lines connected to RK3588, VBUS connected to the input regul
Now that all code has been prepared update the default configuration to
make use of it.
Reviewed-by: Kever Yang
Tested-by: Soeren Moch
Signed-off-by: Sebastian Reichel
---
configs/rock5b-rk3588_defconfig | 4
1 file changed, 4 insertions(+)
diff --git a/configs/rock5b-rk3588_defconfig b
-by: Sebastian Reichel
---
drivers/usb/tcpm/Kconfig |8 +
drivers/usb/tcpm/Makefile |1 +
drivers/usb/tcpm/fusb302.c | 1323
drivers/usb/tcpm/fusb302_reg.h | 177 +
4 files changed, 1509 insertions(+)
create mode 100644 drivers/usb/tcpm
Add new section for USB TypeC Port Manager (TCPM) support, which
is needed to figure out cable orientation of USB-C plus and to do
USB PD communication.
Signed-off-by: Sebastian Reichel
---
MAINTAINERS | 9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
assuming a serial adapter is connected).
This also includes a 'tcpm' command, which can be used to get
information about the current state and the negotiated voltage
and current.
Co-developed-by: Wang Jie
Signed-off-by: Wang Jie
Tested-by: Soeren Moch
Signed-off-by: Sebastian Re
b302: move fusb302_poll_event() to avoid forward defintion
* fusb302: drop probe function
* fusb302: drop unused LOG_BUFFER defines
* roughly 20% of all lines of the series changed between v1 and v2, so
I did not collect the Tested-by from Soeren Moch
Greetings,
-- Sebastian
Sebastian R
lt with
early USB-PD initialization. Until the Kernel DT has the node, let's
add it in U-Boot to get things going.
Reviewed-by: Kever Yang
Tested-by: Soeren Moch
Signed-off-by: Sebastian Reichel
---
arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 28 +
1 file changed, 28 inserti
ated USB PD. Currently existing upstream kernel DTs do
not yet have the USB-C controller at all, so we ignore any
failures.
Reviewed-by: Kever Yang
Tested-by: Soeren Moch
Signed-off-by: Sebastian Reichel
---
board/radxa/rock5b-rk3588/Makefile| 6 ++
board/radxa/rock5b-rk3588/rock5b
Hi Soeren,
On Wed, Sep 04, 2024 at 12:26:43AM GMT, Soeren Moch wrote:
> > * non PD capable (reports 5V 0A)
>
> With a dumb power supply (actually 12V w/o USB-PD) I see a error message
> (not really sure if that makes sense, but no strong opinion from my side)
> and 5V/1.5A reported with 'tcpm in
Now that all code has been prepared update the default configuration to
make use of it.
Reviewed-by: Kever Yang
Signed-off-by: Sebastian Reichel
---
configs/rock5b-rk3588_defconfig | 4
1 file changed, 4 insertions(+)
diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b
Add new section for USB TypeC Port Manager (TCPM) support, which
is needed to figure out cable orientation of USB-C plus and to do
USB PD communication.
Signed-off-by: Sebastian Reichel
---
MAINTAINERS | 9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
ated USB PD. Currently existing upstream kernel DTs do
not yet have the USB-C controller at all, so we ignore any
failures.
Reviewed-by: Kever Yang
Signed-off-by: Sebastian Reichel
---
board/radxa/rock5b-rk3588/Makefile| 6 ++
board/radxa/rock5b-rk3588/rock5b-rk3588.c | 16
* roughly 20% of all lines of the series changed between v1 and v2, so
I did not collect the Tested-by from Soeren Moch
Greetings,
-- Sebastian
Sebastian Reichel (6):
usb: tcpm: add core framework
usb: tcpm: fusb302: add driver
board: rock5b-rk3588: enable USB-C in operating system
roc
assuming a serial adapter is connected).
This also includes a 'tcpm' command, which can be used to get
information about the current state and the negotiated voltage
and current.
Co-developed-by: Wang Jie
Signed-off-by: Wang Jie
Signed-off-by: Sebastian Reichel
---
Makefile
used
to control a mux for connecting the right USB3 lane pair to
the USB3 controller.
The driver is originally from the Linux kernel, but has been
adapted to the requirements of U-Boot and its TCPM framework.
Co-developed-by: Wang Jie
Signed-off-by: Wang Jie
Signed-off-by: Sebastian Reichel
lt with
early USB-PD initialization. Until the Kernel DT has the node, let's
add it in U-Boot to get things going.
Reviewed-by: Kever Yang
Signed-off-by: Sebastian Reichel
---
arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 28 +
1 file changed, 28 insertions(+)
diff --git a/arch
Hi,
On Tue, Sep 03, 2024 at 03:42:51PM GMT, Sören Moch wrote:
> On 03.09.24 13:00, Soeren Moch wrote:
> > Hi Sebastian,
> >
> > On 31.08.24 15:36, Soeren Moch wrote:
> > [...]
> > > Unfortunately I see the same problem as in v3: boot loop when powering
> > > the board from my notebook (ThinkPad X
assuming a serial adapter is connected).
This also includes a 'tcpm' command, which can be used to get
information about the current state and the negotiated voltage
and current.
Co-developed-by: Wang Jie
Signed-off-by: Wang Jie
Signed-off-by: Sebastian Reichel
---
Makefile
Add new section for USB TypeC Port Manager (TCPM) support, which
is needed to figure out cable orientation of USB-C plus and to do
USB PD communication.
Signed-off-by: Sebastian Reichel
---
MAINTAINERS | 9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
used
to control a mux for connecting the right USB3 lane pair to
the USB3 controller.
The driver is originally from the Linux kernel, but has been
adapted to the requirements of U-Boot and its TCPM framework.
Co-developed-by: Wang Jie
Signed-off-by: Wang Jie
Signed-off-by: Sebastian Reichel
Now that all code has been prepared update the default configuration to
make use of it.
Reviewed-by: Kever Yang
Signed-off-by: Sebastian Reichel
---
configs/rock5b-rk3588_defconfig | 4
1 file changed, 4 insertions(+)
diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b
sb302: drop unused LOG_BUFFER defines
* roughly 20% of all lines of the series changed between v1 and v2, so
I did not collect the Tested-by from Soeren Moch
Greetings,
-- Sebastian
Sebastian Reichel (6):
usb: tcpm: add core framework
usb: tcpm: fusb302: add driver
board: rock5b-rk3588:
lt with
early USB-PD initialization. Until the Kernel DT has the node, let's
add it in U-Boot to get things going.
Reviewed-by: Kever Yang
Signed-off-by: Sebastian Reichel
---
arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 28 +
1 file changed, 28 insertions(+)
diff --git a/arch
ated USB PD. Currently existing upstream kernel DTs do
not yet have the USB-C controller at all, so we ignore any
failures.
Reviewed-by: Kever Yang
Signed-off-by: Sebastian Reichel
---
board/radxa/rock5b-rk3588/Makefile| 6 ++
board/radxa/rock5b-rk3588/rock5b-rk3588.c | 16
Hi,
On Mon, Aug 19, 2024 at 07:08:37PM GMT, Marek Vasut wrote:
> On 8/18/24 11:43 PM, Jonas Karlman wrote:
> > > > On ROCK 5B power is usually supplied via it's USB-C port. This port has
> > > > the
> > > > data lines connected to RK3588, VBUS connected to the input regulator
> > > > and
> > > >
Hi,
On Sun, Aug 18, 2024 at 11:43:36PM GMT, Jonas Karlman wrote:
> Hi Marek and Sebastian,
>
> On 2024-08-18 22:35, Marek Vasut wrote:
> > On 8/2/24 7:59 PM, Sebastian Reichel wrote:
> >> Hi,
> >
> > Hello everyone,
> >
> >> On ROCK 5B power
Hi Jonas,
On Fri, Aug 02, 2024 at 10:42:56PM GMT, Jonas Karlman wrote:
> On 2024-08-02 19:59, Sebastian Reichel wrote:
> > Enable support for the fusb302 USB Type-C controller.
> >
> > This will do early USB PD (power deliver) negotiation, which must happen
> > withi
Hi Jonas,
On Fri, Aug 02, 2024 at 11:04:05PM GMT, Jonas Karlman wrote:
> Hi Sebastian,
>
> On 2024-08-02 19:59, Sebastian Reichel wrote:
> > Since older U-Boot releases do not negotiate USB PD, the kernel
> > DT may not enable the USB-C controller by default to avoid a
>
Add new section for USB TypeC Port Manager (TCPM) support, which
is needed to figure out cable orientation of USB-C plus and to do
USB PD communication.
Signed-off-by: Sebastian Reichel
---
MAINTAINERS | 9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
Now that all code has been prepared update the default configuration to
make use of it.
Signed-off-by: Sebastian Reichel
---
configs/rock5b-rk3588_defconfig | 5 +
1 file changed, 5 insertions(+)
diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig
index
lt with
early USB-PD initialization. Until the Kernel DT has the node, let's
add it in U-Boot to get things going.
Signed-off-by: Sebastian Reichel
---
arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 28 +
1 file changed, 28 insertions(+)
diff --git a/arch/arm/dts/rk3588-rock-5b-u-
ated USB PD. Currently existing upstream kernel DTs do
not yet have the USB-C controller at all, so we ignore any
failures.
Signed-off-by: Sebastian Reichel
---
board/radxa/rock5b-rk3588/rock5b-rk3588.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/board/radxa/rock5b-rk35
assuming a serial adapter is connected).
This also includes a 'tcpm' command, which can be used to get
information about the current state and the negotiated voltage
and current.
Co-developed-by: Wang Jie
Signed-off-by: Wang Jie
Signed-off-by: Sebastian Reichel
---
Makefile
used
to control a mux for connecting the right USB3 lane pair to
the USB3 controller.
The driver is originally from the Linux kernel, but has been
adapted to the requirements of U-Boot and its TCPM framework.
Co-developed-by: Wang Jie
Signed-off-by: Wang Jie
Signed-off-by: Sebastian Reichel
loose its power-supply and
reset. By initializing PD in U-Boot, this can be avoided.
Signed-off-by: Sebastian Reichel
---
board/radxa/rock5b-rk3588/Makefile| 6
board/radxa/rock5b-rk3588/rock5b-rk3588.c | 35 +++
2 files changed, 41 insertions(+)
create mode
d forward defintion
* fusb302: drop probe function
* fusb302: drop unused LOG_BUFFER defines
* roughly 20% of all lines of the series changed between v1 and v2, so
I did not collect the Tested-by from Soeren Moch
Greetings,
-- Sebastian
Sebastian Reichel (7):
usb: tcpm: add core framew
Add new section for USB TypeC Port Manager (TCPM) support, which
is needed to figure out cable orientation of USB-C plus and to do
USB PD communication.
Signed-off-by: Sebastian Reichel
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
assuming a serial adapter is connected).
This also includes a 'tcpm' command, which can be used to get
information about the current state and the negotiated voltage
and current.
Co-developed-by: Wang Jie
Signed-off-by: Wang Jie
Signed-off-by: Sebastian Reichel
---
Makefile
used
to control a mux for connecting the right USB3 lane pair to
the USB3 controller.
The driver is originally from the Linux kernel, but has been
adapted to the requirements of U-Boot and its TCPM framework.
Co-developed-by: Wang Jie
Signed-off-by: Wang Jie
Signed-off-by: Sebastian Reichel
Since older U-Boot releases do not negotiate USB PD, the kernel
DT may not enable the USB-C controller by default to avoid a
regression. The plan is to upstream it with 'status = "fail";'
instead. U-Boot should then mark it as 'status = "okay";' if
it nego
U-Boot first.
Signed-off-by: Sebastian Reichel
---
arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 28 +++
board/radxa/rock5b-rk3588/Makefile| 6 +
board/radxa/rock5b-rk3588/rock5b-rk3588.c | 22 ++
configs/rock5b-rk3588_defconfig | 4
hly 20% of all lines of the series changed between v1 and v2, so
I did not collect the Tested-by from Soeren Moch
Greetings,
-- Sebastian
Sebastian Reichel (5):
usb: tcpm: add core framework
usb: tcpm: fusb302: add driver
board: rock5b-rk3588: add USB-C controller support
boar
Hello Jonas,
On Mon, Jun 03, 2024 at 11:58:07AM +0200, Jonas Karlman wrote:
> Some initial quick feedback is that the tcpm uclass and driver should
> probably take more advantage of the u-boot driver model.
>
> Few quick thoughts:
> - Split out uclass/driver api parts into tcpm-uclass.c
> - Take
used
to control a mux for connecting the right USB3 lane pair to
the USB3 controller.
The driver is originally from the Linux kernel, but has been
adapted to the requirements of U-Boot and its TCPM framework.
Co-developed-by: Wang Jie
Signed-off-by: Wang Jie
Signed-off-by: Sebastian Reichel
Add new section for USB TypeC Port Manager (TCPM) support, which
is needed to figure out cable orientation of USB-C plus and to do
USB PD communication.
Signed-off-by: Sebastian Reichel
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
Since older U-Boot releases do not negotiate USB PD, the kernel
DT may not enable the USB-C controller by default to avoid a
regression. The plan is to upstream it with 'status = "fail";'
instead. U-Boot should then mark it as 'status = "okay";' if
it nego
assuming a serial adapter is connected).
This also includes a 'tcpm' command, which can be used to get
information about the current state and the negotiated voltage
and current.
Co-developed-by: Wang Jie
Signed-off-by: Wang Jie
Signed-off-by: Sebastian Reichel
---
Makefile
reads. For this
I used a priorly ported version from Rockchip, removed their hacks and
any states not necessary in U-Boot (e.g. audio accessory support).
Greetings,
-- Sebastian
Sebastian Reichel (5):
usb: tcpm: add core framework
usb: tcpm: fusb302: add driver
board: rock5b-rk3588: add USB-C
U-Boot first.
Signed-off-by: Sebastian Reichel
---
arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 28 +++
board/radxa/rock5b-rk3588/Makefile| 6 +
board/radxa/rock5b-rk3588/rock5b-rk3588.c | 22 ++
configs/rock5b-rk3588_defconfig | 4
c support for rk3588")
> 88619e77b33d ("net: stmmac: rk3588: Allow multiple gmac controller")
>
> Signed-off-by: Jonas Karlman
> Reviewed-by: Kever Yang
> ---
> Cc: David Wu
> Cc: Sebastian Reichel
> Cc: Benjamin Gaignard
> ---
Looks like I've send my R-b to
b60a0ec28 ("net: ethernet: stmmac: dwmac-rk: Add gmac support for
> > rk3588")
> > 88619e77b33d ("net: stmmac: rk3588: Allow multiple gmac controller")
> >
> > Signed-off-by: Jonas Karlman
> Reviewed-by: Kever Yang
FWIW it's also
Reviewed-b
Hi,
On Wed, Sep 27, 2023 at 06:07:59PM +, Jonas Karlman wrote:
> Above works with this series in U-Boot and also in mainline linux. Not
> sure the RK3588 bifurcation part of driver have been verified on real HW,
> rk3588 boards available for testing have typicality not used bifurcation.
Upstr
Hi,
On Wed, Aug 02, 2023 at 03:19:04PM -0600, Simon Glass wrote:
> On Wed, 2 Aug 2023 at 15:03, Simon Glass wrote:
> > Does anyone know how to enable HDMI output on this device in U-Boot,
> > e.g. on rock5b?
Upstream kernel does not yet support RK3588 HDMI output, but
Cristian Ciocaltea (added i
Hi Kever,
On Fri, Apr 14, 2023 at 12:03:00PM +0300, Eugen Hristev wrote:
> On 4/14/23 10:02, Kever Yang wrote:
> > On 2023/4/13 19:36, Eugen Hristev wrote:
> > > The current DT bindings for the rk3588 clock use a different ID than the
> > > one that is supposed to be written to the hardware regist
Hi,
On Tue, Sep 21, 2021 at 05:35:06PM +0100, Martyn Welch wrote:
> I am taking over responsibility for the GE board from Sebastian Reichel.
> Updating the MAINTAINERS files to reflect this.
>
> Signed-off-by: Martyn Welch
Acked-by: Sebastian Reichel
-- Sebastian
> ---
>
Add PCIe reset gpio to the Bx50v3 devicetree and get get rid of
CONFIG_PCIE_IMX_PERST_GPIO.
Signed-off-by: Sebastian Reichel
---
arch/arm/dts/imx6q-bx50v3-uboot.dtsi | 10 ++
include/configs/ge_bx50v3.h | 1 -
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/arch
for local variables in mcp230xx_set_flags()
* Add Reviewed-by from Simon Glass
-- Sebastian
Sebastian Reichel (2):
i2c: add dm_i2c_reg_clrset
gpio: mcp230xx: Introduce new driver
drivers/gpio/Kconfig | 10 ++
drivers/gpio/Makefile| 1 +
drivers/gpio/mcp230xx_gpio.c | 235
Introduce driver for I2C based MCP230xx GPIO chips, which are
quite common and already well supported by the Linux kernel.
Reviewed-by: Simon Glass
Signed-off-by: Sebastian Reichel
---
drivers/gpio/Kconfig | 10 ++
drivers/gpio/Makefile| 1 +
drivers/gpio/mcp230xx_gpio.c
Add function to apply a bitmask to an i2c register, so
that specific bits can be cleared and/or set.
Suggested-by: Simon Glass
Signed-off-by: Sebastian Reichel
---
drivers/i2c/i2c-uclass.c | 15 +++
include/i2c.h| 14 ++
test/dm/i2c.c| 29
Hi,
On Fri, Jul 09, 2021 at 10:11:53AM -0400, Tom Rini wrote:
> These USB defines do not change the build as there is no USB support
> enabled currently.
>
> Cc: Ian Ray
> Cc: Sebastian Reichel
> Signed-off-by: Tom Rini
> ---
Reviewed-by: Sebastian Reichel
-- Sebas
Introduce driver for I2C based MCP230xx GPIO chips, which are
quite common and already well supported by the Linux kernel.
Signed-off-by: Sebastian Reichel
---
drivers/gpio/Kconfig | 10 ++
drivers/gpio/Makefile| 1 +
drivers/gpio/mcp230xx_gpio.c | 235
From: Ian Ray
Prevent shell access on boot failure by entering an infinite
loop.
Signed-off-by: Ian Ray
Signed-off-by: Sebastian Reichel
---
include/configs/ge_bx50v3.h | 3 ++-
include/configs/mx53ppd.h | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/include
From: Ian Ray
Minor cosmetic changes to unify `CONFIG_EXTRA_ENV_SETTINGS'
indentation between Bx50v3 and PPD to make comparison and
review easier and simplify the default boot command.
Signed-off-by: Ian Ray Ian Ray
Signed-off-by: Sebastian Reichel
---
include/configs/ge_bx50v3.h
sters correctly after
resetting the PHY and thus must not reset it.
Signed-off-by: Sebastian Reichel
---
arch/arm/dts/imx6q-bx50v3-uboot.dtsi | 12
1 file changed, 12 insertions(+)
diff --git a/arch/arm/dts/imx6q-bx50v3-uboot.dtsi
b/arch/arm/dts/imx6q-bx50v3-uboot.dtsi
index 2de3b85
From: Ian Ray
Remove unsupported USB boot.
Signed-off-by: Ian Ray
Signed-off-by: Sebastian Reichel
---
include/configs/ge_bx50v3.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/include/configs/ge_bx50v3.h b/include/configs/ge_bx50v3.h
index 2d854af9a06d..f1e0ec553ce6 100644
--- a
From: Ian Ray
Increase watchdog period, in order to accomodate recent kernel size
and configuration changes.
Signed-off-by: Ian Ray
Signed-off-by: Sebastian Reichel
---
configs/ge_bx50v3_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configs/ge_bx50v3_defconfig
From: Ian Ray
Disable the unused persistent environment.
Signed-off-by: Ian Ray
Signed-off-by: Sebastian Reichel
---
configs/ge_bx50v3_defconfig | 2 +-
configs/mx53ppd_defconfig | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/configs/ge_bx50v3_defconfig b/configs
: ge: avoid shell on boot failure
Sebastian Reichel (2):
board: ge: bx50v3: fix crystal bit
board: ge: bx50v3: add phy reset GPIO
arch/arm/dts/imx6q-bx50v3-uboot.dtsi | 12
board/ge/bx50v3/bx50v3.c | 26 ++
configs/ge_bx50v3_defconfig
The DA9063 enables the CRYSTAL bit by default, but there is no
crystal populated on the BA16 system on module. Without explicitly
clearing the CRYSTAL bit the system runs unstable and sometimes
reboots unexpectedly.
Signed-off-by: Sebastian Reichel
---
board/ge/bx50v3/bx50v3.c | 26
Hi Stefano,
On Mon, Jan 04, 2021 at 08:41:33PM +0100, Stefano Babic wrote:
> > I'm about to send PATCHv3 dropping the OF_LIBFDT_OVERLAY related
> > cleanup.
>
> Thanks !
>
> > > So I applied the patches related to the board, but I left this
> > > out.
> >
> > Not applying this patch results in
Support reusing board_fit_config_name_match() to automatically
select a sensible default configuration for booting fitImages
using 'bootm'.
Reviewed-by: Simon Glass
Signed-off-by: Sebastian Reichel
---
common/image-fit.c | 19 +--
1 file changed, 13 insertions(+), 6
OF_LIBFDT_OVERLAY ifdef removal from PATCH 1, this
change requires more work
-- Sebastian
Sebastian Reichel (2):
image: cleanup pre-processor usage
image: support board_fit_config_name_match
common/image-fit.c | 65 +++---
include/image.h| 4 +++
2 files
Replace most #ifdef checks for USE_HOSTCC and CONFIG_*
with normal if instructions.
Reviewed-by: Simon Glass
Signed-off-by: Sebastian Reichel
---
common/image-fit.c | 46 --
include/image.h| 4
2 files changed, 24 insertions(+), 26
1 - 100 of 214 matches
Mail list logo
