Re: [PATCH 1/1] doc: RISC-V supports semihosting

2025-05-08 Thread Sean Anderson
Hi Heinrich, On 5/7/25 00:17, Heinrich Schuchardt wrote: > Mention that RISC-V supports semihosting. > > Update SPDX identifier to current format. > > Signed-off-by: Heinrich Schuchardt > --- > doc/usage/semihosting.rst | 21 - > 1 file changed, 12 insertions(+), 9 deletion

Re: Invalid SPDX License Identifier for test/lib/strlcat.c

2025-03-01 Thread Sean Anderson
Hi, On 3/1/25 04:39, Diederik de Haas wrote: Hi, The file ``test/lib/strlcat.c`` has "SPDX-License-Identifier: GPL-2.1+" and that SPDX identifier doesn't exist. As there is no indication this was a typo it needs to be relicensed by the copyright holders AFAIK. Cheers, Diederik As noted in

Re: [PATCH] spl: return kernel image header size in os boot

2025-02-24 Thread Sean Anderson
rn size; + return actread; } Reviewed-by: Sean Anderson

Re: [BUG report] spl: image size check fails in spl_load()

2025-02-20 Thread Sean Anderson
On 2/20/25 00:22, Anshul Dalal wrote: On Wed Feb 19, 2025 at 9:17 PM IST, Sean Anderson wrote: On 2/18/25 01:07, Anshul Dalal wrote: On Sat Feb 15, 2025 at 11:18 PM IST, Sean Anderson wrote: On 2/14/25 06:12, Anshul Dalal wrote: Hi all! I was trying to implement falcon boot on TI AM62x EVM

Re: [BUG report] spl: image size check fails in spl_load()

2025-02-19 Thread Sean Anderson
On 2/18/25 01:07, Anshul Dalal wrote: On Sat Feb 15, 2025 at 11:18 PM IST, Sean Anderson wrote: On 2/14/25 06:12, Anshul Dalal wrote: Hi all! I was trying to implement falcon boot on TI AM62x EVM with the kernel image on SD card's filesystem but the following check in `_spl_load` at `in

Re: [BUG report] spl: image size check fails in spl_load()

2025-02-15 Thread Sean Anderson
On 2/14/25 06:12, Anshul Dalal wrote: Hi all! I was trying to implement falcon boot on TI AM62x EVM with the kernel image on SD card's filesystem but the following check in `_spl_load` at `include/spl_load.h:95` fails to -EIO as per the latest commit [89d]: return read < spl_image->

Re: FIT signature security flay

2024-10-25 Thread Sean Anderson
ples I have and they seem correct. It may seem silly, but do you have CONFIG_FIT_SIGNATURE set? Also: note that `iminfo` will only report if *image* (not conf) signatures are correct. The conf signatures will be verified, but only when you boot (or source) the image using a particular config. --S

Re: FIT signature security flay

2024-10-14 Thread Sean Anderson
Hi Lev, On 10/14/24 04:42, Lev R. Oshvang wrote: > Hi Sean, > > I am looking for help with Uboot FIT signatures problem > > > > I started to work with FIT image (u-boot 2024) and managed to sign > kernel and load this image with Uboot using 'required' property in > signature as : > > sign

Re: [PATCH v2 3/4] dm: core: migrate debug() messages to use dm_warn

2024-10-02 Thread Sean Anderson
On 10/2/24 05:25, Quentin Schulz wrote: Hi Alexander, On 10/2/24 10:37 AM, Alexander Dahl wrote: Hello Quentin, sorry for being late to the party, but I just tested v2024.10-rc6 and my console output looks like this now: ofnode_read_bool: bootph-all: true ofnode_read_u32_array: rang

Re: [PATCH] spl: spl_load: fix comparison between negative error code and unsigned size

2024-09-10 Thread Sean Anderson
On 8/30/24 23:17, Daniel Palmer wrote: read could be a negative error value but size in spl_image is unsigned so when they are compared read is used as if it's a unsigned value and if it's negative it'll most likely be bigger than size and the result will be true and _spl_load() will return 0 to

Re: [PATCH v2] spl: ram: hide SPL_RAM_SUPPORT

2024-09-10 Thread Sean Anderson
y device support. The ROM code will load and execute Reviewed-by: Sean Anderson

Re: [PATCH] spl: ram: hide SPL_RAM_SUPPORT

2024-09-10 Thread Sean Anderson
On 9/10/24 05:00, Jerome Forissier wrote: Make SPL_RAM_SUPPORT a hidden Kconfig symbol, automatically selected by SPL_RAM_DEVICE or SPL_DFU. Avoids the situation where SPL_RAM_SUPPORT may be enabled without the other two being enabled, which results in the following build warning: common/spl/spl

Re: [PATCH] spl: ram: fix build warning when neither RAM_DEVICE nor DFU are enabled

2024-09-09 Thread Sean Anderson
On 9/9/24 09:22, Jerome Forissier wrote: Fixes the following warning: common/spl/spl_ram.c:19:14: warning: ‘spl_ram_load_read’ defined but not used [-Wunused-function] 19 | static ulong spl_ram_load_read(struct spl_load_info *load, ulong sector, | ^ Do

[PATCH v2 2/2] arm: zynqmp: Enable non-invasive CCI-400 PMU debug

2024-09-05 Thread Sean Anderson
Set NIDEN, enabling non-invasive debug for the CCI-400 PMU. Otherwise, the PMU is effectively disabled. Signed-off-by: Sean Anderson Reviewed-by: Michal Simek --- (no changes since v1) arch/arm/mach-zynqmp/include/mach/hardware.h | 3 +++ board/xilinx/zynqmp/zynqmp.c | 4

[PATCH v2 1/2] zynqmp: Disable secure access for boot devices

2024-09-05 Thread Sean Anderson
Boot devices (QSPI, MMC, NAND, and Ethernet) use secure access for DMA by default. As this causes problems when using the SMMU [1], configure them for normal access instead. [1] https://support.xilinx.com/s/article/72164 Signed-off-by: Sean Anderson --- Changes in v2: - Don't set reserved

[PATCH v2 0/2] arm: zynqmp: Initialize some registers at boot

2024-09-05 Thread Sean Anderson
These patches are independent in intent, but they modify adjacent lines so I have sent them as a series. Changes in v2: - Don't set reserved bits in AXI_RPRTCN, since QSPI doesn't use ARPROT Sean Anderson (2): zynqmp: Disable secure access for boot devices arm: zynqmp: Enable no

Re: [PATCH 1/2] zynqmp: Disable secure access for boot devices

2024-09-03 Thread Sean Anderson
On 9/2/24 04:43, Michal Simek wrote: > > > On 8/13/24 00:07, Sean Anderson wrote: >> >> Boot devices (QSPI, MMC, NAND, and Ethernet) use secure access for DMA >> by default. As this causes problems when using the SMMU [1], configure >> them for norma

Re: Assistance with U-Boot Compilation Error

2024-08-26 Thread Sean Anderson
On 8/26/24 19:18, Reyders Morales wrote: Dear Tom, I hope this message finds you well. My name is Reyders, and I am currently working on compiling U-Boot for am335x_evm_defconfig. However, I have encountered a compilation error. I greatly respect the work being done on this project and would be

Re: [PATCH 09/21] test: Update NAND test to avoid extra macros

2024-08-17 Thread Sean Anderson
On 8/10/24 16:51, Simon Glass wrote: Use a single test function with a for() loop instead of using macros to create multiple test functions. Add a message so it is clear what piece the test is up to, if it fails. Signed-off-by: Simon Glass Well, the whole reason I wrote it this was was to mak

Re: [PATCH] spl: fix error handling of spl_fit_read

2024-08-17 Thread Sean Anderson
On 8/16/24 03:33, mailingli...@johanneskirchmair.de wrote: From: Johannes Kirchmair Returning negative values from spl_fit_read leads to u-boot crashing. The return value of spl_fit_read is compared with an unsigned value. Returning negative values leads to the check not detecting the error. No

[PATCH v3] sandbox: Fix pinmux warnings with non-test devicetrees

2024-08-15 Thread Sean Anderson
avoid ENODEV errors. Then, convert the pin groups and functions to the new style, adding onewire group as well. Fixes: 7f0f1806e3a ("test: pinmux: Add test for pin muxing") Closes: https://source.denx.de/u-boot/u-boot/-/issues/2 Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- Chang

[PATCH v2] sandbox: Fix pinmux warnings with non-test devicetrees

2024-08-15 Thread Sean Anderson
ting Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- Changes in v2: - Only add the pinctrl node pre-relocation, as SPL/VPL try to run dtoc on all nodes included in their device trees. arch/sandbox/dts/sandbox.dtsi| 14 -- drivers/pinctrl/pinctrl-sandbox.c

[PATCH 2/2] arm: zynqmp: Enable non-invasive CCI-400 PMU debug

2024-08-12 Thread Sean Anderson
Set NIDEN, enabling non-invasive debug for the CCI-400 PMU. Otherwise, the PMU is effectively disabled. Signed-off-by: Sean Anderson --- arch/arm/mach-zynqmp/include/mach/hardware.h | 3 +++ board/xilinx/zynqmp/zynqmp.c | 4 2 files changed, 7 insertions(+) diff --git a

[PATCH 1/2] zynqmp: Disable secure access for boot devices

2024-08-12 Thread Sean Anderson
Boot devices (QSPI, MMC, NAND, and Ethernet) use secure access for DMA by default. As this causes problems when using the SMMU [1], configure them for normal access instead. [1] https://support.xilinx.com/s/article/72164 Signed-off-by: Sean Anderson --- arch/arm/mach-zynqmp/include/mach

[PATCH 0/2] arm: zynqmp: Initialize some registers at boot

2024-08-12 Thread Sean Anderson
These patches are independent in intent, but they modify adjacent lines so I have sent them as a series. Sean Anderson (2): zynqmp: Disable secure access for boot devices arm: zynqmp: Enable non-invasive CCI-400 PMU debug arch/arm/mach-zynqmp/include/mach/hardware.h | 5 + board/xilinx

[PATCH] pinmux: generic: Use ENOENT instead of ENOSYS

2024-08-10 Thread Sean Anderson
ENOSYS should only be used when a subsystem is completely absent. Convert its use in pinctrl-generic to ENOENT, which better reflects the error condition (that a function/group/pin is missing). Signed-off-by: Sean Anderson --- drivers/pinctrl/pinctrl-generic.c | 26

[PATCH] sandbox: Fix pinmux warnings with non-test devicetrees

2024-08-10 Thread Sean Anderson
avoid ENODEV errors. Then, convert the pin groups and functions to the new style, adding onewire group as well. Fixes: 7f0f1806e3a ("test: pinmux: Add test for pin muxing") Signed-off-by: Sean Anderson --- arch/sandbox/dts/sandbox.dtsi| 14 -- drivers/

Re: pinctrl warning on sandbox

2024-08-09 Thread Sean Anderson
Hi Simon, On 8/7/24 19:17, Simon Glass wrote: Hi Sean, I was looking at [1] and bisected the message to this commit: 7f0f1806e3a (refs/bisect/bad) test: pinmux: Add test for pin muxing I'm not quite sure what is going on, but could you please take a look? Regards, Simon [1] https://source.d

Re: [PATCH v2] mmc: fix signed vs unsigned compare in read check in _spl_load()

2024-07-31 Thread Sean Anderson
ge_info *spl_image, read = info->read(info, offset, ALIGN(sizeof(*header), spl_get_bl_len(info)), header); - if (read < sizeof(*header)) + if (read < (int)sizeof(*header)) return -EIO; if (image_get_magic(header) == FDT_MAGIC) { Reviewed-by: Sean Anderson

Re: [PATCH v1] mmc: fix signed vs unsigned compare in read check in _spl_load()

2024-07-31 Thread Sean Anderson
Hi Franco, On 7/30/24 09:30, Franco Venturi wrote: Fix signed vs unsigned compare in read check in _spl_load() Issue: when info->read() returns a negative value because of an error, the comparison of 'read' (signed) with 'sizeof(*header)' (unsigned silently converts the negative

Re: [PATCH 11/14] spl: mmc: Try to clean up raw-mode options

2024-07-20 Thread Sean Anderson
On 7/20/24 02:17, Simon Glass wrote: Make the raw-mode options depend on SPL_SYS_MMCSD_RAW_MODE in a more direct way. This makes it easier to understand the options with 'make menuconfig'. There are three different ways of specifying the offset: - sector offset - partition number - partition ty

Re: [PATCH 14/14] blk: Correct comment for blk_get_devnum_by_uclass_idname()

2024-07-20 Thread Sean Anderson
); /** * blk_dselect_hwpart() - select a hardware partition Reviewed-by: Sean Anderson

Re: [PATCH 13/14] spl: Create a function to init spl_load_info

2024-07-20 Thread Sean Anderson
On 7/20/24 02:17, Simon Glass wrote: Rather than having every caller set this up individually, create a common init function. This allows new fields to be added without the risk of them being left uninited. What is the code size impact of this? IIRC the reason why I didn't do this is to avoid

Re: [PATCH 12/14] spl: Use unified inline functions for spl_load_info

2024-07-20 Thread Sean Anderson
quot;); -} #endif +} /* * We need to know the position of U-Boot in memory so we can jump to it. We Reviewed-by: Sean Anderson

Re: [PATCH 10/14] spl: mmc: Adjust args of spl_mmc_find_device()

2024-07-20 Thread Sean Anderson
v); if (ret) return ret; Aside from the above, Reviewed-by: Sean Anderson

Re: [PATCH 09/14] spl: mmc: Handle error codes consistently

2024-07-20 Thread Sean Anderson
On 7/20/24 02:17, Simon Glass wrote: Use 'ret' as the return code, since it may not be an error and this is the common name in U-Boot. Make sure to return the error code when given, rather than transforming it into -1 (-EPERM). Does this transformation affect code size? Signed-off-by: Simon G

Re: [PATCH 08/14] spl: mmc: Drop checks for CONFIG_SPL_LIBCOMMON_SUPPORT

2024-07-20 Thread Sean Anderson
n err; } /* Fall through */ @@ -428,10 +412,8 @@ int spl_mmc_load(struct spl_image_info *spl_image, break; #endif -#ifdef CONFIG_SPL_LIBCOMMON_SUPPORT default: puts("spl: mmc: wrong boot mode\n"); -#endif } return err; Reviewed-by: Sean Anderson

Re: [PATCH 07/14] log: Avoid including function names by default

2024-07-20 Thread Sean Anderson
On 7/20/24 02:16, Simon Glass wrote: Unless function names are requested, the logging system should not compile these into the code. Adjust the macros to handle this. Enable CONFIG_LOGF_FUNC logging for sandbox since the tests expect the function names to be included. Fix up the pinmux test whic

Re: [PATCH 06/14] mmc: Use logging instead of pr_err()

2024-07-20 Thread Sean Anderson
} } @@ -2975,7 +2976,7 @@ int mmc_start_init(struct mmc *mmc) if (no_card) { mmc->has_init = 0; #if !defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_LIBCOMMON_SUPPORT) - pr_err("MMC: no card present\n"); + log_err("MMC: no card present\n"); #endif return -ENOMEDIUM; } @@ -3104,7 +3105,7 @@ static int mmc_probe(struct bd_info *bis) uclass_foreach_dev(dev, uc) { ret = device_probe(dev); if (ret) - pr_err("%s - probe failed: %d\n", dev->name, ret); + log_err("%s - probe failed: %d\n", dev->name, ret); } return 0; Reviewed-by: Sean Anderson

Re: [PATCH 05/14] mmc: Use logging instead of printf()

2024-07-20 Thread Sean Anderson
On 7/20/24 02:16, Simon Glass wrote: The code makes quite a few uses of __func__ which puts the function name into the resulting SPL image. Use the log subsystem instead, to reduce size. The CONFIG_LOGF_FUNC option can be used to enable the function name. Signed-off-by: Simon Glass --- driv

Re: [PATCH 04/14] spl: Remove remaining #ifdef in spl_parse_image_header()

2024-07-20 Thread Sean Anderson
ethods +*/ nit: leave this comment as-is, since it is under 80 columns debug("Raw boot image support not enabled, proceeding to other boot methods\n"); return -EINVAL; -#endif + } return 0; } Reviewed-by: Sean Anderson

Re: [PATCH 03/14] spl: Remove some #ifdefs in spl_parse_image_header()

2024-07-20 Thread Sean Anderson
aw boot image support not enabled, proceeding to other boot methods\n"); return -EINVAL; #endif - } return 0; } Reviewed-by: Sean Anderson

Re: [PATCH 02/14] spl: Correct use of CMD_BOOTI and CMD_BOOTZ

2024-07-20 Thread Sean Anderson
} -#elif defined(CMD_BOOTZ) +#elif defined(CONFIG_CMD_BOOTZ) ulong start, end; if (!bootz_setup((ulong)header, &start, &end)) { Reviewed-by: Sean Anderson

Re: [PATCH v2 15/21] spl: Plumb in the Universal Payload handoff

2024-07-20 Thread Sean Anderson
On 7/20/24 08:36, Simon Glass wrote: Hi Sean, On Thu, 18 Jul 2024 at 14:54, Sean Anderson wrote: On 7/13/24 03:00, Simon Glass wrote: Specify the FIT and include information about each loaded image, as required by the UPL handoff. Write the UPL handoff into the bloblist before jumping to

Re: [PATCH v2 04/21] sandbox: Enable SPL_LOAD_BLOCK

2024-07-18 Thread Sean Anderson
On 7/18/24 09:28, Sean Anderson wrote: On 7/13/24 03:00, Simon Glass wrote: Enable this option for all sandbox boards so that the FIT-loading code can be used without generating an error about block devices not being supported. Signed-off-by: Simon Glass --- (no changes since v1)   common

Re: [PATCH v2 20/21] sandbox: Add an SPL loader for UPL

2024-07-18 Thread Sean Anderson
On 7/13/24 03:00, Simon Glass wrote: Add support for loading a UPL image from SPL. This uses the simple FIT implementation, but also loads the full FIT just to permit more testing. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/cpu/spl.c | 49 +

Re: [PATCH v2 03/21] test: Move some SPL-loading test-code into sandbox common

2024-07-18 Thread Sean Anderson
On 7/13/24 03:00, Simon Glass wrote: This code is useful for loading an image in sandbox_spl so move it into a place where it can be called as needed. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/cpu/spl.c | 67 ++ arch/sandbox/i

Re: [PATCH v2 15/21] spl: Plumb in the Universal Payload handoff

2024-07-18 Thread Sean Anderson
On 7/13/24 03:00, Simon Glass wrote: Specify the FIT and include information about each loaded image, as required by the UPL handoff. Write the UPL handoff into the bloblist before jumping to the next phase. Control this using a runtime flag to avoid conflicting with other handoff mechanisms.

Re: [PATCH v2 04/21] sandbox: Enable SPL_LOAD_BLOCK

2024-07-18 Thread Sean Anderson
On 7/13/24 03:00, Simon Glass wrote: Enable this option for all sandbox boards so that the FIT-loading code can be used without generating an error about block devices not being supported. Signed-off-by: Simon Glass --- (no changes since v1) common/spl/Kconfig | 1 + 1 file changed, 1 inse

Re: [PATCH] ext4: Improve feature checking

2024-06-30 Thread Sean Anderson
On 6/30/24 20:23, Sean Anderson wrote: On 6/30/24 17:25, Richard Weinberger wrote: Evaluate the filesystem incompat and ro_compat bit fields to judge whether the filesystem can be read or written. For the read side only a scary warning is shown so far. I'd love to about mounting too, but I

Re: [PATCH] ext4: Improve feature checking

2024-06-30 Thread Sean Anderson
On 6/30/24 17:25, Richard Weinberger wrote: Evaluate the filesystem incompat and ro_compat bit fields to judge whether the filesystem can be read or written. For the read side only a scary warning is shown so far. I'd love to about mounting too, but I fear this will break some setups I think yo

Re: silent u-boot not working

2024-06-13 Thread Sean Anderson
Hi Jonas, On 6/13/24 09:16, Jonas Kvinge wrote: > Hi, > > I'm running openSUSE Tumbleweed on an RPI CM4, I'm trying to silence u- > boot boot messages, with the default configuration there is an u-boot > logo on the top right corner and boot text, I'd like to get rid of the > logo and all text if

Re: [PATCH 118/149] board: sipeed: Remove and add needed includes

2024-04-30 Thread Sean Anderson
On 4/30/24 22:42, Tom Rini wrote: Remove from this board vendor directory and when needed add missing include files directly. Signed-off-by: Tom Rini --- Cc: Sean Anderson --- board/sipeed/maix/maix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/sipeed/maix

Re: [PATCH v2 01/23] clk: rockchip: rk356x: Add CLK_USB3OTGx_REF support

2024-04-18 Thread Sean Anderson
-by: Sean Anderson

Re: [PATCH v2 02/23] clk: rockchip: rk3588: Add REF_CLK_USB3OTGx support

2024-04-18 Thread Sean Anderson
B3OTG1: + case REF_CLK_USB3OTG2: case TMCLK_EMMC: case TCLK_WDT0: ret = OSC_HZ; Acked-by: Sean Anderson

[PATCH 3/3] patman: Add a tag for when a patch gets added to a series

2024-04-18 Thread Sean Anderson
y just noise in most series, but they may be useful for treewide series to distinguish 'gpio: frobnicate' from 'reset: frobnicate', so I've left them in. Suggestions for the above appreciated. Suggested-by: Douglas Anderson Signed-off-by: Sean Anderson --- tools/pa

[PATCH 2/3] patman: Add Commit-cc as an alias for Patch-cc

2024-04-18 Thread Sean Anderson
Most tags referring to commits (or patches) are named Commit-something. The exception is Patch-cc. Add a Commit-cc alias so we can use whichever one is convenient. Signed-off-by: Sean Anderson --- tools/patman/func_test.py| 5 - tools/patman

[PATCH 1/3] patman: Fix tests if add_maintainers is set to False

2024-04-18 Thread Sean Anderson
intainer-script' argument") Signed-off-by: Sean Anderson --- tools/patman/func_test.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/patman/func_test.py b/tools/patman/func_test.py index e3918497cf4..9c016fb5e9a 100644 --- a/tools/patman/func_test.py +++ b/

[PATCH 0/3] patman: A fix and some new tags

2024-04-18 Thread Sean Anderson
This series has a fix along with a couple of convenient tags. Sean Anderson (3): patman: Fix tests if add_maintainers is set to False patman: Add Commit-cc as an alias for Patch-cc patman: Add a tag for when a patch gets added to a series tools/patman/func_test.py

Re: [PATCH] mmc: sdhci: programmable clock calculation needs multiplier +1

2024-04-15 Thread Sean Anderson
therwise the actual clock > +* multiplier is one more than the value of Clock Multiplier > +* in the Capabilities Register. > +*/ > + if (host->clk_mul) > + host->clk_mul += 1; > } > > if (host->max_clk == 0) { > -- > 2.43.2 > Reviewed-by: Sean Anderson

Re: [PATCH 1/1] clk: sifive: append missing \n to messages

2024-04-11 Thread Sean Anderson
On 4/11/24 04:37, Heinrich Schuchardt wrote: On 11.04.24 05:13, Sean Anderson wrote: On 2/16/24 11:35, Heinrich Schuchardt wrote: If multiple messages are written, line-feeds improve the readability. Fixes: c40b6df87fc0 ("clk: Add SiFive FU540 PRCI clock driver") Signed-off-by

Re: [PATCH] clk: imx8mp: add pwm clocks support

2024-04-10 Thread Sean Anderson
On 4/10/24 23:18, Sean Anderson wrote: On 3/10/23 10:15, Tommaso Merciai wrote: Add clocks support for the PWM controllers. This is ported from Linux v6.3.0-rc1 Signed-off-by: Tommaso Merciai ---   drivers/clk/imx/clk-imx8mp.c | 24   1 file changed, 24 insertions

Re: [PATCH] clk: imx8mp: add pwm clocks support

2024-04-10 Thread Sean Anderson
uot;, base + 0x4190, 0)); clk_dm(IMX8MP_CLK_I2C4_ROOT, imx_clk_gate4("i2c4_root_clk", "i2c4", base + 0x41a0, 0)); + clk_dm(IMX8MP_CLK_PWM1_ROOT, imx_clk_gate4("pwm1_root_clk", "pwm1", base + 0x4280, 0)); + clk_dm(IMX8MP_CLK_PWM2_ROOT, imx_clk_gate4("pwm2_root_clk", "pwm2", base + 0x4290, 0)); + clk_dm(IMX8MP_CLK_PWM3_ROOT, imx_clk_gate4("pwm3_root_clk", "pwm3", base + 0x42a0, 0)); + clk_dm(IMX8MP_CLK_PWM4_ROOT, imx_clk_gate4("pwm4_root_clk", "pwm4", base + 0x42b0, 0)); clk_dm(IMX8MP_CLK_QSPI_ROOT, imx_clk_gate4("qspi_root_clk", "qspi", base + 0x42f0, 0)); clk_dm(IMX8MP_CLK_I2C5_ROOT, imx_clk_gate2("i2c5_root_clk", "i2c5", base + 0x4330, 0)); clk_dm(IMX8MP_CLK_I2C6_ROOT, imx_clk_gate2("i2c6_root_clk", "i2c6", base + 0x4340, 0)); Acked-by: Sean Anderson But I would like to see a RB from one of the i.MX maintainers (CC'd).

Re: [PATCH 1/1] clk: sifive: avoid declaring static variables in includes

2024-04-10 Thread Sean Anderson
On 2/16/24 18:18, Heinrich Schuchardt wrote: The existing code is unnecessarily convoluted: Arrays __prci_init_clocks_fu[5|7]40 are initialized with data. In separate includes fu[5|7]40-prci.h the size of the arrays is provided as constants. By moving the structures prci_clk_fu[5|7]40 to the r

Re: [PATCH] clk: sifive: check wrpll_configure_for_rate() return value

2024-04-10 Thread Sean Anderson
_clock *pc, memcpy(&c, &pwd->c, sizeof(c)); - wrpll_configure_for_rate(&c, rate, *parent_rate); + r = wrpll_configure_for_rate(&c, rate, *parent_rate); + if (r) + return r; return wrpll_calc_output_rate(&c, *parent_rate); } Reviewed-by: Sean Anderson

Re: [PATCH 1/1] clk: sifive: append missing \n to messages

2024-04-10 Thread Sean Anderson
u64 n; if (c->flags & WRPLL_FLAGS_EXT_FEEDBACK_MASK) { - WARN(1, "external feedback mode not yet supported"); + WARN(1, "external feedback mode not yet supported\n"); return ULONG_MAX; } Reviewed-by: Sean Anderson But maybe these should be dev_dbg?

Re: [PATCH] clk: Fix error message in clk_get_bulk

2024-04-10 Thread Sean Anderson
release all clocks for %p\n", + debug("%s: could not release all clocks for %p\n", __func__, dev); return ret; Reviewed-by: Sean Anderson

Re: [PATCH v3] clk: set initial best mux parent to current parent with CLK_MUX_ROUND_CLOSEST

2024-04-10 Thread Sean Anderson
On 3/12/24 04:52, Yang Xiwen wrote: On 3/11/2024 5:34 PM, Maxime Ripard wrote: On Thu, Mar 07, 2024 at 07:18:05PM +0800, Yang Xiwen wrote: On 3/7/2024 4:48 PM, Maxime Ripard wrote: Hi, On Thu, Mar 07, 2024 at 10:03:50AM +0800, Yang Xiwen via B4 Relay wrote: From: Yang Xiwen Originally, the

Re: [PATCH] clk: Propagate clk_set_rate() if CLK_SET_PARENT_RATE present

2024-04-10 Thread Sean Anderson
On 3/7/24 19:04, Sam Protsenko wrote: Sometimes clocks provided to a consumer might not have .set_rate operation (like gate or mux clocks), but have CLK_SET_PARENT_RATE flag set. In that case it's usually possible to find a parent up the tree which is capable of setting the rate (div, pll, etc).

Re: [PATCH 1/1] sandbox: use sane access rights for files

2024-04-10 Thread Sean Anderson
size) < 0) return -EIO; close(fd); - if (chmod(fname, 0777)) + if (chmod(fname, 0755)) return -ENOEXEC; return 0; Reviewed-by: Sean Anderson

Re: [PATCH 1/1] sandbox: don't call os_close with invalid file descriptor

2024-04-10 Thread Sean Anderson
, OS_O_RDONLY); if (fd < 0) { printf("Cannot open file '%s'\n", fname); - goto err; + return -EIO; } size = os_filesize(fd); if (size < 0) { Fixes: 566bf3a8698 ("sandbox: Add a function to read

Re: [PATCH 1/2] dm: core: add support for fallback drivers

2024-04-10 Thread Sean Anderson
On 4/10/24 15:44, Tom Rini wrote: On Wed, Apr 10, 2024 at 07:27:17PM +0200, Heinrich Schuchardt wrote: Am 10. April 2024 19:06:57 MESZ schrieb Caleb Connolly : Introduce support for a uclass to provide a fallback/stub driver which can be used when no device is found for a given node. This mi

Re: [RFC PATCH v1 1/1] mmc: snps_sdhci: Add sdhci driver support for TH1520 SoC

2024-04-02 Thread Sean Anderson
On 3/30/24 13:59, Maksim Kiselev wrote: > Add support for DesignWare SDHCI host controller on Alibaba TH1520 SoC > > Signed-off-by: Maksim Kiselev > --- > drivers/mmc/Kconfig | 12 + > drivers/mmc/Makefile | 1 + > drivers/mmc/snps_sdhci.c | 464 +++

Re: [PATCH] arm64: zynqmp: Also support JTAG as alternative boot mode

2024-03-22 Thread Sean Anderson
On 3/22/24 07:53, Michal Simek wrote: > > > On 3/21/24 17:20, Sean Anderson wrote: >> On 3/20/24 07:18, Michal Simek wrote: >>> if (reg >> BOOT_MODE_ALT_SHIFT) condition rules out alternative jtag boot >>> mode which is 0. When 0 was used origin(HW) boo

Re: [PATCH] arm64: zynqmp: Also support JTAG as alternative boot mode

2024-03-21 Thread Sean Anderson
On 3/20/24 07:18, Michal Simek wrote: > if (reg >> BOOT_MODE_ALT_SHIFT) condition rules out alternative jtag boot > mode which is 0. When 0 was used origin(HW) boot mode was used instead. > That's why directly fill reg variable with requested boot mode and don't > let code to read value back. "else

Re: [PATCH 1/2] clk: clk-imx8qxp: Add LPUART IPG entries

2024-03-20 Thread Sean Anderson
ff-by: Fabio Estevam Please consider applying this series to 2024.04. It fixes a boot regression on imx8qxp and imx8qm. Fine with me, Sean? Acked-by: Sean Anderson Can you pick this up directly, Tom? Thanks.

Re: [PATCH] clk: Propagate clk_set_rate() if CLK_SET_PARENT_RATE present

2024-03-20 Thread Sean Anderson
On 3/20/24 10:02, Yang Xiwen wrote: On 3/20/2024 2:42 AM, Sam Protsenko wrote: On Thu, Mar 7, 2024 at 6:04 PM Sam Protsenko wrote: Sometimes clocks provided to a consumer might not have .set_rate operation (like gate or mux clocks), but have CLK_SET_PARENT_RATE flag set. In that case it's usua

Re: [PATCH] cmd: bootm: add ELF file support

2024-03-19 Thread Sean Anderson
Hi Maxim, On 3/19/24 12:10, Maxim Moskalets wrote: > [You don't often get email from maximmo...@gmail.com. Learn why this is > important at > https://cas5-0-urlprotect.trendmicro.com:443/wis/clicktime/v1/query?url=https%3a%2f%2faka.ms%2fLearnAboutSenderIdentification&umid=d3728a4f-0e7b-4ded-94bc

Re: [PATCH v2] cmd: nand: Add support to print the manufacturer, model and size

2024-03-18 Thread Sean Anderson
On 3/18/24 09:42, Mihai Sain wrote: Add support to nand info for printing the manufacturer,model and size. The manufacturer and model are printed only for ONFI flashes. U-Boot> nand info Device 0: nand0, sector size 256 KiB Manufacturer MACRONIX Model MX30LF4G28AD Device size

Re: [PATCH v5] misc: fs-loader: Use fw_storage_interface instead of storage_interface

2024-02-27 Thread Sean Anderson
Hi Danish, On 2/27/24 05:26, MD Danish Anwar wrote: On 09/02/24 3:38 pm, MD Danish Anwar wrote: The fs-loader driver reads env storage_interface and uses it to load firmware file into memory using the medium set by env. Update the driver to use env fw_storage_interface as this variable is only

Re: [PATCH] clk: Revise help text for clk_get_parent_rate()

2024-02-23 Thread Sean Anderson
parent of current clock rate. + * clk_get_parent_rate() - Get rate of current clock's parent. * @clk: A clock struct that was previously successfully requested by *clk_request/get_by_*(). * base-commit: 7bb761c42d75b2ebacc7190a76cc5385cbba1045 Reviewed-by: Sean Anderson

Re: [PATCH] Check curve_name for null to avoid crash

2024-02-22 Thread Sean Anderson
ey. Likely not an ecdsa key.\n"); + return -ENOMSG; + } + key->size_bits = ecdsa_key_size(key->curve_name); if (key->size_bits == 0) { debug("Unknown ECDSA curve '%s'", key->curve_name); Reviewed-by: Sean Anderson

[RESEND PATCH v2] arm64: zynqmp: Support semihosting boot method

2024-02-22 Thread Sean Anderson
on't break compatibility with existing debuggers that don't expect us to hit semihosting breakpoints. Signed-off-by: Sean Anderson --- I'm resending this from my linux.dev email as my regular email is mangling my patches. Changes in v2: - Fix typo in subject arch/arm/mach-zynqmp/spl.

Re: [PATCH v2] arm64: zynqmp: Support semihosting boot method

2024-02-22 Thread Sean Anderson
On 2/22/24 14:36, Fabio Estevam wrote: > On Thu, Feb 22, 2024 at 1:53 PM Sean Anderson wrote: >> >> From: Sean Anderson > ... >> Signed-off-by: Sean Anderson >> --- >> I'm resending this from my linux.dev email as my regular email is >> mangling m

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-22 Thread Sean Anderson
On 2/22/24 05:34, Michal Simek wrote: > > > On 2/20/24 20:30, Sean Anderson wrote: >> On 2/20/24 14:18, Michal Simek wrote: >>> >>> >>> On 2/20/24 19:43, Sean Anderson wrote: >>>> On 2/20/24 13:24, Michal Simek wrote: >>>>> >&

[PATCH v2] arm64: zynqmp: Support semihosting boot method

2024-02-22 Thread Sean Anderson
From: Sean Anderson Currently, when we boot from JTAG we try to boot U-Boot from RAM. However, this is a bit tricky to time, since the debugger has to wait for SPL to initialize RAM before it can load U-Boot. This can result in long waits, since occasionally initializing RAM (and other things in

Re: [PATCH] ecdsa: Avoid null pointer crash in ecdsa-verify due to absent property

2024-02-21 Thread Sean Anderson
Hi Bob, On 2/21/24 19:27, Bob Wolff wrote: If mixed rsa and ecdsa keys are specified in dtsi, an rsa key can be sent into the ecdsa verify. Without the ecdsa,curve property, this function will crash due to lack of checking the null pointer return. You can wrap commit messages at 75 characters

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-20 Thread Sean Anderson
On 2/20/24 14:18, Michal Simek wrote: > > > On 2/20/24 19:43, Sean Anderson wrote: >> On 2/20/24 13:24, Michal Simek wrote: >>> >>> >>> On 2/16/24 17:09, Sean Anderson wrote: >>>> On 2/16/24 11:03, Sean Anderson wrote: >>>>> On

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-20 Thread Sean Anderson
On 2/20/24 13:24, Michal Simek wrote: > > > On 2/16/24 17:09, Sean Anderson wrote: >> On 2/16/24 11:03, Sean Anderson wrote: >>> On 2/16/24 10:06, Michal Simek wrote: >>>> >>>> >>>> On 2/16/24 14:48, Michal Simek wrote: >>>>&

Re: HABv4 with SPL and u-boot-dtb.img on i.MX6

2024-02-20 Thread Sean Anderson
On 2/20/24 04:50, Benjamin Lemouzy wrote: > Hello, > > I'm trying to make secure boot work on i.MX6 SABRE with SPL and > u-boot-dtb.img files and I'm not sure how to do it. > > I'm using the U-Boot vanilla master branch (2024.04-rc2) with the following > configuration: > > # Remove some stuff

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-16 Thread Sean Anderson
On 2/16/24 11:03, Sean Anderson wrote: > On 2/16/24 10:06, Michal Simek wrote: >> >> >> On 2/16/24 14:48, Michal Simek wrote: >>> >>> >>> On 2/15/24 20:31, Sean Anderson wrote: >>>> On 2/15/24 14:08, Michal Simek wrote: >>>&

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-16 Thread Sean Anderson
On 2/16/24 10:06, Michal Simek wrote: > > > On 2/16/24 14:48, Michal Simek wrote: >> >> >> On 2/15/24 20:31, Sean Anderson wrote: >>> On 2/15/24 14:08, Michal Simek wrote: >>>> >>>> >>>> On 2/15/24 18:19, Sean Anderson wrote

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-15 Thread Sean Anderson
On 2/15/24 14:31, Sean Anderson wrote: > On 2/15/24 14:08, Michal Simek wrote: >> >> >> On 2/15/24 18:19, Sean Anderson wrote: >>> Currently, when we boot from JTAG we try to boot U-Boot from RAM. >>> However, this is a bit tricky to time, since the debugge

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-15 Thread Sean Anderson
On 2/15/24 14:08, Michal Simek wrote: > > > On 2/15/24 18:19, Sean Anderson wrote: >> Currently, when we boot from JTAG we try to boot U-Boot from RAM. >> However, this is a bit tricky to time, since the debugger has to wait >> for SPL to initialize RAM before it can l

[PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-15 Thread Sean Anderson
on't break compatibility with existing debuggers that don't expect us to hit semihosting breakpoints. Signed-off-by: Sean Anderson --- arch/arm/mach-zynqmp/spl.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-zynqmp/spl.c b/arch/arm/mach-zynqmp/spl

[PATCH] boot: Only define checksum algos when the hashes are enabled

2024-02-15 Thread Sean Anderson
Don't define checksum algos when the underlying hashes are not enabled. This allows disabling these hashes in SPL (or U-Boot). Fixes: d16b38f4270 ("Add support for SHA384 and SHA512") Fixes: 646257d1f40 ("rsa: add sha256-rsa2048 algorithm") Signed-off-by: Sean Anderson -

Re: [PATCH v4] misc: fs-loader: Use fw_storage_interface instead of storage_interface

2024-02-07 Thread Sean Anderson
On 1/30/24 01:26, MD Danish Anwar wrote: The fs-loader driver reads env storage_interface and uses it to load firmware file into memory using the medium set by env. Update the driver to use env fw_storage_interface as this variable is only used to load firmwares. The env storage_interface will ac

Re: [PATCH v3 3/3] board: Add support for Conclusive WHLE-LS1088A

2024-02-06 Thread Sean Anderson
On 11/28/23 05:34, Artur Rojek wrote: > Introduce support for Conclusive WHLE-LS1088A Single Board Computer. > > Co-developed-by: Jakub Klama > Signed-off-by: Jakub Klama > Signed-off-by: Artur Rojek > --- > > v3: new patch > > arch/arm/Kconfig | 19 ++ > arch/a

Re: [PATCH v3 2/3] board: Add support for Conclusive WHLE-LS1046A

2024-02-06 Thread Sean Anderson
On 11/28/23 05:34, Artur Rojek wrote: > Introduce support for Conclusive WHLE-LS1046A Single Board Computer. > > Co-developed-by: Jakub Klama > Signed-off-by: Jakub Klama > Signed-off-by: Artur Rojek > --- > > v3: no change > > v2: - drop non-DM_ETH case > - clean-up defines in configs/wh

[PATCH] lib: sparse: Fix error checking for write_sparse_chunk_raw

2024-02-01 Thread Sean Anderson
nk: https://lore.kernel.org/u-boot/1b323ec3-59b0-490b-a2f0-fd961dafcf49@moroto.mountain/ Signed-off-by: Sean Anderson --- lib/image-sparse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/image-sparse.c b/lib/image-sparse.c index f8289064692..09225692e9b 100644 --- a

  1   2   3   4   5   6   7   8   9   10   >