Re: [PATCH 1/9] phy: samsung: Add Exynos USB DRD PHY driver

2025-07-24 Thread Sam Protsenko
On Thu, Jul 24, 2025 at 4:45 AM Minkyu Kang wrote: [snip] >> Hi Minkyu, >> >> FYI: it might not be on your side. I can't access denx gitlab right >> now as well. There is some relevant discussion going on on #u-boot >> IRC. See also [1] thread. >> >> [1] https://lists.denx.de/pipermail/u-boot/20

Re: [PATCH 1/9] phy: samsung: Add Exynos USB DRD PHY driver

2025-07-22 Thread Sam Protsenko
On Tue, Jul 22, 2025 at 2:42 AM Minkyu Kang wrote: > > Hi, > > > 2025년 7월 22일 (화) 13:30, Sam Protsenko 님이 작성: >> >> On Mon, Jul 21, 2025 at 4:26 AM Mattijs Korpershoek >> wrote: >> > >> > On Sun, Jul 20, 2025 at 14:57, Sam Protsenko >

Re: [PATCH 1/9] phy: samsung: Add Exynos USB DRD PHY driver

2025-07-21 Thread Sam Protsenko
On Mon, Jul 21, 2025 at 4:26 AM Mattijs Korpershoek wrote: > > On Sun, Jul 20, 2025 at 14:57, Sam Protsenko > wrote: > > > On Thu, Jul 17, 2025 at 1:58 AM Mattijs Korpershoek > > wrote: > >> > >> Hi Sam, > >> > >> Thank you for

Re: [PATCH 3/3] mmc: exynos_dw_mmc: add exynos5420 compatibles

2025-07-21 Thread Sam Protsenko
it possible to use it with DTSes from Linux kernel. > > Signed-off-by: Jaehoon Chung > [ grimler: rebase after clksel reg abstraction and re-write commit message ] > Signed-off-by: Henrik Grimler > --- Reviewed-by: Sam Protsenko > drivers/mmc/exynos_dw_mmc.c | 6 ++ >

Re: [PATCH 1/3] mmc: s5p_sdhci: remove duplicated card detect code

2025-07-21 Thread Sam Protsenko
has been tested on exynos4210-i9100, a device similar to > exynos4210-trats. > > Signed-off-by: Henrik Grimler > --- Reviewed-by: Sam Protsenko > drivers/mmc/s5p_sdhci.c | 10 -- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/mmc/s5p_sdhci.c b/drive

Re: [PATCH 2/3] mmc: s5p_sdhci: add samsung, exynos4210-sdhci compatible

2025-07-21 Thread Sam Protsenko
5p_sdhci driver as > well so that it can be used with upstream DTSes. > > Signed-off-by: Henrik Grimler > --- Reviewed-by: Sam Protsenko > drivers/mmc/s5p_sdhci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/s5p

Re: [PATCH 1/9] phy: samsung: Add Exynos USB DRD PHY driver

2025-07-20 Thread Sam Protsenko
On Thu, Jul 17, 2025 at 1:58 AM Mattijs Korpershoek wrote: > > Hi Sam, > > Thank you for the patch. > [snip] > > + > > +#define EXYNOS850_DRD_UTMI 0x50 > > +#define UTMI_FORCE_SLEEP BIT(0) > > +#define UTMI_FORCE_SUSPEND BIT(1) > > +#define

[PATCH] treewide: Remove empty board_init() function from all boards

2025-07-16 Thread Sam Protsenko
ARD_INIT in all related defconfigs. This cleanup was made semi-automatically using these scripts: [1]. No functional change, but the binary size for the modified boards is reduced a bit. [1] https://github.com/joe-skb7/uboot-convert-scripts/tree/master/remove-board-init Signed-off-by: Sam Protsenko

Re: [PATCH] dfu: Fix dfu_config_interfaces() for single interface DFU syntax

2025-07-11 Thread Sam Protsenko
On Fri, Jul 11, 2025 at 3:02 AM Mattijs Korpershoek wrote: > > Hi Sam, > > Thank you for the patch. > > On Tue, Jul 08, 2025 at 23:23, Sam Protsenko > wrote: > > > As stated in DFU documentation [1], the device interface part might be > > missing in df

Re: [RFC, PATCH] fdt: Make sure there is no stale initrd left

2025-07-10 Thread Sam Protsenko
On Thu, Jul 10, 2025 at 9:40 AM Richard Weinberger wrote: > > On Mittwoch, 9. Juli 2025 19:05 Sam Protsenko wrote: > > > I think we need to distinguish two cases: > > > 1. The caller explicitly does not want to have an initramfs. e.g. you run > > > "

[PATCH 9/9] doc: samsung: Describe flashing process for E850-96

2025-07-09 Thread Sam Protsenko
Now that USB is enabled on the E850-96 board, DFU and fastboot tools are functional and can be used to flash images to eMMC. Update the E850-96 documentation accordingly and describe flashing to User Data Area and Boot HW Partition of eMMC using fastboot and DFU tools. Signed-off-by: Sam

[PATCH 8/9] board: samsung: e850-96: Enable EFI Capsule Update mechanism

2025-07-09 Thread Sam Protsenko
Boot: Applying capsule capsule4.bin succeeded. Reboot after firmware update. The kernel will also expose the ESRT table information via SysFS in /sys/firmware/efi/esrt/entries. Signed-off-by: Sam Protsenko --- board/samsung/e850-96/e850-96.c | 40 +++

[PATCH 7/9] configs: e850-96: Enable USB gadget and fastboot

2025-07-09 Thread Sam Protsenko
t ROM code jumps, it might be useful to be able to flash that area with fastboot. Other more fine grained choices for updating the firmware would be DFU and EFI Capsule Update mechanism. Signed-off-by: Sam Protsenko --- configs/e850-96_defconfig | 20 +++- 1 file changed, 19 inser

[PATCH 6/9] configs: e850-96: Increase malloc() pool size

2025-07-09 Thread Sam Protsenko
MiB up to 32 MiB, like it's done in many other boards using fastboot. Signed-off-by: Sam Protsenko --- configs/e850-96_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/e850-96_defconfig b/configs/e850-96_defconfig index f0e9ff7c4470..375805b3e5ca 10064

[PATCH 5/9] board: samsung: e850-96: Add Android partitions

2025-07-09 Thread Sam Protsenko
images for E850-96 with booting via GBL app. [1] https://gitlab.com/Linaro/96boards/e850-96/tools/gpt/-/blob/master/gpt_layout_uboot_q_ab Signed-off-by: Sam Protsenko --- board/samsung/e850-96/e850-96.env | 31 +++ 1 file changed, 31 insertions(+) diff --git a/board/sa

[PATCH 4/9] board: samsung: e850-96: Add dfu_alt_info

2025-07-09 Thread Sam Protsenko
ld be ignored -- they are not flashed with real images. [1] doc/board/samsung/e850-96.rst [2] https://docs.u-boot.org/en/latest/board/samsung/e850-96.html [3] https://gitlab.com/Linaro/96boards/e850-96/images/-/tree/master/images Signed-off-by: Sam Protsenko --- board/samsung/e850-96/e850-96.env | 1

[PATCH 3/9] board: samsung: e850-96: Setup serial# env var

2025-07-09 Thread Sam Protsenko
Setup "serial#" environment variable from the chip ID. The chip ID is read from Exynos850 SoC OTP (One Time Programmable) memory, which acts like an EEPROM and contains unique SoC ID. This "serial#" variable is further used for "fastboot devices" serial number, etc.

[PATCH 2/9] usb: dwc3-generic: Add Exynos850 support

2025-07-09 Thread Sam Protsenko
The only thing needed from DWC3 glue layer for Exynos850 is to enable USB clocks. The generic glue layer driver already does that. Add Exynos850 dwc3 compatible string to enable support for this chip. Signed-off-by: Sam Protsenko --- drivers/usb/dwc3/dwc3-generic.c | 1 + 1 file changed, 1

[PATCH 1/9] phy: samsung: Add Exynos USB DRD PHY driver

2025-07-09 Thread Sam Protsenko
rence clock (OSCCLK) Ported from Linux kernel: drivers/phy/samsung/phy-exynos5-usbdrd.c Signed-off-by: Sam Protsenko --- MAINTAINERS | 1 + drivers/phy/Kconfig | 9 + drivers/phy/Makefile| 1 + drivers/phy/phy-exynos-usbdrd.c

[PATCH 0/9] board: samsung: e850-96: Enable USB

2025-07-09 Thread Sam Protsenko
partition tables, as well as updating 'boot0' eMMC area where E850-96 firmware reside. Sam Protsenko (9): phy: samsung: Add Exynos USB DRD PHY driver usb: dwc3-generic: Add Exynos850 support board: samsung: e850-96: Setup serial# env var board: samsung: e850-96: Add dfu_alt_in

Re: [RFC, PATCH] fdt: Make sure there is no stale initrd left

2025-07-09 Thread Sam Protsenko
On Wed, Jul 9, 2025 at 1:24 AM Richard Weinberger wrote: > > On Mittwoch, 9. Juli 2025 00:58 Sam Protsenko wrote: > > fdt_initrd() function (where initrd dts properties are removed) is > > called two times: > > > > 1. First it's called by EFI boot manager (e.

[PATCH] dfu: Fix dfu_config_interfaces() for single interface DFU syntax

2025-07-08 Thread Sam Protsenko
) behavior, when delimiter ("&") is not found, the token (a) becomes the entire string (s), and string (s) becomes NULL. To fix that issue assign "a = d" instead of "a = s", because at that point variable d actually contains previous s, which should be used in this c

Re: [RFC, PATCH] fdt: Make sure there is no stale initrd left

2025-07-08 Thread Sam Protsenko
On Thu, Jun 12, 2025 at 5:15 PM Tom Rini wrote: > > On Thu, 29 May 2025 17:02:13 +0200, Richard Weinberger wrote: > > > Although if we we don't setup an initrd, there could be a stale > > initrd setting from the previous boot firmware in the live > > device tree. So, make sure there is no setting

Re: [PATCH 2/2] common/avb_verify.c: Make use of LBAF for printing lbaint_t

2025-07-03 Thread Sam Protsenko
> Cc: Igor Opaniuk > Cc: Sam Protsenko > --- Reviewed-by: Sam Protsenko > common/avb_verify.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/common/avb_verify.c b/common/avb_verify.c > index cff9117d92f1..29a3272579cf 100644 > --

Re: [PATCH 1/2] boot/android_ab.c: Make use of LBAF for printing lbaint_t

2025-07-03 Thread Sam Protsenko
them harder, so bring this back to a single line. > > Signed-off-by: Tom Rini > --- > Cc: Mattijs Korpershoek > Cc: Igor Opaniuk > Cc: Sam Protsenko > --- Reviewed-by: Sam Protsenko > boot/android_ab.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [PATCH v2] board: samsung: e850-96: Load LDFW in board_late_init()

2025-06-20 Thread Sam Protsenko
On Fri, Jun 20, 2025 at 1:50 PM Sam Protsenko wrote: [snip] > int board_init(void) > +{ > + return 0; > +} CONFIG_BOARD_INIT only appears to be present in -next, but I'd like to target this patch for v2025.07. *If* it's possible, and it can be applied to both ma

Re: [PATCH 0/2] board: samsung: e850-96: Fix MMC devices in EFI

2025-06-20 Thread Sam Protsenko
On Fri, Jun 20, 2025 at 1:54 PM Tom Rini wrote: > > On Fri, Jun 20, 2025 at 01:36:09PM -0500, Sam Protsenko wrote: > > On Fri, Jun 20, 2025 at 9:21 AM Tom Rini wrote: > > > > > > On Thu, Jun 19, 2025 at 09:25:54PM -0500, Sam Protsenko wrote: > > > > >

[PATCH v2] board: samsung: e850-96: Load LDFW in board_late_init()

2025-06-20 Thread Sam Protsenko
load_ldfw() -> fs_read(), blk_dread() exynos_trng_probe() Fixes: ccfd8de541a8 ("board: samsung: e850-96: Report LDFW loading failures") Fixes: f04e58cc9788 ("board: samsung: e850-96: Load LDFW firmware on board init") Signed-off-by: Sam Protsenko --- NOTE to c

Re: [PATCH 0/2] board: samsung: e850-96: Fix MMC devices in EFI

2025-06-20 Thread Sam Protsenko
On Fri, Jun 20, 2025 at 9:21 AM Tom Rini wrote: > > On Thu, Jun 19, 2025 at 09:25:54PM -0500, Sam Protsenko wrote: > > > Avoid using MMC in board_init() to make sure disk objects are created in > > EFI subsystem later. > > > > If it's still possible, plea

Re: [PATCH 1/3] bootstd: Fix memleak on errors in bootmeth_setup_iter_order()

2025-06-19 Thread Sam Protsenko
On Thu, Jun 19, 2025 at 5:35 PM Tom Rini wrote: [snip] > > > > Is it possible to just apply this patch without a test? It's clearly > > fixing a memleak. Not that I'm lazy or anything, I came up with a test > > like below, but I don't want to send something that is quite hard to > > test. If you

Re: [RFC PATCH 1/1] efi_loader: Call efi_init_early() even earlier

2025-06-19 Thread Sam Protsenko
On Mon, Jan 13, 2025 at 1:29 AM Heinrich Schuchardt wrote: [snip] > > There are two DM functions: > > - dm_initr > - dm_initr_dm_devices > > Before dm_initr() gd->dm_root points to the pre-relocation tree. So I > guess we should not register the DM events for EFI before that point. > > Shouldn't

[PATCH 2/2] board: samsung: e850-96: Load LDFW in board_late_init()

2025-06-19 Thread Sam Protsenko
load_ldfw() -> fs_read(), blk_dread() exynos_trng_probe() Fixes: ccfd8de541a8 ("board: samsung: e850-96: Report LDFW loading failures") Fixes: f04e58cc9788 ("board: samsung: e850-96: Load LDFW firmware on board init") Signed-off-by: Sam Protsenko --- board/samsu

[PATCH 0/2] board: samsung: e850-96: Fix MMC devices in EFI

2025-06-19 Thread Sam Protsenko
Avoid using MMC in board_init() to make sure disk objects are created in EFI subsystem later. If it's still possible, please take this series for 2025.07, as it makes EFI functional on E850-96 board. Sam Protsenko (2): configs: e850-96: Enable BOARD_LATE_INIT board: samsung: e850-96:

[PATCH 1/2] configs: e850-96: Enable BOARD_LATE_INIT

2025-06-19 Thread Sam Protsenko
LDFW firmware should be loaded in board_late_init() when MMC driver is already probed and initialized. Doing so in board_init() causes MMC driver to be probed earlier, which leads to EFI disk objects not being created. Enable CONFIG_BOARD_LATE_INIT to make that possible. Signed-off-by: Sam

Re: [PATCH 1/3] bootstd: Fix memleak on errors in bootmeth_setup_iter_order()

2025-06-19 Thread Sam Protsenko
On Fri, Feb 7, 2025 at 7:26 PM Simon Glass wrote: > > Hi Sam, > > On Fri, 7 Feb 2025 at 18:11, Sam Protsenko wrote: > > > > On Tue, Jan 14, 2025 at 7:14 AM Simon Glass wrote: > > > > > > On Sat, 11 Jan 2025 at 20:42, Sam Protsenko > > > wrot

Re: [PATCH 1/3] bootstd: Fix memleak on errors in bootmeth_setup_iter_order()

2025-02-07 Thread Sam Protsenko
On Tue, Jan 14, 2025 at 7:14 AM Simon Glass wrote: > > On Sat, 11 Jan 2025 at 20:42, Sam Protsenko > wrote: > > > > Free memory allocated for 'order' (array of bootmeths) on error paths in > > bootmeth_setup_iter_order() function. > > > > Fixes:

Re: [PATCH 1/3] bootstd: Fix memleak on errors in bootmeth_setup_iter_order()

2025-02-07 Thread Sam Protsenko
On Mon, Jan 13, 2025 at 1:37 AM Heinrich Schuchardt wrote: > > On 1/12/25 04:42, Sam Protsenko wrote: > > Free memory allocated for 'order' (array of bootmeths) on error paths in > > bootmeth_setup_iter_order() function. > > > > Fixes: c627cfc14c08 ("

[PATCH 6/7] board: samsung: e850-96: Report LDFW loading failures

2025-01-16 Thread Sam Protsenko
() in this case, as LDFW firmware is not mandatory for board operation and is only required for some features like TRNG. Signed-off-by: Sam Protsenko --- board/samsung/e850-96/e850-96.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/board/samsung/e850-96/e850-96.c b/

[PATCH 7/7] board: samsung: e850-96: Provide bootstd default env

2025-01-16 Thread Sam Protsenko
fault -f -a => env save => gpt write mmc 0 $partitions => reset [1] doc/develop/bootstd/overview.rst Signed-off-by: Sam Protsenko --- board/samsung/e850-96/e850-96.env | 37 +-- 1 file changed, 11 insertions(+), 26 deletions(-) diff --git a/boa

[PATCH 3/7] configs: e850-96: Enable more EFI features

2025-01-16 Thread Sam Protsenko
[2] https://developer.arm.com/documentation/DUI1101/1-1/Test-SystemReady-IR Signed-off-by: Sam Protsenko --- configs/e850-96_defconfig | 8 1 file changed, 8 insertions(+) diff --git a/configs/e850-96_defconfig b/configs/e850-96_defconfig index d287018ec632..1cae252175be 100644 --- a/c

[PATCH 2/7] configs: e850-96: Enable U-Boot environment on eMMC

2025-01-16 Thread Sam Protsenko
Resetting to default environment => env save Saving Environment to MMC... Writing to redundant MMC(0)... OK Signed-off-by: Sam Protsenko --- configs/e850-96_defconfig | 9 + 1 file changed, 9 insertions(+) diff --git a/configs/e850-96_defconfig b/configs/e850-96_defconfig in

[PATCH 5/7] board: samsung: e850-96: Load LDFW from EFI partition

2025-01-16 Thread Sam Protsenko
ESP first, and if either the partition or the file doesn't exist -- fallback to reading it from 'ldfw' partition. This way backward compatibility can be kept, and Android partition tables without ESP partition can be handled too. Signed-off-by: Sam Protsenko --- board/samsung/e8

[PATCH 4/7] configs: e850-96: Enable Standard Boot

2025-01-16 Thread Sam Protsenko
ow scan -lb' -> efi_mgr -> GRUB -> Debian [1] doc/develop/bootstd/overview.rst Signed-off-by: Sam Protsenko --- configs/e850-96_defconfig | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/configs/e850-96_defconfig b/configs/e850-96_defconfig index 1cae252175be..

[PATCH 0/7] board: samsung: e850-96: Enable Standard Boot

2025-01-16 Thread Sam Protsenko
() even earlier" patch is needed to make EFI functional on E850-96, but this series does not depend on it and can be applied independently. [1] https://lists.denx.de/pipermail/u-boot/2025-January/577194.html Sam Protsenko (7): configs: e850-96: Enable options for updated env configs: e8

[PATCH 1/7] configs: e850-96: Enable options for updated env

2025-01-16 Thread Sam Protsenko
The E850-96 default environment is going to be updated soon, requiring next config options to be enabled: - CONFIG_DEFAULT_FDT_FILE: $fdtfile will use this value - CONFIG_PARTITION_TYPE_GUID: $partitions will rely on "type" feature Signed-off-by: Sam Protsenko --- configs/e850-96

[RFC PATCH 1/1] efi_loader: Call efi_init_early() even earlier

2025-01-12 Thread Sam Protsenko
rlier in "Pull-request efi-2025-01-rc4" [1]. There was also a related discussion in the "efi_loader: more tightly integrate UEFI disks to driver model" patch series [2]. [1] https://lore.kernel.org/u-boot/8910d434-2d77-425f-aa81-8eb803078...@gmx.de/ [2] https://lists.denx.de/

[PATCH 1/3] bootstd: Fix memleak on errors in bootmeth_setup_iter_order()

2025-01-11 Thread Sam Protsenko
Free memory allocated for 'order' (array of bootmeths) on error paths in bootmeth_setup_iter_order() function. Fixes: c627cfc14c08 ("bootstd: Allow scanning for global bootmeths separately") Fixes: 10d16faa436c ("bootstd: Detect empty bootmeth") Signed-off-by: Sam

[PATCH 3/3] bootstd: Fix incorrect struct name in bootmeth_setup_iter_order()

2025-01-11 Thread Sam Protsenko
td: Add the bootmeth uclass and helpers") Signed-off-by: Sam Protsenko --- boot/bootmeth-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/boot/bootmeth-uclass.c b/boot/bootmeth-uclass.c index 049389403191..2496e8c1d8a8 100644 --- a/boot/bootmeth-uclass.c +++ b/boot/bo

[PATCH 2/3] bootstd: Probe bootmeth devices for bootmeths env var

2025-01-11 Thread Sam Protsenko
| bootmeth_setup_iter_order() bootflow_scan_first() do_bootflow_scan() Add an explicit device_probe() call in "we have an ordering" case to fix the issue. Fixes: c627cfc14c08 ("bootstd: Allow scanning for global bootmeths separately") Signed-

[PATCH 0/3] bootstd: Fix efi_mgr usage in bootmeths env var

2025-01-11 Thread Sam Protsenko
Defining the 'bootmeths' environment variable with efi_mgr causes NULL pointer dereference when running 'bootflow scan' on the E850-96 board. This patch series fixes that, and cleans up the surrounding code a little while at it. Sam Protsenko (3): bootstd: Fix

Re: [PATCH v1 0/8] Cleanup the LMB subsystem

2024-12-12 Thread Sam Protsenko
ard.c| 20 +++-- > boot/image-fdt.c | 15 ++-- > cmd/booti.c | 2 +- > cmd/bootz.c | 2 +- > cmd/load.c| 2 +- > fs/fs.c | 2 +- > include/lmb.h | 58 ++- >

Re: [PATCH v1 7/8] lmb: Remove lmb_alloc_base_flags()

2024-12-12 Thread Sam Protsenko
t; a bit easier to follow. > > Signed-off-by: Ilias Apalodimas > --- Reviewed-by: Sam Protsenko > boot/image-board.c | 18 +++--- > boot/image-fdt.c| 5 +++-- > include/lmb.h | 7 +++ > lib/efi_loader/efi_memory.c

Re: [PATCH v1 8/8] lmb: Rename _lmb_alloc_addr() to lmb_alloc_addr_flags()

2024-12-12 Thread Sam Protsenko
On Wed, Dec 11, 2024 at 4:55 AM Ilias Apalodimas wrote: > > lmb_alloc_addr_flags() is a wrapper for _lmb_alloc_addr() and it's the > only function using it. Rename _lmb_alloc_addr() to lmb_alloc_addr_flags() > and remove the wrapper. > > Signed-off-by: Ilias Apalodimas

Re: [PATCH v1 6/8] lmb: Remove lmb_alloc_addr_flags()

2024-12-12 Thread Sam Protsenko
phys_size_t size, > - uint flags); > +phys_addr_t lmb_alloc_addr(phys_addr_t base, phys_size_t size, uint flags); Can we keep u32 for flags everywhere, for consistency? With above nitpicks addressed, feel free to add: Reviewed-by: Sam Protsenko [snip]

Re: [PATCH v1 5/8] lmb: Remove lmb_add_region()

2024-12-12 Thread Sam Protsenko
ich Schuchardt > Signed-off-by: Ilias Apalodimas > --- Reviewed-by: Sam Protsenko > lib/lmb.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/lib/lmb.c b/lib/lmb.c > index da960e422ada..659581f13f20 100644 > --- a/lib/lmb.c > +++ b/

Re: [PATCH v1 4/8] lmb: Rename free_mem to available_mem

2024-12-12 Thread Sam Protsenko
me this field to better match its usage. > > Signed-off-by: Ilias Apalodimas > --- Reviewed-by: Sam Protsenko [snip]

Re: [PATCH v1 3/8] lmb: Remove lmb_reserve_flags()

2024-12-12 Thread Sam Protsenko
de a bit easier to follow. > > Signed-off-by: Ilias Apalodimas > Reviewed-by: Tom Rini > --- Reviewed-by: Sam Protsenko [snip]

Re: [PATCH v1 2/8] lmb: Move enum lmb_flags to a u32

2024-12-12 Thread Sam Protsenko
* %LMB_NONE: No special request * %LMB_NOMAP: Don't add to MMU configuration * %LMB_NOOVERWRITE: The memory region cannot be overwritten/re-reserved * %LMB_NONOTIFY: Do not notify other modules of changes to this memory region */ That's helpful if you want to keep Sphinx generated doc [

Re: [PATCH v1 0/8] Cleanup the LMB subsystem

2024-12-12 Thread Sam Protsenko
On Thu, Dec 12, 2024 at 3:30 PM Sam Protsenko wrote: > Hi Ilias, > > This series doesn't apply as is on current master (tried MBOX file > from lore). I'll still try to review it by merging conflicts locally, > but please double check it on your side, and re-submit in c

Re: [PATCH v1 0/8] Cleanup the LMB subsystem

2024-12-12 Thread Sam Protsenko
On Wed, Dec 11, 2024 at 4:55 AM Ilias Apalodimas wrote: > > Hi all, > > This is v1 of the rfc [0] > > The LMB subsystem was used opportunistically for a number of years. > A while back Sughosh merged it with the EFI subsystem in order to have a > common allocator and avoid subsystems overwriting m

Re: [PATCH v1 1/8] lmb: Remove lmb_align_down()

2024-12-12 Thread Sam Protsenko
On Wed, Dec 11, 2024 at 4:55 AM Ilias Apalodimas wrote: > > We already have a macro for this. Use it instead of adding yet another > variant for alignment. > > Signed-off-by: Ilias Apalodimas > --- Reviewed-by: Sam Protsenko > lib/lmb.c | 15 +-- > 1 fi

[PATCH v2 0/4] lmb: Improve style

2024-12-10 Thread Sam Protsenko
s split by actual functional change patches [1] and cleanup patches (this series) - Collected review tags [1] https://lists.denx.de/pipermail/u-boot/2024-December/574606.html Sam Protsenko (4): lmb: Fix flags data type in lmb_add_region_flags() lmb: Make const flag_str[] in lmb_print_re

[PATCH v2 3/4] lmb: Improve coding style

2024-12-10 Thread Sam Protsenko
Fix checkpatch warnings. No functional change. Signed-off-by: Sam Protsenko Acked-by: Ilias Apalodimas --- Changes in v2: - Added Acked-by tag from Ilias lib/lmb.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/lib/lmb.c b/lib/lmb.c index

[PATCH v2 4/4] lmb: Improve kernel-doc comments

2024-12-10 Thread Sam Protsenko
/codingstyle.rst Signed-off-by: Sam Protsenko Acked-by: Ilias Apalodimas --- Changes in v2: - Added Acked-by tag from Ilias - Provided the excerpt from U-Boot doc about comments for public API include/lmb.h | 125 ++ lib/lmb.c | 55

[PATCH v2 2/4] lmb: Make const flag_str[] in lmb_print_region_flags() more const

2024-12-10 Thread Sam Protsenko
flag_str[] is a pointer to const. Make it also a const pointer. Improve a style a bit while a it, to make this line fit 80 characters limit. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Ilias Apalodimas --- Changes in v2: - Added R-b tag from Ilias lib/lmb.c | 3 ++- 1

[PATCH v2 1/4] lmb: Fix flags data type in lmb_add_region_flags()

2024-12-10 Thread Sam Protsenko
it ed17a33fed29 ("lmb: make LMB memory map persistent and global"). Fix it by using the correct type to match struct lmb_region field. No functional change. Signed-off-by: Sam Protsenko Reviewed-by: Ilias Apalodimas Acked-by: Sughosh Ganu --- Changes in v2: - Added R-b tag from Ili

[PATCH v2 2/2] boot: fdt: Handle already reserved memory in boot_fdt_reserve_region()

2024-12-10 Thread Sam Protsenko
EXIST in lmb_add_region_flags() if region already added Handle -EEXIST error code as a normal (successful) case in lmb_reserve_flags() and don't print any messages. Fixes: 1d9aa4a283da ("lmb: Fix the allocation of overlapping memory areas with !LMB_NONE") Signed-off-by: Sam Protsenko

[PATCH v2 0/2] lmb: Fix reserving the same region multiple times

2024-12-10 Thread Sam Protsenko
ail/u-boot/2024-December/574123.html Sam Protsenko (2): lmb: Return -EEXIST in lmb_add_region_flags() if region already added boot: fdt: Handle already reserved memory in boot_fdt_reserve_region() boot/image-fdt.c | 2 +- lib/lmb.c| 26 +- test/lib/lmb.c |

[PATCH v2 1/2] lmb: Return -EEXIST in lmb_add_region_flags() if region already added

2024-12-10 Thread Sam Protsenko
ccount for the changed return value. No functional change is intended (by this patch itself). Fixes: 1d9aa4a283da ("lmb: Fix the allocation of overlapping memory areas with !LMB_NONE") Signed-off-by: Sam Protsenko --- Changes in v2: - Removed the check for exactly the same region,

Re: [REGRESSION] lmb: add and reserve memory above ram_top

2024-12-10 Thread Sam Protsenko
On Mon, Dec 9, 2024 at 5:43 AM Sughosh Ganu wrote: > > On Mon, 9 Dec 2024 at 12:12, Sughosh Ganu wrote: > > > > On Sun, 8 Dec 2024 at 06:49, Sam Protsenko > > wrote: > > > > > > On Thu, Dec 5, 2024 at 11:23 PM Sughosh Ganu > > > wrote: &

Re: [PATCH 2/6] lmb: Return -EEXIST in lmb_add_region_flags() if region already added

2024-12-10 Thread Sam Protsenko
On Mon, Dec 9, 2024 at 1:08 AM Sughosh Ganu wrote: > > On Sun, 8 Dec 2024 at 12:20, Ilias Apalodimas > wrote: > > > > Hi Sam, > > > > On Sun, 8 Dec 2024 at 02:21, Sam Protsenko > > wrote: > > > > > > An attempt to add the already ad

Re: [PATCH 2/6] lmb: Return -EEXIST in lmb_add_region_flags() if region already added

2024-12-10 Thread Sam Protsenko
On Sun, Dec 8, 2024 at 12:50 AM Ilias Apalodimas wrote: > > Hi Sam, > > On Sun, 8 Dec 2024 at 02:21, Sam Protsenko wrote: > > > > An attempt to add the already added LMB region (with exactly the same > > start address, size and flags) using lmb_add_region_flags() en

Re: [PATCH 5/6] lmb: Improve kernel-doc comments

2024-12-10 Thread Sam Protsenko
n and make it more clear. > But I don't really mind as long as we have a common policy > Agreed, that's the most important thing. It's easy to move things around when everything is clean and tidy in the first place. > On Sun, 8 Dec 2024 at 02:21, Sam Protsenko wrote: > >

Re: [REGRESSION] lmb: add and reserve memory above ram_top

2024-12-07 Thread Sam Protsenko
On Thu, Dec 5, 2024 at 11:23 PM Sughosh Ganu wrote: > [snip] > > ERROR: reserving fdt memory region failed (addr=bab0 > > size=550 flags=2) > > ERROR: reserving fdt memory region failed (addr=f000 > > size=20 flags=4) > > > > It looks like all mentioned error messages are

[PATCH 6/6] boot: fdt: Handle already reserved memory in boot_fdt_reserve_region()

2024-12-07 Thread Sam Protsenko
is: lmb: Return -EEXIST in lmb_add_region_flags() if region already added Handle -EEXIST error code as a normal (successful) case in lmb_reserve_flags() and don't print any messages. Fixes: 1d9aa4a283da ("lmb: Fix the allocation of overlapping memory areas with !LMB_NONE")

[PATCH 5/6] lmb: Improve kernel-doc comments

2024-12-07 Thread Sam Protsenko
cosmetic cleanups as well. No functional change. Signed-off-by: Sam Protsenko --- include/lmb.h | 125 ++ lib/lmb.c | 55 -- 2 files changed, 74 insertions(+), 106 deletions(-) diff --git a/include/lmb.h b/include/lmb.h index

[PATCH 4/6] lmb: Improve coding style

2024-12-07 Thread Sam Protsenko
Fix checkpatch warnings. No functional change. Signed-off-by: Sam Protsenko --- lib/lmb.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/lib/lmb.c b/lib/lmb.c index 1642ce48bbbd..8c1c9b0f67c8 100644 --- a/lib/lmb.c +++ b/lib/lmb.c @@ -57,7

[PATCH 3/6] lmb: Make const flag_str[] in lmb_print_region_flags() more const

2024-12-07 Thread Sam Protsenko
flag_str[] is a pointer to const. Make it also a const pointer. Improve a style a bit while a it, to make this line fit 80 characters limit. No functional change. Signed-off-by: Sam Protsenko --- lib/lmb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/lmb.c b/lib

[PATCH 2/6] lmb: Return -EEXIST in lmb_add_region_flags() if region already added

2024-12-07 Thread Sam Protsenko
emory areas with !LMB_NONE") Signed-off-by: Sam Protsenko --- lib/lmb.c | 18 ++ test/lib/lmb.c | 2 +- 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/lib/lmb.c b/lib/lmb.c index 713f072f75ee..ce0dc49345fb 100644 --- a/lib/lmb.c +++ b/lib/lmb.c @@ -18

[PATCH 1/6] lmb: Fix flags data type in lmb_add_region_flags()

2024-12-07 Thread Sam Protsenko
gs for no-map properties") Signed-off-by: Sam Protsenko --- lib/lmb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/lmb.c b/lib/lmb.c index b03237bc06cb..713f072f75ee 100644 --- a/lib/lmb.c +++ b/lib/lmb.c @@ -200,7 +200,7 @@ static long lmb_add_region_flags

[PATCH 0/6] lmb: Fix reserving the same region multiple times

2024-12-07 Thread Sam Protsenko
, while at it. Only [PATCH 6/6] introduces an actual functional change. Sam Protsenko (6): lmb: Fix flags data type in lmb_add_region_flags() lmb: Return -EEXIST in lmb_add_region_flags() if region already added lmb: Make const flag_str[] in lmb_print_region_flags() more const lmb: Improve coding s

[REGRESSION] lmb: add and reserve memory above ram_top

2024-12-05 Thread Sam Protsenko
Hi Sughosh, Commit eb052cbb896f ("lmb: add and reserve memory above ram_top") causes a regression on the E850-96 board. It looks like it could be not E850-96 specific though. During U-Boot boot (the most recent master branch, with this commit present), before U-Boot shell appears, I observe the ne

[PATCH] configs: e850-96: Disable PSCI reset

2024-11-18 Thread Sam Protsenko
PSCI reset is not implemented in Exynos850 EL3 firmware. Disable it to fix the reset in cases where it can be used, e.g. when running EFI selftest. Signed-off-by: Sam Protsenko --- configs/e850-96_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/e850-96_defconfig b

Re: [PATCH v2 1/2] armv8: Fix get_sctlr() return type

2024-11-12 Thread Sam Protsenko
On Mon, Nov 11, 2024 at 8:48 AM Ilias Apalodimas wrote: > > On Thu, 7 Nov 2024 at 04:58, Sam Protsenko wrote: > > > > SCTLR_EL2 is a 64-bit register [1]. Return its value as long (64 bit) > > instead of int (32 bit) in get_sctlr() to make sure it's not tr

Re: [PATCH v5 6/6] common: android_ab: fix slot suffix for abc block

2024-11-06 Thread Sam Protsenko
On Wed, Nov 6, 2024 at 4:02 AM Mattijs Korpershoek wrote: > > Hi Sam, > > On mar., nov. 05, 2024 at 18:58, Sam Protsenko > wrote: > > > On Tue, Nov 5, 2024 at 9:06 AM Mattijs Korpershoek > > wrote: > >> > >> Hi Sam, > >> > > >

[PATCH v2 2/2] armv8: cpu: Implement allow_unaligned()

2024-11-06 Thread Sam Protsenko
27;t implemented for ARMv8 CPUs, so data abort happened. Signed-off-by: Sam Protsenko --- Changes in v2: - None arch/arm/cpu/armv8/cpu.c | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/cpu/armv8/cpu.c b/arch/arm/cpu/armv8/cpu.c index d568efa427ab..82ecf02f4b03 100644 --- a/

[PATCH v2 1/2] armv8: Fix get_sctlr() return type

2024-11-06 Thread Sam Protsenko
quot;arm64: core support") Suggested-by: Heinrich Schuchardt Signed-off-by: Sam Protsenko --- Changes in v2: - None (this patch was introduced in v2) arch/arm/cpu/armv8/cache_v8.c | 2 +- arch/arm/include/asm/system.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] armv8: cpu: Implement allow_unaligned()

2024-11-05 Thread Sam Protsenko
On Fri, Nov 1, 2024 at 6:46 AM Heinrich Schuchardt wrote: > [snip] > > +void allow_unaligned(void) > > +{ > > + set_sctlr(get_sctlr() & ~CR_A); > > Looking at the ARM documentation SCTLR_EL2 is a 64bit register. > > https://developer.arm.com/documentation/ddi0595/2021-06/AArch64-Registers/SC

Re: [PATCH v5 6/6] common: android_ab: fix slot suffix for abc block

2024-11-05 Thread Sam Protsenko
On Tue, Nov 5, 2024 at 9:06 AM Mattijs Korpershoek wrote: > > Hi Sam, > Hey Mattijs, [snip] > >> @@ -328,7 +328,8 @@ int ab_select_slot(struct blk_desc *dev_desc, struct > >> disk_partition *part_info, > >> * or the device tree. > >> */ > >> me

Re: [PATCH v5 6/6] common: android_ab: fix slot suffix for abc block

2024-11-04 Thread Sam Protsenko
On Thu, Oct 17, 2024 at 9:12 AM Dmitry Rokosov wrote: > > To align with the official Android BCB (Bootloader Control Block) > specifications, it's important to note that the slot_suffix should start > with an underscore symbol. > > For a comprehensive understanding of the expected slot_suffix form

Re: [PATCH] clk: Propagate clk_set_rate() if CLK_SET_PARENT_RATE present

2024-11-04 Thread Sam Protsenko
Hi Tom, Sean, Can we please apply this patch? I don't really understand why it's been consistently ignored for so long, with no explanation even. eMMC on E850-96 still doesn't work properly, this patch is really needed. Thanks! On Tue, Aug 13, 2024 at 8:17 PM Sam Protsenko wro

[PATCH] armv8: cpu: Implement allow_unaligned()

2024-10-31 Thread Sam Protsenko
27;t implemented for ARMv8 CPUs, so data abort happened. Signed-off-by: Sam Protsenko --- arch/arm/cpu/armv8/cpu.c | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/cpu/armv8/cpu.c b/arch/arm/cpu/armv8/cpu.c index d568efa427ab..82ecf02f4b03 100644 --- a/arch/arm/cpu/a

[PATCH] arm: dts: e850-96: Remove TRNG node from appended dts

2024-10-30 Thread Sam Protsenko
27;rng' command in U-Boot shell. Signed-off-by: Sam Protsenko --- arch/arm/dts/exynos850-e850-96-u-boot.dtsi | 11 --- 1 file changed, 11 deletions(-) diff --git a/arch/arm/dts/exynos850-e850-96-u-boot.dtsi b/arch/arm/dts/exynos850-e850-96-u-boot.dtsi index 3aa5d8bb10d0..6d7148f7

Re: [PATCH] android_ab: Fix backup offset calculation

2024-08-27 Thread Sam Protsenko
On Wed, Aug 7, 2024 at 9:14 AM Joshua Watt wrote: > > The backup offset is in bytes, but was incorrectly be interpreted as > blocks, leading to it being written to the wrong location. Fix the > calculation and clarify that ANDROID_AB_BACKUP_OFFSET is in bytes and > must be a multiple of the block

Re: [PATCH v5 00/38] mmc: dw_mmc: Enable eMMC on E850-96 board

2024-08-20 Thread Sam Protsenko
On Tue, Aug 20, 2024 at 3:16 PM Tom Rini wrote: > > On Tue, Aug 20, 2024 at 02:48:59PM -0500, Sam Protsenko wrote: > > On Mon, Aug 19, 2024 at 8:45 PM Minkyu Kang wrote: > > > > > > Hi, > > > > > > 2024년 8월 14일 (수) 10:15, Sam Protsenko 님이 작성: &g

Re: [PATCH v5 00/38] mmc: dw_mmc: Enable eMMC on E850-96 board

2024-08-20 Thread Sam Protsenko
On Mon, Aug 19, 2024 at 8:45 PM Minkyu Kang wrote: > > Hi, > > 2024년 8월 14일 (수) 10:15, Sam Protsenko 님이 작성: >> >> Hi Minkyu, >> >> What do you think about this series? It's been pending for a while >> now, so may I ask you to take care of it? >

Re: [PATCH] clk: Propagate clk_set_rate() if CLK_SET_PARENT_RATE present

2024-08-13 Thread Sam Protsenko
Hi Sean, This series has been pending for 5 months now. If there are no objections, can you please apply it? Thanks! On Wed, Jul 31, 2024 at 3:05 PM Sam Protsenko wrote: > > On Thu, Jul 25, 2024 at 3:57 PM Sam Protsenko > wrote: > > > > [snip] > > > > >&g

Re: [PATCH v5 00/38] mmc: dw_mmc: Enable eMMC on E850-96 board

2024-08-13 Thread Sam Protsenko
Hi Minkyu, What do you think about this series? It's been pending for a while now, so may I ask you to take care of it? Thanks! On Wed, Aug 7, 2024 at 10:14 PM Sam Protsenko wrote: > > Bring 64-bit support to dw_mmc core and Exynos dw_mmc drivers, and > enable it on E850-96 board

[PATCH v5 38/38] doc: samsung: Mention enabled eMMC in E850-96 board doc

2024-08-07 Thread Sam Protsenko
eMMC is enabled on E850-96 board now. Mention that in the board documentation. Signed-off-by: Sam Protsenko --- Changes in v5: - (none) Changes in v4: - (none) Changes in v3: - (none) Changes in v2: - (none) doc/board/samsung/e850-96.rst | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH v5 35/38] mmc: exynos_dw_mmc: Improve coding style

2024-08-07 Thread Sam Protsenko
Fix most of checkpatch warnings and other obvious style issues. No functional change. Signed-off-by: Sam Protsenko --- Changes in v5: - (none) Changes in v4: - (none) Changes in v3: - (none) Changes in v2: - (none) arch/arm/mach-exynos/include/mach/dwmmc.h | 36

  1   2   3   4   5   6   7   8   9   10   >