U-Boot custodian workflow

2020-05-15 Thread Remy Bohmer
Hi, Regarding the Custodian workflow I have a general question: why do we follow a rebase flow for the custodian trees? If custodians merge master frequently into their own branches and merge that back on pull requests would technically work too right? But there are downsides to it why this is not

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2012-01-15 Thread Remy Bohmer
Hi All, 2011/12/22 Ilya Yanok : > Hi Govindraj, > > On 22.12.2011 10:55, Govindraj wrote: >>> >>> Signed-off-by: Ilya Yanok >>> --- >>> Changes from V3: >>>  - None >>> Changes from V2: >>>  - None >>> Changes from V1: >>>  - CONFIG_OMAP_EHCI_PHYx_RESET changed to CONFIG_OMAP_EHCI_PHYx_RESET_GPIO

Re: [U-Boot] [PATCH v4 16/20] tegra: usb: Add support for Tegra USB peripheral

2012-01-15 Thread Remy Bohmer
; >        aliases { >                /* This defines the order of our USB ports */ >                usb0 = "/usb@0xc5008000"; >                usb1 = "/usb@0xc500"; >        }; > > drivers/usb/host files ONLY: Acked-by: Remy Bohmer > Signed-off-by: Simon Glass

Re: [U-Boot] [PATCH] USB: move keyboard polling into kbd driver

2012-01-15 Thread Remy Bohmer
Hi, 2011/12/21 Allen Martin : > This moves keyboard polling logic from USB HCD drivers into USB > keyboard driver.  Remove usb_event_poll() as keyboard polling was > the only user of this API.  With this patch USB keyboard works with > EHCI controllers again.  Tested on a tegra2 seaboard. > > Sign

Re: [U-Boot] [PATCH] USB: reevaluate iomux stdin on USB kbd detect

2012-01-15 Thread Remy Bohmer
Hi, 2011/12/23 Allen Martin : > If CONSOLE_MUX is enabled, reevaluate console stdin when USB keyboard > device is detected. > > Signed-off-by: Allen Martin > --- >  common/usb_kbd.c |    6 ++ >  1 files changed, 6 insertions(+), 0 deletions(-) Applied to u-boot-usb. Thanks. Kind regards, R

Re: [U-Boot] [PATCH v4 14/20] usb: Add support for txfifo threshold

2012-01-15 Thread Remy Bohmer
t;  drivers/usb/host/ehci.h     |    6 +- >  3 files changed, 15 insertions(+), 1 deletions(-) Acked-by: Remy Bohmer ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] usb: add numeric keypad support to HID driver

2012-01-15 Thread Remy Bohmer
Hi, 2012/1/9 Vincent Palatin : > When keys are pressed on the numeric keypad, emit key codes for the numbers, > operators, dot and enter. > > Signed-off-by: Vincent Palatin > --- >  common/usb_kbd.c |   10 ++ >  1 files changed, 10 insertions(+), 0 deletions(-) Applied to u-boot-usb. Tha

Re: [U-Boot] [PATCH] USB: fix USB keyboard polling parameter

2012-01-15 Thread Remy Bohmer
Hi, 2012/1/9 Vincent Palatin : > When doing a "GET_REPORT" request on the keyboard control endpoint, > the report ID should 0 (ie report ID not used) rather than 1 > as reports are not used in boot mode. > > Signed-off-by: Vincent Palatin > --- Applied to u-boot-usb. Thanks. Kind regards, Remy

Re: [U-Boot] [PATCH] USB: relax usbcore reset timings

2012-01-15 Thread Remy Bohmer
h speed devices. > Furthermore, the wait is only done once after power has been enabled > on all ports. > > CC: Remy Bohmer > CC: Vincent Palatin > Signed-off-by: Wolfgang Grandegger > --- >  common/usb.c |    5 - >  1 files changed, 4 insertions(+), 1 deletions(-) Ap

Re: [U-Boot] [PATCH] eth: remove usb-ethernet devices before re-enumerating them

2012-01-15 Thread Remy Bohmer
Hi, 2012/1/9 Vincent Palatin : > Fix the crash when running several times usb_init() with a USB ethernet > device plugged. > > Signed-off-by: Vincent Palatin > Tested-by: Wolfgang Grandegger > --- >  drivers/usb/eth/usb_ether.c |    7 +-- >  include/net.h               |    1 + >  net/eth.c

Re: [U-Boot] [PATCH] ehci: speed up initialization

2011-12-19 Thread Remy Bohmer
Hi Wolfgang, 2011/12/19 Wolfgang Grandegger : > On 12/19/2011 01:51 PM, Vincent Palatin wrote: >> On Mon, Dec 19, 2011 at 04:07, Wolfgang Grandegger >> wrote: >>> I just realized that this patch breaks "usb start" on my mx53loco board: >>> >>> The device is not found at the first attempt. Obviou

Re: [U-Boot] [PATCH] USB: move keyboard polling from EHCI driver into kbd driver

2011-12-17 Thread Remy Bohmer
Hi, 2011/12/16 Allen Martin : > This removes dependency on global variable "new" from EHCI driver with > CONFIG_SYS_USB_EVENT_POLL turned on and gets USB keyboard working with > EHCI driver again. > > Signed-off-by: Allen Martin > --- >  common/usb_kbd.c            |   18 +- >  dr

[U-Boot] Pull request: u-boot-usb

2011-12-16 Thread Remy Bohmer
The following changes since commit 06e42c6e2ce269667daecd6229d0b7c813838203: Merge branch 'ag...@denx.de' of git://git.denx.de/u-boot-staging (2011-12-12 14:51:16 +0100) are available in the git repository at: git://git.denx.de/u-boot-usb.git master Igor Grinberg (4): USB: ULPI: switc

Re: [U-Boot] [PATCH 4/4] README: add documentation for CONFIG_USB_ULPI*

2011-12-16 Thread Remy Bohmer
Hi, 2011/12/16 Simon Glass : > Hi Remy, > > On Fri, Dec 16, 2011 at 12:10 PM, Remy Bohmer wrote: >> Hi Igor, >> >>> Here the configs are documented. >>> I admit, it is not that brilliant documentation... >> >> Are you planning to post an update

Re: [U-Boot] [PATCH v2 1/1] USB: Use (get|put)_unaligned for accessing wMaxPacketSize

2011-12-16 Thread Remy Bohmer
ze and in others, a > macro. > > Cc: Minkyu Kang > Cc: Remy Bohmer > > OpenRISC: > Tested-by: Stefan Kristiansson > > Beagleboard xM, Pandaboard run-tested, s5p_goni build-tested. > Signed-off-by: Tom Rini > --- >  common/cmd_usb.c      

Re: [U-Boot] [PATCH v3 3/3] usb:gadget:s5p Enable the USB Gadget framework at Exynos4210 (C210 Universal)

2011-12-16 Thread Remy Bohmer
Hi, 2011/12/15 Lukasz Majewski : > This commit enables support for USB Gadgets on the Exynos4210 (C210 Universal) > reference target. > > Signed-off-by: Lukasz Majewski > Signed-off-by: Kyungmin Park > Cc: Minkyu Kang > CC: Remy Bohmer > --- > Changes fo

Re: [U-Boot] [PATCH 4/4] README: add documentation for CONFIG_USB_ULPI*

2011-12-16 Thread Remy Bohmer
Hi Igor, 2011/12/15 Igor Grinberg : Where does it say that only this one is supported in the code? >>> >>> You mean comments or the code? >> >> Well the filename seems generic and not specific to that chip. Are >> viewports something that other chips can support? > > Let me clarify: > 1) It i

Re: [U-Boot] [PATCH 3/4] USB: ULPI: increase error case verbosity

2011-12-16 Thread Remy Bohmer
Hi, 2011/12/12 Igor Grinberg : > Add the argument value to the error message. > > Signed-off-by: Igor Grinberg > --- >  drivers/usb/ulpi/ulpi.c |   12 ++-- >  1 files changed, 6 insertions(+), 6 deletions(-) Applied to -u-boot-usb. Thanks. Kind regards, Remy ___

Re: [U-Boot] [PATCH 2/4] USB: ULPI: clean a mixup of return types

2011-12-16 Thread Remy Bohmer
Hi, 2011/12/12 Igor Grinberg : > Clean a mixup between u32 and int as a return type > for functions returning error values. > Use int as it is native (and widely used) return type. > > Signed-off-by: Igor Grinberg > --- >  drivers/usb/ulpi/ulpi-viewport.c |    4 ++-- >  drivers/usb/ulpi/ulpi.c  

Re: [U-Boot] [PATCH v2 1/4] USB: ULPI: switch argument type from u8 to unsigned

2011-12-16 Thread Remy Bohmer
Hi, 2011/12/16 Simon Glass : > On Tue, Dec 13, 2011 at 10:16 PM, Igor Grinberg > wrote: >> There is no benefit in using u8, so switch to unsigned to reduce the >> binary image size (by 20 bytes). >> >> Signed-off-by: Igor Grinberg >> Acked-by: Simon Glass > > Looks good thanks > >> --- >> v2:

Re: [U-Boot] [PATCH v3] AT91: pio: Add PIO3 features

2011-12-15 Thread Remy Bohmer
> Signed-off-by: Hong Xu Maybe this helps getting this patch rolling again: Acked-by: Remy Bohmer Kind regards, Remy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] Pull request: u-boot-usb

2011-12-11 Thread Remy Bohmer
The following changes since commit c90a4dd79cb17abb46689f27ff9f1c971362d6e2: post/post.c: Use lldiv for 64-bit divisions (2011-12-10 23:15:14 +0100) are available in the git repository at: git://git.denx.de/u-boot-usb.git master Jana Rapava (1): USB: Add generic ULPI layer and a viewpo

Re: [U-Boot] [PATCH v1 3/3] usb:gadget:s5p Enable the USB Gadget framework at C210 Universal

2011-12-11 Thread Remy Bohmer
Hi Lukasz, 2011/11/27 Remy Bohmer : > Hi, > > 2011/10/27 Lukasz Majewski : >> This commit enables support for USB Gadgets on the C210 Universal >> reference target. >> >> Signed-off-by: Lukasz Majewski >> Signed-off-by: Kyungmin Park >> Cc: Minkyu

Re: [U-Boot] [PATCH 0/9] MX5x USB support

2011-12-10 Thread Remy Bohmer
Hi Marek, > > If some of the patches didn't make it through gmail because of the different > From:, please check git://git.denx.de/u-boot-marex.git, "usb" branch. Pulling it failed. Can you please rebase it on top of current u-boot-usb, then I will pull it from there. Kind regards, Remy ___

Re: [U-Boot] [PATCH 0/9] MX5x USB support

2011-12-10 Thread Remy Bohmer
Hi Marek, 2011/12/7 Marek Vasut : > This patchset adds the USB support for MX5x. Most of the code is based on work > of Wolfgang Grandegger with modifications done by various other authors. I > also > included version of ULPI support code cleaned up by Igor Grinberg. > > NOTE: I'd really love to

Re: [U-Boot] [PATCH v3 11/16] usb: Add support for txfifo threshold

2011-12-10 Thread Remy Bohmer
t;  drivers/usb/host/ehci.h     |    6 +- >  3 files changed, 15 insertions(+), 1 deletions(-) Since it is part of a bigger series: Acked-by: Remy Bohmer Kind regards, Remy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] ehci: speed up initialization

2011-12-10 Thread Remy Bohmer
Hi, 2011/12/5 Vincent Palatin : > According to EHCI specification v1.0, the controller should stabilize > the power on a port at most 20 ms after the port power bit transition. > So, we put this setting in the virtual descriptor corresponding field, > (bPwrOn2PwrGood = 10 => 10 x 2ms = 20ms), this

Re: [U-Boot] [PATCH v2 11/17] usb: Add support for data alignment

2011-12-10 Thread Remy Bohmer
Hi Simon, 2011/12/6 Simon Glass : >> >> I do not really like this solution. Maybe we can introduce something >> like an usbbuf_alloc() function that takes care of the alignment. >> This saves the memcpy() for every transmit. I know it has more impact >> if we do it like that, but I think it is cle

[U-Boot] Pull request: u-boot-usb

2011-12-10 Thread Remy Bohmer
The following changes since commit c4eba6ec5c58083b38340724c006294c7a4fe2eb: common/usb_kbd.c: fix bug introduced in commit 00b7d6e (2011-12-09 12:09:35 +0100) are available in the git repository at: git://git.denx.de/u-boot-usb.git master Lei Wen (1): USB: gadaget: add Marvell control

Re: [U-Boot] [PATCH 6/9] drivers/usb/gadget/ep0.c: Fix GCC 4.6 warning

2011-12-04 Thread Remy Bohmer
Hi, 2011/12/3 Anatolij Gustschin : > Fix: > ep0.c: In function 'ep0_get_descriptor': > ep0.c:187:8: warning: variable 'cp' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin > Cc: Remy Bohmer > --- >  drivers/u

Re: [U-Boot] [PATCH v2 11/17] usb: Add support for data alignment

2011-12-04 Thread Remy Bohmer
Hi, 2011/12/3 Simon Glass : > CONFIG_USB_EHCI_DATA_ALIGN sets the required alignment of data for > USB packets (e.g. 4 means word-aligned). This is required for Tegra > to operate. > > Signed-off-by: Simon Glass > --- > Changes in v2: > - Tidy code style in USB buffer alignment code > - Display p

Re: [U-Boot] [PATCH v2 13/17] tegra: usb: Add support for Tegra USB peripheral

2011-12-04 Thread Remy Bohmer
> - Decode phy type differently (to match new kernel fdt) > - Rename tegra20-usb to tegra20-ehcui (to match new kernel fdt) > - Improve debug() printouts in case of failure to init USB > >  drivers/usb/host/Makefile                 |    1 + &g

Re: [U-Boot] [PATCH 4/9] drivers/usb/musb/musb_udc.c: Fix GCC 4.6 warning

2011-12-04 Thread Remy Bohmer
ed > [-Wunused-but-set-variable] > musb_udc.c:165:5: warning: variable 'intrusb' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin > Cc: Remy Bohmer > --- >  drivers/usb/musb/musb_udc.c |    8 +++- >  1 files changed, 3 in

Re: [U-Boot] [PATCH 5/9] drivers/usb/gadget/core.c: Fix GCC 4.6 warning

2011-12-04 Thread Remy Bohmer
Hi, 2011/12/3 Anatolij Gustschin : > Fix: > core.c: In function 'usbd_device_event_irq': > core.c:596:21: warning: variable 'state' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin > Cc: Remy Bohmer > --- >  d

Re: [U-Boot] [PATCH 4/5] usbtty: init endpoints prior to startup events

2011-11-30 Thread Remy Bohmer
Hi Stefan, 2011/11/28 Stefan Herbrechtsmeier : > Am 26.11.2011 23:25, schrieb Remy Bohmer: > >> 2011/10/17 Stefan Herbrechtsmeier: >>> >>> On some usb device controllers (pxa) the endpoint configuration must be >>> programmed prior to enable it. >&g

Re: [U-Boot] [PATCH] drivers/usb/host/ehci-mxc.c: Fix GCC 4.6 warning

2011-11-26 Thread Remy Bohmer
Hi, 2011/11/19 Anatolij Gustschin : > Fix: > ehci-mxc.c: In function 'ehci_hcd_init': > ehci-mxc.c:113:6: warning: variable 'tmp' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Anatolij Gustschin > --- >  drivers/usb/host/ehci-mxc.c |    3 +-- >  1 files changed, 1 insertions(+

Re: [U-Boot] [PATCH 1/2] cosmetic: remove excess whitespace from usb command help

2011-11-26 Thread Remy Bohmer
Hi, 2011/11/2 Veli-Pekka Peltola : > Signed-off-by: Veli-Pekka Peltola > Cc: Remy Bohmer > --- >  common/cmd_usb.c |   10 +- >  1 files changed, 5 insertions(+), 5 deletions(-) Applied to u-boot-usb. Thanks. Kind regards, Remy ___

Re: [U-Boot] [PATCH 2/2] usb: add help for missing start subcommand

2011-11-26 Thread Remy Bohmer
Hi, 2011/11/2 Veli-Pekka Peltola : > Signed-off-by: Veli-Pekka Peltola > Cc: Remy Bohmer > --- > When I first time used USB framework it was not so obvious to start with > "usb reset" to get everything going on. So lets add help text for start. > >  common/cmd

Re: [U-Boot] [PATCH v2 3/3] usb:gadget:s5p Support for USB Mass Storage Gadget at GONI

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/18 Lukasz Majewski : > This patch adds support for USB Mass Storage Gadget on the > Samsung's GONI reference target > > Signed-off-by: Lukasz Majewski > Signed-off-by: Kyungmin Park > Cc: Remy Bohmer > Cc: Minkyu Kang > --- > Changes for v2: >

Re: [U-Boot] [PATCH v1 3/3] usb:gadget:s5p Enable the USB Gadget framework at C210 Universal

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/27 Lukasz Majewski : > This commit enables support for USB Gadgets on the C210 Universal > reference target. > > Signed-off-by: Lukasz Majewski > Signed-off-by: Kyungmin Park > Cc: Minkyu Kang > --- > Depend on: "New generic PMIC framework" > > http://patchwork.ozlabs.org/patch/1180

Re: [U-Boot] [PATCH v5 1/3] usb:gadget:s5p USB Device Controller (UDC) implementation

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/27 Lukasz Majewski : > This commit provides UDC driver support for Samsung's SoC > family of processors. > > Signed-off-by: Lukasz Majewski > Signed-off-by: Marek Szyprowski > Signed-off-by: Kyungmin Park > Cc: Minkyu Kang > Cc: Remy B

Re: [U-Boot] [PATCH] usb: align usb_endpoint_descriptor to 16-bit boundary

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/20 Stefan Kristiansson : > The usb_endpoint_descriptor struct is 7 bytes large and is > defined as an array (ep_desc[USB_MAXENDPOINTS]) > in the usb_interface struct in include/usb.h > > This fact will result in that every odd index in that > array will start at an uneven address, this

Re: [U-Boot] [PATCH 5/5] pxa: fix relocation

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/17 Stefan Herbrechtsmeier : > The current relocation don't work correct, as it doesn't clear the > initial ram (dcache) after relocation. This leads to missing bootargs > during Linux boot. Additionally the current relocation use the sdram > address for the initial ram which introduce

Re: [U-Boot] [PATCH 4/5] usbtty: init endpoints prior to startup events

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/17 Stefan Herbrechtsmeier : > On some usb device controllers (pxa) the endpoint configuration must be > programmed prior to enable it. > > Signed-off-by: Stefan Herbrechtsmeier > CC: Marek Vasut > CC: Remy Bohmer   > --- >  drivers/serial/usbtty.c |    4 ++

Re: [U-Boot] [PATCH 3/5] pxa: convert pxa27x_udc to use read and write functions

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/17 Marek Vasut : > On Monday, October 17, 2011 05:22:48 PM Stefan Herbrechtsmeier wrote: >> Signed-off-by: Stefan Herbrechtsmeier >> CC: Marek Vasut >> CC: Remy Bohmer   >> --- > > Hi Stefan, > > this patch is awesome, I really need this one. B

Re: [U-Boot] [PATCH 2/5] pxa: activate the first usb host port on pxa27x by default

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/17 Stefan Herbrechtsmeier : > The pxa27x has 3 usb host ports. Activate all by default. > > Signed-off-by: Stefan Herbrechtsmeier > CC: Marek Vasut > CC: Remy Bohmer   > --- >  arch/arm/cpu/pxa/usb.c |    4 ++-- >  1 files changed, 2 insertions(+), 2 deletio

Re: [U-Boot] [PATCH 1/5] pxa: fix usb host register mismatch

2011-11-26 Thread Remy Bohmer
Hi 2011/10/17 Stefan Herbrechtsmeier : > Signed-off-by: Stefan Herbrechtsmeier > CC: Marek Vasut > CC: Remy Bohmer   > --- >  arch/arm/cpu/pxa/usb.c                   |    2 +- >  arch/arm/include/asm/arch-pxa/pxa-regs.h |    2 ++ >  2 files changed, 3 insertions(+), 1 del

Re: [U-Boot] [PATCH] ehci-fsl: correct size of ehci caplength

2011-11-26 Thread Remy Bohmer
Hi, 2011/10/18 Kumar Gala : > > On Oct 17, 2011, at 1:16 PM, Wolfgang Grandegger wrote: > >> According to the EHCI specification the Capability Register Length >> has a size of 8 bits. >> >> Signed-off-by: Wolfgang Grandegger >> --- >> include/usb/ehci-fsl.h |   25 + >> 1

Re: [U-Boot] [PATCH 0/3] USB keyboard driver rework (round 2)

2011-11-26 Thread Remy Bohmer
email-marek.va...@gmail.com> > > [PATCH V2] USB: Add usb_event_poll() to get keyboards working with EHCI > Message-Id: <1316977676-10284-1-git-send-email-marek.va...@gmail.com> > > Cc: Mike Frysinger > Cc: Remy Bohmer > Cc: Wolfgang Denk > > Marek Vasut (3): &g

Re: [U-Boot] [PATCH 1/2] USB: Rework USB keyboard driver

2011-10-09 Thread Remy Bohmer
Hi Marek, >> > > it's hard to evaluate each piece by itself when it's just one patch >> > > smooshing it all together >> > >> > Well how would you rework crap code piece by piece? >> >> - fix style >> - abstract out stuff > > Not like there was so much abstraction it couldn't be squashed into this

Re: [U-Boot] [PATCH V2] USB: Add functionality to poll the USB keyboard via control EP

2011-10-08 Thread Remy Bohmer
This uses the Get_Report request. >> >> Signed-off-by: Marek Vasut >> Cc: Remy Bohmer >> --- >>  common/usb_kbd.c |   64 >> ++--- >>  1 files changed, 50 insertions(+), 14 deletions(-) >> >> V

Re: [U-Boot] [PATCH V2] USB: Add functionality to poll the USB keyboard via control EP

2011-10-08 Thread Remy Bohmer
Hi, 2011/10/7 Wolfgang Denk : > Dear Marek Vasut, > > In message <201110070131.53775.marek.va...@gmail.com> you wrote: >> >> > Checkpatch says: >> > >> > total: 5 errors, 1 warnings, 97 lines checked > ... >> Please see my previous comment about the state of usbkbd.c. The warnings are >> from orig

Re: [U-Boot] [PATCH 2/2] USB: Drop dead code from usb_kbd.c

2011-10-08 Thread Remy Bohmer
Hi Marek, 2011/10/7 Marek Vasut : > Signed-off-by: Marek Vasut > Cc: Wolfgang Denk > Cc: Remy Bohmer > --- >  common/usb_kbd.c |  369 > -- >  1 files changed, 0 insertions(+), 369 deletions(-) Looks good to me, but sinc

Re: [U-Boot] [PATCH V2] USB: Add usb_event_poll() to get keyboards working with EHCI

2011-10-08 Thread Remy Bohmer
Hi, 2011/9/25 Marek Vasut : > Signed-off-by: Marek Vasut > Cc: Remy Bohmer > --- >  drivers/usb/host/ehci-hcd.c |   33 - >  1 files changed, 32 insertions(+), 1 deletions(-) > > V2: Drop redundant bogus header. > Applied to u-boot-

Re: [U-Boot] [PATCH V2] USB: Add usb_event_poll() to get keyboards working with EHCI

2011-10-08 Thread Remy Bohmer
Hi Marek, 2011/10/7 Marek Vasut : > On Friday, October 07, 2011 07:25:22 AM Wolfgang Denk wrote: >> Dear Marek Vasut, >> >> In message <201110070130.14881.marek.va...@gmail.com> you wrote: >> > > Checkpatch says: >> > > >> > > total: 0 errors, 1 warnings, 43 lines checked >> > > >> > > Please clea

Re: [U-Boot] [PATCH] USB: gadaget: add Marvell controller support

2011-10-08 Thread Remy Bohmer
Hi, 2011/10/5 Lei Wen : > Signed-off-by: Lei Wen > --- >  drivers/usb/gadget/Makefile       |    1 + >  drivers/usb/gadget/gadget_chips.h |    7 + >  drivers/usb/gadget/mv_udc.c       |  499 > + >  include/usb/mv_udc.h              |  151 +++ >  4 file

Re: [U-Boot] [PATCH 7/7] common/usb.c: fix warning: variable ... set but not used

2011-10-08 Thread Remy Bohmer
iable 'portchange' set but not used > [-Wunused-but-set-variable] > usb.c: In function 'usb_hub_configure': > usb.c:1183:25: warning: variable 'hubsts' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Wolfgang Denk > Cc: Rem

Re: [U-Boot] [PATCH 6/7] drivers/usb/host/ohci-hcd.c: fix warning: variable ... set but not used

2011-10-08 Thread Remy Bohmer
Hi, 2011/10/5 Wolfgang Denk : > Fix: > ohci-hcd.c: In function 'dl_transfer_length': > ohci-hcd.c:968:8: warning: variable 'tdINFO' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Wolfgang Denk > Cc: Remy Bohmer > --- >  dr

Re: [U-Boot] [PATCH 5/7] common/cmd_usb.c: fix warning: variable ... set but not used

2011-10-08 Thread Remy Bohmer
Hi, 2011/10/5 Wolfgang Denk : > Fix: > cmd_usb.c: In function 'usb_show_tree_graph': > cmd_usb.c:284:29: warning: variable 'port' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Wolfgang Denk > Cc: Remy Bohmer > --- >  co

Re: [U-Boot] [PATCH 1/2 V3] USB: Fix complaints about strict aliasing in OHCI-HCD

2011-10-08 Thread Remy Bohmer
Hi, 2011/10/7 Marek Vasut : > Signed-off-by: Marek Vasut > --- >  drivers/usb/host/ohci-hcd.c |   75 -- >  1 files changed, 43 insertions(+), 32 deletions(-) Applied to u-boot-usb. Thanks. > V2: Fix comment, use union > V3: Fix checkpatch warnings (btw. t

[U-Boot] Pull request: u-boot-usb

2011-09-24 Thread Remy Bohmer
The following changes since commit 279bbbca12e71ae68278b756048194003a6d6e21: Merge branch 'master' of git://git.denx.de/u-boot-arm (2011-09-23 08:23:25 +0200) are available in the git repository at: git://git.denx.de/u-boot-usb.git master Marek Vasut (1): ASIX: Fix buffer access in as

Re: [U-Boot] [PATCH 3/6] USB: Fix complaints about strict aliasing in OHCI-HCD

2011-09-24 Thread Remy Bohmer
Hi Marek, 2011/8/28 Marek Vasut : > Signed-off-by: Marek Vasut > --- >  drivers/usb/host/ohci-hcd.c |   69 +++--- >  1 files changed, 38 insertions(+), 31 deletions(-) > I guess this is a v3 of this patch. Am I right? Kind regards, Remy _

Re: [U-Boot] [PATCH 2/2] GCC4.6: Remove unused "port" variable in cmd_usb.c

2011-09-24 Thread Remy Bohmer
;                                 */ > -                               port = i; >                                while (i++ < dev->parent->maxchild) { >                                        if (dev->parent->children[i] != NULL) { >                                                /* found a sister */

Re: [U-Boot] [PATCH v3 0/2] usb:gadget:s5p USB Device Controller (UDC) implementation

2011-09-24 Thread Remy Bohmer
Hi, 2011/9/16 Lukasz Majewski : > Dear all, > >> This patch series adds support for Samsung's USB Device Controller >> (UDC) on GONI reference target. >> >> --- >> Depend on: >> http://patchwork.ozlabs.org/patch/112847/ >> >> Lukasz Majewski (2): >>   usb:gadget:s5p USB Device Controller (UDC) imp

Re: [U-Boot] [PATCH] ASIX: Fix buffer access in asix_get_phy_addr()

2011-09-24 Thread Remy Bohmer
Hi, 2011/9/23 Marek Vasut : > Signed-off-by: Marek Vasut > --- >  drivers/usb/eth/asix.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/eth/asix.c b/drivers/usb/eth/asix.c Applied to u-boot-usb. Thanks. Remy ___

Re: [U-Boot] [PATCH] USB: Add usb_event_poll() to get keyboards working with EHCI

2011-09-24 Thread Remy Bohmer
Hi, 2011/9/24 Marek Vasut : > On Saturday, September 24, 2011 06:41:58 PM Remy Bohmer wrote: >> Hi, >> >> 2011/9/23 Marek Vasut : >> > Signed-off-by: Marek Vasut >> > Cc: Remy Bohmer >> > --- >> >  drivers/usb/host/ehci-hcd.c |   33 ++

Re: [U-Boot] [PATCH] USB: Add usb_event_poll() to get keyboards working with EHCI

2011-09-24 Thread Remy Bohmer
Hi, 2011/9/23 Marek Vasut : > Signed-off-by: Marek Vasut > Cc: Remy Bohmer > --- >  drivers/usb/host/ehci-hcd.c |   33 - >  1 files changed, 32 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/ho

Re: [U-Boot] [PATCH] arm, usb, davinci: make USBPHY_CTL register configurable

2011-09-24 Thread Remy Bohmer
t it ... and then > I post this patchset again with this patch in it! Can I add then your > "Acked-by" for this patch? Acked-by: Remy Bohmer Kind regards, Remy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3] Add USB support for Efika

2011-09-24 Thread Remy Bohmer
Hi Stefano, 2011/9/19 Stefano Babic : > you change several files, some of them in the general USB support. You > must then split your patch into a patchset, and each patch must address > a single issue. Really with your patch you do not only add USB support > to the EfikaMX board, but you want to

Re: [U-Boot] [RFC] fastboot gadget support

2011-08-24 Thread Remy Bohmer
Hi, 2011/8/10 Sebastian Andrzej Siewior : > > It was tested before it has been re-written. It is possible that it is > broken. It is posted for reference only not for merging. Looking at this code, I can already say that the way it is written is not suitable for mainline acceptance at all. If you

Re: [U-Boot] [RFC] fastboot gadget support

2011-08-13 Thread Remy Bohmer
Hi Sebastian, 2011/8/10 Sebastian Andrzej Siewior : > This is the faastboot gadget code based on > git://git.omapzoom.org/repo/u-boot.git as of commit 601ff71c8 including > a few changes. Some of them are: > - generic mmc framework > - "new" gadget framework > - different / easier command parsing

Re: [U-Boot] [PATCH 1/2][v2] powerpc/85xx: Add ULPI and UTMI USB Phy support for P1010/P1014

2011-08-13 Thread Remy Bohmer
- Use both getenv() and hwconfig to get USB phy type till getenv() >>   is depricated >> - Introduce CONFIG_SYS_FSL_USB_INTERNAL_UTMI_PHY to specify if soc >>   has internal UTMI phy >> >> Signed-off-by: Ramneek Mehresh >> CC: Remy Bohmer >> Signed-off-by:

Re: [U-Boot] [PATCH 1/2] powerpc/85xx: Add ULPI and UTMI USB Phy support for P1010/P1014

2011-08-08 Thread Remy Bohmer
Hi, >> The ifdef-ery makes the code somewhat messy as well. Can it be written >> somewhat else? >> Apart from that and the style issues, no remarks or concerns. > > Not really sure how to do that.  The patch is a bit more messy than the > actual code. I was talking about the actual code, not the

Re: [U-Boot] [PATCH v2] usb: increase non-bulk timeout for slow chipsets.

2011-08-08 Thread Remy Bohmer
Hi, 2011/7/31 Jason Cooper : > If you take a look at 96820a35, you'll see the original timeout was > CONFIG_SYS_HZ.  Which is 1000.  After the mentioned change, non-bulk timeout > was changed to 100.  This causes timeout failures on the dreamplug platform > when trying to initialize the usb micros

[U-Boot] Pull request: u-boot-usb

2011-08-08 Thread Remy Bohmer
The following changes since commit fa82f871c8dbc9a15e8dc274b3f99dd5fa0da458: Convert ISO-8859 files to UTF-8 (2011-08-04 23:34:02 +0200) are available in the git repository at: git://git.denx.de/u-boot-usb.git master Jason Cooper (1): usb: increase non-bulk timeout for slow chipsets.

Re: [U-Boot] [PATCH] arm, usb, davinci: make USBPHY_CTL register configurable

2011-08-08 Thread Remy Bohmer
Hi, 2011/8/2 Heiko Schocher : > Define CONFIG_DV_USBPHY_CTL for setting the USB PHY control > register. > Signed-off-by: Heiko Schocher > cc: Sandeep Paulraj > cc: Remy Bohmer > --- >  drivers/usb/musb/davinci.c |    6 +- >  1 files changed, 5 insertions(+), 1 delet

Re: [U-Boot] [PATCH v2] usb: increase non-bulk timeout for slow chipsets.

2011-08-08 Thread Remy Bohmer
Hi, 2011/8/4 Jason : > Remy, > > I neglected to include you in my original submission, could you please > take a look at this for u-boot-usb?  Original email is here [1].  And > the commit I'm referring to is here [2]. No problem... I am subscribed to the list, and I have seen it already. (I am a

Re: [U-Boot] [PATCH 1/2] powerpc/85xx: Add ULPI and UTMI USB Phy support for P1010/P1014

2011-08-08 Thread Remy Bohmer
t;   is depricated >  - Introduce CONFIG_SYS_FSL_USB_INTERNAL_UTMI_PHY to specify if soc >   has internal UTMI phy > > Signed-off-by: Ramneek Mehresh > CC: Remy Bohmer > Signed-off-by: Kumar Gala > --- >  arch/powerpc/include/asm/config_mpc85xx.h |    2 + >  dri

Re: [U-Boot] [PATCH 4/5] USB: Move USB_PRINTF() out of ifdef in usb_scan_devices()

2011-08-08 Thread Remy Bohmer
Hi, >> Yea of course ... I sent this to Remy some time ago already, got no response >> so >> far ... > > Hey.. It is a holiday season... ;-) > > Acked-by: Remy Bohmer > (It can go with the rest of the series) Seems that it time to go again on a next vacatio

Re: [U-Boot] [PATCH 4/5] USB: Move USB_PRINTF() out of ifdef in usb_scan_devices()

2011-08-08 Thread Remy Bohmer
. > > Yea of course ... I sent this to Remy some time ago already, got no response > so > far ... Hey.. It is a holiday season... ;-) Acked-by: Remy Bohmer (It can go with the rest of the series) Kind regards, Remy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 5/5] USB: Set portnr so USB1.1 and 1.0 devices work on EHCI controllers

2011-08-08 Thread Remy Bohmer
Hi, 2011/7/12 Marek Vasut : > Signed-off-by: Marek Vasut > --- >  common/usb.c |    1 + >  1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/common/usb.c b/common/usb.c > index 8e84266..a401c09 100644 > --- a/common/usb.c > +++ b/common/usb.c > @@ -1166,6 +1166,7 @@ void usb_hub_p

Re: [U-Boot] [PATCH] usb: r8a66597: Fix argument mistake of inl

2011-08-08 Thread Remy Bohmer
Hi, 2011/7/11 Nobuhiro Iwamatsu : > Fail in build, because argument of inl used in r8a66597_read_fifo is wrong. > > r8a66597.h:441:35: error: macro "inl" passed 2 arguments, but takes just 1 > In file included from r8a66597-hcd.c:25: > r8a66597.h: In function ‘r8a66597_read_fifo’: > r8a66597.h:441

Re: [U-Boot] [PATCH v2] MUSB timeout broken

2011-08-08 Thread Remy Bohmer
Hi, > 2011/7/4 Orjan Friberg : >> Use pre-decrement to leave timeout at 0 when the timeout happens (which is >> what >> the timeout detecting code expects). >> >> Signed-off-by: Orjan Friberg >> --- >>  drivers/usb/musb/musb_hcd.c |    2 +- >>  1 files changed, 1 insertions(+), 1 deletions(-) >>

Re: [U-Boot] [PATCH v2] MUSB timeout broken

2011-08-08 Thread Remy Bohmer
Hi, 2011/7/4 Orjan Friberg : > Use pre-decrement to leave timeout at 0 when the timeout happens (which is > what > the timeout detecting code expects). > > Signed-off-by: Orjan Friberg > --- >  drivers/usb/musb/musb_hcd.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --g

Re: [U-Boot] [PATCH 47/52] ARM: remove broken "at91sam9261ek" / "at91sam9g10ek" boards

2011-08-03 Thread Remy Bohmer
Hi Reinhard, > As of now, this board is "unbroken" again. Thanks! Remy ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 47/52] ARM: remove broken "at91sam9261ek" / "at91sam9g10ek" boards

2011-07-30 Thread Remy Bohmer
ilable in the git repository at: git://git.denx.de/u-boot-usb.git fix-at91sam9261ek Remy Bohmer (1): at91sam9261ek: make operational again Makefile | 23 --- arch/arm/cpu/arm926ejs/at91/at91sam9261_devices.c | 31 ++-- arch/arm/cpu/arm926

Re: [U-Boot] status of patches in usb next branch

2011-07-30 Thread Remy Bohmer
Hi, 2011/7/11 John Rigby : > Remy, > > Are the patches in your next branch candidates for moving to master > and doing a pull request or is there still work to be done? Things have been pushed to u-boot-usb master,and there will be a pull-request. Kind regards, Remy

Re: [U-Boot] [PATCH 0/2] usb:gadget: Linux USB Gadget framework

2011-07-05 Thread Remy Bohmer
Hi, 2011/7/5 Lukasz Majewski : > Included commits provide Linux USB gadget support for U-boot. > The USB Gadget infrastructure is running on top of the Samsung's > UDC OTG controller. The code has been tested on the GONI (S5PC110) > reference target. > > Files: > drivers/usb/gadget/file_storage.c

Re: [U-Boot] [PATCH] usb: convert to partial linking

2011-06-25 Thread Remy Bohmer
Hi, 2011/6/25 Mike Frysinger : > Looks like this was missed during the conversion to partial linking. > > Signed-off-by: Mike Frysinger > --- >  Makefile                 |    2 +- >  drivers/usb/eth/Makefile |    4 ++-- >  2 files changed, 3 insertions(+), 3 deletions(-) Applied to u-boot-usb ma

[U-Boot] Pull request: u-boot-usb

2011-06-25 Thread Remy Bohmer
The following changes since commit 9623c158f6a5150a21c25026bfba79e7ff7912f5: Merge branch 'master' of git://git.denx.de/u-boot-arm (2011-06-23 15:37:33 +0200) are available in the git repository at: git://git.denx.de/u-boot-usb.git master Cliff Cai (1): musb: process control messages

Re: [U-Boot] [PATCH v8 4/4] Put common autoload code into auto_load() function

2011-06-20 Thread Remy Bohmer
Hi, 2011/6/14 Simon Glass : > This is a small clean-up patch. > > Changes for v8: >  - Fix typo in auto_load > > Signed-off-by: Simon Glass > Tested-by: Eric Bénard > --- Applied to u-boot-usb AFTER cleaning up commit message (Change history of the patch should be below the '---' line) Kind r

Re: [U-Boot] [PATCH v8 3/4] Add documentation for USB Host Networking

2011-06-20 Thread Remy Bohmer
Hi, 2011/6/14 Simon Glass : > This describes what it is for, devices supported, how to enable for your > board in U-Boot, setting up the server, and notes about MAC addresses. > > Changes for v6: > - Adjust documentation file according to Wolfgang's comments > > Signed-off-by: Simon Glass > Teste

Re: [U-Boot] [PATCH v8 1/4] Add support for SMSC95XX USB 2.0 10/100MBit Ethernet Adapter

2011-06-20 Thread Remy Bohmer
Hi, 2011/6/14 Simon Glass : > The SMSC95XX is a USB hub with a built-in Ethernet adapter. This adds support > for this, using the USB host network framework. > > Changes for v2: > - Coding style cleanup > - Changed some comments as suggested > > Changes for v3: > - Change turbo_mode to #define > >

Re: [U-Boot] [PATCH v8 2/4] Add Ethernet hardware MAC address framework to usbnet

2011-06-20 Thread Remy Bohmer
Hi, 2011/6/14 Simon Glass : > Built-in Ethernet adapters support setting the mac address by means of a > ethaddr environment variable for each interface (ethaddr, eth1addr, eth2addr). > > This adds similar support to the USB network side, using the names > usbethaddr, usbeth1addr, etc. They are ke

Re: [U-Boot] [PATCH v2 6/7] Tegra2: Add USB support

2011-05-13 Thread Remy Bohmer
Hi Simon, >> This patch touches a lot of files in different subsystems. >> Please split it up. For example start with a patch series modifying >> the generic USB code in drivers/usb, followed by a series that >> modifies board files. > > Hi Remy, > Thanks for the response. The series has 7 patches

Re: [U-Boot] [PATCH] ehci-pci: Fix PCI EHCI driver for 36-bit

2011-05-12 Thread Remy Bohmer
Hi, 2011/4/19 Zhao Chenhui : > Convert the PCI base address into a virtual address. > > Signed-off-by: Zhao Chenhui > Signed-off-by: Li Yang > --- >  drivers/usb/host/ehci-pci.c |    5 ++--- >  1 files changed, 2 insertions(+), 3 deletions(-) Applied to u-boot-usb. Thanks. Remy ___

Re: [U-Boot] [PATCH] musb: process control messages after roothub accepted it

2011-05-12 Thread Remy Bohmer
Hi, 2011/4/21 Mike Frysinger : > From: Cliff Cai > > When dealing with non-multipoint devices, if the software root hub code > accepted the message, then we still need to process it normally.  So only > return quickly when the root hub skipped the message or is otherwise in > an error state. > >

Re: [U-Boot] [PATCH v2 6/7] Tegra2: Add USB support

2011-05-12 Thread Remy Bohmer
Hi, 2011/5/5 Simon Glass : > This adds basic USB support for port 0. The other port is not supported by > this CL. > > Signed-off-by: Simon Glass > --- >  arch/arm/include/asm/arch-tegra2/tegra2.h |    2 + >  arch/arm/include/asm/arch-tegra2/usb.h    |  217 >  board/nvidia/c

Re: [U-Boot] [PATCH v4 2/5] Add Ethernet hardware MAC address framework to usbnet

2011-04-18 Thread Remy Bohmer
Hi, 2011/4/14 Simon Glass : > Built-in Ethernet adapters support setting the mac address by means of a > ethaddr environment variable for each interface (ethaddr, eth1addr, eth2addr). > > This adds similar support to the USB network side, using the names > usbethaddr, usbeth1addr, etc. They are ke

[U-Boot] Pull request: u-boot-usb

2011-04-02 Thread Remy Bohmer
The following changes since commit 67a490d60d70f2b01d55976440ba30154af96965: atmel_nand: don't require CONFIG_SYS_NAND_ENABLE_PIN (2011-04-01 14:49:08 -0500) are available in the git repository at: git://git.denx.de/u-boot-usb.git master Erik Hansen (2): Remove unnecessary reset in usb

  1   2   3   4   5   6   >