Re: [PATCH v4 2/3] board: phytec: imx93: Add eeprom-based hardware introspection

2024-11-21 Thread Primoz Fiser
Tested on phyBOARD-Nash-i.MX93 with 1.8V IO_VOLTAGE capable of HS400ES eMMC mode. Link: https://gist.github.com/pfiser/964617af99e43fb5cc6fec6b65070f21 Tested-by: Primoz Fiser On 20. 11. 24 17:31, Christoph Stoidner wrote: > The phyCORE-i.MX 93 is available in various variants. Relev

Re: [PATCH v3 2/3] board: phytec: imx93: Add eeprom-based hardware introspection

2024-11-20 Thread Primoz Fiser
g variant > options. Add evaluation of the eeprom data to the spl/u-boot to > enable/disable HS400 and to select the appropriate ram configuration at > startup. > > Signed-off-by: Christoph Stoidner > Reviewed-by: Wadim Egorov > --- > Cc: Mathieu Othacehe > Cc: Chri

Re: [PATCH v3 1/3] board: phytec: phycore-imx93: Add 2GB LPDDR4X RAM timings

2024-11-20 Thread Primoz Fiser
Tested on phyBOARD-Nash-i.MX93 with phyCORE-i.MX93 2GiB SOM Link: https://gist.github.com/pfiser/d5766c95f5639e6a9852c94412f39eb5 Tested-by: Primoz Fiser On 19. 11. 24 17:29, Christoph Stoidner wrote: > The phyCORE-i.MX 93 is available with a 1GB ram chip or a 2GB ram chip. > Add t

Re: [PATCH v2 2/3] board: phytec: imx93: Add eeprom-based hardware introspection

2024-11-14 Thread Primoz Fiser
ehe > Cc: Christoph Stoidner > Cc: Stefano Babic > Cc: Fabio Estevam > Cc: "NXP i.MX U-Boot Team" > Cc: Tom Rini > Cc: Yannic Moog > Cc: Primoz Fiser > Cc: Andrej Picej > Cc: Wadim Egorov > --- > Changes in v2: > - encapsulate handling of feature fl

Re: [PATCH v2 3/3] board: phytec: imx93: Add phyCORE-i.MX 93 support for all SOM variants

2024-11-14 Thread Primoz Fiser
evam > Cc: "NXP i.MX U-Boot Team" > Cc: Tom Rini > Cc: Yannic Moog > Cc: Primoz Fiser > Cc: Andrej Picej > Cc: Wadim Egorov > --- > Changes in v2: > - just rename imx93-phyboard-segin_defconfig and add needed CONFIGs, > instead of creating an en

Re: [PATCH 1/2] net: fec_mxc: Fix clk_ref rate on iMX93

2024-09-23 Thread Primoz Fiser
is change breaks fec ethernet. I had to revert this already in NXP downstream u-boot. BR, Primoz > + > ret = clk_set_rate(clk_ref, freq); > if (ret < 0) > return ret; -- Primoz Fiser| phone: +386-41-390-545 | -

[PATCH] imx: imx9: Set correct critical temperature

2024-08-13 Thread Primoz Fiser
Commit 3233349fa6e2 ("imx: imx9: fixup thermal trips from fuses") wrongly set critical temperature to (maxc - 5) instead of maxc. Fixes: 3233349fa6e2 ("imx: imx9: fixup thermal trips from fuses") Signed-off-by: Primoz Fiser --- arch/arm/mach-imx/imx9/soc.c | 2 +- 1 file

Re: [PATCH 1/3] arm: dts: imx93-phyboard-segin: Add USB support.

2024-03-19 Thread Primoz Fiser
Hi Marek, On 18. 03. 24 22:48, Marek Vasut wrote: > On 3/18/24 6:16 PM, Mathieu Othacehe wrote: >> Enable both usbotg1 and usbotg2 ports. > > Drop fullstop from $subject end. > >> Signed-off-by: Mathieu Othacehe >> --- >>   arch/arm/dts/imx93-phyboard-segin.dts | 13 + >>   1 file ch

Re: [PATCH 2/3] configs: imx93-phyboard-segin: Add USB support.

2024-03-19 Thread Primoz Fiser
CONFIG_IMX_TMU=y > +CONFIG_USB=y > +CONFIG_USB_EHCI_HCD=y > +CONFIG_USB_GADGET=y > +CONFIG_USB_GADGET_MANUFACTURER="FSL" > +CONFIG_USB_GADGET_VENDOR_NUM=0x1fc9 > +CONFIG_USB_GADGET_PRODUCT_NUM=0x0152 > +CONFIG_CI_UDC=y > CONF

Re: [PATCH v4] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support

2024-01-31 Thread Primoz Fiser
Hi Mathieu, Thanks for v4. I have no more remarks. Also tested your v4 on the board. Everything works, even eMMC booting which you were not able to test. With that my Tested-by: can be applied. Tested-by: Primoz Fiser BR, Primoz On 30. 01. 24 15:50, Mathieu Othacehe wrote: > Add init

Re: [PATCH v3] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support

2024-01-30 Thread Primoz Fiser
Hi Mathieu, On 30. 01. 24 14:37, Mathieu Othacehe wrote: > >> I am based on latest master 6faba41927bd (tag: v2024.04-rc1) > > That was it. I rebased from 043ca8c8a9b to 6faba41927bd and I now have > the same behaviour as you. I cannot find which commit fixed the > situation in that interval tho

Re: [PATCH v3] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support

2024-01-30 Thread Primoz Fiser
Hi Mathieu, On 30. 01. 24 13:49, Mathieu Othacehe wrote: > > Hey, > >> Can you re-check, please? >> >> Maybe check your include/generated/environment.h? > > Thanks for checking. It is strange that you do not reproduce that one. > > My include/generated/environment.h looks like: > > --8<--

[PATCH] imx9: clock: Fix board_interface_eth_init for FEC

2024-01-30 Thread Primoz Fiser
is always returned from the function in such case. Fix this by returning 0 (success) when FEC interface is primarily used instead of EQOS interface on i.MX93. Fixes: d5eae216d833 ("net: dwc_eth_qos: Add board_interface_eth_init() for i.MX93") Signed-off-by: Primoz Fiser --- arch/arm/mach-

Re: [PATCH v3] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support

2024-01-30 Thread Primoz Fiser
Hi Mathieu, On 30. 01. 24 10:43, Mathieu Othacehe wrote: > > Hello, > >> Please remove findfdt script. >> >> Not needed when you set fdt_file to CONFIG_DEFAULT_FDT_FILE above. > > The reason I used findfdt is that CONFIG_DEFAULT_FDT_FILE is a string > so, we end up with: > > --8<--

Re: [PATCH v3] board: phytec: phycore-imx93: Add phyBOARD-Segin-i.MX93 support

2024-01-29 Thread Primoz Fiser
Hi Mathieu, thanks for fixing my remarks. Here are just a few left for v4. On 25. 01. 24 17:45, Mathieu Othacehe wrote: > Add initial support for the PHYTEC phyBOARD-Segin-i.MX93 board based on > the PHYTEC phyCORE-i.MX93 SoM. > > Supported features: > - 1GB LPDDR4 RAM > - eMMC > - external

Re: [PATCH v2] Add Phytec i.MX93 support

2024-01-25 Thread Primoz Fiser
Hi Mathieu, First of all, thank you for the v2. I was able quickly build & test on the actual board. Here are my findings: - FEC ethernet doesn't work - distroboot doesn't work Did you expirience the same? Nonetheless, here are my comments for v2: On 24. 01. 24 14:42, Mathieu Othacehe wrote

Re: [PATCH] Add Phytec i.MX93 support

2024-01-18 Thread Primoz Fiser
Hi Mathieu, I already gave my review on the kernel mailing list. As first step, naming scheme is not compatible with PHYTEC naming convention. Please fix it across the entire patch. Maybe reference downstream u-boot for that? Please also use "phyBOARD-Segin-i.MX93" when referencing the board as

[PATCH 0/1] i.MX9 thermal trip fixups

2024-01-11 Thread Primoz Fiser
, Primoz Primoz Fiser (1): imx: imx9: fixup thermal trips from fuses arch/arm/mach-imx/imx9/soc.c | 45 1 file changed, 45 insertions(+) -- 2.25.1

[PATCH 1/1] imx: imx9: fixup thermal trips from fuses

2024-01-11 Thread Primoz Fiser
Read i.MX9 CPU temp grade from fuses and fixup thermal trips in Linux device-tree accordingly. Based on commit 0543a1ed2787 ("imx8m: fixup thermal trips") Signed-off-by: Primoz Fiser --- arch/arm/mach-imx/imx9/soc.c | 45 1 file changed, 45