Re: [U-Boot] [PATCH] mkimage: Fix generating multi and script images again

2015-12-07 Thread Philippe De Swert
Hi, On 07/12/15 21:06, Tom Rini wrote: On Mon, Dec 07, 2015 at 06:01:54PM +0100, Marek Vasut wrote: Seems 6ae6e160 broke creating multi and script type images and even building of mkimage itself. There are two problems with that patch. First is that expression (!(x == 0) || !(x == 1)) is alwa

Re: [U-Boot] [PATCH] mkimage: Fix generating multi and script images again

2015-12-07 Thread Philippe De Swert
Hi, I haven't had time to check the previous report yet. On 07/12/15 19:01, Marek Vasut wrote: Seems 6ae6e160 broke creating multi and script type images and even building of mkimage itself. There are two problems with that patch. First is that expression (!(x == 0) || !(x == 1)) is always tru

Re: [U-Boot] [PATCH] mkimage : Fix generating multi and script images

2015-12-07 Thread Philippe De Swert
Hi Simon, On 07/12/15 06:31, Simon Glass wrote: - dfd = open(params.datafile, O_RDONLY | O_BINARY); - if (dfd < 0) { - fprintf(stderr, "%s: Can't open %s: %s\n", - params.cmdname, params.datafile, strerror(errno)); - exit(EXIT_FAILUR

[U-Boot] [PATCH] mkimage : Fix generating multi and script images

2015-12-03 Thread Philippe De Swert
open zImage:splash.bmp:device.dtb: No such file or directory Since the sizes of the different parts seem to get added in the actual routine that handles multi and script type images, we can probably skip the bit of the code that causes the failure for that type of images. Signed-off-by: Philippe De Swert ---