On Mon, Nov 18, 2024 at 11:34:59AM -0800, Tony Dinh wrote:
> These boards don't use JFFS2 file system for booting so remove it.
>
> Ref: https://lore.kernel.org/u-boot/20241114233005.GN3600562@bill-the-cat/T/#t
> Signed-off-by: Tony Dinh
For DS414 at least:
Acked-by: Phil Sutter
Thanks, Phil
T_LBA to support >2TB HDD/SDD
> >
> > Signed-off-by: Tony Dinh
Acked-by: Phil Sutter
> Reviewed-by: Stefan Roese
>
> @Phil, is this ready to be merged from your point of view as well?
I still want to investigate legacy bootstd integration, but that's
follow-up work anyway.
Tony, thanks for your efforts and the good discussion so far!
Cheers, Phil
Hi Tony,
On Fri, Jun 28, 2024 at 03:44:01PM -0700, Tony Dinh wrote:
> On Fri, Jun 28, 2024 at 3:04 PM Tony Dinh wrote:
> > On Wed, Jun 26, 2024 at 3:31 AM Phil Sutter wrote:
> > > On Sat, Jun 15, 2024 at 03:06:54PM -0700, Tony Dinh wrote:
> > > [...]
> > >
Hi Tony,
On Sat, Jun 15, 2024 at 03:06:54PM -0700, Tony Dinh wrote:
[...]
> diff --git a/board/Synology/ds414/ds414.c b/board/Synology/ds414/ds414.c
> index abe6f9eb5e..f0b55fa095 100644
> --- a/board/Synology/ds414/ds414.c
> +++ b/board/Synology/ds414/ds414.c
> @@ -181,18 +181,9 @@ int board_init
Hi,
On Sun, Jun 09, 2024 at 01:51:34PM -0700, Tony Dinh wrote:
> On Sat, Jun 8, 2024 at 4:32 PM Phil Sutter wrote:
> > On Fri, Jun 07, 2024 at 04:14:26PM -0700, Tony Dinh wrote:
> > > On Fri, Jun 7, 2024 at 6:45 AM Phil Sutter wrote:
> > > > On Thu, Jun 06, 2024
On Fri, Jun 07, 2024 at 04:14:26PM -0700, Tony Dinh wrote:
> On Fri, Jun 7, 2024 at 6:45 AM Phil Sutter wrote:
> > On Thu, Jun 06, 2024 at 04:44:36PM -0700, Tony Dinh wrote:
> > > - Switch to standard boot (in include/configs/ds414.h and
> > > configs/ds414_d
Hi Tony,
On Thu, Jun 06, 2024 at 04:44:36PM -0700, Tony Dinh wrote:
> - Switch to standard boot (in include/configs/ds414.h and
> configs/ds414_defconfig)
> - Implement board_late_init() to ensure successful enumeration
> of USB3 devices
Oh, this makes the rear USB3 ports usable? I had failed to
On Tue, Aug 09, 2022 at 01:21:51PM +0200, Pali Rohár wrote:
> On Tuesday 09 August 2022 13:16:41 Marek Vasut wrote:
> > On 8/9/22 12:58, Pali Rohár wrote:
> > > On Tuesday 09 August 2022 12:07:00 Philip Oberfichtner wrote:
> > > > This converts CONFIG_SYS_L2_PL310 to Kconfig.
> > > ...
> > > > diff
right bootargs/bootcmd to correctly boot legacy kernel out of
the (DS414) box. Getting the ramdisk location right is a bit tedious.
Cc: Walter Schweizer
Signed-off-by: Phil Sutter
--
Changes since v2:
- Drop PREBOOT entirely, 'usb init' is not needed.
Changes since v1:
- Avoid
With the recent fixes in pci_mvebu and xhci-pci drivers, the two rear
USB3 ports are finally usable and accessing them no longer hangs the
system.
Signed-off-by: Phil Sutter
---
Changes since v2:
- Leave PREBOOT alone, with recent kernels XHCI HCD works fine even if
not initialized.
- Adjust
On Sat, Mar 06, 2021 at 09:15:27AM +0100, Stefan Roese wrote:
> On 05.03.21 21:03, Phil Sutter wrote:
> > With the recent fixes in pci_mvebu and xhci-pci drivers, the two rear
> > USB3 ports are finally usable and accessing them no longer hangs the
> > system. Moreover, if Li
ithin assigned flash boundaries even if an oversized image was
fetched.
Signed-off-by: Phil Sutter
---
Changes since v1:
- Add a proper commit message.
---
include/configs/ds414.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/include/configs/ds414.h b/include/c
Define a misc_init_r() which calls "syno populate_env" if the
environment seems incomplete (or default), indicated by missing
"ethaddr" variable. With this in place, no random MAC address fallback
is needed anymore.
Signed-off-by: Phil Sutter
---
Changes since v1:
- Don&#
right bootargs/bootcmd to correctly boot legacy kernel out of
the (DS414) box. Getting the ramdisk location right is a bit tedious.
Cc: Walter Schweizer
Signed-off-by: Phil Sutter
--
Changes since v1:
- Avoid deprecated common.h header include.
- Remove 'sf probe' call from DS4
detected
[...]
| xhci_hcd :02:00.0: Error while assigning device slot ID
| xhci_hcd :02:00.0: Max number of devices this xHCI host supports is 64.
| usb usb2-port2: couldn't allocate usb_device
To avoid this problem, enumerate PCI (and USB) from PREBOOT.
Signed-off-by: Phil Sutter
-
On Thu, Mar 04, 2021 at 02:34:53PM +0100, Stefan Roese wrote:
> On 04.03.21 14:28, Phil Sutter wrote:
> > On Thu, Mar 04, 2021 at 02:09:34PM +0100, Stefan Roese wrote:
> >> On 03.03.21 01:55, Phil Sutter wrote:
> >>> Signed-off-by: Phil Sutter
> >>
> &
On Thu, Mar 04, 2021 at 02:09:34PM +0100, Stefan Roese wrote:
> On 03.03.21 01:55, Phil Sutter wrote:
> > Signed-off-by: Phil Sutter
>
> It's common practice to add some minimal text in the commit text,
> even for simple patches.
I should learn to put less meaningful sub
On Thu, Mar 04, 2021 at 02:06:01PM +0100, Stefan Roese wrote:
> On 03.03.21 01:55, Phil Sutter wrote:
> > Define a misc_init_r() which calls "syno populate_env" if the
> > environment seems incomplete (or default), indicated by missing
> > "ethaddr" va
On Thu, Mar 04, 2021 at 02:03:58PM +0100, Stefan Roese wrote:
> On 03.03.21 01:55, Phil Sutter wrote:
> > Move the relevant bits from ds109.{c,h} into common/ and adjust the code
> > to fit both DS109 and DS414. Moreover:
> >
> > * Introduce syno_board_id() which trans
On Thu, Mar 04, 2021 at 02:00:50PM +0100, Stefan Roese wrote:
> On 03.03.21 01:55, Phil Sutter wrote:
> > With the recent fixes in pci_mvebu and xhci-pci drivers, the two rear
> > USB3 ports are finally usable and accessing them no longer hangs the
> > system.
> >
>
Just a bit more info to the reader.
Signed-off-by: Phil Sutter
---
drivers/pci/pci_auto.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/pci_auto.c b/drivers/pci/pci_auto.c
index da76148c58398..05663c72b4b84 100644
--- a/drivers/pci/pci_auto.c
+++ b/drivers
Signed-off-by: Phil Sutter
---
include/configs/ds414.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/include/configs/ds414.h b/include/configs/ds414.h
index a2248cf75ad72..c8b45066cc75a 100644
--- a/include/configs/ds414.h
+++ b/include/configs/ds414.h
@@ -88,7 +88,12
right bootargs/bootcmd to correctly boot legacy kernel out of
the (DS414) box. Getting the ramdisk location right is a bit tedious.
Cc: Walter Schweizer
Signed-off-by: Phil Sutter
---
board/Synology/common/Makefile | 5 +++
board/Synology/common/legacy.c | 75
A rather cosmetic change to conform with other board definitions.
Signed-off-by: Phil Sutter
---
board/Synology/ds414/Kconfig | 12
1 file changed, 12 insertions(+)
create mode 100644 board/Synology/ds414/Kconfig
diff --git a/board/Synology/ds414/Kconfig b/board/Synology/ds414
Define a misc_init_r() which calls "syno populate_env" if the
environment seems incomplete (or default), indicated by missing
"ethaddr" variable. With this in place, no random MAC address fallback
is needed anymore.
Signed-off-by: Phil Sutter
---
board/Synology/ds414/cmd_s
m MAC address fallback anymore.
Patch 6 extends the default environment by a command to update u-boot
via tftp.
Phil Sutter (5):
ds414: Add a Kconfig defining some strings
configs: ds414: Enable XHCI_PCI by default
board/Synology: Unify legacy kernel support
ds414: Auto-populate e
With the recent fixes in pci_mvebu and xhci-pci drivers, the two rear
USB3 ports are finally usable and accessing them no longer hangs the
system.
Signed-off-by: Phil Sutter
---
configs/ds414_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/ds414_defconfig b/configs
Configure an IO region and window for PNP identical to how MEM region is
set up. Linux does this only if the DT defines a pcie-io-aperture
property for the SOC, but since all supported boards do this should not
be needed.
Signed-off-by: Phil Sutter
---
drivers/pci/pci_mvebu.c | 28
. 0xffff or 0xfff4 and thus manage to break
size calculation due to the "middle" zeroes. Mitigate that copying more
or less what Linux does and do a "find least bit set".
Signed-off-by: Phil Sutter
---
drivers/pci/pci_auto.c | 9 +
1 file changed, 5 insertions(+),
;t
find out why.
This series collects the brighter bits: Apart from a rather unrelated
review of include/configs/ds414.h in patch one, patches two and three at
least fix for the error messages emitted by 'pci enum' trying to PNP
devices.
Phil Sutter (3):
arm: mvebu: ds414: Config header min
meout was often too
short.
Signed-off-by: Phil Sutter
---
include/configs/ds414.h | 21 +++--
1 file changed, 3 insertions(+), 18 deletions(-)
diff --git a/include/configs/ds414.h b/include/configs/ds414.h
index a92e788a38b9e..8aa2d47bec68d 100644
--- a/include/configs/ds414.
On Thu, Mar 24, 2016 at 10:13:35AM +0100, Stefan Roese wrote:
> On 04.01.2016 12:25, Marek Vasut wrote:
> > On Monday, January 04, 2016 at 04:02:26 AM, Phil Sutter wrote:
> >> Hi,
> >>
> >> On Mon, Jan 04, 2016 at 12:47:37AM +0100, Marek Vasut wrote:
> >
Hi Stefan,
On Wed, Jan 13, 2016 at 09:17:54AM +0100, Stefan Roese wrote:
> I'm preparing a branch for Luka to pull from. With all the pending
> mvebu patches included. And noticed a small issue with this patch.
> See below...
>
> On 25.12.2015 14:41, Phil Sutter wrote:
[
On Sat, Jan 09, 2016 at 02:03:31PM +0100, Phil Sutter wrote:
> This was my first shot and I hit: changing the dependency from
> u-boot-dtb.img to u-boot-dtb.bin, U-Boot runs.
>
> Let me know if I can help track the issue down.
Ah, nevermind. Stupid me forgot to change BOOT_FROM
Hi,
On Sat, Jan 09, 2016 at 10:07:44AM +0100, Stefan Roese wrote:
> This patch adds runtime detection of the Marvell UART boot-mode (xmodem
> protocol). If this boot-mode is detected, SPL will return to the
> BootROM to continue the UART booting.
>
> With this patch its now possible, to generate
Hi,
On Mon, Jan 04, 2016 at 12:47:37AM +0100, Marek Vasut wrote:
> On Monday, January 04, 2016 at 12:38:07 AM, Phil Sutter wrote:
> > The bit which really was missing is the USB mode setting I smuggled in
> > along with my patch - setting the devices to host mode is sufficient f
Hi,
On Sun, Jan 03, 2016 at 09:59:23AM +0100, Wolfgang Denk wrote:
> [added USB custodian to Cc:]
>
> In message <20160102211834.e49a161...@mail.nwl.cc> you wrote:
> > In order to allow for Linux properly register the integrated EHCI host,
> > we have to reset it after initialization. Without thi
In order to allow for Linux properly register the integrated EHCI host,
we have to reset it after initialization. Without this, enumeration
fails if 'usb start' wasn't issued prior to booting Linux.
Signed-off-by: Phil Sutter
---
arch/arm/mach-mvebu/cpu.c | 12
1 f
way this is implemented here is not exactly beautiful, but it mimics
how Marvell's BSP does it. Alternatively we could get the information
using board_serdes_cfg_get(), but that won't lead to clean code, either.
Signed-off-by: Phil Sutter
---
arch/arm/mach-mvebu/include/mach/soc.h | 2 +
If MV_DEBUG_WL is defined, DEBUG_WL_S and DEBUG_WL_D macros are missing.
In addition to that, get rid of debug output printing non-existent
counter variable.
Signed-off-by: Phil Sutter
---
drivers/ddr/marvell/axp/ddr3_write_leveling.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
Instead of calling board_sat_r_get() only for those boards providing the
satr11 value via I2C, call it for all boards and return static values
for those not using I2C.
In addition to that, make this a weak function to allow for board code
to override it.
Signed-off-by: Phil Sutter
---
.../arm
The debug printing references bar_res, which exists only if
CONFIG_PCI_ENUM_ONLY is not defined. Therefore move it into the ifdef'd
area.
Signed-off-by: Phil Sutter
---
drivers/pci/pci_auto_old.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pci_auto_ol
also rd.gz into memory. This way it is
possible to use about 7MB for kernel with piggyback initramfs.
Signed-off-by: Phil Sutter
---
arch/arm/dts/Makefile | 3 +-
arch/arm/dts/armada-xp-synology-ds414.dts | 337
arch/arm/mach-mvebu/Kconfig
right file headers.
* Removed commented code.
* Add board-specific board_sat_r_get() function.
* Statically enable CONFIG_DM_USB.
* Dropped unused CONFIG_SYS_MVEBU_DDR_AXP and CONFIG_SYNOLOGY_DS414
defines.
* Moved syno command set into board/Synology directory.
Phil Sutter (10):
drivers/pci:
y, therefore
implemented 'syno populate_env' command which extracts the three values
and puts them into environment. To make things permanent though, one has
to 'saveenv'.
Another command is 'syno clk_gate', which allows to change the clock
gating which is done in DS414
This should make it clear that this symbol is meant to be defined by
board headers.
Signed-off-by: Phil Sutter
---
drivers/ddr/marvell/axp/ddr3_axp_config.h| 2 +-
drivers/ddr/marvell/axp/ddr3_axp_mc_static.h | 20 ++--
2 files changed, 11 insertions(+), 11 deletions
* There is no boards.cfg anymore, so drop (1).
* Creating flash.c and u-boot.lds seems not mandatory as well.
* Adjusting the enumerators for the above implicitly fixed for
double items numbered (3).
Signed-off-by: Phil Sutter
---
README | 11 ---
1 file changed, 4 insertions(+), 7
This patch adds intermediate kconfig symbols which select their SoC
family. Boards then select them instead of the family symbol directly.
Signed-off-by: Phil Sutter
---
arch/arm/mach-mvebu/Kconfig | 24
include/configs/clearfog.h | 1 -
include/configs/db
This adds basic support for Marvell's MV78230 SoC which belongs to the
Armada XP series.
Signed-off-by: Phil Sutter
---
arch/arm/mach-mvebu/cpu.c | 16 +++-
arch/arm/mach-mvebu/include/mach/soc.h | 1 +
arch/arm/mach-mvebu/serde
Hi Stefan,
On Wed, Dec 23, 2015 at 08:56:39AM +0100, Stefan Roese wrote:
> >>> diff --git a/arch/arm/mach-mvebu/serdes/axp/board_env_spec.h
> >>> b/arch/arm/mach-mvebu/serdes/axp/board_env_spec.h
> >>> index f00f327..3dca6a1 100644
> >>> --- a/arch/arm/mach-mvebu/serdes/axp/board_env_spec.h
> >>>
Hi,
On Tue, Dec 22, 2015 at 10:05:03AM +0100, Stefan Roese wrote:
> I've consolidated a bit of the Armada XP / 38x defines and
> Kconfig options just very recently. Please take a look at
> these two patches from yesterday:
>
> http://patchwork.ozlabs.org/patch/559579/
> http://patchwork.ozlabs.or
Hi Stefan,
On Tue, Dec 22, 2015 at 09:02:44AM +0100, Stefan Roese wrote:
> On 22.12.2015 00:25, Phil Sutter wrote:
> > This mimics the relevant code in mach-kirkwood headers. The
> > *_winctrl_calcsize functions are identical, as well as the MVCPU_WIN_*
> > macros. Implem
way this is implemented here is not exactly beautiful, but it mimics
how Marvell's BSP does it. Alternatively we could get the information
using board_serdes_cfg_get(), but that won't lead to clean code, either.
Especially since the ugly includes will have to be done anyway.
Signed-of
for MV78230 SoC and a board specific part for clarity.
* Patch 8 adds a new command to deal with Synology specialties.
In case you would like me to split this into multiple series, just let me
know and I will resend.
Phil Sutter (8):
drivers/pci: Fix for debug builds without
The debug printing references bar_res, which exists only if
CONFIG_PCI_ENUM_ONLY is not defined. Therefore move it into the ifdef'd
area.
Signed-off-by: Phil Sutter
---
drivers/pci/pci_auto_old.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pci_auto_ol
also rd.gz into memory. This way it is
possible to use about 7MB for kernel with piggyback initramfs.
Signed-off-by: Phil Sutter
---
arch/arm/Kconfig | 1 +
arch/arm/dts/Makefile | 2 +
arch/arm/dts/armada-xp-syno
If MV_DEBUG_WL is defined, DEBUG_WL_S and DEBUG_WL_D macros are missing.
In addition to that, get rid of debug output printing non-existent
counter variable.
Signed-off-by: Phil Sutter
---
drivers/ddr/marvell/axp/ddr3_write_leveling.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
* There is no boards.cfg anymore, so drop (1).
* Creating flash.c and u-boot.lds seems not mandatory as well.
* Adjusting the enumerators for the above implicitly fixed for
double items numbered (3).
Signed-off-by: Phil Sutter
---
README | 11 ---
1 file changed, 4 insertions(+), 7
y, therefore
implemented 'syno populate_env' command which extracts the three values
and puts them into environment. To make things permanent though, one has
to 'saveenv'.
Another command is 'syno clk_gate', which allows to change the clock
gating which is done in DS414 b
: Phil Sutter
---
arch/arm/mach-mvebu/cpu.c | 21 +
arch/arm/mach-mvebu/include/mach/cpu.h | 3 +++
arch/arm/mach-mvebu/include/mach/soc.h | 9 -
3 files changed, 32 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-mvebu/cpu.c b/arch/arm/mach-mvebu
Signed-off-by: Phil Sutter
---
arch/arm/mach-mvebu/cpu.c | 16 +++-
arch/arm/mach-mvebu/include/mach/soc.h | 1 +
arch/arm/mach-mvebu/serdes/axp/high_speed_env_lib.c | 6 +-
3 files changed, 17 insertions(+), 6 deletions(-)
diff --git a
Hi Stefan,
On Mon, Dec 14, 2015 at 01:06:07PM +0100, Stefan Roese wrote:
> Okay. I've sent the new patches to the list. And also added a branch
> to the "u-boot-a38x.git" gitlab repository. You can find a full
> working version in this branch now "mvebu-dm-spl-2015-12-14":
>
> https://gitlab.denx
Hi Stefan,
On Mon, Dec 14, 2015 at 08:38:06AM +0100, Stefan Roese wrote:
> On 13.12.2015 01:29, Phil Sutter wrote:
> > This patch series ultimately adds support for Synology DS414 NAS after a
> > few fixes:
> > * Patches 1-3 and 5 fix various files for enabled debugging.
>
:
pex_max_unit_get returns 2, pex_max_if_get returns 7 and
max_serdes_lines is set to 7. Not changing this seems to not have an
impact, although I'm not entirely sure it does not cause issues I am not
aware of.
Signed-off-by: Phil Sutter
---
arch/arm/Kconfig |
y, therefore
implemented 'syno populate_env' command which extracts the three values
and puts them into environment. To make things permanent though, one has
to 'saveenv'.
Another command is 'syno clk_gate', which allows to change the clock
gating which is done in DS414 b
Signed-off-by: Phil Sutter
---
arch/arm/mach-mvebu/cpu.c | 5 -
arch/arm/mach-mvebu/include/mach/soc.h | 1 +
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-mvebu/cpu.c b/arch/arm/mach-mvebu/cpu.c
index d3b9789..b485be7 100644
--- a/arch/arm/mach
The debug printing tries to reference slave->bus and slave->cs which
don't exist when CONFIG_DM_SPI is defined.
Signed-off-by: Phil Sutter
---
drivers/spi/kirkwood_spi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c
in
The debug printing references bar_res, which exists only if
CONFIG_PCI_ENUM_ONLY is not defined. Therefore move it into the ifdef'd
area.
Signed-off-by: Phil Sutter
---
drivers/pci/pci_auto_old.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pci_auto_ol
* There is no boards.cfg anymore, so drop (1).
* Creating flash.c and u-boot.lds seems not mandatory as well.
* Adjusting the enumerators for the above implicitly fixed for
double items numbered (3).
Signed-off-by: Phil Sutter
---
README | 11 ---
1 file changed, 4 insertions(+), 7
actual board support, split into a generic
part for MV78230 SoC and a board specific part for clarity.
* Patch 11 adds a new command to deal with Synology specialties.
In case you would like me to split this into multiple series, just let me
know and I will resend.
Phil Sutter (11):
drivers/pci
way this is implemented here is not exactly beautiful, but it mimics
how Marvell's BSP does it. Alternatively we could get the information
using board_serdes_cfg_get(), but that won't lead to clean code, either.
Especially since the ugly includes will have to be done anyway.
Signed-of
Signed-off-by: Phil Sutter
---
arch/arm/mach-mvebu/serdes/axp/high_speed_env_lib.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-mvebu/serdes/axp/high_speed_env_lib.c
b/arch/arm/mach-mvebu/serdes/axp/high_speed_env_lib.c
index 702273a..6c7738c 100644
--- a
: Phil Sutter
---
arch/arm/mach-mvebu/cpu.c | 21 +
arch/arm/mach-mvebu/include/mach/cpu.h | 3 +++
arch/arm/mach-mvebu/include/mach/soc.h | 9 -
3 files changed, 32 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-mvebu/cpu.c b/arch/arm/mach-mvebu
If MV_DEBUG_WL is defined, DEBUG_WL_S and DEBUG_WL_D macros are missing.
In addition to that, get rid of debug output printing non-existent
counter variable.
Signed-off-by: Phil Sutter
---
drivers/ddr/marvell/axp/ddr3_write_leveling.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
Not all boards implementing an Armada XP chip are equipped with ECC RAM.
Defining DRAM_ECC to 1 enables ECC without a chance to turn it off in
board configs, which breaks DDR training for them.
Signed-off-by: Phil Sutter
---
drivers/ddr/marvell/axp/ddr3_axp_config.h | 2 +-
1 file changed, 1
Scott,
On Wed, Nov 13, 2013 at 07:31:02PM -0600, Scott Wood wrote:
> On Mon, Aug 26, 2013 at 02:10:56PM +0200, Phil Sutter wrote:
> > From: Nico Erfurth
> >
> > The basic idea is taken from the linux-kernel, but further optimized.
> >
> > First align the buff
On Mon, Aug 26, 2013 at 06:00:39PM +0200, Phil Sutter wrote:
> On Mon, Aug 26, 2013 at 10:43:38AM -0500, Scott Wood wrote:
> > On Mon, 2013-08-26 at 14:10 +0200, Phil Sutter wrote:
> > > From: Nico Erfurth
> > >
> > > The basic idea is taken from the
On Mon, Aug 26, 2013 at 10:43:38AM -0500, Scott Wood wrote:
> On Mon, 2013-08-26 at 14:10 +0200, Phil Sutter wrote:
> > From: Nico Erfurth
> >
> > The basic idea is taken from the linux-kernel, but further optimized.
> >
> > First align the buffer to 8 byte
this patch, NAND read of 132MB took 49s (~2.69MB/s). With this
patch in place, reading the same amount of data was done in 27s
(~4.89MB/s). So read performance is increased by ~80%!
Signed-off-by: Nico Erfurth
Tested-by: Phil Sutter
Cc: Prafulla Wadaskar
---
Changed since V3:
- fixed author
---
d
well.
Signed-off-by: Phil Sutter
---
Changes since V1:
- Print status message for each of the redundant copies when writing, so
the error message for any first failed attempt does not confuse that
much.
Changes since V2:
- Checkpatch-compliance:
- do not typedef struct env_location
- avoid
Hi,
On Wed, Jul 17, 2013 at 05:25:31PM -0500, Scott Wood wrote:
> On 06/26/2013 01:25:26 PM, Phil Sutter wrote:
> > Without this patch, when the currently chosen environment to be
> > written
> > has bad blocks, saveenv fails completely. Instead, when there is
> >
On Fri, Jul 19, 2013 at 12:20:26PM +0200, Phil Sutter wrote:
Subject: [U-Boot] [PATCH] env_nand.c: support falling back to redundant
~
Heck, PATCHv4 that is.
--
Viprinet Europe GmbH
Mainzer Str. 43
55411 Bingen am Rhein
Germany
Phone/Zentrale: +49 6721
well.
Signed-off-by: Phil Sutter
---
common/env_nand.c | 105 --
1 file changed, 46 insertions(+), 59 deletions(-)
diff --git a/common/env_nand.c b/common/env_nand.c
index b745822..06af5ce 100644
--- a/common/env_nand.c
+++ b/common/env_nand.c
Respin of the remaining two of my patch series for review. First patch
is identical but removed the versioning from the title as suggested.
Second patch cleaned up so checkpatch.pl does not complain anymore.
Kudos to Scott for pointing out the warnings and his further comments.
Greetings, Phil
_
d of 132MB took 49s (~2.69MB/s). With this
patch in place, reading the same amount of data was done in 27s
(~4.89MB/s). So read performance is increased by ~80%!
Signed-off-by: Nico Erfurth
Tested-by: Phil Sutter
Cc: Prafulla Wadaskar
---
drivers/mtd/nand/kirkwood_n
Scott,
On Fri, Feb 22, 2013 at 07:59:41PM -0600, Scott Wood wrote:
> On Thu, Feb 21, 2013 at 06:21:55PM +0100, Phil Sutter wrote:
> > The single message is misleading, since there is no equivalent success
> > note when reading the other copy succeeds. Instead, warn if one of th
d of 132MB took 49s (~2.69MB/s). With this
patch in place, reading the same amount of data was done in 27s
(~4.89MB/s). So read performance is increased by ~80%!
Signed-off-by: Nico Erfurth
Tested-by: Phil Sutter
Cc: Prafulla Wadaskar
---
drivers/mtd/nand/kirkwood_nan
Respin of my patch series for review. Only changes in patches 2 and 3:
env_nand.c: support falling back to redundant env when writing:
Print status message for each of the redundant copies when writing. So
when writing, we see which image is being written to. Also, when the first
attempt fai
Calculating the checksum of incompletely read data is useless.
Signed-off-by: Phil Sutter
---
common/env_nand.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/env_nand.c b/common/env_nand.c
index 60a87ec..0e1d17a 100644
--- a/common/env_nand.c
+++ b/common
well.
Signed-off-by: Phil Sutter
---
common/env_nand.c | 103 ++--
1 files changed, 44 insertions(+), 59 deletions(-)
diff --git a/common/env_nand.c b/common/env_nand.c
index 22e72a2..c0c985c 100644
--- a/common/env_nand.c
+++ b/common/env_nand.c
The single message is misleading, since there is no equivalent success
note when reading the other copy succeeds. Instead, warn if one of the
redundant copies could not be loaded and emphasise on the error when
reading both fails.
Signed-off-by: Phil Sutter
---
common/env_nand.c | 12
On Thu, Dec 20, 2012 at 03:41:37PM -0600, Scott Wood wrote:
> On 12/20/2012 03:28:39 PM, Phil Sutter wrote:
> > On Tue, Dec 11, 2012 at 05:12:32PM -0600, Scott Wood wrote:
> > > Erase blocks are larger than write pages, yes. I've never heard
> > erase
> > >
On Tue, Dec 11, 2012 at 05:12:32PM -0600, Scott Wood wrote:
> On 12/10/2012 07:41:43 AM, Phil Sutter wrote:
> > On Fri, Dec 07, 2012 at 11:38:11AM -0600, Scott Wood wrote:
> > > On 12/07/2012 10:58:53 AM, Phil Sutter wrote:
> > > > Hmm. Does not look like CONFIG_EN
Hi Prafulla,
On Wed, Dec 19, 2012 at 10:44:01PM -0800, Prafulla Wadaskar wrote:
> For your next post of this patch, please do not forget to add version info
> and changlog to the patch.
Ah yes, indeed! Thanks a lot for the hint and sorry for the confusion
caused.
Best wishes, Phil
--
Viprinet
On Fri, Dec 07, 2012 at 11:38:11AM -0600, Scott Wood wrote:
> On 12/07/2012 10:58:53 AM, Phil Sutter wrote:
> > Scott,
> >
> > On Fri, Dec 07, 2012 at 12:53:34PM +0100, Phil Sutter wrote:
> > > On Thu, Dec 06, 2012 at 12:18:39PM -0600, Scott Wood wrote:
> >
Scott,
On Fri, Dec 07, 2012 at 12:53:34PM +0100, Phil Sutter wrote:
> On Thu, Dec 06, 2012 at 12:18:39PM -0600, Scott Wood wrote:
> > On 11/28/2012 03:06:00 PM, Phil Sutter wrote:
> > > Hi,
> > >
> > > On Tue, Nov 27, 2012 at 04:04:15PM -0600, Scott Wood wrot
Scott,
On Thu, Dec 06, 2012 at 12:18:39PM -0600, Scott Wood wrote:
> On 11/28/2012 03:06:00 PM, Phil Sutter wrote:
> > Hi,
> >
> > On Tue, Nov 27, 2012 at 04:04:15PM -0600, Scott Wood wrote:
> > > On 11/21/2012 06:59:19 AM, Phil Sutter wrote:
> > > > Wit
Hi,
On Tue, Nov 27, 2012 at 04:04:15PM -0600, Scott Wood wrote:
> On 11/21/2012 06:59:19 AM, Phil Sutter wrote:
> > Without this patch, when the currently chosen environment to be
> > written
> > has bad blocks, saveenv fails completely. Instead, when there is
> >
d of 132MB took 49s (~2.69MB/s). With this
patch in place, reading the same amount of data was done in 27s
(~4.89MB/s). So read performance is increased by ~80%!
Signed-off-by: Nico Erfurth
Tested-by: Phil Sutter
Cc: Prafulla Wadaskar
---
drivers/mtd/nand/kirkwood_nan
e tested-by line. I just caught up on this,
please see the patch I send in reply to this mail.
Best wishes,
Phil Sutter
Software Engineer
--
Viprinet Europe GmbH
Mainzer Str. 43
55411 Bingen am Rhein
Germany
Phone/Zentrale: +49 6721 49030-0
Direct line/Durchwahl:+49 67
1 - 100 of 104 matches
Mail list logo
