Re: [PATCH v8 1/5] efi: add EFI_SYSTEM_TABLE_POINTER for debug

2025-07-04 Thread Paul Liu
Hi Heinrich, Ilias, Sorry for the late reply. I'm a bit worried about this change. This structure (efi_system_table_pointer), is not packed. So its actual size is a bit larger. The crc32 field is not at the end of the structure. Actually there are 4 bytes padding after it. But the CRC32 function i

Re: [PATCH v6 2/4] efi: add EFI_DEBUG_IMAGE_INFO_TABLE for debug

2025-06-18 Thread Paul Liu
On Wed, 18 Jun 2025 at 07:39, Heinrich Schuchardt wrote: > On 6/17/25 14:08, Ying-Chun Liu (PaulLiu) wrote: > > From: "Ying-Chun Liu (PaulLiu)" > > > > EFI_DEBUG_IMAGE_INFO_TABLE is used to store EFI_LOADED_IMAGE for > > debug purpose. This commit adds the table to the EFI_CONFIGURATION_TABLE. >

Re: [PATCH v3 1/4] efi: add EFI_SYSTEM_TABLE_POINTER for debug

2025-05-27 Thread Paul Liu
Hi Ilias, On Mon, 26 May 2025 at 15:01, Ilias Apalodimas wrote: > Hi Paul, > > [...] > > > > bool > > > > +config EFI_DEBUG_SUPPORT_TABLE > > + bool "EFI Debug Support Table" > > + help > > + Select this option if you want to setup the EFI Debug Support > > +

Re: [PATCH v3 3/4] lib: efi_loader: efi_memory.c: add efi_realloc() for realloc memory

2025-05-27 Thread Paul Liu
On Fri, 23 May 2025 at 14:44, Simon Glass wrote: > Hi, > > On Thu, 22 May 2025 at 03:18, Ying-Chun Liu (PaulLiu) > wrote: > > > > From: "Ying-Chun Liu (PaulLiu)" > > > > Add efi_realloc() for realloc memory that previously alloc by > efi_alloc(). > > > > Signed-off-by: Ying-Chun Liu (PaulLiu)

Re: [PATCH v3 3/4] lib: efi_loader: efi_memory.c: add efi_realloc() for realloc memory

2025-05-23 Thread Paul Liu
Hi Simon, On Fri, 23 May 2025 at 14:44, Simon Glass wrote: > Hi, > > On Thu, 22 May 2025 at 03:18, Ying-Chun Liu (PaulLiu) > wrote: > > > > From: "Ying-Chun Liu (PaulLiu)" > > > > Add efi_realloc() for realloc memory that previously alloc by > efi_alloc(). > > > > Signed-off-by: Ying-Chun Li

Re: [PATCH 3/3] efi: add EFI_DEBUG_IMAGE_INFO for debug

2025-04-28 Thread Paul Liu
Hi Heinrich, Yes. I just copied the code from EDK2. Seems this is incorrect. I'll try to ask some help from EDK2 people. Actually I'm working on Android (AOSP)'s GBL project. It is an EFI application, used as a bootloader for loading and booting Android images. So some people are asking how to deb

Re: [PATCH v2 2/3] efi: add EFI_DEBUG_IMAGE_INFO_TABLE for debug

2025-04-25 Thread Paul Liu
On Fri, 25 Apr 2025 at 21:31, Heinrich Schuchardt wrote: > On 4/25/25 21:05, Paul Liu wrote: > > > > > > On Thu, 24 Apr 2025 at 23:02, Heinrich Schuchardt > <mailto:xypron.g...@gmx.de>> wrote: > > > > On 24.04.25 22:19, Ying-Chun Liu (PaulLiu) wr

Re: [PATCH v2 1/3] efi: add EFI_SYSTEM_TABLE_POINTER for debug

2025-04-25 Thread Paul Liu
Hi Heinrich, Thanks for the review. On Thu, 24 Apr 2025 at 22:46, Heinrich Schuchardt wrote: > On 24.04.25 22:19, Ying-Chun Liu (PaulLiu) wrote: > > From: "Ying-Chun Liu (PaulLiu)" > > > > Add EFI_SYSTEM_TABLE_POINTER structure for debugger to locate > > the address of EFI_SYSTEM_TABLE. > > >

Re: [PATCH v2 3/3] efi: add EFI_DEBUG_IMAGE_INFO for debug

2025-04-25 Thread Paul Liu
Hi Heinrich, Thanks for the review. All of the issues in this commit will be fixed in the next version. Thanks a lot. Yours, Paul On Thu, 24 Apr 2025 at 23:34, Heinrich Schuchardt wrote: > On 24.04.25 22:19, Ying-Chun Liu (PaulLiu) wrote: > > From: "Ying-Chun Liu (PaulLiu)" > > > > This com

Re: [PATCH v2 2/3] efi: add EFI_DEBUG_IMAGE_INFO_TABLE for debug

2025-04-25 Thread Paul Liu
On Thu, 24 Apr 2025 at 23:02, Heinrich Schuchardt wrote: > On 24.04.25 22:19, Ying-Chun Liu (PaulLiu) wrote: > > From: "Ying-Chun Liu (PaulLiu)" > > > > EFI_DEBUG_IMAGE_INFO_TABLE is used to store EFI_LOADED_IMAGE for > > debug purpose. This commit adds the table to the EFI_CONFIGURATION_TABLE.

Re: inconsistent wget behavior

2024-02-11 Thread Paul Liu
Hi Fabio, I'm on vacation now (Chinese new year). I hope I'll find some time to revive my imx8 board. I've tried sandbox and qemu. Both of them are not reproducible. I'm wondering if it could be some packet loss that causes the issue. Because sandbox and qemu there won't be any missing packets bec

Re: inconsistent wget behavior

2024-01-05 Thread Paul Liu
, Fabio Estevam wrote: > Hi Paul, > > On Thu, Nov 16, 2023 at 6:41 AM Paul Liu wrote: > > > > Hi Fabio, > > > > Yes. I'll look into this problem. > > Did you have a chance to investigate this problem? > > Thanks >

Re: inconsistent wget behavior

2023-11-16 Thread Paul Liu
Hi Fabio, Yes. I'll look into this problem. Yours, Paul On Thu, 16 Nov 2023 at 08:34, Fabio Estevam wrote: > Hi Paul, > > On Wed, Nov 8, 2023 at 10:24 PM Fabio Estevam wrote: > > > I was not able to see a failure when using "tftp" to transfer the same > > 420MB file. > > > > The number of by

Re: [PATCH 1/1] lib/vsprintf.c: fix integer overflow in vsprintf

2023-08-15 Thread Paul Liu
Hi Tom, Yes, I think Rasmus is correct. I didn't have any real cases that can trigger the bug. So let's don't include this patch. I'll see if I can revert this in AOSP's branch. Yours, Paul Y On Tue, 15 Aug 2023 at 22:42, Tom Rini wrote: > On Thu, Mar 09, 2023 at 10:12:21AM +0800, Ying-Chun

Re: [PATCH 5/6] net: add fastboot TCP documentation and IP6-only mode

2023-07-03 Thread Paul Liu
Reviewed-by: Ying-Chun Liu (PaulLiu) On Tue, 9 May 2023 at 01:16, Dmitrii Merkurev wrote: > Command to start IP6 only TCP fastboot: > fastboot tcp -ipv6 > > Signed-off-by: Dmitrii Merkurev > Cc: Ying-Chun Liu (PaulLiu) > Cc: Simon Glass > Сс: Joe Hershberger > Сс: Ramon Fried > --- > cmd/

Re: [PATCH v2 4/6] net: add fastboot TCP6 support

2023-07-03 Thread Paul Liu
Reviewed-by: Ying-Chun Liu (PaulLiu) On Thu, 11 May 2023 at 01:00, Dmitrii Merkurev wrote: > fastboot tcp command remains the same, but started > listening IP6 in case it's enabled. > > Signed-off-by: Dmitrii Merkurev > Cc: Ying-Chun Liu (PaulLiu) > Cc: Simon Glass > Сс: Joe Hershberger >

Re: [PATCH 1/6] net: split IP_TCP header into separate IP/IP6 and TCP headers

2023-05-08 Thread Paul Liu
Hi Dmitrii, It seems to me that this series of patches breaks the unittest of TCP stack in sandbox. I'll see if I have some time to fix the unittest too. The unittest can be built by the following commands. 1. "make sandbox64_defconfig" 2. turn on the options that need to be tested. For exampl

Re: [PATCH 1/3] net: support being a TCP server to unblock TCP fastboot

2023-03-29 Thread Paul Liu
On Wed, 29 Mar 2023 at 04:31, Dmitrii Merkurev wrote: > Make following changes to unblock TCP fastboot support: > > 1. Implement being a TCP server support > 2. Introduce dedicated TCP traffic handler (get rid of UDP signature) > 3. Ensure seq_num and ack_num are respected in net_send_tcp_packet

Re: [PATCH 4/6] compulab: imx8mm-cl-iot-gate: Fix some function declarations in eeprom_spl.c

2023-03-09 Thread Paul Liu
Hi Tom, Maybe we should fix the header by changing it to u8? Because the eeprom only returns one byte for the DDRSUBIND value. Yours, Paul On Fri, 10 Mar 2023 at 00:22, Tom Rini wrote: > We have a few places here we the function declarations do not match > their prototypes in another header,

Re: [PATCH 1/2] arm: cpu: Add optional CMOs by VA

2023-02-07 Thread Paul Liu
Hi Marc, I think you are the author. I'm just making some minor fixes and then upstreaming to the mailing list. What is the correct way to make the Signed-off-by list? Yours, Paul On Wed, 8 Feb 2023 at 00:35, Marc Zyngier wrote: > On 2023-02-07 16:20, Ying-Chun Liu (PaulLiu) wrote: > > Exposi

Re: [PATCH v14 0/2] add TCP and HTTP for downloading images

2022-05-18 Thread Paul Liu
Hi Michal, Thanks for reviewing. I'll make a fix based on your review soon. However I don't know the change from v1 to v12. The previous version are made by Duncan, and the patches are one year ago so I lost track of the changes from v1 to v12. For booting iso images (installer) from distros I t

Re: [PATCH] imx8m: fix reading of DDR4 MR registers

2022-04-26 Thread Paul Liu
Hi Fabio, I tested. It works. Tested-by: Ying-Chun Liu (PaulLiu) On Tue, 26 Apr 2022 at 20:59, Fabio Estevam wrote: > Hi Paul, > > On Mon, Apr 25, 2022 at 11:23 AM Rasmus Villemoes > wrote: > > > > I was trying to employ lpddr4_mr_read() to something similar to what > > the imx8mm-cl-iot-gat

Re: [PATCH 2/5] imx8mm-cl-iot-gate: Retrieve the DDR type from EEPROM

2022-03-21 Thread Paul Liu
Hi Tim, It seems to me the correct logic is. If EEPROM provides information, we use that information directly. Pick a dram setting and test the ram if it works. If it is not working, then that means EEPROM has wrong data or someone clean it wrongly. So we loop the table, try to find the correct se

Re: [RFC 1/2] drivers: mmc: write protect active boot area after mmc init.

2022-01-26 Thread Paul Liu
Hi Jaehoon, There are 2 boot partitions on eMMC. So the active one is write-protected. Users can write the new firmware to another boot partition (inactive) which is not write-protected. And then switch it on. In U-boot, execute "mmc wp" write-protect all of the boot partitions. Maybe we can add

Re: [PATCH v3] imx8mm-cl-iot-gate: Split the defconfigs

2021-08-24 Thread Paul Liu
On Tue, 24 Aug 2021 at 08:11, Fabio Estevam wrote: > Currently imx8mm-cl-iot-gate_defconfig fails to produce a working boot > binary due to the lack of fip.bin: > > " BINMAN all > Image 'main-section' is missing external blobs and is non-functional: > blob-ext > > Some images are invalid" > > T

Re: [PATCH v2] imx8mm-cl-iot-gate: Split the defconfigs

2021-08-23 Thread Paul Liu
Hi Fabio, Yes. This patch works for me after fixing the top address. I have another little comment on the name of bl31.bin as following. --- /dev/null +++ b/arch/arm/dts/imx8mm-cl-iot-gate-optee-u-boot.dtsi @@ -0,0 +1,255 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright 2019 NXP + */ +

Re: [PATCH 1/2] imx8mm-cl-iot-gate: Do not build fip.bin by default

2021-08-19 Thread Paul Liu
am_top(). Yours, Paul On Fri, 20 Aug 2021 at 04:51, Paul Liu wrote: > Hi Frieder, > > I'll confirm it. But I guess you are correct. I'll send a patch soon when > I implement this right. > > Yours, > Paul > > > On Thu, 19 Aug 2021 at 15:14, Frieder Schre

Re: [PATCH 1/2] imx8mm-cl-iot-gate: Do not build fip.bin by default

2021-08-19 Thread Paul Liu
, 2021 at 6:39 PM Fabio Estevam > wrote: > >> > >> Hi Paul, > >> > >> On Wed, Aug 18, 2021 at 6:32 PM Paul Liu wrote: > >>> > >>> Hi Fabio, > >>> > >>> I got several boards. With all different PN. But all of t

Re: [PATCH 1/2] imx8mm-cl-iot-gate: Do not build fip.bin by default

2021-08-18 Thread Paul Liu
e what happened on my side. Yours, Paul On Wed, 18 Aug 2021 at 20:24, Fabio Estevam wrote: > Hi Paul, > > On Tue, Aug 17, 2021 at 9:09 PM Paul Liu wrote: > > > > Hi Fabio, > > > > Can I know your Compulab's hardware PN? > > Something like "I

Re: [PATCH 1/2] imx8mm-cl-iot-gate: Do not build fip.bin by default

2021-08-17 Thread Paul Liu
Hi Fabio, Can I know your Compulab's hardware PN? Something like "IOTG-IMX8-D2-NA16-WB-FATPM". Yours, Paul On Wed, 18 Aug 2021 at 02:32, Fabio Estevam wrote: > Hi Paul, > > On Mon, Aug 16, 2021 at 9:50 PM Paul Liu wrote: > > > > Hi Fabio, > > &g

Re: [PATCH 1/2] imx8mm-cl-iot-gate: Do not build fip.bin by default

2021-08-16 Thread Paul Liu
Hi Fabio, It looks good to me. Thanks a lot. BTW. mbedtls version might not always work. In my local directory the mbedtls commit is bd21b18a1faa08705ac6d9980794c181e645f53a. Which is a commit in the development branch. Based on Tom's correction I'll write more detailed steps. Yours, Paul On

Re: [PATCH 1/2] imx8mm-cl-iot-gate: Do not build fip.bin by default

2021-08-15 Thread Paul Liu
it shouldn't complain about missing images. Yours, Paul On Fri, 13 Aug 2021 at 20:15, Fabio Estevam wrote: > Hi Paul, > > On 13/08/2021 06:59, Paul Liu wrote: > > Hi Fabio, > > > > Can we think of a way to keep this fip.bin feature? This is part of > &g

Re: [PATCH 2/2] imx8mm-cl-iot-gate: Add documentation

2021-08-13 Thread Paul Liu
Hi Fabio, Did you use the boot partition? I mean, why don't we use "mmc partconf 0 0 1 0" So that we can flash u-boot to partition 1 and leave partition 0 for distro install. The following sequence should work. init setup 1. mmc dev 2 2. mmc partconf 0 0 1 0 flash u-boot 1. tftp ${loadaddr} fl

Re: [PATCH 1/2] imx8mm-cl-iot-gate: Do not build fip.bin by default

2021-08-13 Thread Paul Liu
Hi Fabio, Can we think of a way to keep this fip.bin feature? This is part of the SystemReady IR certificate for this Compulab board. [1] [1] https://developer.arm.com/architectures/system-architectures/arm-systemready/ir Yours, Paul On Fri, 13 Aug 2021 at 08:59, Fabio Estevam wrote: > W

Re: Building U-Boot for Compulab's imx8mm-cl-iot-gate board

2021-08-10 Thread Paul Liu
> Hi Paul, > > Thanks for your response. > > On Thu, Jul 1, 2021 at 6:38 PM Paul Liu wrote: > > > > Hi Fabio, > > > > We have dfu_alt_info set. So that we can capsule update from UEFI. > > First, "setenv -e -nv -bs -rt -v OsIndications =0x04"

Re: Building U-Boot for Compulab's imx8mm-cl-iot-gate board

2021-07-01 Thread Paul Liu
t; "./tools/mkeficapsule --fit capsule1.itb --index 1 capsule1.bin" And we can tftp the capsule1.bin to ${loadaddr} and then use the capsule update. Yours, Paul On Fri, 2 Jul 2021 at 00:39, Fabio Estevam wrote: > Hi Paul, > > On Thu, Jul 1, 2021 at 12:45 PM Paul Liu wrote

Re: Building U-Boot for Compulab's imx8mm-cl-iot-gate board

2021-07-01 Thread Paul Liu
Hi Fabio, Yes. It is able to not provide the fip,bin. If you use bl31.bin as bl31.bin then fip.bin can be empty. If you use bl2.bin as bl31.bin then you have to have the fip. This depends on how TF-A are being built. If you build TF-A without NEED_BL2=yes. Then you don't need the fip.bin. If you

Re: [PATCH 1/2] power: regulator: add driver for ANATOP regulator

2021-03-08 Thread Paul Liu
Hi Jaehoon, Thanks for the review. On Mon, 8 Mar 2021 at 07:03, Jaehoon Chung wrote: > Dear Ying-Chun > > On 3/8/21 3:18 AM, Ying-Chun Liu wrote: > > From: "Ying-Chun Liu (PaulLiu)" > > > > Anatop is an integrated regulator inside i.MX6 SoC. > > There are 3 digital regulators which controls PU