Hi Kevin,
On 25/01/2023 23:50, Kevin Hilman wrote:
Niel Fourie writes:
Split out _usb_eth_start() from _usb_eth_init() and
usb_eth_stop() from _usb_eth_halt(). Now _usb_eth_init() only
initialises and registers the gadget device, which _usb_eth_halt()
reverses, and together are used for
list_head to break out
of these loops. No memory is leaked as the previous last element gets
reused.
This issue occurs when Netconsole is active over Ethernet gadget,
and the cause it is still unclear. Any ideas?
Signed-off-by: Niel Fourie
Cc: Marek Vasut
---
drivers/usb/dwc3/gadget.c | 16
Hi Marek
On 20/01/2023 19:42, Marek Vasut wrote:
On 1/20/23 18:15, Niel Fourie wrote:
[...]
Same question as in V1 below.
+static int _usb_eth_start(struct ether_priv *priv)
+{
+ unsigned long timeout = USB_CONNECT_TIMEOUT;
+ struct eth_dev *dev = &priv->ethdev;
+ unsigned
still crop up with other gadget drivers.
Best regards,
Niel Fourie
--
DENX Software Engineering GmbH,Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-21 Fax: +49-8142-66989-80 Email: lu...@denx.de
() functions connect
and disconnect the gadget as expected by the start()/stop()
callbacks.
Previously the gadget device was probed on every start() and
removed on every stop(), which is inconsistent with other DM_ETH
drivers.
Signed-off-by: Niel Fourie
Cc: Marek Vasut
Cc: Lukasz Majewski
Cc: Ramon Fried
Hi Marek,
On 12/12/2022 17:46, Marek Vasut wrote:
On 12/12/22 16:29, Niel Fourie wrote:
Split out _usb_eth_start() from _usb_eth_init() and
usb_eth_stop() from _usb_eth_halt(). Now _usb_eth_init() only
initialises and registers the gadget device, which _usb_eth_halt()
reverses, and together
: Niel Fourie
Cc: Marek Vasut
Cc: Lukasz Majewski
Cc: Ramon Fried
---
drivers/usb/gadget/ether.c | 58 +-
1 file changed, 45 insertions(+), 13 deletions(-)
diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c
index 43aec7ffa70..a75b4eeb5bb 100644
. Writing to
`priv` after stop() may corrupt the `fd` member of `struct
malloc_chunk`, which represents the freed block, and could cause
hard-to-debug crashes on subsequent calls to malloc()/free().
Signed-off-by: Niel Fourie
Cc: Ramon Fried
Cc: Marek Vasut
Cc: Lukasz Majewski
---
Changes for v2
Hi Marek,
On 05/12/2022 13:06, Niel Fourie wrote:
[...]
It does however show that this patch introduces a bug -- this patch
changes the order in which priv->state = ETH_STATE_PASSIVE; is
assigned from _after_ the ->stop callback to _before_ the -> stop
callback. This breaks dr
Hi Marek,
On 04/12/2022 03:17, Marek Vasut wrote:
On 12/2/22 11:36, Niel Fourie wrote:
Hi Marek,
Hi,
On 01/12/2022 11:44, Marek Vasut wrote:
On 12/1/22 09:24, Lukasz Majewski wrote:
On Wed, 30 Nov 2022 17:42:25 +0100
Niel Fourie wrote:
In eth_halt(), change the private uclass state
Hi Marek,
On 01/12/2022 11:44, Marek Vasut wrote:
On 12/1/22 09:24, Lukasz Majewski wrote:
On Wed, 30 Nov 2022 17:42:25 +0100
Niel Fourie wrote:
In eth_halt(), change the private uclass state before calling
stop() instead of afterwards, to avoid writing to memory which
may have been freed
`uclass_priv_` to which `priv` is pointing. Writing to
`priv` after stop() may corrupt the `fd` member of `struct
malloc_chunk`, which represents the freed block, and could cause
hard-to-debug crashes on subsequent calls to malloc()/free().
Signed-off-by: Niel Fourie
Cc: Ramon Fried
Cc: Marek Vasut
on SOMs with Winbond NAND flash chips.
Signed-off-by: Niel Fourie
---
arch/arm/dts/imx6q-phytec-mira-rdk-nand-u-boot.dtsi | 5 +
include/configs/pcm058.h| 1 +
2 files changed, 6 insertions(+)
diff --git a/arch/arm/dts/imx6q-phytec-mira-rdk-nand-u-boot.dtsi
b/arch/
Add basic support for the Hitachi Power Grids kmcent2 board, based
on the NXP QorIQ T1040 SoC.
Signed-off-by: Valentin Longchamp
Signed-off-by: Rainer Boschung
Signed-off-by: Niel Fourie
Cc: Holger Brunck
Cc: Heiko Schocher
Cc: Priyanka Jain
Cc: Stefan Roese
---
Changes in v2:
- Sorted
Replace instances of sprintf()/set_env() for setting hexadecimal
values with set_env_hex().
In set_km_env() the "pram" variable was set to an hexadecimal
value, while initr_mem() expects an unsigned decimal, so use
set_env_ulong() instead.
Signed-off-by: Niel Fourie
Cc: Holger Brunck
Pulled in the kmcent2.dts and all its dependents from Linux 5.10,
commit 2c85ebc57b3e upstream. Replaced the license text with
SPDX License Identifiers.
Signed-off-by: Niel Fourie
Reviewed-by: Stefan Roese
Cc: Holger Brunck
Cc: Heiko Schocher
Cc: Priyanka Jain
Cc: Stefan Roese
---
Changes
support for the kmcent2
Changes in v2:
- DTs pulled in from Linux reviewed
- In common.c, use set_env_hex()/set_env_ulong()
- Sort header includes, remove includes
- Removed unnecessary #ifdefs
- Moved MTDPARTS_DEFAULT/MTDIDS_DEFAULT to defconfig
Niel Fourie (3):
PowerPC: dts: Pulled in kmcent2 dts
instead if available in Kconfig.
With the exceptions of MTDPARTS_DEFAULT and MTDIDS_DEFAULT, I originally
did go through each of these defines, and moved everything that could
into the defconfig already. Everything else would require editing the
Kconfigs themselves. Some macros above do
Hi Stefan
On 19/01/2021 16:13, Stefan Roese wrote:
Hi Niel,
On 08.01.21 11:53, Niel Fourie wrote:
In set_km_env() the pram variable was set to an hexadecimal value,
while initr_mem() expects an unsigned decimal. Set the pram variable
to an unsigned decimal instead.
Signed-off-by: Niel Fourie
Hi Stefan,
On 19/01/2021 16:06, Stefan Roese wrote:
Hi Niel,
On 08.01.21 11:53, Niel Fourie wrote:
Pulled in the kmcent2.dts and all its dependents from Linux 5.10,
commit 2c85ebc57b3e upstream. Replaced the license text with
SPDX License Identifiers.
I assume that you did not change the
Add basic support for the Hitachi Power Grids kmcent2 board, based
on the NXP QorIQ T1040 SoC.
Signed-off-by: Valentin Longchamp
Signed-off-by: Rainer Boschung
Signed-off-by: Niel Fourie
Cc: Holger Brunck
Cc: Heiko Schocher
Cc: Priyanka Jain
---
arch/powerpc/cpu/mpc85xx/Kconfig | 4
Pulled in the kmcent2.dts and all its dependents from Linux 5.10,
commit 2c85ebc57b3e upstream. Replaced the license text with
SPDX License Identifiers.
Signed-off-by: Niel Fourie
Cc: Holger Brunck
Cc: Heiko Schocher
Cc: Priyanka Jain
---
arch/powerpc/dts/elo3-dma-0.dtsi | 55 ++
arch
In set_km_env() the pram variable was set to an hexadecimal value,
while initr_mem() expects an unsigned decimal. Set the pram variable
to an unsigned decimal instead.
Signed-off-by: Niel Fourie
Cc: Holger Brunck
Cc: Heiko Schocher
Cc: Priyanka Jain
---
board/keymile/common/common.c | 2
support for the kmcent2
Niel Fourie (3):
PowerPC: dts: Pulled in kmcent2 dts files from Linux 5.10
keymile: common: Fix pram variable radix
PowerPC: keymile: Add support for kmcent2 board
arch/powerpc/cpu/mpc85xx/Kconfig | 4 +
arch/powerpc/dts/Makefile | 1 +
arch/powerpc
d pointer of the previously freed chunk.
Signed-off-by: Niel Fourie
Cc: Simon Glass
---
drivers/spi/spi-uclass.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/spi/spi-uclass.c b/drivers/spi/spi-uclass.c
index 55a8eed8901..a16ac9280fd 100644
--- a/drivers/spi/spi-uclass.c
+++ b/driver
README to reflect this
change.
Signed-off-by: Niel Fourie
Cc: Stefano Babic
---
board/phytec/pcm058/README | 20
configs/pcm058_defconfig | 3 ++-
2 files changed, 14 insertions(+), 9 deletions(-)
diff --git a/board/phytec/pcm058/README b/board/phytec/pcm058/README
index
Convert pcm058 support to use device trees and the driver model.
Add rudimentary boot scripts to the environment, expand README.
Signed-off-by: Niel Fourie
Cc: Stefano Babic
---
arch/arm/dts/Makefile | 1 +
.../imx6q-phytec-mira-rdk-nand-u-boot.dtsi| 42 +++
arch
Change the MAINTAINER of pcm058.
Signed-off-by: Niel Fourie
Cc: Stefano Babic
---
board/phytec/pcm058/MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/board/phytec/pcm058/MAINTAINERS b/board/phytec/pcm058/MAINTAINERS
index b0ca40277f..909dfc44af 100644
--- a
Add Phytec Mira device tree files, for use with pcm058.
>From Linux 5.6, commit 7111951b8d49 upstream
Signed-off-by: Niel Fourie
Cc: Stefano Babic
---
arch/arm/dts/imx6q-phytec-mira-rdk-nand.dts | 72
arch/arm/dts/imx6qdl-phytec-mira.dtsi| 390 +++
arch/arm/
Add da9063-regulator bindings from Linux 5.6:
commit 7111951b8d49 upstream
Signed-off-by: Niel Fourie
Cc: Stefano Babic
---
.../dt-bindings/regulator/dlg,da9063-regulator.h | 16
1 file changed, 16 insertions(+)
create mode 100644 include/dt-bindings/regulator/dlg,da9063
This patch series updates the existing pcm058 board support to use device
trees with driver model. The first two patches in the series pulls in the
unmodified Linux dt-binding and dts files. The third patch changes the
maintainer. The last patch contains the required changes.
Niel Fourie (4
Hi Simon
On 3/28/20 9:05 PM, Simon Glass wrote:
Hi Niel,
On Wed, 25 Mar 2020 at 07:47, Niel Fourie wrote:
Expand warnings printed by Makefile after compile when legacy
drivers are in use. These include:
- CONFIG_HAVE_BLOCK_DEVICE without CONFIG_BLK
- CONFIG_BOOTCOUNT_LIMIT without
Add a command to print a list of available block device drivers,
and for each, the list of known block devices.
Signed-off-by: Niel Fourie
Cc: Simon Glass
Cc: Stefan Roese
Reviewed-by: Simon Glass
Reviewed-by: Stefan Roese
---
Changes in v2:
- Removed legacy block device variant of blkls and
Add a command to print a list of available block device drivers,
and for each, the list of known block devices.
Signed-off-by: Niel Fourie
Cc: Simon Glass
Cc: Stefan Roese
---
Changes in v2:
- Removed legacy block device variant of blkls and its test.
- Handle return value of uclass_get
out the #ifdef after adding the
Kconfig dependency. Will fix. Well spotted, thanks!
Best regards,
Niel Fourie
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-21 Fax: +49-8142-66989
Add a command to print a list of available block device drivers,
and for each, the list of known block devices.
Signed-off-by: Niel Fourie
---
cmd/Kconfig | 8
cmd/Makefile| 1 +
cmd/lsblk.c | 83 +
test
without CONFIG_DM_PMIC
- Absence of CONFIG_RAM and CONFIG_SPL_RAM
Also replaced existing CONFIG_DM_SPI warning for consistency.
Removed CONFIG_BLK requirement for CONFIG_DM_USB, as all USB
devices not block devices.
Signed-off-by: Niel Fourie
Cc: Simon Glass
---
Makefile | 73
Added command "fstypes" to list supported/included filesystems.
Signed-off-by: Niel Fourie
Cc: Simon Glass
Reviewed-by: Simon Glass
---
Changes in v2:
- Add Python test
Changes in v3:
- Rewrote comment for do_fs_types() in fs.h
cmd/fs.c | 11 ++
Add a subcommand "types" to the part command, which lists the supported
partition table types.
Signed-off-by: Niel Fourie
Cc: Simon Glass
Reviewed-by: Simon Glass
---
Changes in v2:
- Add Python test
Changes in v3:
- none
cmd/part.c | 27 +-
drivers which use static platform data
(instead of the device tree).
These patches were tested in the Sandbox and on the Wandboard
i.MX6Quad Board rev B1.
Changes in v2:
- Rebased on https://patchwork.ozlabs.org/patch/1234460/
- Added Python tests
- Fixed minor typographical errors
Changes in v3:
s driver and names of
attached devices.
Added a new "static" subcommand to dump a list of DM drivers with
statically defined platform data.
Signed-off-by: Niel Fourie
Cc: Simon Glass
Cc: Sean Anderson
Reviewed-by: Simon Glass
---
Depends on: https://patchwork.ozlabs.org/patch/1234460/
so listed in `dm
drivers`."""
+response = u_boot_console.run_command('dm static')
+drivers = (line[:25].rstrip() for line in
response[:-1].split('\n')[2:])
response = u_boot_console.run_command('dm drivers')
for driver in drive
s driver and names of
attached devices.
Added a new "static" subcommand to dump a list of DM drivers with
statically defined platform data.
Signed-off-by: Niel Fourie
CC: Simon Glass
CC: Sean Anderson
---
Depends on: https://patchwork.ozlabs.org/patch/1234460/
Changes in v2:
- Add/exte
Add a subcommand "types" to the part command, which lists the supported
partition table types.
Signed-off-by: Niel Fourie
CC: Simon Glass
---
Changes in v2:
- Add Python test
cmd/part.c | 27 +--
test/py/tests/test_part.py | 14 +
Added command "fstypes" to list supported/included filesystems.
Signed-off-by: Niel Fourie
CC: Simon Glass
---
Changes in v2:
- Add Python test
cmd/fs.c | 11 +++
fs/fs.c | 20
in
drivers which use static platform data
(instead of the device tree).
These patches were tested in the Sandbox and on the Wandboard
i.MX6Quad Board rev B1.
Changes in v2:
- Rebased on https://patchwork.ozlabs.org/patch/1234460/
- Added Python tests
- Fixed minor typographical errors
Niel Fourie
Hi Tom,
On 3/17/20 7:51 PM, Sean Anderson wrote:
On 3/17/20 10:09 AM, Niel Fourie wrote:
Renamed dm "drivers" subcommand to "compat" (as it listed
compatibility strings) and prevent it from segfaulting when
drivers have no of_match populated.
Added a new "drivers"
tree, I felt that it was useful to list them to see
their impact. The address is useful to for eyeballing the platform data
with md.b to distinguish between multiple driver instances...
In the hunt against legacy drivers, I am also looking at ways of
listing/highlighting other problem-children
s driver and names of
attached devices.
Added a new "static" subcommand to dump a list of DM drivers with
statically defined platform data.
Signed-off-by: Niel Fourie
CC: Simon Glass
---
cmd/dm.c| 24 --
drivers/core/dump.c | 60 +++
Added command "fstypes" to list supported/included filesystems.
Signed-off-by: Niel Fourie
CC: Simon Glass
---
cmd/fs.c | 11 +++
fs/fs.c | 20
include/fs.h | 5 +
3 files changed, 36 insertions(+)
diff --git a/cmd/fs.c b/cmd/fs.c
index
Add a subcommand "types" to the part command, which lists the supported
partition table types.
Signed-off-by: Niel Fourie
CC: Simon Glass
---
cmd/part.c | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/cmd/part.c b/cmd/part.c
index
drivers which use static platform data
(instead of the device tree).
These patches were tested in the Sandbox and on the Wandboard
i.MX6Quad Board rev B1.
Niel Fourie (3):
cmd: part: Add subcommand to list supported partition tables
cmd: fs: Add command to list supported fs types
cmd: dm: Fi
trees were taken from Linux mainline:
commit 37624b58542f ("Linux 5.1-rc7")
Signed-off-by: Niel Fourie
Reviewed-by: Heiko Schocher
---
Notes:
Changes for v6:
- RAM initialisation reworked to detect available memory
- Remove memory section from am335x-wega-rdk-u
Hi Tom,
On 5/7/19 3:19 PM, Tom Rini wrote:
On Tue, May 07, 2019 at 11:39:12AM +0200, Niel Fourie wrote:
Hi Tom,
On 5/6/19 7:24 PM, Tom Rini wrote:
On Mon, May 06, 2019 at 06:44:48PM +0200, Niel Fourie wrote:
Hi Tom,
On 5/6/19 4:18 PM, Tom Rini wrote:
On Mon, May 06, 2019 at 04:02:53PM
Hi Tom,
On 5/6/19 7:24 PM, Tom Rini wrote:
On Mon, May 06, 2019 at 06:44:48PM +0200, Niel Fourie wrote:
Hi Tom,
On 5/6/19 4:18 PM, Tom Rini wrote:
On Mon, May 06, 2019 at 04:02:53PM +0200, Niel Fourie wrote:
Support for Phytech phyCORE AM335x R2 SOM (PCL060) on the Phytec
phyBOARD-Wega
Hi Tom,
On 5/6/19 4:18 PM, Tom Rini wrote:
On Mon, May 06, 2019 at 04:02:53PM +0200, Niel Fourie wrote:
Support for Phytech phyCORE AM335x R2 SOM (PCL060) on the Phytec
phyBOARD-Wega AM335x.
CPU : AM335X-GP rev 2.1
Model: Phytec AM335x phyBOARD-WEGA
DRAM: 256 MiB
NAND: 256 MiB
MMC: OMAP
trees were taken from Linux mainline:
commit 37624b58542f ("Linux 5.1-rc7")
Signed-off-by: Niel Fourie
---
Changes for v2:
- Remove formatting changes to upstream Linux dtsi files
- Remove incorrectly added MACH_TYPE
- Rename board from phycore_pcl060 to phycore_am335x_r2
- Implement
Hi Tom,
On 5/3/19 4:07 PM, Tom Rini wrote:
On Fri, May 03, 2019 at 01:28:02PM +0200, Niel Fourie wrote:
[snip]
diff --git a/arch/arm/dts/am33xx-u-boot.dtsi b/arch/arm/dts/am33xx-u-boot.dtsi
index 78f5e2c4d3..a58734e441 100644
--- a/arch/arm/dts/am33xx-u-boot.dtsi
+++ b/arch/arm/dts/am33xx-u
trees were taken from Linux mainline:
commit 37624b58542fb9f2 ("Linux 5.1-rc7")
Signed-off-by: Niel Fourie
---
arch/arm/dts/Makefile | 3 +-
arch/arm/dts/am335x-phycore-som.dtsi | 322 +
arch/arm/dts/am335x-wega-rdk-u-boot.dtsi | 27 ++
trees were taken from Linux mainline revision
37624b58542fb9f2d9a70e6ea006ef8a5f66c30b
Signed-off-by: Niel Fourie
---
arch/arm/dts/Makefile | 3 +-
arch/arm/dts/am335x-phycore-som.dtsi | 322 +
arch/arm/dts/am335x-wega-rdk-u-boot.dtsi | 40
.
I simply removed the hard-coded USB stuff, as the DM_USB was already
enabled and working anyways. DM_USB_GADGET was also enabled. Thanks for
the recommendation.
Best regards,
Niel Fourie
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirch
-off-by: Niel Fourie
---
arch/arm/dts/Makefile | 3 +-
arch/arm/dts/am335x-phycore-som.dtsi | 322 +
arch/arm/dts/am335x-wega-rdk-u-boot.dtsi | 40 +++
arch/arm/dts/am335x-wega-rdk.dts | 23 ++
arch/arm/dts/am335x-wega.dtsi
mented all points, along with some further
refinement/clean-up.
Best regards,
Niel Fourie
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-21 Fax: +49-8142-66989-80 Email: lu.
-off-by: Niel Fourie
---
arch/arm/dts/Makefile| 3 +-
arch/arm/dts/am335x-phycore-som.dtsi | 327 ++
arch/arm/dts/am335x-wega-rdk-u-boot.dtsi | 35 +++
arch/arm/dts/am335x-wega-rdk.dts | 23 ++
arch/arm/dts/am335x-wega.dtsi| 231
64 matches
Mail list logo
