Re: [PATCH v2] env: mmc: fix offsets relative to the end of the partition

2025-06-10 Thread Michael Walle
Hi Javier, According to the help text, you can set negative offsets to indicated that the offset is relative to the end of the parition. But kconfig doesn't let you specify negative hex values. I think this fell through the cracks when converting the symbol from a '#define' to a kconfig option.

Re: [PATCH v2] env: mmc: fix offsets relative to the end of the partition

2025-06-06 Thread Michael Walle
Hi Andrew, Maybe a Fixes: tag would be nice there, but since we don't have stable releases like the kernel, not sure it matters much :) Please always include a Fixes tag when appropriate. Will do. But please use reply-to-all as not everyone is subscribed to all the MLs and I've just found yo

[PATCH v2] env: mmc: fix offsets relative to the end of the partition

2025-06-05 Thread Michael Walle
n. Introduce a new boolean kconfig option to switch on the "relative to the end" behavior. Signed-off-by: Michael Walle --- v2: - made the Kconfig help text clearer on MMC hardware partitions. I've used the term "MMC hardware partition" as it was already used in s

Re: [PATCH] net: fsl_enetc: fix imdio register calculation

2025-04-28 Thread Michael Walle
fset to calculation of imdio.priv to > fix this. > > Fixes: cc4e8af2c552 ("net: fsl_enetc: Split register accessors") > Signed-off-by: Thomas Schaefer > Signed-off-by: Heiko Thiery With the nitpick above: Reviewed-by: Michael Walle > --- > > But the question th

Re: [PATCH] doc: board: ti: Add optee rng support

2025-04-11 Thread Michael Walle
Hi, > > > J722S has hw rng, which can be used by OPTEE. > > > So remove option to use SW TRNG by OPTEE. > > > > > > Signed-off-by: Udit Kumar > > > --- > > > reference discussion > > > https://lore.kernel.org/all/20250313144155.2382316-1-mwa...@kernel.org/ > > > > > > Bootlogs with optee trng >

Re: [PATCH] doc: board: ti: Add optee rng support

2025-04-11 Thread Michael Walle
Hi, > J722S has hw rng, which can be used by OPTEE. > So remove option to use SW TRNG by OPTEE. > > Signed-off-by: Udit Kumar > --- > reference discussion > https://lore.kernel.org/all/20250313144155.2382316-1-mwa...@kernel.org/ > > Bootlogs with optee trng > https://gist.github.com/uditkumarti

Re: [PATCH] tiny-printf: Handle formatting of %p with an extra Kconfig

2025-04-10 Thread Michael Walle
On Wed Apr 9, 2025 at 5:22 PM CEST, Tom Rini wrote: > On Wed, Apr 09, 2025 at 02:33:08PM +0200, Michael Walle wrote: > > Hi, > > > > > >> The formatting with %pa / %pap behaves like %x, which results in an > > > >> incorrect value being output. To imp

Re: [PATCH] tiny-printf: Handle formatting of %p with an extra Kconfig

2025-04-09 Thread Michael Walle
when needed. For SPL_NET and NET_LWIP it is selected by default. > >> Then it also supports the formatting with %pm, %pM and %pI4. > >> > >> Signed-off-by: Christoph Niedermaier > >> --- > >> Cc: Tom Rini > >> Cc: Simon Glass > >> Cc: M

Re: [PATCH] tiny-printf: Add support for upper case hex values

2025-04-06 Thread Michael Walle
Hi, > > > > I wouldn't mind printing the pointer for %p[mMI], but %pa prints the > > > > *content* of the pointer which is really confusing. I.e. in > > > > pinctrl-single.c the reg value pairs are printed like > > > > > > > > dev_dbg(dev, "reg/val %pa/0x%08x\n", ®, val); > > > > > > > > with r

Re: [PATCH] tiny-printf: Add support for upper case hex values

2025-04-04 Thread Michael Walle
Hi, > > I wouldn't mind printing the pointer for %p[mMI], but %pa prints the > > *content* of the pointer which is really confusing. I.e. in > > pinctrl-single.c the reg value pairs are printed like > > > > dev_dbg(dev, "reg/val %pa/0x%08x\n", ®, val); > > > > with reg being a pointer to a phy

Re: [PATCH] tiny-printf: Add support for upper case hex values

2025-04-02 Thread Michael Walle
Hi, > The issue is that disabling TINY_PRINTF may not be possible (size > constraints) and some code is compiled for different stages and people > typically don't check whether the format used in printf is valid with > tiny_printf. I've had this issue already in the past, I vaguely recall > "c

Re: [PATCH] tiny-printf: Add support for upper case hex values

2025-04-02 Thread Michael Walle
Hi, > >> The issue is that disabling TINY_PRINTF may not be possible (size > >> constraints) and some code is compiled for different stages and people > >> typically don't check whether the format used in printf is valid with > >> tiny_printf. I've had this issue already in the past, I vaguely rec

Re: [PATCH 1/3] fastboot: lift restrictions on !NET_LWIP for USB

2025-03-28 Thread Michael Walle
. Add some ifdeffery to guard against > > that. > > > > This will make fastboot over USB work with the new LWIP stack. > > > > Signed-off-by: Michael Walle > > checkpatch.pl reports some issues with this: > > $ ./scripts/checkpatch.pl --strict --u-boot --git

[PATCH 3/3] env: mmc: fix offsets relative to the end of the partition

2025-03-13 Thread Michael Walle
n. Introduce a new boolean kconfig option to switch on the "relative to the end" behavior. Signed-off-by: Michael Walle --- env/Kconfig | 42 +- env/mmc.c | 8 2 files changed, 33 insertions(+), 17 deletions(-) diff --git a/env/Kc

Re: [PATCH 3/3] env: mmc: fix offsets relative to the end of the partition

2025-03-13 Thread Michael Walle
from a '#define' to a kconfig > > option. > > > > Introduce a new boolean kconfig option to switch on the "relative to the > > end" behavior. > > > > Signed-off-by: Michael Walle > > --- > > env/Kconfig | 42 ++

Re: [PATCH 3/3] env: mmc: fix offsets relative to the end of the partition

2025-03-12 Thread Michael Walle
Sorry this should have been individual patches. Please read the subject as "[PATCH 1/1]" or just "[PATCH]". -michael

Re: [PATCH 2/3] net: lwip: remove superfluous newline at tftp help text

2025-03-12 Thread Michael Walle
Sorry this should have been individual patches. Please read the subject as "[PATCH 1/1]" or just "[PATCH]". -michael

Re: [PATCH 1/3] fastboot: lift restrictions on !NET_LWIP for USB

2025-03-12 Thread Michael Walle
Sorry this should have been individual patches. Please read the subject as "[PATCH 1/1]" or just "[PATCH]". -michael

[PATCH 2/3] net: lwip: remove superfluous newline at tftp help text

2025-03-12 Thread Michael Walle
The help text has a newline at the end which will lead to an empty line after the tftpboot when printing the help overview. Remove it. Fixes: 4d4d7838127e ("net: lwip: add TFTP support and tftpboot command") Signed-off-by: Michael Walle --- cmd/net-lwip.c | 2 +- 1 file changed, 1

[PATCH 1/3] fastboot: lift restrictions on !NET_LWIP for USB

2025-03-12 Thread Michael Walle
make fastboot over USB work with the new LWIP stack. Signed-off-by: Michael Walle --- Alternatively, we could add the defines and stub functions to the lwip header. --- cmd/fastboot.c | 4 drivers/fastboot/Kconfig | 1 - drivers/fastboot/fb_common.c | 4 3 files chang

[PATCH 2/5] board: sl28: increase SPL_SYS_MALLOC_SIZE

2024-12-13 Thread Michael Walle
Increase the malloc size to 2MiB because our FIT image exceeds the 1MiB limit either if BL31 mode is enabled or if another device tree is added to the image. Signed-off-by: Michael Walle --- configs/kontron_sl28_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs

[PATCH 5/5] board: sl28: fix USB0

2024-12-13 Thread Michael Walle
nabled host mode and never OTG mode. Add it to our board "-u-boot.dtsi" to fix it. Fixes: 61ff13283c3b ("board: sl28: move to OF_UPSTREAM") Reported-by: Heiko Thiery Signed-off-by: Michael Walle --- arch/arm/dts/fsl-ls1028a-kontron-sl28-u-boot.dtsi | 4 1 file chang

[PATCH 4/5] doc: board: sl28: fix table

2024-12-13 Thread Michael Walle
Convert the table to a correct reST table syntax. Signed-off-by: Michael Walle --- doc/board/kontron/sl28.rst | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/doc/board/kontron/sl28.rst b/doc/board/kontron/sl28.rst index 2cb8ec62be4..5d47ce6c158 100644 --- a

[PATCH 3/5] board: sl28: fix network on variant 3

2024-12-13 Thread Michael Walle
missed that the -u-boot.dtsi is not inlcuded in this case which will set the ethernet alias. Now that the var3 device tree is upstream, just re-add it to the SPL handling again. Fixes: 61ff13283c3b ("board: sl28: move to OF_UPSTREAM") Signed-off-by: Michael Walle --- board/kon

[PATCH 1/5] board: sl28: fix linking with disabled watchdog

2024-12-13 Thread Michael Walle
We don't have a reference to the driver used by uclass_get_device_by_driver() in stop_recovery_watchdog(). Fix it by not calling that function if the watchdog driver isn't enabled. Signed-off-by: Michael Walle --- board/kontron/sl28/sl28.c | 3 ++- 1 file changed, 2 insertions(+),

[PATCH 0/5] board: sl28: various fixes

2024-12-13 Thread Michael Walle
Give the sl28 board some love and fix various issues. Most of them were due to the transition to the upstream device trees. Michael Walle (5): board: sl28: fix linking with disabled watchdog board: sl28: increase SPL_SYS_MALLOC_SIZE board: sl28: fix network on variant 3 doc: board: sl28

Re: [PATCH v2] boot: android: fix booting without a ramdisk

2024-07-31 Thread Michael Walle
Hi, > > > - if (ret) > > > + if (ret == -ENOENT) > > > + return -ENOPKG; > > We normally use -ENOENT for this sort of thing. That's the way select_ramdisk() is documented. It was actually introduced by yourself in commit e4c92879

[PATCH v2] boot: android: fix booting without a ramdisk

2024-07-29 Thread Michael Walle
oot again: fastboot --base 0x4100 --header-version 2 --dtb /path/to/dtb \ --cmdline "root=/dev/mmcblk0p1 rootwait" boot path/to/Image Signed-off-by: Michael Walle --- boot/image-android.c | 7 +++ boot/image-board.c | 4 +++- include/image.h | 2 +- 3 files changed,

[PATCH] boot: android: fix booting without a ramdisk

2024-07-26 Thread Michael Walle
error in the (valid) case that there is no ramdisk in the image. With this, I'm able to boot a linux kernel using fastboot again: fastboot --base 0x4100 --header-version 2 --dtb /path/to/dtb \ --cmdline "root=/dev/mmcblk0p1 rootwait" boot path/to/Image Signed-off-by: Micha

[PATCH v2 2/2] spi: sunxi: fix clock divider calculation for max frequency setting

2024-07-18 Thread Michael Walle
. While at it, correct the comment above the calculation. Signed-off-by: Michael Walle --- drivers/spi/spi-sunxi.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-sunxi.c b/drivers/spi/spi-sunxi.c index f110a8b7658..81f1298adea 100644 --- a/drivers/spi/spi

[PATCH v2 1/2] spi: sunxi: fix CDR2 calculation

2024-07-18 Thread Michael Walle
igns the CDR2 calculation with the linux driver. Suggested-by: Andre Przywara Signed-off-by: Michael Walle --- drivers/spi/spi-sunxi.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-sunxi.c b/drivers/spi/spi-sunxi.c index bfb402902b8..f110a8b7658 100644

Re: [PATCH 2/2] spi: sunxi: fix clock divider calculation for max frequency setting

2024-07-16 Thread Michael Walle
> > - if ((div / 2) <= (SUN4I_CLK_CTL_CDR2_MASK + 1)) { > > + if (div != 1 && ((div / 2) <= (SUN4I_CLK_CTL_CDR2_MASK + 1))) { > > div /= 2; > > This is still not fully correct, is it? If I ask for 10 MHz, the > algorithm should select 8 MHz (24/3) or actually 6 MHz (24/4), but it >

Re: [PATCH 1/2] spi: sunxi: drop max_hz handling

2024-07-15 Thread Michael Walle
whole max_hz handling. > > Looks good to me, I verified this by timing the read, this patch indeed > significantly increases the performance. Also changing the limit in the > DT gets reflected in the driver and in the read speed. Also verified > that the values read from the SPI flash a

Re: [PATCH 0/2] spi: sunxi: Improve the loading speed

2024-07-12 Thread Michael Walle
Right now, the maximal transfer speed from an SPI flash on a V3s is about 240kb/s. That is pretty slow. It turns out, that due to an error u-boot is setting the maximum frequency to 1MHz. By fixing that another bug is unearthed: one cannot set a clock divider of 1:1 due to the handling between CDR

[PATCH 2/2] spi: sunxi: fix clock divider calculation for max frequency setting

2024-07-12 Thread Michael Walle
. While at it, correct the comment above the calculation. Signed-off-by: Michael Walle --- drivers/spi/spi-sunxi.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-sunxi.c b/drivers/spi/spi-sunxi.c index bfb402902b8..3048ab0ecf7 100644 --- a/drivers/spi/spi

[PATCH 1/2] spi: sunxi: drop max_hz handling

2024-07-12 Thread Michael Walle
flash reads are very slow with just about 215kb/s. In fact, the SPI uclass will already take care of everything and we just have to clamp the frequency to the values the driver/hardware supports. Thus, drop the whole max_hz handling. Signed-off-by: Michael Walle --- drivers/

[PATCH 0/2] spi: sunxi: Improve the loading speed

2024-07-12 Thread Michael Walle
CDR1 and CDR2 handling. By fixing that I achieved loading speeds of about 1.5MB/s. Michael Walle (2): spi: sunxi: drop max_hz handling spi: sunxi: fix clock divider calculation for max frequency setting drivers/spi/spi-sunxi.c | 28 +++- 1 file changed, 15 insertions

[PATCH] sunxi: board: probe USB gadget

2024-07-11 Thread Michael Walle
Due to the lazy probing, the gadget driver might not be probed when the u-boot cli is active. In this case the "ums" command won't work, for example. If enabled, probe the USB gadget during board_init(). Signed-off-by: Michael Walle --- board/sunxi/board.c | 4 1 file change

Re: [PATCH] sunxi: SPL SPI: add support for the V3s SoC

2024-07-11 Thread Michael Walle
On Tue May 14, 2024 at 1:43 AM CEST, Michael Walle wrote: > The V3s is identical regarding register layout, clocks and resets to > the sun6i variants. Therefore, we can just add the MACH_SUN8I_V3S to > the sun6i compatible ones. > > SPI boot was tested on a custom board with a Gig

Re: [PATCH 0/2] sunxi: v3s: add network support

2024-07-11 Thread Michael Walle
Hi, On Mon May 13, 2024 at 10:56 PM CEST, Michael Walle wrote: > Add network support for the V3s which only supports the internal > PHY. Adding support was straight forward. The emac driver just needs > the compatible string and some platform data and the clock driver > needs to know

Re: obscure microsd detection issue between U-Boot and kernel

2024-06-04 Thread Michael Walle
On Tue Jun 4, 2024 at 9:47 AM CEST, Christian Loehle wrote: > On 6/3/24 22:28, Tim Harvey wrote: > > On Mon, Jun 3, 2024 at 1:18 AM Christian Loehle > > wrote: > >> > >> On 5/31/24 21:47, Tim Harvey wrote: > >>> Greetings, > >>> > >>> I'm seeing an issue on an imx8mm board (imx8mm-venice-gw73xx) w

[PATCH] sunxi: SPL SPI: add support for the V3s SoC

2024-05-13 Thread Michael Walle
The V3s is identical regarding register layout, clocks and resets to the sun6i variants. Therefore, we can just add the MACH_SUN8I_V3S to the sun6i compatible ones. SPI boot was tested on a custom board with a Gigadevice GD25Q64 8MiB SPI flash. Signed-off-by: Michael Walle --- arch/arm/mach

[PATCH 2/2] net: sun8i_emac: add support for the V3s

2024-05-13 Thread Michael Walle
Add the compatible string for the emac found on the V3s SoC. The SoC only supports the internal PHY. There are no (R)MII signals on any pins. Signed-off-by: Michael Walle --- drivers/net/sun8i_emac.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/sun8i_emac.c b/drivers

[PATCH 1/2] clk: sunxi: add EMAC and EPHY clocks and resets for the V3s SoC

2024-05-13 Thread Michael Walle
Add the clock gate registers as well as the reset register bits for the EMAC and EPHY for the V3s. These are needed by the sun8i network driver. Signed-off-by: Michael Walle --- drivers/clk/sunxi/clk_v3s.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/clk/sunxi/clk_v3s.c b

[PATCH 0/2] sunxi: v3s: add network support

2024-05-13 Thread Michael Walle
custom board. Michael Walle (2): clk: sunxi: add EMAC and EPHY clocks and resets for the V3s SoC net: sun8i_emac: add support for the V3s drivers/clk/sunxi/clk_v3s.c | 6 ++ drivers/net/sun8i_emac.c| 7 +++ 2 files changed, 13 insertions(+) -- 2.39.2

Re: [PATCH 032/149] board: buffalo: Remove and add needed includes

2024-05-02 Thread Michael Walle
On Wed May 1, 2024 at 4:41 AM CEST, Tom Rini wrote: > Remove from this board vendor directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini Acked-by: Michael Walle

Re: [PATCH 080/149] board: kontron: Remove and add needed includes

2024-05-02 Thread Michael Walle
On Wed May 1, 2024 at 4:42 AM CEST, Tom Rini wrote: > Remove from this board vendor directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini Acked-by: Michael Walle

Re: Capsule GUIDs and LVFS

2024-04-25 Thread Michael Walle
Hi, On Thu Apr 25, 2024 at 8:19 AM CEST, Ilias Apalodimas wrote: > I've cc'ed all the people I could find in board specific MAINTAINER files. > Can you respond to Richard with the proper company name & board name > so we can bind the following GUIDs to a vendor properly? > Richard any guidance on

Re: [PATCH] board: sl28: move to OF_UPSTREAM

2024-04-15 Thread Michael Walle
On Wed Mar 6, 2024 at 5:19 PM CET, Michael Walle wrote: > Use the new device devicetree files in dts/upstream/ and delete the old > ones. Still keep the -u-boot.dtsi with all u-boot specifics around. > > There is one catch and that is fsl-ls1028a-kontron-sl28-var3.dts which > i

Re: [PATCH 3/4] arm: dts: k3-*-binman.dtsi: Clean up and templatize boot binaries

2024-04-12 Thread Michael Walle
Hi, On Fri Apr 12, 2024 at 5:03 AM CEST, Neha Malcom Francis wrote: > On 05/04/24 13:12, Michael Walle wrote: > > On Thu Apr 4, 2024 at 11:10 AM CEST, Neha Malcom Francis wrote: > >> But again in the interest of time... this would mean this cleaning up > >> effort be &

Re: [PATCH 3/4] arm: dts: k3-*-binman.dtsi: Clean up and templatize boot binaries

2024-04-05 Thread Michael Walle
Hi, On Thu Apr 4, 2024 at 11:10 AM CEST, Neha Malcom Francis wrote: > But again in the interest of time... this would mean this cleaning up effort > be > kept on hold. If we can agree to move to using the generator later as the > final > solution, can we pick up this series for now? Agreed. I

Re: [PATCH 3/4] arm: dts: k3-*-binman.dtsi: Clean up and templatize boot binaries

2024-04-03 Thread Michael Walle
Hi, > > > > > And on top of that, it will just be a base board and there will > > > > > likely be some carrier device trees (overlay? I'm not sure yet). > > > > > > > > > > As far as I can tell, you've put the memory configuration into the > > > > > device tree, so I'll probably need to switch be

[PATCH] net: ti: am65-cpsw: Fix buffer overflow

2024-04-03 Thread Michael Walle
size. Fixes: 38922b1f4acc ("net: ti: am65-cpsw: Add support for multi port independent MAC mode") Signed-off-by: Michael Walle --- drivers/net/ti/am65-cpsw-nuss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ti/am65-cpsw-nuss.c b/drivers/net/ti

Re: [PATCH] net: phy: broadcom: Configure LEDs on BCM54210E

2024-04-02 Thread Michael Walle
On Thu Mar 28, 2024 at 4:09 PM CET, Tom Rini wrote: > On Mon, Jan 01, 2024 at 10:07:47PM +0100, Marek Vasut wrote: > > > Configure LEDs on BCM54210E so they would blink on activity > > and indicate link speed. Without this the LEDs are always on > > if cable is plugged in. > > > > Signed-off-by: M

Re: [PATCH 3/4] arm: dts: k3-*-binman.dtsi: Clean up and templatize boot binaries

2024-03-28 Thread Michael Walle
Hi, On Thu Mar 28, 2024 at 12:18 PM CET, Neha Malcom Francis wrote: > On 27-Mar-24 8:03 PM, Michael Walle wrote: > > On Wed Mar 27, 2024 at 8:01 AM CET, Neha Malcom Francis wrote: > >> On 26/03/24 19:18, Michael Walle wrote: > >>> On Fri Mar 22, 2024 at 2:10 PM

Re: [PATCH v2] arm: dts: kirkwood: Enable upstream DT on Kirkwood boards

2024-03-28 Thread Michael Walle
bx81lifxcat.dts: No such > file or directory ... Are you sure you want to have all this text in the commit log? You seem to have forgotten my tag: Tested-by: Michael Walle # on lschv2

Re: [PATCH 3/4] arm: dts: k3-*-binman.dtsi: Clean up and templatize boot binaries

2024-03-27 Thread Michael Walle
Hi, On Wed Mar 27, 2024 at 8:01 AM CET, Neha Malcom Francis wrote: > On 26/03/24 19:18, Michael Walle wrote: > > On Fri Mar 22, 2024 at 2:10 PM CET, Neha Malcom Francis wrote: > >> Clean up templatized boot binaries for all K3 boards. This includes > >> modifyin

Re: [PATCH 3/4] arm: dts: k3-*-binman.dtsi: Clean up and templatize boot binaries

2024-03-26 Thread Michael Walle
Hi, On Fri Mar 22, 2024 at 2:10 PM CET, Neha Malcom Francis wrote: > Clean up templatized boot binaries for all K3 boards. This includes > modifying the k3-binman.dtsi to use SPL_BOARD_DTB, BOARD_DESCRIPTION and > UBOOT_BOARD_DESCRIPTION from the files that include it to further reuse > code. > >

[PATCH] tools: binman: ti_board_cfg: improve error message

2024-03-26 Thread Michael Walle
ey have to look. Signed-off-by: Michael Walle --- tools/binman/etype/ti_board_config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/binman/etype/ti_board_config.py b/tools/binman/etype/ti_board_config.py index 2c3bb8f7b56..c10d66edcb1 100644 --- a/too

Re: [PATCH] arm: dts: kirkwood: Enable upstream DT on Kirkwood boards

2024-03-22 Thread Michael Walle
rom arch/arm/dts/ directory. Thanks for taking care. > Signed-off-by: Tony Dinh Tested-by: Michael Walle # on lschlv2 lsxl should work too as it is just different in memory and cpu frequency settings. > --- > > arch/arm/dts/kirkwood-lschlv2-u-boot.dtsi | 6 -- > ar

[PATCH] board: sl28: move to OF_UPSTREAM

2024-03-06 Thread Michael Walle
this only differ in the compatible and the (human readable) model name. Signed-off-by: Michael Walle --- I'll send a patch to linux to add the var3.dts, then I'll add the correct var3 dts again. --- .../arm/dts/fsl-ls1028a-kontron-sl28-var1.dts | 59 .../arm/dts/fsl-ls1028a-kontron

Re: [PATCH] mtd: spi-nor: Clear Winbond SR3 WPS bit on boot

2024-03-06 Thread Michael Walle
Hi, On Wed Mar 6, 2024 at 3:56 AM CET, Marek Vasut wrote: > > I'd argue if one wants to use the locking at all, you have to set > > UNLOCK_ALL=n. Otherwise, the bootloader might come alone and just > > clear your locking bits again. Clearing the WPS bit there is just > > one more thing which IMHO

Re: [PATCH] mtd: spi-nor: Clear Winbond SR3 WPS bit on boot

2024-03-05 Thread Michael Walle
On Tue Mar 5, 2024 at 7:54 PM CET, Marek Vasut wrote: > On 3/5/24 5:55 PM, Michael Walle wrote: > > [...] > > >>>>>> Clearing this SR3 WPS bit fixes that problem, both in U-Boot and in > >>>>>> Linux, since Linux that is booted afterwa

Re: [PATCH] mtd: spi-nor: Clear Winbond SR3 WPS bit on boot

2024-03-05 Thread Michael Walle
On Tue Mar 5, 2024 at 5:28 PM CET, Marek Vasut wrote: > On 3/5/24 4:53 PM, Michael Walle wrote: > > On Tue Mar 5, 2024 at 4:37 PM CET, Marek Vasut wrote: > >> On 3/5/24 1:50 PM, Michael Walle wrote: > >>> On Tue Mar 5, 2024 at 1:31 PM CET, Marek Vasut wrote: > >

Re: [PATCH] mtd: spi-nor: Clear Winbond SR3 WPS bit on boot

2024-03-05 Thread Michael Walle
On Tue Mar 5, 2024 at 4:37 PM CET, Marek Vasut wrote: > On 3/5/24 1:50 PM, Michael Walle wrote: > > Hi Marek, > > Hi, > > > On Tue Mar 5, 2024 at 1:31 PM CET, Marek Vasut wrote: > >> On 3/5/24 9:55 AM, Michael Walle wrote: > >>> On Mon Mar 4, 2024 a

Re: [PATCH] mtd: spi-nor: Clear Winbond SR3 WPS bit on boot

2024-03-05 Thread Michael Walle
Hi Marek, On Tue Mar 5, 2024 at 1:31 PM CET, Marek Vasut wrote: > On 3/5/24 9:55 AM, Michael Walle wrote: > > On Mon Mar 4, 2024 at 5:16 PM CET, Marek Vasut wrote: > >> Some Winbond SPI NORs have special SR3 register which is > >> used among other things to c

Re: [PATCH] mtd: spi-nor: Clear Winbond SR3 WPS bit on boot

2024-03-05 Thread Michael Walle
[+ linux-mtd ] Hi Marek, On Mon Mar 4, 2024 at 5:16 PM CET, Marek Vasut wrote: > Some Winbond SPI NORs have special SR3 register which is > used among other things to control whether non-standard > "Individual Block/Sector Write Protection" (WPS bit) > locking scheme is activated. This non-standa

Re: [PATCH v2] boot: add support for button commands

2024-01-18 Thread Michael Walle
Using CONFIG_EXTRA_ENV_SETTINGS should be good enough to provide the fallback defaults. However, the users can still mess the things up, but again, they can do that already in many places. I disagree. In my case that is a last resort recovery. And it should work in any case. Even if the user

Re: [PATCH v2] boot: add support for button commands

2024-01-17 Thread Michael Walle
Hi, Using CONFIG_EXTRA_ENV_SETTINGS should be good enough to provide the fallback defaults. However, the users can still mess the things up, but again, they can do that already in many places. I disagree. In my case that is a last resort recovery. And it should work in any case. Even if the

Re: [PATCH v2] boot: add support for button commands

2024-01-11 Thread Michael Walle
>> This is simply awesome, but I see one possible issue -- the need to have >> proper environment variables defined for a particular board or device, >> to make the buttons work as expected.  Obviously, those environment >> variables can be absent or can become missing for numerous reasons. > > Is

Re: Adding EFI runtime support to the Arm's FF-A bus

2023-12-19 Thread Michael Walle
Hi Mark, > Any runtime device drivers for variable storage should not be in the > U-Boot runtime but live in the secure world (e.g. OP-TEE) FF-A is the > new ARM protocol for talking to the secure world and hence fits into > the picture. What if I just want a simple embedded boot stack where I

Re: Adding EFI runtime support to the Arm's FF-A bus

2023-12-19 Thread Michael Walle
Hi Heinrich, > Any runtime device drivers for variable storage should not be in the > U-Boot runtime but live in the secure world (e.g. OP-TEE) FF-A is the > new ARM protocol for talking to the secure world and hence fits into > the picture. What if I just want a simple embedded boot stack where

Re: [PATCH v1] cmd: mtd: OTP access support

2023-12-01 Thread Michael Walle
Hi, +static int do_mtd_otp_write(struct cmd_tbl *cmdtp, int flag, int argc, +    char *const argv[]) +{ .. +    printf("Caution! OTP data bits can't be erased! Continue (y/n)?\n"); Please note, that with current SPI-NOR flashes this is not true and there is usually some kind of

Re: [PATCH v1] cmd: mtd: OTP access support

2023-11-30 Thread Michael Walle
+static int do_mtd_otp_write(struct cmd_tbl *cmdtp, int flag, int argc, + char *const argv[]) +{ .. + printf("Caution! OTP data bits can't be erased! Continue (y/n)?\n"); Please note, that with current SPI-NOR flashes this is not true and there is usually some

Re: [PATCH v2 1/3] dt-bindings: mtd: fixed-partitions: Add binman compatible

2023-10-06 Thread Michael Walle
Hi, I'm still not sure why that compatible is needed. Also I'd need to change the label which might break user space apps looking for that specific name. Also, our board might have u-boot/spl or u-boot/spl/bl31/bl32, right now that's something which depends on an u-boot configuration variable

Re: [PATCH v2 1/3] dt-bindings: mtd: fixed-partitions: Add binman compatible

2023-10-05 Thread Michael Walle
Hi, >> >> Add a compatible string for binman, so we can extend fixed-partitions >> >> in various ways. >> > >> > I've been thinking at the proper way to describe the binman partitions. >> > I am wondering if we should really extend the fixed-partitions >> > schema. This description is really bas

Re: [PATCH v2 1/3] dt-bindings: mtd: fixed-partitions: Add binman compatible

2023-10-04 Thread Michael Walle
Hi, >> Add a compatible string for binman, so we can extend fixed-partitions >> in various ways. > > I've been thinking at the proper way to describe the binman partitions. > I am wondering if we should really extend the fixed-partitions > schema. This description is really basic and kind of sup

Re: [PATCH v2 1/3] dt-bindings: mtd: fixed-partitions: Add binman compatible

2023-10-04 Thread Michael Walle
Hi, >> Add a compatible string for binman, so we can extend fixed-partitions >> in various ways. > > I've been thinking at the proper way to describe the binman partitions. > I am wondering if we should really extend the fixed-partitions > schema. This description is really basic and kind of supp

Re: [PATCH] MAINTAINERS: remove Vikas Manocha

2023-08-24 Thread Michael Walle
Hi, The mails are bouncing with 550 5.1.1 User Unknown (in reply to RCPT TO command) Remove the entry and mark the ARM STM STV0991 arch as Orphan. Signed-off-by: Michael Walle Cc: Patrick Delaunay Cc: Patrice Chotard --- CCing other ST people, maybe someone want to take over instead

Re: [PATCH 0/6] Attempt to enforce standard extensions for build output

2023-08-24 Thread Michael Walle
Hi, > This series adjusts binman to enforce just 4 extensions for output > images: > >.bin >.rom >.itb >.img > > Other extensions will produce an error. With this rule observed, > buildman > can keep the required files. How does this work? I didn't get all the patches from this

[PATCH] MAINTAINERS: remove Vikas Manocha

2023-08-24 Thread Michael Walle
The mails are bouncing with 550 5.1.1 User Unknown (in reply to RCPT TO command) Remove the entry and mark the ARM STM STV0991 arch as Orphan. Signed-off-by: Michael Walle Cc: Patrick Delaunay Cc: Patrice Chotard --- CCing other ST people, maybe someone want to take over instead

Re: [PATCH 5/6] kontron_sl28: Use u-boot-update.bin instead of u-boot.update

2023-08-24 Thread Michael Walle
Am 2023-08-24 05:02, schrieb Simon Glass: A '.update' extension is not allowed anymore, so change it. Signed-off-by: Simon Glass Looks good to me, as it is just an intermediate binary. Acked-by: Michael Walle

Re: [PATCH 0/6] Attempt to enforce standard extensions for build output

2023-08-24 Thread Michael Walle
Hi, This series adjusts binman to enforce just 4 extensions for output images: .bin .rom .itb .img Other extensions will produce an error. With this rule observed, buildman can keep the required files. How does this work? I didn't get all the patches from this series, which m

Re: [PATCH v5 2/2] board: mediatek: add mt8195 demo board

2023-08-07 Thread Michael Walle
Hi, > + printf("Disabling WDT\n"); > + writel(0, 0x10007000); Please don't use magic numbers. Also, I guess this should be a real watchdog driver and u-boot will take care of disabling it if the user wants to. > + > + printf("Enabling SCP SRAM\n"); > + for (unsigned int val = 0xF

Re: [PATCH 3/4] mtd/fpga: add fpga directory to mtd (with Cyclone 10)

2023-02-21 Thread Michael Walle
If the use of MTD is restricted to passive serial, this is OK with me. Yeah, but that is not how upstream things work. You need to also think of any other use cases. These are the things I want to achieve. * transfer data using the SPI driver and not use board files. For that, the FPGA shou

Re: [PATCH 3/4] mtd/fpga: add fpga directory to mtd (with Cyclone 10)

2023-02-21 Thread Michael Walle
Sorry, I didn't follow this too closely. Do you have some pointers? I just saw your latest mail. Thanks. -michael

Re: [PATCH 3/4] mtd/fpga: add fpga directory to mtd (with Cyclone 10)

2023-02-21 Thread Michael Walle
Am 2023-02-21 11:42, schrieb Ulf Samuelsson: Den 2023-02-21 kl. 10:08, skrev Michael Walle: If it is right or wrong to use that as an MTD is a matter of opinion. I am still hoping the MTD maintainer would provide input here. I might be missing something, but what is the reasoning here, to add

Re: [PATCH 3/4] mtd/fpga: add fpga directory to mtd (with Cyclone 10)

2023-02-21 Thread Michael Walle
>> If it is right or wrong to use that as an MTD is a matter of opinion. > > I am still hoping the MTD maintainer would provide input here. I might be missing something, but what is the reasoning here, to add this to the mtd subsystem? One is saving space, but I agree with Marek, this isn't a val

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Pogoplug V4 board

2023-02-13 Thread Michael Walle
Am 2023-02-13 09:43, schrieb Stefan Roese: On 2/10/23 22:08, Tony Dinh wrote: When DM_SERIAL is enabled, the device-tree tag u-boot,dm-pre-reloc is required for this board to boot over UART with kwboot. Enable this in kirkwood-pogoplug-series-4-u-boot.dtsi. Signed-off-by: Tony Dinh Reviewed-

Re: [PATCH v1] RFC: rtc: rv8803: avoid bootloop on low voltage of button cell

2023-02-08 Thread Michael Walle
Am 2023-02-08 12:29, schrieb Oliver Graute: Am 08.02.2023 um 09:32 schrieb Michael Walle : Am 2023-02-08 08:38, schrieb Oliver Graute: if the rtc button cell is on low voltage this can result in a permanent bootloop in u-boot because V2F Register is permanent set. ### Warning: temperature

Re: [PATCH v1] RFC: rtc: rv8803: avoid bootloop on low voltage of button cell

2023-02-08 Thread Michael Walle
Am 2023-02-08 08:38, schrieb Oliver Graute: if the rtc button cell is on low voltage this can result in a permanent bootloop in u-boot because V2F Register is permanent set. ### Warning: temperature compensation has stopped ### Warning: Voltage low, data is invalid resetting ... With this patch

Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2023-02-07 Thread Michael Walle
Basically I want the following: (1) board boots with watchdog enabled (2) u-boot services watchdog (3a) booting embedded linux with booti (watchdog enabled) or (3b) booting generic OS with bootefi (watchdog disabled) The missing case is booting an embedded linux with bootefi, which would be nice

Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2023-02-07 Thread Michael Walle
Honestly, not really? Some good number of SoCs will start the watchdog in ROM and these are also the ones that don't allow you to turn it off. I hope not, that sounds really risky. How would you debug such a platform? _Every single_ custom piece of industrial (as opposed to consumer-grade)

Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2023-02-07 Thread Michael Walle
>>> Honestly, not really? Some good number of SoCs will start the watchdog >>> in ROM and these are also the ones that don't allow you to turn it off. >> >> I hope not, that sounds really risky. How would you debug such a platform? > > _Every single_ custom piece of industrial (as opposed to consu

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-02-01 Thread Michael Walle
> When DM_SERIAL is enabled, the device-tree property dm-pre-reloc is > required to boot over UART with kwboot. Enable this in a Kirkwood > common u-boot dtsi. My (dev) board unfortunately, have a bootloader which can't boot over serial. This is feature of Marvell BootROM and does not require a

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-01-31 Thread Michael Walle
Hi Tony, Am 2023-02-01 02:11, schrieb Tony Dinh: When DM_SERIAL is enabled, the device-tree property dm-pre-reloc is required to boot over UART with kwboot. Enable this in a Kirkwood common u-boot dtsi. My (dev) board unfortunately, have a bootloader which can't boot over serial. Could you ela

Re: [PATCH 2/3] pinctrl: get rid of some ifdeffery

2023-01-18 Thread Michael Walle
Am 2023-01-18 14:08, schrieb Marek Vasut: On 1/18/23 13:43, Michael Walle wrote: Am 2023-01-18 13:18, schrieb Marek Vasut: On 1/18/23 13:12, Michael Walle wrote: [...] @@ -411,12 +405,11 @@ static int __maybe_unused pinctrl_post_bind(struct udevice *dev)   }     /* - * If

Re: [PATCH 2/3] pinctrl: get rid of some ifdeffery

2023-01-18 Thread Michael Walle
Am 2023-01-18 13:18, schrieb Marek Vasut: On 1/18/23 13:12, Michael Walle wrote: [...] @@ -411,12 +405,11 @@ static int __maybe_unused pinctrl_post_bind(struct udevice *dev) } /* - * If set_state callback is set, we assume this pinctrl driver is the - * full implementation

[PATCH 3/3] pinctrl: fix docstring

2023-01-18 Thread Michael Walle
Fix the copy and paste error. Signed-off-by: Michael Walle --- drivers/pinctrl/pinctrl-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-uclass.c b/drivers/pinctrl/pinctrl-uclass.c index e6cd0889b0..23a1504716 100644 --- a/drivers/pinctrl

[PATCH 2/3] pinctrl: get rid of some ifdeffery

2023-01-18 Thread Michael Walle
Don't define an empty version for pinconfig_post_bind(). Just guard the call and let the linker garbage collection do the rest. This way, we also don't have to do any guesswork. Signed-off-by: Michael Walle --- drivers/pinctrl/pinctrl-uclass.c | 17 + 1 file

  1   2   3   4   5   6   7   8   9   10   >