Hi Simon,
Simon Glass writes:
> On Thu, 12 Oct 2023 at 20:06, Maxim Cournoyer
> wrote:
>>
>> A Change-Id can be useful for traceability purposes, and some projects
>> may wish to have them preserved. This change makes it configurable
>> via a new 'keep_chan
A Change-Id can be useful for traceability purposes, and some projects
may wish to have them preserved. This change makes it configurable
via a new 'keep_change_id' setting.
Signed-off-by: Maxim Cournoyer
---
Changes in v2:
- Add missing argument to send parser
- Correctly
A Change-Id can be useful for traceability purposes, and some projects
may wish to have them preserved. This change makes it configurable
via a new 'keep_change_id' setting.
Signed-off-by: Maxim Cournoyer
---
tools/patman/control.py | 9 +++--
tools/patman/patchstream.p
There is no "run_patman" procedure in patman's __main__.py file, which
would cause the following error at execution:
"AttributeError: module 'patman.__main__' has no attribute 'run_patman'"
Signed-off-by: Maxim Cournoyer
---
tools/patman/pypro
When building from source, setuptools would complain about not finding
package via its auto-discovery mechanism. Manually specify how to
locate the files, relative to the package's directory.
* tools/u_boot_pylib/pyproject.toml: New tool.setuptools.packages.find
section.
Signed-off-by:
* tools/u_boot_pylib/pyproject.toml (readme): Replace README.md with
README.rst.
Signed-off-by: Maxim Cournoyer
---
tools/u_boot_pylib/pyproject.toml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/u_boot_pylib/pyproject.toml
b/tools/u_boot_pylib/pyproject.toml
index
The extra python inputs are only needed for running the u-boot-test-tools test
suite. This lowers the requirements for cross-building the various u-boot
packages.
* gnu/packages/bootloaders.scm (u-boot) [native-inputs]: Delete bc.
Move python-coverage, python-pycryptodomex and python-pytest to...
Hi Sjoerd,
- Original Message -
> From: "Sjoerd Simons"
> To: "Simon Glass" , "Maxim Cournoyer"
>
> Cc: "Maxim Cournoyer" , "U-Boot Mailing
> List"
> Sent: Friday, January 13, 2023 5:19:39 AM
> Subject: Re: [PATCH
This makes it possible to run the patman test suite simply by invoking
'pytest' from the patman sub-directory:
$ cd tools/patman
$ pytest
Otherwise, the top level .checkpatch.conf would be ignored and
multiple test_checkpatch.py tests would fail.
Signed-off-by: Maxim
This reverts commit 648d8186dd7f9c444fb07f355090d275dcdd4de4, because
it broke usage of patman on Linux, whose check script doesn't know
about '--strict' or '--u-boot'.
Reported-by: Sjoerd Simons
Signed-off-by: Maxim Cournoyer
---
tools/patman/checkpatch.py | 2 +-
1
Hi,
- Original Message -
> From: "Tony Dinh"
> To: "Simon Glass" , "Maxim Cournoyer"
> , "U-Boot Mailing List"
>
> Cc: "Stefan Roese"
> Sent: Thursday, January 12, 2023 7:07:20 PM
> Subject: patman: ModuleNotFou
Hi Simon,
Simon Glass writes:
> On Mon, 19 Dec 2022 at 22:38, Maxim Cournoyer
> wrote:
>>
>> This enables versioning a project specific patman configuration file.
>> It also makes it possible to declare the project name, which is not a
>> useful thing to do in
This enables versioning a project specific patman configuration file.
It also makes it possible to declare the project name, which is not a
useful thing to do in $HOME/.patman. A new test is added, along
updated documentation.
Signed-off-by: Maxim Cournoyer
---
Changes in v5:
- Use try/finally
Rationale: if the user explicitly provide this argument, they probably
intend for it to be used.
Signed-off-by: Maxim Cournoyer
---
(no changes since v1)
tools/patman/settings.py | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/patman/settings.py b/tools/patman
This better matches Python conventions, allowing to easily test
whether the optional argument is provided.
Signed-off-by: Maxim Cournoyer
---
(no changes since v1)
tools/patman/__main__.py | 2 +-
tools/patman/settings.py | 9 +
2 files changed, 6 insertions(+), 5 deletions(-)
diff
Instead of propagating it from the module entry point (main script).
Signed-off-by: Maxim Cournoyer
---
(no changes since v1)
tools/patman/__main__.py | 3 +--
tools/patman/settings.py | 8 +---
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/tools/patman/__main__.py b
The SafeConfigParser class has been renamed in Python 3.2 to
ConfigParser, and the old alias has been deprecated since.
Signed-off-by: Maxim Cournoyer
---
(no changes since v1)
tools/patman/settings.py | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff
Remove extraneous imports, variables and comply to PEP 8 maximum line
width, among other PEP 8 changes suggested by Pyflake.
Signed-off-by: Maxim Cournoyer
---
(no changes since v1)
tools/patman/settings.py | 38 +-
1 file changed, 21 insertions(+), 17
an empty args list to parse_known_args in test
Maxim Cournoyer (6):
patman: fix pep8 warnings in settings module
patman: replace deprecated SafeConfigParser with ConfigParser
patman: import gitutil module where it is needed
patman: set the default config_fname argument value to None
pat
Hi Simon,
Simon Glass writes:
> Hi Maxim,
>
> On Mon, 19 Dec 2022 at 15:12, Maxim Cournoyer
> wrote:
>>
>> This makes it possible to configure a project to use some other
>> location or script than the default scripts/get_maintainer.pl one
>> used in the
-by: Maxim Cournoyer
---
Changes in v2:
- Add functional test
- Fix 'os.path.exist' typo in 'find_get_maintainer'
tools/patman/__main__.py | 7 +
tools/patman/control.py| 12 ---
tools/patman/func_test.py | 49 +++
Hi Simon,
Simon Glass writes:
> Hi Maxim,
>
> On Mon, 19 Dec 2022 at 08:50, Maxim Cournoyer
> wrote:
>>
>> This enables versioning a project specific patman configuration file.
>> It also makes it possible to declare the the project name is,
>> which
This enables versioning a project specific patman configuration file.
It also makes it possible to declare the project name, which is not a
useful thing to do in $HOME/.patman. A new test is added, along
updated documentation.
Signed-off-by: Maxim Cournoyer
---
Changes in v4:
- Use tools.run
Rationale: if the user explicitly provide this argument, they probably
intend for it to be used.
Signed-off-by: Maxim Cournoyer
---
(no changes since v1)
tools/patman/settings.py | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/patman/settings.py b/tools/patman
This better matches Python conventions, allowing to easily test
whether the optional argument is provided.
Signed-off-by: Maxim Cournoyer
---
(no changes since v1)
tools/patman/__main__.py | 2 +-
tools/patman/settings.py | 9 +
2 files changed, 6 insertions(+), 5 deletions(-)
diff
Instead of propagating it from the module entry point (main script).
Signed-off-by: Maxim Cournoyer
---
(no changes since v1)
tools/patman/__main__.py | 3 +--
tools/patman/settings.py | 8 +---
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/tools/patman/__main__.py b
The SafeConfigParser class has been renamed in Python 3.2 to
ConfigParser, and the old alias has been deprecated since.
Signed-off-by: Maxim Cournoyer
---
(no changes since v1)
tools/patman/settings.py | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff
Remove extraneous imports, variables and comply to PEP 8 maximum line
width, among other PEP 8 changes suggested by Pyflake.
Signed-off-by: Maxim Cournoyer
---
(no changes since v1)
tools/patman/settings.py | 38 +-
1 file changed, 21 insertions(+), 17
es in v4:
- Use tools.run to invoke git in test suite
Changes in v3:
- Clear command line arguments in test_git_local_config
- Also test overriding a 'send' command line argument
Changes in v2:
- Explicitly provide an empty args list to parse_known_args in test
Maxim Cournoyer (6):
patman
Document that this command is the default and what it's intended for.
Reviewed-by: Simon Glass
Signed-off-by: Maxim Cournoyer
---
(no changes since v1)
tools/patman/__main__.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/patman/__main__.py b/tools/p
Pytest offers useful features such as selecting tests by means of a
regular expression, or running the pdb debugger upon encountering a
test failure.
Reviewed-by: Simon Glass
Signed-off-by: Maxim Cournoyer
---
(no changes since v1)
tools/patman/patman.rst | 6 ++
1 file changed, 6
Some tests would fail when the test data is not available, so it
doesn't make much sense to expose the action when patman is running
outside of the u-boot git checkout.
Reviewed-by: Simon Glass
Signed-off-by: Maxim Cournoyer
---
Changes in v3:
- Mention the test command is hidden unles
This allows running the package as a Python module, like e.g.:
$ python -m patman
It also prevents Pytest from attempting to parse main.py, which
would cause errors.
Reviewed-by: Simon Glass
Signed-off-by: Maxim Cournoyer
---
(no changes since v1)
tools/patman/{main.py => __main__
With this change, a user can run the patman test suite using Pytest
the same as when using 'patman test':
$ cd tools/patman && pytest
[...]
44 passed, 8 warnings in 8.87s
$ ./patman test
Ran 44 tests in 8.460s
Reviewed-by: Simon Glass
Signed-off-b
always invoking the checkpatch.pl script with the minimally required
arguments for the test suite to pass.
Reviewed-by: Simon Glass
Signed-off-by: Maxim Cournoyer
---
Changes in v3:
- Fix typo in commit message
Changes in v2:
- Reword the commit message with a better explanation of the problem
Previously it would rely on the executing script location, which could
break for example when running the tests via 'pytest'.
Reviewed-by: Simon Glass
Signed-off-by: Maxim Cournoyer
---
(no changes since v1)
tools/patman/func_test.py | 8 ++--
1 file changed, 6 insertions(+), 2
This patch fixes all the PEP 8 warnings reported by Pyflake for the
gitutil module.
Reviewed-by: Simon Glass
Signed-off-by: Maxim Cournoyer
---
(no changes since v1)
tools/patman/gitutil.py | 106
1 file changed, 65 insertions(+), 41 deletions
This makes it possible to configure a project to use some other
location or script than the default scripts/get_maintainer.pl one
used in the U-Boot and Linux projects. It can be configured via a
.patman configuration file and accepts arguments, as documented.
Signed-off-by: Maxim Cournoyer
This enables versioning a project specific patman configuration file.
It also makes it possible to declare the project name, which is not a
useful thing to do in $HOME/.patman. A new test is added, along
updated documentation.
Signed-off-by: Maxim Cournoyer
---
Changes in v3:
- Clear command
This enables versioning a project specific patman configuration file.
It also makes it possible to declare the project name, which is not a
useful thing to do in $HOME/.patman. A new test is added, along
updated documentation.
Signed-off-by: Maxim Cournoyer
---
Changes in v2:
- Explicitly
v2:
- Explicitly provide an empty args list to parse_known_args in test
Maxim Cournoyer (1):
patman: additionally honor a local .patman config file
tools/patman/patman.rst | 8 ++-
tools/patman/settings.py | 24 +++
tools/patman/test_settings.py | 43 ++
This enables versioning a project specific patman configuration file.
It also makes it possible to declare the the project name is,
which is not a useful thing to do in $HOME/.patman. A new test is
added, along updated documentation.
Signed-off-by: Maxim Cournoyer
---
tools/patman/patman.rst
Rationale: if the user explicitly provide this argument, they probably
intend for it to be used.
Signed-off-by: Maxim Cournoyer
---
tools/patman/settings.py | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/patman/settings.py b/tools/patman/settings.py
index
This better matches Python conventions, allowing to easily test
whether the optional argument is provided.
Signed-off-by: Maxim Cournoyer
---
tools/patman/__main__.py | 2 +-
tools/patman/settings.py | 9 +
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/tools/patman
Instead of propagating it from the module entry point (main script).
Signed-off-by: Maxim Cournoyer
---
tools/patman/__main__.py | 3 +--
tools/patman/settings.py | 8 +---
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/tools/patman/__main__.py b/tools/patman/__main__.py
The SafeConfigParser class has been renamed in Python 3.2 to
ConfigParser, and the old alias has been deprecated since.
Signed-off-by: Maxim Cournoyer
---
tools/patman/settings.py | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/tools/patman
Remove extraneous imports, variables and comply to PEP 8 maximum line
width, among other PEP 8 changes suggested by Pyflake.
Signed-off-by: Maxim Cournoyer
---
tools/patman/settings.py | 38 +-
1 file changed, 21 insertions(+), 17 deletions(-)
diff --git a
This series is based on top of series #45. It adds support for a
.patman config file local to the git repository. A new test
'test_settings.py' test module is added; it is automatically
discovered and run via pytest, e.g.: 'cd tools/patman && pytest'.
Maxim
Document that this command is the default and what it's intended for.
Signed-off-by: Maxim Cournoyer
---
(no changes since v1)
tools/patman/__main__.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/patman/__main__.py b/tools/patman/__main__.py
index 82cef
Pytest offers useful features such as selecting tests by means of a
regular expression, or running the pdb debugger upon encountering a
test failure.
Signed-off-by: Maxim Cournoyer
---
(no changes since v1)
tools/patman/patman.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a
With this change, a user can run the patman test suite using Pytest
the same as when using 'patman test':
$ cd tools/patman && pytest
[...]
44 passed, 8 warnings in 8.87s
$ ./patman test
Ran 44 tests in 8.460s
Signed-off-by: Maxim Cournoyer
---
(n
Some tests would fail when the test data is not available, so it
doesn't make much sense to expose the action when patman is running
outside of the u-boot git checkout.
Signed-off-by: Maxim Cournoyer
---
(no changes since v1)
tools/patman/__main__.py | 9 ++---
1 file chang
This allows running the package as a Python module, like e.g.:
$ python -m patman
It also prevents Pytest from attempting to parse main.py, which
would cause errors.
Signed-off-by: Maxim Cournoyer
---
(no changes since v1)
tools/patman/{main.py => __main__.py} | 0
tools/patman/pat
always invoking the checkpatch.pl script with the minimally required
arguments for the test suite to pass.
Signed-off-by: Maxim Cournoyer
---
Changes in v2:
- Reword the commit message with a better explanation of the problem
- Add the '--strict' argument to script invocation
tools/patma
Previously it would rely on the executing script location, which could
break for example when running the tests via 'pytest'.
Signed-off-by: Maxim Cournoyer
---
(no changes since v1)
tools/patman/func_test.py | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --g
This patch fixes all the PEP 8 warnings reported by Pyflake for the
gitutil module.
Signed-off-by: Maxim Cournoyer
---
(no changes since v1)
tools/patman/gitutil.py | 106
1 file changed, 65 insertions(+), 41 deletions(-)
diff --git a/tools/patman
.
Signed-off-by: Maxim Cournoyer
---
Changes in v3:
- Adjust texinfo target and direntry names, description in doc/conf.py
- Equally adjust the man page name, for consistency
Changes in v2:
- Do not invoke nonexistent 'sphinx-pre-install' script
Makefile | 2 +-
doc/Makefile
Document that this command is the default and what it's intended for.
Signed-off-by: Maxim Cournoyer
---
tools/patman/__main__.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/patman/__main__.py b/tools/patman/__main__.py
index 82cef4fc0b..11f19281fb 100755
With this change, a user can run the patman test suite using Pytest
the same as when using 'patman test':
$ cd tools/patman && pytest
[...]
44 passed, 8 warnings in 8.87s
$ ./patman test
Ran 44 tests in 8.460s
Signed-off-by: Maxim Cournoyer
---
tools/pat
Some tests would fail when the test data is not available, so it
doesn't make much sense to expose the action when patman is running
outside of the u-boot git checkout.
Signed-off-by: Maxim Cournoyer
---
tools/patman/__main__.py | 9 ++---
1 file changed, 6 insertions(+), 3 dele
This allows running the package as a Python module, like e.g.:
$ python -m patman
It also prevents Pytest from attempting to parse main.py, which
would cause errors.
Signed-off-by: Maxim Cournoyer
---
tools/patman/{main.py => __main__.py} | 0
tools/patman/patman
Pytest offers useful features such as selecting tests by means of a
regular expression, or running the pdb debugger upon encountering a
test failure.
Signed-off-by: Maxim Cournoyer
---
tools/patman/patman.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tools/patman/patman.rst b
The checkpatch.pl script indentation check now checks that lines start
with tabs an complains otherwise, so to make the test fail, start a
line with spaces. This is now also emitted as a warning rather than
as a check.
Signed-off-by: Maxim Cournoyer
---
tools/patman/test_checkpatch.py | 11
This resolves 10 out of 11 test failures seen when running
'tools/patman/patman test', which were caused by a change in the
checkpatch.pl script.
Signed-off-by: Maxim Cournoyer
---
tools/patman/checkpatch.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/to
Previously it would rely on the executing script location, which could
break for example when running the tests via 'pytest'.
Signed-off-by: Maxim Cournoyer
---
tools/patman/func_test.py | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/patman/func
This patch fixes all the PEP 8 warnings reported by Pyflake for the
gitutil module.
Signed-off-by: Maxim Cournoyer
---
tools/patman/gitutil.py | 106
1 file changed, 65 insertions(+), 41 deletions(-)
diff --git a/tools/patman/gitutil.py b/tools/patman
.
Signed-off-by: Maxim Cournoyer
---
Changes in v2:
- Do not invoke nonexistent 'sphinx-pre-install' script
Makefile | 2 +-
doc/Makefile | 10 ++
doc/media/Makefile | 3 ++-
3 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Make
Hi Heinrich,
Heinrich Schuchardt writes:
> On 12/17/22 02:51, Maxim Cournoyer wrote:
>> Sphinx supports generating Texinfo sources and Info documentation,
>> which can be navigated easily and is convenient to search (via the
>> indexed nodes or anchors, for example). This
Hi,
Heinrich Schuchardt writes:
> On 12/17/22 06:28, Julien Lepiller wrote:
>> Le 17 décembre 2022 03:09:40 GMT+01:00, Maxim Cournoyer
>> a écrit :
>>> Fix a few typos spot during a first read of the contribution process.
>>>
>>> Signed-off-by: Ma
Hi Julien,
Julien Lepiller writes:
> Le 17 décembre 2022 03:09:40 GMT+01:00, Maxim Cournoyer
> a écrit :
>>Fix a few typos spot during a first read of the contribution process.
>>
>>Signed-off-by: Maxim Cournoyer
>>---
>>
>> doc/develop/proces
.
Signed-off-by: Maxim Cournoyer
---
Makefile | 2 +-
doc/Makefile | 11 +++
doc/media/Makefile | 3 ++-
3 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index de5746399a..597a8886c3 100644
--- a/Makefile
+++ b/Makefile
@@ -2372,7 +2372,7
Fix a few typos spot during a first read of the contribution process.
Signed-off-by: Maxim Cournoyer
---
doc/develop/process.rst | 4 ++--
doc/develop/sending_patches.rst | 6 +++---
doc/develop/system_configuration.rst | 6 +++---
3 files changed, 8 insertions(+), 8
Rationale: this is more robust than assumptions about the file
hierarchy layout of the installation of patman, for example on non
file-hierarchy standard (FHS) systems such as Guix System or Nix OS.
Signed-off-by: Maxim Cournoyer
---
tools/patman/main.py | 8 +++-
1 file changed, 3
This fixes a regression introduced in commit 74df491051d6 ("buildman:
Convert documentation to rST").
Signed-off-by: Maxim Cournoyer
---
tools/patman/setup.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/patman/setup.py b/tools/patman/setup.py
index
* tools/patman/main.py: Remove extraneous imports and fix indentation.
Signed-off-by: Maxim Cournoyer
---
tools/patman/main.py | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/tools/patman/main.py b/tools/patman/main.py
index 5a7756a221..8067a288ab 100755
--- a/tools
75 matches
Mail list logo
