Re: [PATCH] Fix data abort in startup for at91 machines based on ARM926EJS

2021-03-20 Thread Martin Townsend
t save r4 to stack and restore before returning. Let's see if this solution works for you. I will wait for your v2 of the patch. Thanks ! Eugen On 3/18/21 10:31 PM, Martin Townsend wrote: > Hi Eugen, > > Pop and push gets my vote as it future proofs the code from usage of r6 > in lo

Re: [PATCH] Fix data abort in startup for at91 machines based on ARM926EJS

2021-03-18 Thread Martin Townsend
Hi Eugen, Pop and push gets my vote as it future proofs the code from usage of r6 in lowlevel_init. Let me know if you want me to respin the patch with this and test it out on my board here. Kind regards Martin Martin Townsend | Embedded Software Engineer mar...@rufilla.com<mailto:

Re: [PATCH] Fix data abort in startup for at91 machines based on ARM926EJS

2021-03-01 Thread Martin Townsend
Kind regards Martin Martin Townsend | Embedded Software Engineer mar...@rufilla.com<mailto:mar...@rufilla.com> W http://www.rufilla.com<http://www.rufilla.com/> T+44 (0)1865 601201 ABuilding D5 | Culham Science Centre | Abingdon, UK | OX14 3DB [rufilla_logo

[PATCH] Fix data abort in startup for at91 machines based on ARM926EJS

2021-02-26 Thread Martin Townsend
for at91 machines based on the same CPU uses r4 and hence corrupts it causing a data abort when it returns to the startup code. This patch fixes this by using r6 instead of r4 in the lowlevel_init function. Discovered and the fix was tested on a AT91SAM9261 based board. Signed-off-by: Martin

[U-Boot] [PATCH v2] ubi: Ensure no fastmap flush after uif_close

2018-01-18 Thread Martin Townsend
On detach UBI attempts to update fastmap after closing user interfaces but at this point UBI volumes have already been free()'ed and fastmap can no longer access these data structures. Signed-off-by: Martin Townsend Cc: h...@denx.de Cc: kmp...@infradead.org Cc: rich...@sigma-star.at --- Ch

Re: [U-Boot] [PATCH] ubi: Fix filesystem corruption on detach when fastmap enabled

2018-01-17 Thread Martin Townsend
Hi, On Wed, Jan 17, 2018 at 3:47 PM, Richard Weinberger wrote: > Martin, > > Am Dienstag, 16. Januar 2018, 15:13:04 CET schrieb Martin Townsend: >> > Martin, can you please explain what corruption you see? >> > From reading the code I'd assume that you miss vo

Re: [U-Boot] [PATCH] ubi: Fix filesystem corruption on detach when fastmap enabled

2018-01-16 Thread Martin Townsend
Hi Richard, On Tue, Jan 16, 2018 at 1:22 PM, Richard Weinberger wrote: > Heiko, Martin, > > Am Dienstag, 16. Januar 2018, 10:11:41 CET schrieb Martin Townsend: >> Ah. Must be the mail client. Sorry about that I'll setup git send-mail >> for v2. I'll wait to see

Re: [U-Boot] [PATCH] ubi: Fix filesystem corruption on detach when fastmap enabled

2018-01-16 Thread Martin Townsend
Hi, On Tue, Jan 16, 2018 at 5:43 AM, Heiko Schocher wrote: > Hello Martin, > > added Richard to cc > > > Am 15.01.2018 um 13:13 schrieb Martin Townsend: >> >> Hi Heiko, >> >> >> On Mon, Jan 15, 2018 at 11:30 AM, Heiko Schocher wrote: >>

Re: [U-Boot] [PATCH] ubi: Fix filesystem corruption on detach when fastmap enabled

2018-01-15 Thread Martin Townsend
Hi Heiko, On Mon, Jan 15, 2018 at 11:30 AM, Heiko Schocher wrote: > Hello Martin, > > > Am 12.01.2018 um 20:03 schrieb Martin Townsend: >>> >>> From d35b7ea298fbd6c9d08b1b7132d43b9289d2b914 Mon Sep 17 00:00:00 2001 >> >> From: Martin Townsend >>

[U-Boot] [PATCH] ubi: Fix filesystem corruption on detach when fastmap enabled

2018-01-13 Thread Martin Townsend
From d35b7ea298fbd6c9d08b1b7132d43b9289d2b914 Mon Sep 17 00:00:00 2001 From: Martin Townsend Date: Fri, 12 Jan 2018 18:59:23 + Subject: [PATCH] ubi: Fix filesystem corruption on detach when fastmap enabled MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding