Re: [PATCH 1/2] Raspberry Pi: Keep warnings from firmware in DT, if any

2025-02-13 Thread Matthias Brugger
undefined symbol "&nosuchdev" the warning can be read after boot: $ cat /proc/device-tree/chosen/user-warnings dterror: can't find symbol 'nosuchdev' Failed to resolve overlay 'error-example' Signed-off-by: Fiona Klute Reviewed-by: Matthias Brugger -

Re: [PATCH 05/32] lib: Provide fdtdec_get_pci_bar32() only with PCI enabled

2025-02-05 Thread Matthias Brugger
On 03/02/2025 18:41, Simon Glass wrote: This function calls dm_pci_read_bar32() which is only available if PCI is enabled. Add this condition here too, so that the EFI app can build without needing --gc-sections Signed-off-by: Simon Glass Reviewed-by: Matthias Brugger --- lib

Re: [PATCH] rpi: Add identifiers for the new RPi 5 series

2025-01-03 Thread Matthias Brugger
On 29/12/2024 15:46, Peter Robinson wrote: The Raspberry Pi foundation have released the Raspberry Pi 500, CM5 an CM5 lite devices so add the assoicated revision identifers so we can detect them. Signed-off-by: Peter Robinson Acked-by: Matthias Brugger --- board/raspberrypi/rpi/rpi.c

Re: [PATCH v2 2/2] fdt: Swap the signature for board_fdt_blob_setup()

2024-11-11 Thread Matthias Brugger
; + + return 0; } int copy_property(void *dst, void *src, char *path, char *property) For Raspberry Pi: Reviewed-by: Matthias Brugger

Re: [PATCH v1 1/1] rpi: Only add frame buffer node if CONFIG_FDT_SIMPLEFB is set

2024-10-23 Thread Matthias Brugger
On 23/10/2024 15:09, Martin Stolpe wrote: The functions fdt_simplefb_add_node and fdt_simplefb_enable_and_mem_rsv are only available if CONFIG_FDT_SIMPLEFB is enabled. Signed-off-by: Martin Stolpe Acked-by: Matthias Brugger --- board/raspberrypi/rpi/rpi.c | 12 +++- 1 file

Re: [PATCH 2/2] fdt: Swap the signature for board_fdt_blob_setup()

2024-10-23 Thread Matthias Brugger
(void *)fw_dtb_pointer; + *fdtp = (void *)fw_dtb_pointer; + + return 0; } int copy_property(void *dst, void *src, char *path, char *property) Reviewed-by: Matthias Brugger

Re: [PATCH v2] board: rpi: Pass CMA through from firmware DT

2024-10-14 Thread Matthias Brugger
ff-by: Peter Robinson Acked-by: Matthias Brugger --- v2: Update the cma string board/raspberrypi/rpi/rpi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c index ab5ea85cf9f..dd5a318d239 100644 --- a/

Re: [PATCH] board: rpi: Pass CMA through from firmware DT

2024-10-04 Thread Matthias Brugger
ff-by: Peter Robinson Acked-by: Matthias Brugger --- board/raspberrypi/rpi/rpi.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c index ab5ea85cf9f..d4dbd96bc96 100644 --- a/board/raspberrypi/rpi/rpi.c +++ b/

Re: [PATCH v4 27/35] arm: mach-bcm283x: Bring in some header files from tianocore

2024-09-19 Thread Matthias Brugger
-by: Simon Glass Cc: Matthias Brugger Cc: Peter Robinson Cc: Tom Rini Acked-by: Matthias Brugger --- .../mach-bcm283x/include/mach/acpi/bcm2711.h | 152 ++ .../mach-bcm283x/include/mach/acpi/bcm2836.h | 127 +++ .../include/mach/acpi/bcm2836_gpi

Re: [PATCH v4 26/35] arm: mach-bcm283x: Map the ARM local MMIO as well

2024-09-19 Thread Matthias Brugger
erals) for reference. TEST: Enabled CONFIG_GICV2 and accessed the GIC in C code without crash. 1: https://datasheets.raspberrypi.com/bcm2711/bcm2711-peripherals.pdf Signed-off-by: Patrick Rudolph Cc: Matthias Brugger Cc: Peter Robinson Acked-by: Matthias Brugger --- arch/arm/mach-bcm283x/

Re: [PATCH] board: rpi: Enable capsule updates

2024-09-13 Thread Matthias Brugger
27;t really understand why you are mentioning EFI HTTP. From what I can see we need efidebug to be able to do capsule updates from U-Boot command line. It is also needed for EFI HTTP boot but this needs CONFIG_EFI_HTTP_BOOT which we don't enable (and I think is out-of-scope for capsule update). /me is puzzled :) Regards, Matthias

Re: [PATCH] board: rpi: Enable capsule updates

2024-09-10 Thread Matthias Brugger
M2835=y CONFIG_CONSOLE_SCROLL_LINES=10 CONFIG_PHYS_TO_BUS=y +CONFIG_EFI_RUNTIME_UPDATE_CAPSULE=y +CONFIG_EFI_CAPSULE_FIRMWARE_RAW=y Would you mind to enable this in all corresponding configs. That would be at least: rpi_3_b_plus_defconfig, rpi_3_defconfig, rpi_arm64_defconfig. Thanks, Matthias

[PATCH] mkimage: ecdsa: add nodes to signature/key node

2024-08-29 Thread Matthias Pritschet
From: Matthias Pritschet Add the "required", "algo", and "key-name-hint" nodes to the signature/key node if ecdsa256 is used. This change is mainly copy&paste from rsa_add_verify_data which already adds these nodes. Signed-off-by: Matthias Pritschet ---

Re: [PATCH] mkimage: ecdsa: add signature/key nodes to dtb if missing

2024-08-27 Thread Matthias Pritschet
Am 27.08.24 um 20:40 schrieb Peter Robinson: On Tue, 27 Aug 2024 at 18:52, Matthias Pritschet wrote: From: Matthias Pritschet If the signature/key node(s) are not yet present in the U-Boot device tree, ecdsa_add_verify_data simply fails if it can't find the nodes. This behaviour di

[PATCH] mkimage: ecdsa: add signature/key nodes to dtb if missing

2024-08-27 Thread Matthias Pritschet
From: Matthias Pritschet If the signature/key node(s) are not yet present in the U-Boot device tree, ecdsa_add_verify_data simply fails if it can't find the nodes. This behaviour differs from rsa_add_verify_data, wich does add the missing nodes and proceeds in that case. This change is m

[PATCH] riscv: dts: jh7110: Update qspi node with upstream

2024-05-27 Thread matthias . bgg
From: Matthias Brugger Upstream node uses a specific SoC compatible to make the kernel driver work. Copy over the upstream node to fullfill that need. Signed-off-by: Matthias Brugger --- .../jh7110-starfive-visionfive-2-u-boot.dtsi | 2 +- .../dts/jh7110-starfive-visionfive-2.dtsi | 29

Re: [PATCH] Revert "arm: dts: bcm283x: Add minimal smbios information"

2024-05-27 Thread Matthias Brugger
it. Signed-off-by: Peter Robinson Acked-by: Matthias Brugger --- arch/arm/dts/bcm283x-u-boot.dtsi | 19 --- 1 file changed, 19 deletions(-) diff --git a/arch/arm/dts/bcm283x-u-boot.dtsi b/arch/arm/dts/bcm283x-u-boot.dtsi index 8c17c6f6a52..ec0f93dd850 100644 --- a/arch/arm

[PATCH 5/5] dma: ti: k3-udma: invalidate prepared buffers before pushing to recv ring

2024-04-26 Thread Matthias Schiffer
ff-by: Matthias Schiffer --- drivers/dma/ti/k3-udma.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c index 4e6f7f570c5..8f6d396653e 100644 --- a/drivers/dma/ti/k3-udma.c +++ b/drivers/dma/ti/k3-udma.c @@ -2678,6 +2678,9 @

[PATCH 4/5] dma: ti: k3-udma: add missing include

2024-04-26 Thread Matthias Schiffer
net.h is needed for PKTBUFSRX. Without this definition, the driver will always use 4 RX buffers, causing am65-cpsw-nuss initialization to fail when a higher number of buffers is requested. Signed-off-by: Matthias Schiffer --- drivers/dma/ti/k3-udma.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 3/5] net: ti: am65-cpsw-nuss: fix error handling for "RX dma add buf failed"

2024-04-26 Thread Matthias Schiffer
The RX DMA channel has been requested at this point already, so it must be freed. Signed-off-by: Matthias Schiffer --- drivers/net/ti/am65-cpsw-nuss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ti/am65-cpsw-nuss.c b/drivers/net/ti/am65-cpsw-nuss.c index

[PATCH 2/5] net: ti: am65-cpsw-nuss: avoid errors due to imbalanced start()/stop()

2024-04-26 Thread Matthias Schiffer
alted during bootm. Signed-off-by: Matthias Schiffer --- drivers/net/ti/am65-cpsw-nuss.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ti/am65-cpsw-nuss.c b/drivers/net/ti/am65-cpsw-nuss.c index b151e25d6a4..4a57e945a3a 100644 --- a/drivers/net/ti/am65-cpsw-nuss.c +++ b/dr

[PATCH 1/5] net: eth-uclass: guard against reentrant eth_init()/eth_halt() calls

2024-04-26 Thread Matthias Schiffer
gt; netconsole -> eth_init() Rather than expecting every single Ethernet driver to handle this case, prevent the reentrant calls in eth_init() and eth_halt(). The issue was noticed on an AM62x board, where a bootm after simultaneous netconsole and TFTP would result in a crash. Signed-off-by: Ma

Re: [PATCH 3/4] arm: dts: k3-*-binman.dtsi: Clean up and templatize boot binaries

2024-04-04 Thread Matthias Schiffer
; ... > > }; > > fdt-1 { > > ... > > }; > > }; > > configurations { > > conf-0 { > > ... > > }; > > conf-1 { > > ... > > }; > > }; > > }; > > }; > > > > > is not doable. It might be a bit duplicate but if I think about it but > > we are not losing out on extending the templates for multiple DTBs even > > with this design. I know it might not be what you want but I feel that > > for single DTB it's really convenient with the macro stuff and we don't > > have to override any of the other binman nodes. > > I've raised my concern about stuffing board dependent stuff into the > now generic "k3--binman.dtsi". I get it that it will work for > 90% of the boards and that it is very convenient. I'd have rather > seen a split of lets say > k3--binman.dtsi > and > k3-one-dtb-template-binman.dtsi > > All the generic stuff goes into k3-soc-binman.dtsi whereas 90% of > the boards might still use the second dtsi with some define magic. > But it seems you've already made your mind up on that :) > > -michael > My hope would be that we can get rid of board-specific binman configuration in the common case altogether for the K3 SoC families, using @fdt-SEQ etc. generator sections that will just include all FDTs configured in Kconfig.  A while ago [1], this was blocked on ti-secure signing not working with generator sections, and according to my experiments, this is still the case in U-Boot 2024.01 (and looking at the Git log, also 2024.04/master/next). Are there still plans to make this work? Are there any other blockers? Best regards, Matthias [1] https://lists.denx.de/pipermail/u-boot/2023-July/525095.html > >  

Re: [PATCH 4/7] smbios: string table always needs two terminating NUL bytes

2024-01-31 Thread Matthias Brugger
cation. > > Signed-off-by: Heinrich Schuchardt I send the very same patch some years ago [1], unfortunately it got somehow lost. Happy to see you trying to fix the same problem, so: Reviewed-by: Matthias Brugger [1] https://patchwork.ozlabs.org/project/uboot/patch/20210406090435.19357-

Re: [PATCH v3 3/3] cmd: rng: Add rng list command

2024-01-31 Thread Matthias Brugger
On Wed, Jan 31, 2024 at 02:14:26PM +, Weizhao Ouyang wrote: > The 'rng list' command probes all RNG devices and list those devices > that are successfully probed. Also update the help info. > > Reviewed-by: Heinrich Schuchardt > Signed-off-by: Weizhao Ouyang Revi

Re: [PATCH v3 2/3] driver: rng: Fix SMCCC TRNG crash

2024-01-31 Thread Matthias Brugger
Weizhao Ouyang Reviewed-by: Matthias Brugger > --- > v3: add Fixes tag > --- > drivers/rng/smccc_trng.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rng/smccc_trng.c b/drivers/rng/smccc_trng.c > index 3a4bb33941..3087cb991a 100644

[GIT PULL] rpi: updates for v2024.04

2024-01-31 Thread Matthias Brugger
e tag, although it's not the same test-run. Regards, Matthias --- The following changes since commit 6faba41927bdc8973b59678649ef83c564cc421e: Prepare v2024.04-rc1 (2024-01-29 20:53:19 -0500) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-raspberrypi

Re: [PATCH v4 0/6] rpi5: initial support

2024-01-22 Thread Matthias Brugger
_arm64: enable SDHCI BCMSTB driver In the meantime I was able to test this series. So here my: Tested-by: Matthias Brugger arch/arm/mach-bcm283x/include/mach/base.h | 5 +- arch/arm/mach-bcm283x/include/mach/mbox.h | 3 +- arch/arm/mach-bcm283x/include/mach/sdhci.h | 3 +- arch/ar

Re: [PATCH v4 4/6] bcm2835: Dynamically calculate bytes per pixel parameter

2024-01-10 Thread Matthias Brugger
. Signed-off-by: Ivan T. Ivanov Reviewed-by: Matthias Brugger --- drivers/video/bcm2835.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/video/bcm2835.c b/drivers/video/bcm2835.c index 14942526f1..63efa762db 100644 --- a/drivers/video/bcm2835.c

Re: [PATCH v3 7/7] pci: pcie-brcmstb: Add bcm2712 PCIe controller support

2023-12-22 Thread Matthias Brugger
On 18/12/2023 22:03, Ivan T. Ivanov wrote: PCIe controller have minor register map difference compared to bcm2711 variant. Handle this using device specific register offset. Signed-off-by: Ivan T. Ivanov Reviewed-by: Matthias Brugger --- drivers/pci/pcie_brcmstb.c | 23

Re: [PATCH v3 3/7] rpi5: Use devicetree to retrieve board revision

2023-12-22 Thread Matthias Brugger
revision = <0xc04170>; linux,serial = <0x6cf44e80 0x3c533ede>; }; Signed-off-by: Ivan T. Ivanov Reviewed-by: Matthias Brugger --- board/raspberrypi/rpi/rpi.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/boa

Re: [PATCH v3 2/7] rpi5: Use devicetree as alternative way to read IO base addresses

2023-12-22 Thread Matthias Brugger
On 18/12/2023 22:03, Ivan T. Ivanov wrote: From: Dmitry Malkin MBOX and Watchdog on RPi5/bcm2712 has a different base IO offsets. Find them via devicetree blob passed by bootloader. Signed-off-by: Dmitry Malkin Signed-off-by: Ivan T. Ivanov Reviewed-by: Matthias Brugger --- arch

Re: [PATCH v3 0/7] rpi5: initial support

2023-12-21 Thread Matthias Brugger
tor Up to now I wasn't able to get serial console on the normal pins 8/10. Regards Matthias -- Stefan Hopefully this will help others add missing pieces more easily. Happy hacking! Regards, Ivan [1] https://lore.kernel.org/all/CAKRNjQ0dsWozGo4n8g58m4cCEk3n=qx1r+l24wbgpo-ip1y...

Re: [PATCH v3 4/7] bcm2835: brcm,bcm2708-fb device is using r5g6b5 format

2023-12-20 Thread Matthias Brugger
find better way to handle this. Do you remember which RPi version was this? I think that was RPi1 maybe RPi2 Zero W as well. Regards, Matthias

Re: [PATCH] boot: add support for fdt_fixup command in environment

2023-12-15 Thread Matthias Schiffer
pdesk weiter. > Attention external email: Open attachments and links only if you know that > they are from a secure source and are safe. In doubt forward the email to the > IT-Helpdesk to check it. > > > On Mon, 11 Dec 2023 at 04:04, Matthias Schiffer >

[PATCH] boot: add support for fdt_fixup command in environment

2023-12-11 Thread Matthias Schiffer
a command "fdt_fixup" from the environment at the beginning of image_setup_libfdt() (after overlays are applied, and before the other fixups). Signed-off-by: Matthias Schiffer --- boot/Kconfig | 9 + boot/image-fdt.c | 19 +-- 2 files changed, 26 insert

Re: [PATCH] boards: Disable NET on platforms without NETDEVICES

2023-11-27 Thread Winker Matthias (HC-CW/ENG-PJM)
smime.p7s Description: S/MIME cryptographic signature

[PATCH] arm: mach-k3: common: fix compile warnings with PHYS_64BIT on 32bit

2023-09-27 Thread Matthias Schiffer
on gd->bd->bi_dram to fdt_fixup_memory_banks() etc., so PHYS_64BIT is needed for fixing up the upper bank). Signed-off-by: Matthias Schiffer --- arch/arm/mach-k3/common.c | 4 ++-- arch/arm/mach-k3/common.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-

[PATCH 4/5] pinctrl: single: fix compile warnings with PHYS_64BIT on 32bit

2023-09-27 Thread Matthias Schiffer
single_get_pin_muxing()). Signed-off-by: Matthias Schiffer --- Tested on x86 sandbox and TI AM62x. No new unit test failures in sandbox. drivers/pinctrl/pinctrl-single.c | 33 +--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/pinctrl/pinctrl-single.c b

[PATCH 5/5] treewide: use dev_read_addr_*_ptr() where appropriate

2023-09-27 Thread Matthias Schiffer
HYS_64BIT=y. In some places, it also fixes error handling where the return value of dev_read_addr() etc. was checked for NULL instead of FDT_ADDR_T_NONE. Signed-off-by: Matthias Schiffer --- This seems to work correctly (tested on x86 sandbox and TI AM62x; I have not tested the Tegra, Sun4i and

[PATCH 3/5] core: introduce dev_read_addr_name[_size]_ptr() functions

2023-09-27 Thread Matthias Schiffer
Same as dev_read_addr_name[_size](), but returns a pointer, cast through map_sysmem(). Signed-off-by: Matthias Schiffer --- drivers/core/fdtaddr.c | 21 + drivers/core/read.c| 21 + include/dm/fdtaddr.h | 31 +++ include

[PATCH 2/5] core: return FDT_ADDR_T_NONE from devfdt_get_addr_[size_]name() on errors

2023-09-27 Thread Matthias Schiffer
match the expectation. Signed-off-by: Matthias Schiffer --- drivers/core/fdtaddr.c | 4 ++-- include/dm/fdtaddr.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/core/fdtaddr.c b/drivers/core/fdtaddr.c index 546db675aaf..426bb762754 100644 --- a/drivers/core/fdtad

[PATCH 1/5] core: fix doc comments of dev_read_addr*() and related functions

2023-09-27 Thread Matthias Schiffer
- The dev_read_addr_name*() family of functions has no "index" argument, doc comments should refer to "name" - Specify the error return for several devfdt_get_addr*() functions Signed-off-by: Matthias Schiffer --- include/dm/fdtaddr.h | 12 ++-- include/dm/read

[PATCH] mailbox: k3-sec-proxy: fix error handling for missing scfg in FDT

2023-09-26 Thread Matthias Schiffer
The wrong field was checked. Fixes: f9aa41023bd9 ("mailbox: Introduce K3 Secure Proxy Driver") Signed-off-by: Matthias Schiffer --- drivers/mailbox/k3-sec-proxy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/k3-sec-proxy.c b/drivers/mailbox/k3-s

Re: [PATCH 1/2] Revert "lib: string: Fix strlcpy return value", fix callers

2023-08-02 Thread Matthias Schiffer
On Fri, 2023-07-14 at 13:24 +0200, Matthias Schiffer wrote: > Both the Linux kernel and libbsd agree that strlcpy() should always > return strlen(src) and not include the NUL termination. The incorrect > U-Boot implementation makes it impossible to check the return value for > tru

[PATCH 1/2] Revert "lib: string: Fix strlcpy return value", fix callers

2023-07-14 Thread Matthias Schiffer
: Fix strlcpy return value") Signed-off-by: Matthias Schiffer --- board/amlogic/vim3/vim3.c| 6 +++--- drivers/fastboot/fb_getvar.c | 2 +- lib/string.c | 14 +++--- test/lib/strlcat.c | 4 ++-- 4 files changed, 13 insertions(+), 13 deletions(-) diff --g

[PATCH 2/2] lib/charset: fix u16_strlcat() return value

2023-07-14 Thread Matthias Schiffer
strlcat returns min(strlen(dest), count)+strlen(src). Make u16_strlcat's behaviour the same for consistency. Fixes: eca08ce94ceb ("lib/charset: add u16_strlcat() function") Signed-off-by: Matthias Schiffer --- lib/charset.c | 8 test/unicode_ut.c | 8 2 f

[PATCH] video: backlight: pwm: avoid integer overflow in duty cycle calculation

2023-06-30 Thread Matthias Schiffer
The intermediate value could overflow for large periods and levels. Signed-off-by: Matthias Schiffer --- drivers/video/pwm_backlight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/pwm_backlight.c b/drivers/video/pwm_backlight.c index d7c096923b3..46c16a8f447

Re: ELCE 2023 - Prague

2023-06-19 Thread Matthias Brugger
else is coming? Cheers, Michal I'll be around as well. Regards, Matthias

Re: [PATCH v5 00/17] Basic StarFive JH7110 RISC-V SoC support

2023-05-02 Thread Matthias Brugger
On 02/05/2023 14:41, Andreas Schwab wrote: On Apr 14 2023, Matthias Brugger wrote: My opinion isIn my opinion user-friendlyness is more important then developer friendly that from an end-user point of view it's much easier to have one binary that works on all different board version

Re: [RFC] riscv: visionfive2: use OF_BOARD_SETUP

2023-04-20 Thread Matthias Brugger
Hi Torsten, On 20/04/2023 09:43, Torsten Duwe wrote: Hi Leo, thanks for the quick reply! On Thu, 20 Apr 2023 06:33:57 + Leo Liang wrote: Hi, Torsten, Matthias, On Wed, Apr 19, 2023 at 02:34:03PM +0200, Matthias Brugger wrote: On 19/04/2023 13:28, Torsten Duwe wrote: This is only

Re: [RFC] riscv: visionfive2: use OF_BOARD_SETUP

2023-04-19 Thread Matthias Brugger
pointed out by Matthias. The defconfig changes required (in diffconfig format) are -I2C n -NET_RANDOM_ETHADDR y +CMD_I2C y +CMD_MISC y +DM_I2C y +I2C_EEPROM y +MISC y +MISC_INIT_R y +OF_BOARD_SETUP y +SPL_DM_I2C n +SPL_MISC n +SYS_I2C_DW y +SYS_I2C_EEPROM_ADDR 0x0 along with the patch below. It

Re: [PATCH v5 00/17] Basic StarFive JH7110 RISC-V SoC support

2023-04-14 Thread Matthias Brugger
Just my thoughts about the issue :) Best regards, Matthias The EEPROM is being prepared and will be submitted as soon as possible. Is it necessary to incorporate EEPROM into this submission? When eeprom is supported, the MAC address will be read from eeprom. The board reversion can be read f

Re: [PATCH] rpi: Update the RPi Zero 2W DT filename

2023-03-01 Thread Matthias Brugger
On 28/02/2023 11:19, Peter Robinson wrote: Update the Raspberry Pi Zero 2W device tree file name to match what landed upstream. Signed-off-by: Peter Robinson Acked-by: Matthias Brugger Peter will you take care to push the patch? Regards, Matthias --- board/raspberrypi/rpi/rpi.c | 2

Re: [PATCH 117/171] Correct SPL uses of OF_BOARD

2023-01-31 Thread Matthias Brugger
_ENABLED(OF_CONTROL) || CONFIG_IS_ENABLED(OF_BOARD) +#if !CONFIG_IS_ENABLED(OF_CONTROL) || IS_ENABLED(CONFIG_OF_BOARD) .flags = DM_FLAG_PRE_RELOC, #endif .priv_auto = sizeof(struct pl01x_priv), For bcm283x: Reviewed-by: Matthias Brugger

[PATCH] MAINTAINERS: add RaspberryPi co-maintainer

2022-11-30 Thread matthias . bgg
From: Matthias Brugger Peter accpeted to step up as a co-maintainer for the RPis. Reflect that in the corresponding MAINTAINERS files. Signed-off-by: Matthias Brugger --- MAINTAINERS | 1 + board/raspberrypi/rpi/MAINTAINERS | 1 + 2 files changed, 2 insertions(+) diff

Re: [PATCH] ARM: mx7: psci: fix suspend/resume e10133 workaround

2022-11-08 Thread Matthias Schiffer
On Mon, 2022-09-26 at 10:31 +0200, Matthias Schiffer wrote: > The e10133 workaround was broken in two places: > > - The code intended to temporarily mask all interrupts in GPC_IMRx_CORE0. > While the old register values were saved, the actual masking was > missing. > - im

[PATCH] ARM: mx7: psci: fix suspend/resume e10133 workaround

2022-09-26 Thread Matthias Schiffer
: 57b620255e ("imx: mx7: add system suspend/resume support") Signed-off-by: Matthias Schiffer --- arch/arm/mach-imx/mx7/psci-mx7.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-imx/mx7/psci-mx7.c b/arch/arm/mach-imx/mx7/psci-mx7.c index f32945ea37..

Re: [PATCH] rpi: Set FDT for RPi CM4 to the IO Board one

2022-09-19 Thread Matthias Brugger
ule 4 IO Board", + DTB_DIR "bcm2711-rpi-cm4-io.dtb", We had that discussion in the past. It is supposed that most CM4s will be used with a custom board. I don't think it's a good idea to tie the ID of the module to a specific IO board. Regards, Matthias true, }, };

Serial console input dead after successfully booting buildroot system on rpi4

2022-06-28 Thread Matthias
Hi, after using the u-boot (v2022.01) bootloader built with rpi_4_32b_defconfig on a buildroot 2022.05 custom system, I can no longer input on the serial console connected to an FTDI adapter wired to Pins 8/10 of the RPi4 GPIO pin header. Here's what I did: * Replaced kernel=zImage by kernel=u

Re: [PATCH v2 0/7] Add video damage tracking

2022-06-10 Thread Matthias Brugger
implements VIDEO_COPY using this mechanism, reducing its overhead compared to before as well. So even x86 systems should be faster with this now :). Series tested on RPi4, thanks a lot! Tested-by: Matthias Brugger Alternatives considered: 1) Lazy sync - Sandbox does this. It only calls

Re: Vulnerability Disclosure in net/

2022-05-26 Thread Matthias Brugger
Could you keep me in CC on any patch you have for this? Thanks a lot. Matthias

Re: Raspberry Pi won’t boot from compressed subvolume (BTRFS)

2022-05-25 Thread Matthias Brugger
ich version of U-Boot you are using and if it has any patches on top of the upstream version. Regards, Matthias FDT creation failed! resetting ... This happens even though I have CONFIG_ZSTD=y. If I do *not* enable compression (in my BTRFS mount options), it reboots normally and everything

[PATCH] doc: board: raspberrypi: Add documentation

2022-03-14 Thread matthias . bgg
From: Matthias Brugger Add documentation about the different configuration files for the RaspberryPi board family. Signed-off-by: Matthias Brugger --- doc/board/raspberrypi/index.rst | 10 + doc/board/raspberrypi/raspberrypi.rst | 53 +++ 2 files changed, 63

Re: [PATCH] rpi: always set fdt_addr to the correct value

2022-02-15 Thread Matthias Brugger
On 15/02/2022 15:55, Matthias Brugger wrote: On 18/02/2022 03:44, Jaehoon Chung wrote: On 22. 2. 14. 20:25, Marek Szyprowski wrote: The fdt_addr env have meaning only for the current runtime and it depends on the dtb size or firmware version. If one save the environment to disk and the

Re: [PATCH] rpi: always set fdt_addr to the correct value

2022-02-15 Thread Matthias Brugger
discussion where we left it the last time you submitted the patch? Thanks! :) Regards, Matthias Best Regards, Jaehoon Chung --- board/raspberrypi/rpi/rpi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/rpi.c index bc3cc597adb

[PATCH] common: fdt_support: add support for "partitions" subnode to fdt_fixup_mtdparts()

2022-02-03 Thread Matthias Schiffer
practices can be fixed up. Signed-off-by: Matthias Schiffer --- common/fdt_support.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/common/fdt_support.c b/common/fdt_support.c index daa24d4c10..ea18ea3f04 100644 --- a/common/fdt_support.c +++ b/common/fdt_support.c

Re: [PATCH] fastboot: only look up real partition names when no alias exists

2022-01-26 Thread Matthias Schiffer
On Fri, 2021-12-17 at 18:20 -0500, Sean Anderson wrote: > Hi Matthias, > > On 12/16/21 5:26 AM, Matthias Schiffer wrote: > > Having U-Boot look up the passed partition name even though an > > alias > > exists is unexpected, leading to warning messages (when the alias &g

Re: [PATCH 13/14] video: Convert CONFIG_VIDEO_BCM2835 to Kconfig

2022-01-24 Thread Matthias Brugger
On 23/01/2022 15:04, Simon Glass wrote: This converts the following to Kconfig: CONFIG_VIDEO_BCM2835 This is the final ad-hoc CONFIG_VIDEO_... to convert. Signed-off-by: Simon Glass Acked-by: Matthias Brugger --- configs/rpi_0_w_defconfig | 1 + configs/rpi_2_defconfig

Re: [PATCH] socfpga: enable EFI partition support for de0-nano-soc

2022-01-19 Thread Matthias Brugger
Hi Simon, On 28/10/2021 08:52, Matthias Brugger wrote: On 22/10/2021 19:59, Frank Kunz wrote: This fixes boot problems with distributions that use EFI boot like opensuse. Signed-off-by: Frank Kunz Reviewed-by: Matthias Brugger I can see that this patched got delegated to you in

[PATCH] fastboot: only look up real partition names when no alias exists

2021-12-16 Thread Matthias Schiffer
ly if no alias of the same name exists, allowing to use aliases to override the configuration for existing partition names. Also change one use of strcpy() to strlcpy(). Signed-off-by: Matthias Schiffer --- drivers/fastboot/fb_mmc.c | 29 - 1 file changed, 12 inser

[GIT PULL] rpi: updates for v2022.01

2021-12-15 Thread Matthias Brugger
Hi Tom, Here come a small set of patches for v2022.01 for the RaspberryPi. You can find the passing tests here: https://source.denx.de/u-boot/custodians/u-boot-raspberrypi/-/pipelines/10047 It's the same commit ID as the tag, although it's not the same test-run. Regards, Matthias

Re: [PATCH] Fix MMC numbering issue for Raspberry Pi 3

2021-11-30 Thread Matthias Brugger
On Thu, Oct 28, 2021 at 09:44:09AM +0200, Emmanuel Vadot wrote: > On Wed, 27 Oct 2021 22:26:15 + > kar...@freebsd.org wrote: > > > From: Mike Karels > > > > Using mmc.dtbo from rpi-firmware to switch the controller for the SD > > card slot from sdhci to sdhost causes the numbering to change;

Re: [PATCH 2/2] rpi: Add identifier for the new RPi Zero 2 W

2021-11-30 Thread Matthias Brugger
On Sun, Nov 21, 2021 at 05:03:46PM +, Peter Robinson wrote: > The Raspberry Pi Foundation released the new Zero 2 W which we > want to detect, so we can detect the correct device tree file name. > > Signed-off-by: Peter Robinson Applied to rpi-next Thanks! > --- > board/raspberrypi/rpi/rp

Re: [PATCH 1/2] rpi: Update the Raspberry Pi doucmentation URL

2021-11-30 Thread Matthias Brugger
On Sun, Nov 21, 2021 at 05:03:45PM +, Peter Robinson wrote: > The Raspberry Pi Foundation has updated their documentation so update > the URL to the latest place to find the HW device revision codes. > > Signed-off-by: Peter Robinson Applied to rpi-next Thanks! > --- > board/raspberrypi/r

Re: [RESEND PATCH] rpi: Copy properties from firmware dtb to the loaded dtb

2021-11-26 Thread Matthias Brugger
first place? Wouldn't that fix all the problems you have? Regards, Matthias Signed-off-by: Sjoerd Simons --- board/raspberrypi/rpi/rpi.c | 48 + 1 file changed, 48 insertions(+) diff --git a/board/raspberrypi/rpi/rpi.c b/board/raspberrypi/rpi/r

Re: [PATCH 3/7] common: rename functions lcd_dt_simplefb to fdt_simplefb

2021-11-15 Thread Matthias Brugger
On 15/11/2021 16:32, Patrick Delaunay wrote: Rename the function named lcd_dt_simplefb* to fdt_simplefb* to be aligned with the associated file name fdt_simplefb.h/fdt_simplefb.c Signed-off-by: Patrick Delaunay Reviewed-by: Matthias Brugger --- board/raspberrypi/rpi/rpi.c | 2

Re: [PATCH 1/7] Convert CONFIG_LCD_DT_SIMPLEFB to Kconfig

2021-11-15 Thread Matthias Brugger
: Matthias Brugger --- common/Kconfig | 9 + common/Makefile| 2 +- configs/rpi_0_w_defconfig | 1 + configs/rpi_2_defconfig| 1 + configs/rpi_3_32b_defconfig| 1 + configs/rpi_3_b_plus_defconfig | 1 + configs/rpi_3_defconfig

Simultaneous support of CONFIG_MX6UL and CONFIG_MX6ULL

2021-11-08 Thread Matthias Schiffer
or GPIO5 differ (and none of the differing definitions are used at all) I can propose patches for these changes if you think that it is a good idea. Kind regards, Matthias

Re: [PATCH 4/7] common: board_r: drop initr_addr_map wrapper

2021-11-03 Thread Matthias Brugger
, BCM2711_RPI4_PCIE_XHCI_MMIO_PHYS, For the bcm283x part: Reviewed-by: Matthias Brugger

[PATCH 2/2] board: tq: fix spelling of "TQ-Systems"

2021-11-02 Thread Matthias Schiffer
"TQ-Systems" is written with a dash. Signed-off-by: Matthias Schiffer --- arch/arm/mach-imx/mx6/Kconfig | 2 +- board/tq/tqma6/MAINTAINERS| 2 +- board/tq/tqma6/README | 6 +++--- board/tq/tqma6/tqma6.c| 2 +- board/tq/tqma6/tqma6_bb.h | 2 +- board/tq/tqma6/tq

[PATCH 1/2] board: rename "tqc" vendor to "tq"

2021-11-02 Thread Matthias Schiffer
The subdivision name "TQ Components" hasn't been in use for a long time. Rename the vendor directory to "tq", which also matches our Device Tree vendor prefix. Signed-off-by: Matthias Schiffer --- Take care of the renaming first, in preparation for a larger round

Re: [PATCH v4 1/4] tools: Separate image types which depend on OpenSSL

2021-10-28 Thread Matthias Brugger
ary but those are not part of our u-boot-tools package. For that package we use sandbox_defconfig to only build the tools. So we are using openSSL in our packaging. AFAIK that's not an issue for us. Regards, Matthias

Re: [PATCH] socfpga: enable EFI partition support for de0-nano-soc

2021-10-27 Thread Matthias Brugger
On 22/10/2021 19:59, Frank Kunz wrote: This fixes boot problems with distributions that use EFI boot like opensuse. Signed-off-by: Frank Kunz Reviewed-by: Matthias Brugger --- configs/socfpga_de0_nano_soc_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [ANN] U-Boot v2021.10 released

2021-10-05 Thread Matthias Brugger
I wasn't able to find any commits from Novell email addresses. I wonder if SUSE still maps to Novell, which would be a long-time oversight :) Are the script to generate this email available somewhere? Regards, Matthias

Re: [PATCH] rpi: always set fdt_addr with firmware-provided FDT address

2021-09-29 Thread Matthias Brugger
On 29/09/2021 23:05, Ricardo Salveti wrote: On Wed, Sep 29, 2021 at 1:49 PM Matthias Brugger wrote: On 29/09/2021 14:19, Mauro Salvini wrote: Hi Matthias, On 29/09/21 13:41, Matthias Brugger wrote: Hi Mauro, On 29/09/2021 12:14, Mauro Salvini wrote: Hi Matthias On 15/09/21 13:16

Re: [PATCH] rpi: always set fdt_addr with firmware-provided FDT address

2021-09-29 Thread Matthias Brugger
On 29/09/2021 14:19, Mauro Salvini wrote: Hi Matthias, On 29/09/21 13:41, Matthias Brugger wrote: Hi Mauro, On 29/09/2021 12:14, Mauro Salvini wrote: Hi Matthias On 15/09/21 13:16, mbrugger at suse.com (Matthias Brugger) wrote: Hi Mauro, On 07/06/2021 11:27, Mauro Salvini wrote: On 12

[GIT PULL] rpi: updates for v2021.10 second round

2021-09-29 Thread Matthias Brugger
know. Regards, Matthias --- The following changes since commit 0b9bcf665cd98fe9db0956c894006b250a7d465f: Prepare v2021.10-rc5 (2021-09-27 09:34:20 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-raspberrypi.git/ tags/rpi-next-2021.10.2 for you to

Re: [PATCH] rpi: always set fdt_addr with firmware-provided FDT address

2021-09-29 Thread Matthias Brugger
Hi Mauro, On 29/09/2021 12:14, Mauro Salvini wrote: Hi Matthias On 15/09/21 13:16, mbrugger at suse.com (Matthias Brugger) wrote: Hi Mauro, On 07/06/2021 11:27, Mauro Salvini wrote: On 12/05/21 14:39, Mauro Salvini wrote: Raspberry firmware prepares the FDT blob in memory at an address

Re: [PATCH] fastboot: fix partition name truncation in environment lookup

2021-09-28 Thread Matthias Schiffer
On Fri, 2021-07-30 at 10:04 -0400, Sean Anderson wrote: > On 7/30/21 8:23 AM, Matthias Schiffer wrote: > > strlcat() need to be passed the full buffer length. The incorrect call > > caused truncation of partition names for fastboot_raw_partition_... and > > fastboot_partition

[PATCH] imx: mx7: spl: fix CONFIG_SPL_MAX_SIZE definition

2021-09-28 Thread Matthias Schiffer
The CONFIG_SPL_MAX_SIZE definition did not account for all areas that are used by the boot ROM according to the manual, causing boot failures due to truncated SPL images when actually hitting this limit. Signed-off-by: Matthias Schiffer --- include/configs/imx7_spl.h | 20

Re: [PATCH] board: rpi: always set fdt_addr if provided by firmware

2021-09-27 Thread Matthias Brugger
Hi Oleksandr, Thanks for your patch. There was the very same patch posted already, please follow-up in that thread for any comments from your side: https://patchwork.ozlabs.org/project/uboot/patch/20210512123945.25649-1-m.salv...@koansoftware.com/ Regards, Matthias On 25/09/2021 12:22

Re: [PATCH 1/2] mmc: add helper to query max enhanced part size

2021-09-23 Thread Matthias Schiffer
On Thu, 2021-09-23 at 20:58 +0900, Jaehoon Chung wrote: > Hi, > > On 9/22/21 9:30 PM, Matthias Schiffer wrote: > > From: Markus Niebel > > > > This helper will be used later on in an extension of the mmc > > command. > > > > Signed-off-by: Markus

[PATCH 2/2] cmd/mmc: add subcommand to query max enhanced partition size

2021-09-22 Thread Matthias Schiffer
automated partitioning scripts, for example the following would convert a whole eMMC to pSLC mode: mmc maxhwpartsectors mmc hwpartition user enh 0 ${maxhwpartsectors} wrrel on complete Signed-off-by: Markus Niebel Signed-off-by: Matthias Schiffer --- The human-readable output of the com

[PATCH 1/2] mmc: add helper to query max enhanced part size

2021-09-22 Thread Matthias Schiffer
From: Markus Niebel This helper will be used later on in an extension of the mmc command. Signed-off-by: Markus Niebel Signed-off-by: Matthias Schiffer --- drivers/mmc/mmc.c | 38 ++ include/mmc.h | 1 + 2 files changed, 39 insertions(+) diff --git a

[PATCH 3/4] usb: ehci-ci: remove redundant PORTSC flag definitions

2021-09-20 Thread Matthias Schiffer
These definitions are unused, all boards that define portsc flags use the equivalent PORT_* definitions instead. Signed-off-by: Markus Niebel Signed-off-by: Matthias Schiffer --- include/usb/ehci-ci.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/include/usb/ehci-ci.h b

[PATCH 4/4] usb: ehci-mx6: use phy_type from device tree

2021-09-20 Thread Matthias Schiffer
: Matthias Schiffer --- drivers/usb/host/ehci-mx6.c | 25 +++-- include/usb/ehci-ci.h | 1 + 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host/ehci-mx6.c index c3e4170513e..1bd6147c76a 100644 --- a/drivers/usb

[PATCH 2/4] include/configs: replace MXC_EHCI_MODE_SERIAL with PORT_PTS_SERIAL

2021-09-20 Thread Matthias Schiffer
The MXC_EHCI_MODE_ definitions are redundant. Replace MXC_EHCI_MODE_SERIAL with the equivalent PORT_PTS_SERIAL. Only the zmx25 platform is affected. Signed-off-by: Markus Niebel Signed-off-by: Matthias Schiffer --- include/configs/zmx25.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 1/4] usb: add support for ULPI/SERIAL/HSIC PHY modes

2021-09-20 Thread Matthias Schiffer
Import usb_phy_interface enum values and DT match strings from the Linux kernel. Signed-off-by: Markus Niebel Signed-off-by: Matthias Schiffer --- drivers/usb/common/common.c | 3 +++ include/linux/usb/phy.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/drivers/usb/common

Re: [PATCH] arm: rpi: perform XHCI firmware upload only once

2021-09-17 Thread Matthias Brugger
On 17/09/2021 10:42, Matthias Brugger wrote: On 17/09/2021 10:19, Marek Szyprowski wrote: XHCI firmware upload must be performed only once after initializing the PCI bridge. This fixes USB stack initialization after calling "usb stop; usb start" on Raspberry Pi 4B. Signed-off

  1   2   3   4   5   6   7   8   9   10   >