Re: [PATCH v4 1/4] checkpatch: Support wide strings

2022-01-24 Thread Joe Perches
On Sun, 2022-01-23 at 13:12 -0700, Simon Glass wrote: > Hi Joe, > > On Sun, 23 Jan 2022 at 09:27, Joe Perches wrote: > > > > On Sun, 2022-01-23 at 11:19 -0500, Tom Rini wrote: > > > On Sun, Jan 23, 2022 at 08:10:37AM -0800, Joe Perches wrote: > > > >

Re: [PATCH v4 1/4] checkpatch: Support wide strings

2022-01-23 Thread Joe Perches
On Sun, 2022-01-23 at 11:19 -0500, Tom Rini wrote: > On Sun, Jan 23, 2022 at 08:10:37AM -0800, Joe Perches wrote: > > On Sun, 2022-01-23 at 09:03 -0700, Simon Glass wrote: > > > > > Do you think we > > > should try to send the U-Boot things upstream? > > &

Re: [PATCH v4 1/4] checkpatch: Support wide strings

2022-01-23 Thread Joe Perches
On Sun, 2022-01-23 at 09:03 -0700, Simon Glass wrote: > Do you think we > should try to send the U-Boot things upstream? No idea. What are the U-Boot things that could or should be generic ? https://source.denx.de/u-boot/u-boot/-/commits/master/scripts/checkpatch.pl

Re: [U-Boot] [BUG] checkpatch: false positive storage class location

2017-07-05 Thread Joe Perches
On Tue, 2017-07-04 at 23:08 +0200, Heinrich Schuchardt wrote: > On 07/04/2017 10:44 PM, Joe Perches wrote: > > On Tue, 2017-07-04 at 21:29 +0200, Heinrich Schuchardt wrote: > > > The U-Boot project uses the same scripts/checkpatch.pl as the Linux > > > kernel. I ran

Re: [U-Boot] [BUG] checkpatch: false positive storage class location

2017-07-04 Thread Joe Perches
On Tue, 2017-07-04 at 21:29 +0200, Heinrich Schuchardt wrote: > The U-Boot project uses the same scripts/checkpatch.pl as the Linux > kernel. I ran upon the problem below when working on U-Boot. But I > guess it should be fixed in the Linux upstream. > > Running checkpatch for this email produces

Re: [U-Boot] [PATCH] checkpatch.pl: Fix checkpatch.pl warnings with Perl 5.22

2015-11-30 Thread Joe Perches
On Mon, 2015-11-30 at 10:56 -0500, Tom Rini wrote: > On Mon, Nov 30, 2015 at 10:23:20AM +, Alexey Brodkin wrote: [] > > Similar fix is already in Linus' master tree, see > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/comm > > it/?id=4e5d56bdf892e18832a6540b63ebf709966bce2a >

Re: [U-Boot] [PATCH] checkpatch.pl: Fix checkpatch.pl warnings with Perl 5.22

2015-09-03 Thread Joe Perches
On Thu, 2015-09-03 at 12:25 -0700, Moritz Fischer wrote: > This patch fixes a bunch of deprecation warings that show up when using > checkpatch.pl with Perl 5.22. Thanks. I believe these are all fixed in linux-next and should be resolved when v4.3 is released. commit 09165246126819ca19b47103d283

Re: [U-Boot] [PATCH V2] checkpatch: add check for whitespace before semicolon at end-of-line

2012-05-04 Thread Joe Perches
f a bare semicolon > for empty loops: > > while (foo()) > ; > > --- > V2 adds the special case and requirement for --strict based on > recommendations of Joe Perches. > > scripts/checkpatch.pl |6 ++ > 1 files changed, 6 insertions(+),

Re: [U-Boot] [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line

2012-05-03 Thread Joe Perches
On Thu, 2012-05-03 at 06:41 -0700, Eric Nelson wrote: > >> +# check for whitespace before semicolon - not allowed at end-of-line > >> + if ($line =~ /\s+;$/) { > > > > if ($line =~ /\s+;\s*$/) > Won't the extra space at end of line be caught by other tests? Yes it will. You

Re: [U-Boot] [PATCH] checkpatch: add check for whitespace before semicolon at end-of-line

2012-05-02 Thread Joe Perches
On Wed, 2012-05-02 at 20:32 -0700, Eric Nelson wrote: > This tests for a bad habits of mine like this: > > return 0 ; > > Signed-off-by: Eric Nelson > --- > scripts/checkpatch.pl |6 ++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/scripts/checkpatch.pl b/sc

Re: [U-Boot] [RFC PATCH] checkpatch.pl: Add ability to ignore various messages

2011-08-24 Thread Joe Perches
On Wed, 2011-08-24 at 23:25 +0200, Wolfgang Denk wrote: > > > This feature would be really useful for us, but I'd rather see this in > > > mainline than starting a fork. > > A better version is in Linus' current 3.0+ as of a couple of days ago. > > It's not in 3.0. > Great. Are you planning to sub

Re: [U-Boot] [RFC PATCH] checkpatch.pl: Add ability to ignore various messages

2011-07-27 Thread Joe Perches
types. > > Add .checkpatch.conf file to store a default set of "ignore" flags > > Categorize all ERROR, WARN and CHK types with flags. > > Signed-off-by: Joe Perches > > --- > > scripts/checkpatch.pl | 456 > > +++

Re: [U-Boot] [RFC PATCH] checkpatch.pl: Add ability to ignore various messages

2011-06-09 Thread Joe Perches
On Mon, 2011-04-25 at 17:43 -0700, Joe Perches wrote: > Some users would like the ability to not emit some of the > messages that checkpatch produces. > > Add command line option to "--ignore" various message types. > Add .checkpatch.conf file to store a default set of &q

[U-Boot] [RFC PATCH] checkpatch.pl: Add ability to ignore various messages

2011-04-25 Thread Joe Perches
Some users would like the ability to not emit some of the messages that checkpatch produces. Add command line option to "--ignore" various message types. Add .checkpatch.conf file to store a default set of "ignore" flags Categorize all ERROR, WARN and CHK types with flags.

Re: [U-Boot] Expanding checkpatch for non-linux (specifically U-Boot) use

2011-04-24 Thread Joe Perches
On Mon, 2011-04-25 at 16:22 +1000, Graeme Russ wrote: > I like this - And checkpatch.pl could set the default options for 'Linux > flavour' so Linux would not need a .conf file :) > > BUT - The question still remains - Will patches for obviously non-Linux > related 'features' of checkpatch be welc

Re: [U-Boot] Expanding checkpatch for non-linux (specifically U-Boot) use

2011-04-24 Thread Joe Perches
On Mon, 2011-04-25 at 15:36 +1000, Graeme Russ wrote: > There has been a bit of discussion lately on the U-Boot mailing list > regarding the use of checkpatch for U-Boot patches (see > http://lists.denx.de/pipermail/u-boot/2011-April/090954.html) > > U-Boot uses the Linux coding style and checkpat