Re: [U-Boot] [PATCH v2 2/3] env: Tidy up some of the env code

2019-11-27 Thread James Byrne
On 27/11/2019 05:52, AKASHI Takahiro wrote: On Thu, Nov 21, 2019 at 02:32:47PM +, James Byrne wrote: This commit tidies up a few things in the env code to make it safer and easier to extend: - The hsearch_r() function took a 'struct env_entry' as its first parameter, but only use

[U-Boot] [PATCH v3] gpio: at91_gpio: Add bank names

2019-11-26 Thread James Byrne
Make the at91_gpio driver set sensible GPIO bank names in the platform data. This makes the 'gpio status' command a lot more useful. Signed-off-by: James Byrne --- Changes in v3: - Move at91_get_bank_name() into #ifdef CONFIG_DM_GPIO section. Changes in v2: - Use "undefined&

[U-Boot] [PATCH v2 3/3] env: Provide programmatic equivalent to 'setenv -f'

2019-11-21 Thread James Byrne
Add env_force_set() to provide an equivalent to 'setenv -f' that can be used programmatically. Signed-off-by: James Byrne --- Changes in v2: None cmd/nvedit.c | 17 ++--- include/env.h | 13 + 2 files changed, 27 insertions(+), 3 deletions(-) diff -

[U-Boot] [PATCH v2 1/3] tools: checkpatch: Restore 'debug' and 'printf' to logFunctions list

2019-11-21 Thread James Byrne
out getting a warning for "line over 80 characters" instead. Signed-off-by: James Byrne --- Changes in v2: None scripts/checkpatch.pl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 6fcc66afb0..c2641bc995 100755 --- a/scripts/che

[U-Boot] [PATCH v2 2/3] env: Tidy up some of the env code

2019-11-21 Thread James Byrne
nctions, do_env_remove() and do_env_update(), which can also be called from the programmatic version env_set(), meaning it no longer has to create fake command line parameters. The do_interactive_env_set() function is not required in SPL builds. - Fix some warnings identified by checkpatch.pl Signed-

Re: [U-Boot] [PATCH] env: Provide programmatic equivalent to 'setenv -f'

2019-11-20 Thread James Byrne
On 19/11/2019 21:01, Simon Goldschmidt wrote: Heinrich Schuchardt mailto:xypron.g...@gmx.de>> schrieb am Di., 19. Nov. 2019, 21:56: On 11/19/19 9:30 PM, Simon Goldschmidt wrote: > Am 19.11.2019 um 18:31 schrieb James Byrne: >> Add env_force() to provide a

[U-Boot] [PATCH] env: Provide programmatic equivalent to 'setenv -f'

2019-11-19 Thread James Byrne
Add env_force() to provide an equivalent to 'setenv -f' that can be used programmatically. Also tighten up the definition of argv in _do_env_set() so that 'const char *' pointers are used. Signed-off-by: James Byrne --- cmd/nvedit.c | 43 +---

[U-Boot] [PATCH v2] gpio: at91_gpio: Add bank names

2019-11-19 Thread James Byrne
Make the at91_gpio driver set sensible GPIO bank names in the platform data. This makes the 'gpio status' command a lot more useful. Signed-off-by: James Byrne --- Changes in v2: - Use "undefined" for an unknown bank name. drivers/gpio/at91_gpio.c | 29 +

Re: [U-Boot] [PATCH] gpio: at91_gpio: Add bank names

2019-11-19 Thread James Byrne
Hi Eugen, On 18/11/2019 08:59, eugen.hris...@microchip.com wrote: @@ -582,14 +604,15 @@ static int at91_gpio_probe(struct udevice *dev) clk_free(&clk); - uc_priv->bank_name = plat->bank_name; - uc_priv->gpio_count = GPIO_PER_BANK; - #if CONFIG_IS_ENABLED(OF_CONTROL)

[U-Boot] [PATCH] gpio: at91_gpio: Add bank names

2019-11-15 Thread James Byrne
Make the at91_gpio driver set sensible GPIO bank names in the platform data. This makes the 'gpio status' command a lot more useful. Signed-off-by: James Byrne --- drivers/gpio/at91_gpio.c | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) di

[U-Boot] [PATCH] board: Remove unnecessary inclusion of micrel.h from boards

2019-11-15 Thread James Byrne
Several boards still unnecessarily included micrel.h but no longer require it since the switch to Device Tree configuration. Signed-off-by: James Byrne --- board/atmel/sama5d3xek/sama5d3xek.c | 2 -- board/kosagi/novena/novena.c | 2 -- board/seco/mx6quq7/mx6quq7.c

[U-Boot] [PATCH] net: phy: micrel: Allow KSZ8xxx and KSZ90x1 to be used together

2019-03-06 Thread James Byrne
21 and PHY_MICREL_KSZ9031 no longer select PHY_GIGE since this is selected by PHY_MICREL_KSZ90X1. - All of the relevant defconfig files have been updated now that PHY_MICREL_KSZ8XXX does not default to 'Y'. Signed-off-by: James Byrne --- configs/alt_defconfig|

[U-Boot] [PATCH 0/2] Apply correct skew values to KSZ9021 PHYs

2019-03-04 Thread James Byrne
d was converted to use device trees. After fixing the problem that caused the skew values to be missed, I found that the wrong values got programmed, so I had to fix that as well. The following patches resolve both issues. James Byrne (2): net: phy: micrel: Use correct skew values on KSZ9021 net

[U-Boot] [PATCH 2/2] net: phy: micrel: Find Micrel PHY node correctly

2019-03-04 Thread James Byrne
cyclone5_de0_nano_soc.dts, socfpga_cyclone5_de10_nano.dts, socfpga_cyclone5_de1_soc.dts, socfpga_cyclone5_is1.dts, socfpga_cyclone5_socdk.dts, socfpga_cyclone5_sockit.dts. These should be unaffected by this change. The changes were tested on a sama5d3xcm. Signed-off-by: James Byrne --- drivers

[U-Boot] [PATCH 1/2] net: phy: micrel: Use correct skew values on KSZ9021

2019-03-04 Thread James Byrne
rs as the equivalent device trees in the Linux kernel do, where it incorrectly uses 200ps steps (since that's where all these device trees were copied from). Signed-off-by: James Byrne --- arch/arm/dts/sama5d3xcm.dtsi | 32 +-- arch/arm/dts/sama5d3xcm_c

[U-Boot] [PATCH v3] common: cli_readline: Improve command line editing

2016-08-16 Thread James Byrne
', and the 'Home' key can be 'ESC [ H', 'ESC O H', 'ESC 1 ~' or 'ESC 7 ~', depending on what terminal emulator you use and how it is configured. Signed-off-by: James Byrne Changes for v2 - Explicitly initialize variable to avoid

[U-Boot] [PATCH v2] common: cli_readline: Improve command line editing

2016-07-31 Thread James Byrne
', and the 'Home' key can be 'ESC [ H', 'ESC O H', 'ESC 1 ~' or 'ESC 7 ~', depending on what terminal emulator you use and how it is configured. Signed-off-by: James Byrne --- Changes for v2 - Explicitly initialize variable to avoid sp

[U-Boot] [PATCH] common: cli_readline: Improve command line editing

2016-06-08 Thread James Byrne
', and the 'Home' key can be 'ESC [ H', 'ESC O H', 'ESC 1 ~' or 'ESC 7 ~', depending on what terminal emulator you use and how it is configured. Signed-off-by: James Byrne --- common/cli_readline.c | 108