Re: [PATCH 1/1] Makefile: pass KEYDIR when set to sunxi-spl.bin mkimage

2025-07-01 Thread James Hilliard
On Fri, Apr 11, 2025 at 4:10 AM James Hilliard wrote: > > Currently we pass this for u-boot-spl.kwb targets, however when > building sunxi-spl.bin in the TOC0 format we may also need to > specify a KEYDIR, as such we should also pass this when set > to mkimage for the sunxi

[PATCH 1/1] Makefile: pass KEYDIR when set to sunxi-spl.bin mkimage

2025-04-11 Thread James Hilliard
Currently we pass this for u-boot-spl.kwb targets, however when building sunxi-spl.bin in the TOC0 format we may also need to specify a KEYDIR, as such we should also pass this when set to mkimage for the sunxi-spl.bin target. Signed-off-by: James Hilliard --- scripts/Makefile.xpl | 3 ++- 1

Re: [PATCH] tpm: measure DTB in PCR1 instead of PCR0

2024-06-14 Thread Eddie James
-by: Eddie James So let's switch over the DTB measurements to PCR1 which seems a better fit. [0] https://trustedcomputinggroup.org/resource/pc-client-specific-platform-firmware-profile-specification Reported-by: Heinrich Schuchardt Signed-off-by: Ilias Apalodimas --- boot/bootm.c

Re: [PATCH v2 1/1] xilinx: zynq: add FDT_FIXUP_PARTITIONS support

2024-04-02 Thread James Hilliard
On Tue, Apr 2, 2024 at 6:41 AM Michal Simek wrote: > > > > On 4/1/24 01:28, James Hilliard wrote: > > There are situations where we may want to let U-Boot modify the FDT > > nand partitions for the kernel, such as when supporting multiple > > sizes of NAND chips

[PATCH v2 1/1] xilinx: zynq: add FDT_FIXUP_PARTITIONS support

2024-03-31 Thread James Hilliard
There are situations where we may want to let U-Boot modify the FDT nand partitions for the kernel, such as when supporting multiple sizes of NAND chips. Signed-off-by: James Hilliard --- Changes v1 -> v2: - move partition fixups to board/xilinx/common/board.c --- board/xilinx/common/boar

Re: tcg2_platform_get_log failing to read address and size of memory-region via ofnode_get_addr_size

2024-03-27 Thread Eddie James
On 3/26/24 11:15, Tim Harvey wrote: On Tue, Mar 26, 2024 at 2:24 AM Ilias Apalodimas wrote: Hi Tim, On Tue, 26 Mar 2024 at 03:15, Tim Harvey wrote: Greetings, I'm unable to understand why tcg2_platform_get_log is failing to read a memory region. For example the following diffs: I am not

Re: tcg2_platform_get_log failing to read address and size of memory-region via ofnode_get_addr_size

2024-03-27 Thread Eddie James
On 3/26/24 11:15, Tim Harvey wrote: On Tue, Mar 26, 2024 at 2:24 AM Ilias Apalodimas wrote: Hi Tim, On Tue, 26 Mar 2024 at 03:15, Tim Harvey wrote: Greetings, I'm unable to understand why tcg2_platform_get_log is failing to read a memory region. For example the following diffs: I am not

Re: [PATCH 1/1] xilinx: zynq: add FDT_FIXUP_PARTITIONS support

2024-03-18 Thread James Hilliard
On Mon, Mar 18, 2024 at 5:07 AM Michal Simek wrote: > > > > On 3/18/24 09:48, James Hilliard wrote: > > On Mon, Mar 18, 2024 at 2:26 AM Michal Simek wrote: > >> > >> > >> > >> On 3/15/24 20:25, James Hilliard wrote: > >>> T

Re: [PATCH 1/1] xilinx: zynq: add FDT_FIXUP_PARTITIONS support

2024-03-18 Thread James Hilliard
On Mon, Mar 18, 2024 at 2:26 AM Michal Simek wrote: > > > > On 3/15/24 20:25, James Hilliard wrote: > > There are situations where we may want to let U-Boot modify the FDT > > please use imperative mood. > > > nand partitions for the kernel, such as when supp

[PATCH 1/1] xilinx: zynq: add FDT_FIXUP_PARTITIONS support

2024-03-15 Thread James Hilliard
so that we can add non-common functionality to each ft_board_setup like FDT_FIXUP_PARTITIONS as needed. This pattern is modeled after the one used by tdx-common.c. Signed-off-by: James Hilliard --- board/xilinx/common/board.c | 2 +- board/xilinx/common/board.h | 2 ++ board/xilinx/mbv

Re: [PATCH v14 4/8] bootm: Support boot measurement

2023-10-25 Thread Eddie James
On 10/25/23 07:41, Ilias Apalodimas wrote: On Tue, 24 Oct 2023 at 18:44, Eddie James wrote: Add a configuration option to measure the boot through the bootm function. Add the measurement state to the booti and bootz paths as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass

[PATCH v14 7/8] efi_loader: fix EFI_ENTRY point on get_active_pcr_banks

2023-10-24 Thread Eddie James
From: Ilias Apalodimas efi_tcg2_get_active_pcr_banks doesn't immediately call the EFI_ENTRY() wrapper once it enters the function. Move the call a few lines above to cover the error cases properly as well. Signed-off-by: Ilias Apalodimas --- lib/efi_loader/efi_tcg2.c | 4 ++-- 1 file changed,

[PATCH v14 1/8] tpm: Fix spelling for tpmu_ha union

2023-10-24 Thread Eddie James
tmpu -> tpmu Signed-off-by: Eddie James Reviewed-by: Ilias Apalodimas --- include/tpm-v2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/tpm-v2.h b/include/tpm-v2.h index 2b6980e441..6684033deb 100644 --- a/include/tpm-v2.h +++ b/include/tpm-v2.h @@ -16

[PATCH v14 2/8] tpm: sandbox: Update for needed TPM2 capabilities

2023-10-24 Thread Eddie James
The driver needs to support getting the PCRs in the capabilities command. Fix various other things and support the max number of PCRs for TPM2. Remove the !SANDBOX dependency for EFI TCG2 as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- Changes since

[PATCH v14 0/8] tpm: Support boot measurements

2023-10-24 Thread Eddie James
er functions to allow EFI system to use them, and remove duplicate EFI functions. - Add test case - Drop #ifdefs for bootm - Add devicetree measurement config option - Update sandbox TPM driver Eddie James (6): tpm: Fix spelling for tpmu_ha union tpm: sandbox: Update for needed TPM2 ca

[PATCH v14 6/8] doc: Add measured boot documentation

2023-10-24 Thread Eddie James
Briefly describe the feature and specify the requirements. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- Changes since v12: - Add a bit of detail about OS usage and what pieces are measured doc/usage/index.rst | 1 + doc/usage/measured_boot.rst | 31

[PATCH v14 5/8] test: Add sandbox TPM boot measurement

2023-10-24 Thread Eddie James
Use the sandbox TPM driver to measure some boot images in a unit test case. Signed-off-by: Eddie James Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- Changes since v5: - Only compile in the measurement u-boot command when CONFIG_MEASURED_BOOT is enabled. arch/sandbox/dts

[PATCH v14 4/8] bootm: Support boot measurement

2023-10-24 Thread Eddie James
Add a configuration option to measure the boot through the bootm function. Add the measurement state to the booti and bootz paths as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- Changes since v8: - Added a configuration option to select to ignore any existing event log

[PATCH v14 8/8] test: use a non system PCR for testing PCR extend

2023-10-24 Thread Eddie James
From: Ilias Apalodimas We currently use PCR 0 for testing the PCR read/extend functionality in our selftests. How ever those PCRs are defined by the TCG spec for platform use. For example if the tests run *after* the efi subsystem initialization, which extends PCRs 0 & 7 it will give a false po

[PATCH v14 3/8] tpm: Support boot measurements

2023-10-24 Thread Eddie James
Add TPM2 functions to support boot measurement. This includes starting up the TPM, initializing/appending the event log, and measuring the U-Boot version. Much of the code was used in the EFI subsystem, so remove it there and use the common functions. Signed-off-by: Eddie James --- Changes since

Re: [PATCH v13 0/8] tpm: Support boot measurements

2023-10-24 Thread Eddie James
but since this used to work on earlier versions I suspect it's going to be trivial to fix Cheers /Ilias On Thu, 19 Oct 2023 at 19:21, Eddie James wrote: This series adds support for measuring the boot images more generically than the existing EFI support. Several EFI functions have been mo

[PATCH v13 4/8] bootm: Support boot measurement

2023-10-19 Thread Eddie James
Add a configuration option to measure the boot through the bootm function. Add the measurement state to the booti and bootz paths as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- Changes since v8: - Added a configuration option to select to ignore any existing event log

[PATCH v13 8/8] test: use a non system PCR for testing PCR extend

2023-10-19 Thread Eddie James
From: Ilias Apalodimas We currently use PCR 0 for testing the PCR read/extend functionality in our selftests. How ever those PCRs are defined by the TCG spec for platform use. For example if the tests run *after* the efi subsystem initialization, which extends PCRs 0 & 7 it will give a false po

[PATCH v13 3/8] tpm: Support boot measurements

2023-10-19 Thread Eddie James
Add TPM2 functions to support boot measurement. This includes starting up the TPM, initializing/appending the event log, and measuring the U-Boot version. Much of the code was used in the EFI subsystem, so remove it there and use the common functions. Signed-off-by: Eddie James --- Changes since

[PATCH v13 6/8] doc: Add measured boot documentation

2023-10-19 Thread Eddie James
Briefly describe the feature and specify the requirements. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- Changes since v12: - Add a bit of detail about OS usage and what pieces are measured doc/usage/index.rst | 1 + doc/usage/measured_boot.rst | 31

[PATCH v13 5/8] test: Add sandbox TPM boot measurement

2023-10-19 Thread Eddie James
Use the sandbox TPM driver to measure some boot images in a unit test case. Signed-off-by: Eddie James Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- Changes since v5: - Only compile in the measurement u-boot command when CONFIG_MEASURED_BOOT is enabled. arch/sandbox/dts

[PATCH v13 7/8] efi_loader: fix EFI_ENTRY point on get_active_pcr_banks

2023-10-19 Thread Eddie James
From: Ilias Apalodimas efi_tcg2_get_active_pcr_banks doesn't immediately call the EFI_ENTRY() wrapper once it enters the function. Move the call a few lines above to cover the error cases properly as well. Signed-off-by: Ilias Apalodimas --- lib/efi_loader/efi_tcg2.c | 4 ++-- 1 file changed,

[PATCH v13 1/8] tpm: Fix spelling for tpmu_ha union

2023-10-19 Thread Eddie James
tmpu -> tpmu Signed-off-by: Eddie James Reviewed-by: Ilias Apalodimas --- include/tpm-v2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/tpm-v2.h b/include/tpm-v2.h index 2b6980e441..6684033deb 100644 --- a/include/tpm-v2.h +++ b/include/tpm-v2.h @@ -16

[PATCH v13 2/8] tpm: sandbox: Update for needed TPM2 capabilities

2023-10-19 Thread Eddie James
The driver needs to support getting the PCRs in the capabilities command. Fix various other things and support the max number of PCRs for TPM2. Remove the !SANDBOX dependency for EFI TCG2 as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- Changes since

[PATCH v13 0/8] tpm: Support boot measurements

2023-10-19 Thread Eddie James
nctions. - Add test case - Drop #ifdefs for bootm - Add devicetree measurement config option - Update sandbox TPM driver Eddie James (6): tpm: Fix spelling for tpmu_ha union tpm: sandbox: Update for needed TPM2 capabilities tpm: Support boot measurements bootm: Support boot measurement t

Re: [PATCH v12 6/8] doc: Add measured boot documentation

2023-10-19 Thread Eddie James
On 10/12/23 10:29, Simon Glass wrote: Hi Eddie, On Thu, 12 Oct 2023 at 08:08, Eddie James wrote: Briefly describe the feature and specify the requirements. Signed-off-by: Eddie James Reviewed-by: Simon Glass This could use a bit more detail. What pieces are measured? What DT binding is

Re: [PATCH v12 5/8] test: Add sandbox TPM boot measurement

2023-10-19 Thread Eddie James
On 10/13/23 12:22, Ilias Apalodimas wrote: Hi Eddie, This doesn't apply on -master, can you please rebase? Ugh I thought you wanted -next... I can rebase again. Thanks /Ilias On Thu, 12 Oct 2023 at 16:49, Eddie James wrote: Use the sandbox TPM driver to measure some boot images

[PATCH v12 4/8] bootm: Support boot measurement

2023-10-12 Thread Eddie James
Add a configuration option to measure the boot through the bootm function. Add the measurement state to the booti and bootz paths as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- Changes since v8: - Added a configuration option to select to ignore any existing event log

[PATCH v12 2/8] tpm: sandbox: Update for needed TPM2 capabilities

2023-10-12 Thread Eddie James
The driver needs to support getting the PCRs in the capabilities command. Fix various other things and support the max number of PCRs for TPM2. Remove the !SANDBOX dependency for EFI TCG2 as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- Changes since

[PATCH v12 8/8] test: use a non system PCR for testing PCR extend

2023-10-12 Thread Eddie James
From: Ilias Apalodimas We currently use PCR 0 for testing the PCR read/extend functionality in our selftests. How ever those PCRs are defined by the TCG spec for platform use. For example if the tests run *after* the efi subsystem initialization, which extends PCRs 0 & 7 it will give a false po

[PATCH v12 3/8] tpm: Support boot measurements

2023-10-12 Thread Eddie James
Add TPM2 functions to support boot measurement. This includes starting up the TPM, initializing/appending the event log, and measuring the U-Boot version. Much of the code was used in the EFI subsystem, so remove it there and use the common functions. Signed-off-by: Eddie James --- Changes since

[PATCH v12 7/8] efi_loader: fix EFI_ENTRY point on get_active_pcr_banks

2023-10-12 Thread Eddie James
From: Ilias Apalodimas efi_tcg2_get_active_pcr_banks doesn't immediately call the EFI_ENTRY() wrapper once it enters the function. Move the call a few lines above to cover the error cases properly as well. Signed-off-by: Ilias Apalodimas --- lib/efi_loader/efi_tcg2.c | 4 ++-- 1 file changed,

[PATCH v12 1/8] tpm: Fix spelling for tpmu_ha union

2023-10-12 Thread Eddie James
tmpu -> tpmu Signed-off-by: Eddie James Reviewed-by: Ilias Apalodimas --- include/tpm-v2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/tpm-v2.h b/include/tpm-v2.h index 2b6980e441..6684033deb 100644 --- a/include/tpm-v2.h +++ b/include/tpm-v2.h @@ -16

[PATCH v12 6/8] doc: Add measured boot documentation

2023-10-12 Thread Eddie James
Briefly describe the feature and specify the requirements. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- doc/usage/index.rst | 1 + doc/usage/measured_boot.rst | 23 +++ 2 files changed, 24 insertions(+) create mode 100644 doc/usage/measured_boot.rst

[PATCH v12 5/8] test: Add sandbox TPM boot measurement

2023-10-12 Thread Eddie James
Use the sandbox TPM driver to measure some boot images in a unit test case. Signed-off-by: Eddie James Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- Changes since v5: - Only compile in the measurement u-boot command when CONFIG_MEASURED_BOOT is enabled. arch/sandbox/dts

[PATCH v12 0/8] tpm: Support boot measurements

2023-10-12 Thread Eddie James
t config option - Update sandbox TPM driver Eddie James (6): tpm: Fix spelling for tpmu_ha union tpm: sandbox: Update for needed TPM2 capabilities tpm: Support boot measurements bootm: Support boot measurement test: Add sandbox TPM boot measurement doc: Add measured boot documenta

Re: [PATCH v11 3/8] tpm: Support boot measurements

2023-08-10 Thread Eddie James
On 8/10/23 02:44, Ilias Apalodimas wrote: On Wed, Aug 09, 2023 at 09:01:40AM -0500, Eddie James wrote: On 8/9/23 05:43, Ilias Apalodimas wrote: On Wed, 9 Aug 2023 at 13:42, Heinrich Schuchardt wrote: On 8/9/23 10:34, Ilias Apalodimas wrote: Hi Eddie On Mon, Aug 07, 2023 at 02:25:37PM

Re: [PATCH v11 3/8] tpm: Support boot measurements

2023-08-09 Thread Eddie James
On 8/9/23 05:43, Ilias Apalodimas wrote: On Wed, 9 Aug 2023 at 13:42, Heinrich Schuchardt wrote: On 8/9/23 10:34, Ilias Apalodimas wrote: Hi Eddie On Mon, Aug 07, 2023 at 02:25:37PM -0500, Eddie James wrote: Add TPM2 functions to support boot measurement. This includes starting up the

[PATCH v11 3/8] tpm: Support boot measurements

2023-08-07 Thread Eddie James
Add TPM2 functions to support boot measurement. This includes starting up the TPM, initializing/appending the event log, and measuring the U-Boot version. Much of the code was used in the EFI subsystem, so remove it there and use the common functions. Signed-off-by: Eddie James --- Changes since

[PATCH v11 2/8] tpm: sandbox: Update for needed TPM2 capabilities

2023-08-07 Thread Eddie James
The driver needs to support getting the PCRs in the capabilities command. Fix various other things and support the max number of PCRs for TPM2. Remove the !SANDBOX dependency for EFI TCG2 as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- Changes since

[PATCH v11 8/8] test: use a non system PCR for testing PCR extend

2023-08-07 Thread Eddie James
From: Ilias Apalodimas We currently use PCR 0 for testing the PCR read/extend functionality in our selftests. How ever those PCRs are defined by the TCG spec for platform use. For example if the tests run *after* the efi subsystem initialization, which extends PCRs 0 & 7 it will give a false po

[PATCH v11 5/8] test: Add sandbox TPM boot measurement

2023-08-07 Thread Eddie James
Use the sandbox TPM driver to measure some boot images in a unit test case. Signed-off-by: Eddie James Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- Changes since v5: - Only compile in the measurement u-boot command when CONFIG_MEASURED_BOOT is enabled. arch/sandbox/dts

[PATCH v11 1/8] tpm: Fix spelling for tpmu_ha union

2023-08-07 Thread Eddie James
tmpu -> tpmu Signed-off-by: Eddie James Reviewed-by: Ilias Apalodimas --- include/tpm-v2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/tpm-v2.h b/include/tpm-v2.h index 2b6980e441..6684033deb 100644 --- a/include/tpm-v2.h +++ b/include/tpm-v2.h @@ -16

[PATCH v11 7/8] efi_loader: fix EFI_ENTRY point on get_active_pcr_banks

2023-08-07 Thread Eddie James
From: Ilias Apalodimas efi_tcg2_get_active_pcr_banks doesn't immediately call the EFI_ENTRY() wrapper once it enters the function. Move the call a few lines above to cover the error cases properly as well. Signed-off-by: Ilias Apalodimas --- lib/efi_loader/efi_tcg2.c | 4 ++-- 1 file changed,

[PATCH v11 0/8] tpm: Support boot measurements

2023-08-07 Thread Eddie James
EFI images that should be measured Changes since v1: - Refactor TPM layer functions to allow EFI system to use them, and remove duplicate EFI functions. - Add test case - Drop #ifdefs for bootm - Add devicetree measurement config option - Update sandbox TPM driver Eddie James (6): tpm: Fix s

[PATCH v11 6/8] doc: Add measured boot documentation

2023-08-07 Thread Eddie James
Briefly describe the feature and specify the requirements. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- doc/usage/index.rst | 1 + doc/usage/measured_boot.rst | 23 +++ 2 files changed, 24 insertions(+) create mode 100644 doc/usage/measured_boot.rst

[PATCH v11 4/8] bootm: Support boot measurement

2023-08-07 Thread Eddie James
Add a configuration option to measure the boot through the bootm function. Add the measurement state to the booti and bootz paths as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- Changes since v8: - Added a configuration option to select to ignore any existing event log

Re: [PATCH v10 07/10] efi_loader: fix EFI_ENTRY point on get_active_pcr_banks

2023-08-07 Thread Eddie James
On 8/7/23 10:56, Ilias Apalodimas wrote: Hi Eddie, On Mon, 7 Aug 2023 at 18:17, Eddie James wrote: From: Ilias Apalodimas We need a commit message for that. Something along the lines of efi_tcg2_get_active_pcr_banks() doesnt immediately call the EFI_ENTRY() wrappers once it enters the

Re: [PATCH v10 10/10] fix armv7 compilation warning

2023-08-07 Thread Eddie James
On 8/7/23 10:50, Ilias Apalodimas wrote: Hi Eddie, On Mon, 7 Aug 2023 at 18:18, Eddie James wrote: From: Ilias Apalodimas Signed-off-by: Ilias Apalodimas --- lib/tpm-v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/tpm-v2.c b/lib/tpm-v2.c index d22e21985b

[PATCH v10 05/10] test: Add sandbox TPM boot measurement

2023-08-07 Thread Eddie James
Use the sandbox TPM driver to measure some boot images in a unit test case. Signed-off-by: Eddie James Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- Changes since v5: - Only compile in the measurement u-boot command when CONFIG_MEASURED_BOOT is enabled. arch/sandbox/dts

[PATCH v10 10/10] fix armv7 compilation warning

2023-08-07 Thread Eddie James
From: Ilias Apalodimas Signed-off-by: Ilias Apalodimas --- lib/tpm-v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/tpm-v2.c b/lib/tpm-v2.c index d22e21985b..bd0fb078dc 100644 --- a/lib/tpm-v2.c +++ b/lib/tpm-v2.c @@ -671,7 +671,7 @@ __weak int tcg2_platform_get_log(

[PATCH v10 08/10] test: use a non system PCR for testing PCR extend

2023-08-07 Thread Eddie James
From: Ilias Apalodimas We currently use PCR 0 for testing the PCR read/extend functionality in our selftests. How ever those PCRs are defined by the TCG spec for platform use. For example if the tests run *after* the efi subsystem initialization, which extends PCRs 0 & 7 it will give a false po

[PATCH v10 01/10] tpm: Fix spelling for tpmu_ha union

2023-08-07 Thread Eddie James
tmpu -> tpmu Signed-off-by: Eddie James Reviewed-by: Ilias Apalodimas --- include/tpm-v2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/tpm-v2.h b/include/tpm-v2.h index 2b6980e441..6684033deb 100644 --- a/include/tpm-v2.h +++ b/include/tpm-v2.h @@ -16

[PATCH v10 03/10] tpm: Support boot measurements

2023-08-07 Thread Eddie James
Add TPM2 functions to support boot measurement. This includes starting up the TPM, initializing/appending the event log, and measuring the U-Boot version. Much of the code was used in the EFI subsystem, so remove it there and use the common functions. Signed-off-by: Eddie James --- Changes since

[PATCH v10 09/10] test/py: only run 'tpm2 autostart' to init the tpm

2023-08-07 Thread Eddie James
From: Ilias Apalodimas commit ("") replaced the forced and sandbox tpm2 initialization running 'tpm2 autostart' instead of the startup tpm sequence. The difference is that the new function handles the internal tpm_init state internally and doesn't return an error when trying to initiali

[PATCH v10 02/10] tpm: sandbox: Update for needed TPM2 capabilities

2023-08-07 Thread Eddie James
The driver needs to support getting the PCRs in the capabilities command. Fix various other things and support the max number of PCRs for TPM2. Remove the !SANDBOX dependency for EFI TCG2 as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- Changes since

[PATCH v10 00/10] tpm: Support boot measurements

2023-08-07 Thread Eddie James
d remove duplicate EFI functions. - Add test case - Drop #ifdefs for bootm - Add devicetree measurement config option - Update sandbox TPM driver Eddie James (6): tpm: Fix spelling for tpmu_ha union tpm: sandbox: Update for needed TPM2 capabilities tpm: Support boot measurements bootm:

[PATCH v10 07/10] efi_loader: fix EFI_ENTRY point on get_active_pcr_banks

2023-08-07 Thread Eddie James
From: Ilias Apalodimas Signed-off-by: Ilias Apalodimas --- lib/efi_loader/efi_tcg2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/efi_loader/efi_tcg2.c b/lib/efi_loader/efi_tcg2.c index 5f0f4b5dd2..829bae7436 100644 --- a/lib/efi_loader/efi_tcg2.c +++ b/lib/efi_lo

[PATCH v10 04/10] bootm: Support boot measurement

2023-08-07 Thread Eddie James
Add a configuration option to measure the boot through the bootm function. Add the measurement state to the booti and bootz paths as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- Changes since v8: - Added a configuration option to select to ignore any existing event log

[PATCH v10 06/10] doc: Add measured boot documentation

2023-08-07 Thread Eddie James
Briefly describe the feature and specify the requirements. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- doc/usage/index.rst | 1 + doc/usage/measured_boot.rst | 23 +++ 2 files changed, 24 insertions(+) create mode 100644 doc/usage/measured_boot.rst

Re: [PATCH v9 4/6] bootm: Support boot measurement

2023-08-07 Thread Eddie James
On 8/7/23 09:52, Ilias Apalodimas wrote: Hi, On Mon, 7 Aug 2023 at 17:43, Eddie James wrote: On 8/4/23 13:10, Sean Edmond wrote: On 2023-03-08 1:25 p.m., Eddie James wrote: Add a configuration option to measure the boot through the bootm function. Add the measurement state to the booti

Re: [PATCH v9 4/6] bootm: Support boot measurement

2023-08-07 Thread Eddie James
On 8/4/23 13:10, Sean Edmond wrote: On 2023-03-08 1:25 p.m., Eddie James wrote: Add a configuration option to measure the boot through the bootm function. Add the measurement state to the booti and bootz paths as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- Changes since

Re: [PATCH v9 3/6] tpm: Support boot measurements

2023-04-10 Thread Eddie James
v9? I believed I had fixed at least some of the failures with patch 2 to update the sandbox driver. I also haven't figured out how to run the ci suite locally Thanks, Eddie Thanks /Ilias On Wed, 8 Mar 2023 at 23:25, Eddie James wrote: Add TPM2 functions to support boot measure

[PATCH v9 3/6] tpm: Support boot measurements

2023-03-08 Thread Eddie James
Add TPM2 functions to support boot measurement. This includes starting up the TPM, initializing/appending the event log, and measuring the U-Boot version. Much of the code was used in the EFI subsystem, so remove it there and use the common functions. Signed-off-by: Eddie James --- Changes since

[PATCH v9 6/6] doc: Add measured boot documentation

2023-03-08 Thread Eddie James
Briefly describe the feature and specify the requirements. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- doc/usage/index.rst | 1 + doc/usage/measured_boot.rst | 23 +++ 2 files changed, 24 insertions(+) create mode 100644 doc/usage/measured_boot.rst

[PATCH v9 4/6] bootm: Support boot measurement

2023-03-08 Thread Eddie James
Add a configuration option to measure the boot through the bootm function. Add the measurement state to the booti and bootz paths as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- Changes since v8: - Added a configuration option to select to ignore any existing event log

[PATCH v9 2/6] tpm: sandbox: Update for needed TPM2 capabilities

2023-03-08 Thread Eddie James
The driver needs to support getting the PCRs in the capabilities command. Fix various other things and support the max number of PCRs for TPM2. Remove the !SANDBOX dependency for EFI TCG2 as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- Changes since

[PATCH v9 5/6] test: Add sandbox TPM boot measurement

2023-03-08 Thread Eddie James
Use the sandbox TPM driver to measure some boot images in a unit test case. Signed-off-by: Eddie James Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- Changes since v5: - Only compile in the measurement u-boot command when CONFIG_MEASURED_BOOT is enabled. arch/sandbox/dts

[PATCH v9 0/6] tpm: Support boot measurements

2023-03-08 Thread Eddie James
tem to use them, and remove duplicate EFI functions. - Add test case - Drop #ifdefs for bootm - Add devicetree measurement config option - Update sandbox TPM driver Eddie James (6): tpm: Fix spelling for tpmu_ha union tpm: sandbox: Update for needed TPM2 capabilities tpm: Support boot meas

[PATCH v9 1/6] tpm: Fix spelling for tpmu_ha union

2023-03-08 Thread Eddie James
tmpu -> tpmu Signed-off-by: Eddie James Reviewed-by: Ilias Apalodimas --- include/tpm-v2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/tpm-v2.h b/include/tpm-v2.h index 2b6980e441..6684033deb 100644 --- a/include/tpm-v2.h +++ b/include/tpm-v2.h @@ -16

Re: [PATCH v8 0/6] tpm: Support boot measurements

2023-03-08 Thread Eddie James
ks, Eddie [0] https://source.denx.de/u-boot/custodians/u-boot-tpm/-/pipelines/15471 Regards /Ilias On Fri, Mar 03, 2023 at 01:25:00PM -0600, Eddie James wrote: This series adds support for measuring the boot images more generically than the existing EFI support. Several EFI functions have bee

[PATCH v8 5/6] test: Add sandbox TPM boot measurement

2023-03-03 Thread Eddie James
Use the sandbox TPM driver to measure some boot images in a unit test case. Signed-off-by: Eddie James Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- Changes since v5: - Only compile in the measurement u-boot command when CONFIG_MEASURED_BOOT is enabled arch/sandbox/dts

[PATCH v8 3/6] tpm: Support boot measurements

2023-03-03 Thread Eddie James
Add TPM2 functions to support boot measurement. This includes starting up the TPM, initializing/appending the event log, and measuring the U-Boot version. Much of the code was used in the EFI subsystem, so remove it there and use the common functions. Signed-off-by: Eddie James --- Changes since

[PATCH v8 6/6] doc: Add measured boot documentation

2023-03-03 Thread Eddie James
Briefly describe the feature and specify the requirements. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- doc/usage/index.rst | 1 + doc/usage/measured_boot.rst | 23 +++ 2 files changed, 24 insertions(+) create mode 100644 doc/usage/measured_boot.rst

[PATCH v8 4/6] bootm: Support boot measurement

2023-03-03 Thread Eddie James
Add a configuration option to measure the boot through the bootm function. Add the measurement state to the booti and bootz paths as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- Changes since v6: - Added comment for bootm_measure - Fixed line length in bootm_measure boot

[PATCH v8 2/6] tpm: sandbox: Update for needed TPM2 capabilities

2023-03-03 Thread Eddie James
The driver needs to support getting the PCRs in the capabilities command. Fix various other things and support the max number of PCRs for TPM2. Remove the !SANDBOX dependency for EFI TCG2 as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- Changes since

[PATCH v8 0/6] tpm: Support boot measurements

2023-03-03 Thread Eddie James
I system to use them, and remove duplicate EFI functions. - Add test case - Drop #ifdefs for bootm - Add devicetree measurement config option - Update sandbox TPM driver Eddie James (6): tpm: Fix spelling for tpmu_ha union tpm: sandbox: Update for needed TPM2 capabilities tpm: Support

[PATCH v8 1/6] tpm: Fix spelling for tpmu_ha union

2023-03-03 Thread Eddie James
tmpu -> tpmu Signed-off-by: Eddie James Reviewed-by: Ilias Apalodimas --- include/tpm-v2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/tpm-v2.h b/include/tpm-v2.h index 2b6980e441..6684033deb 100644 --- a/include/tpm-v2.h +++ b/include/tpm-v2.h @@ -16

Re: [PATCH v7 3/6] tpm: Support boot measurements

2023-03-03 Thread Eddie James
On 3/2/23 14:22, Ilias Apalodimas wrote: Hi Eddie, I found the issue. I still think we could squeeze things even more in our abstraction. Specifically the measure_event() tcg2_agile_log_append() contain some efi specific bits and I am trying to figure out if we can make those more generic.

[PATCH v7 3/6] tpm: Support boot measurements

2023-03-01 Thread Eddie James
Add TPM2 functions to support boot measurement. This includes starting up the TPM, initializing/appending the event log, and measuring the U-Boot version. Much of the code was used in the EFI subsystem, so remove it there and use the common functions. Signed-off-by: Eddie James --- Changes since

[PATCH v7 6/6] doc: Add measured boot documentation

2023-03-01 Thread Eddie James
Briefly describe the feature and specify the requirements. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- doc/usage/index.rst | 1 + doc/usage/measured_boot.rst | 23 +++ 2 files changed, 24 insertions(+) create mode 100644 doc/usage/measured_boot.rst

[PATCH v7 5/6] test: Add sandbox TPM boot measurement

2023-03-01 Thread Eddie James
Use the sandbox TPM driver to measure some boot images in a unit test case. Signed-off-by: Eddie James Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- Changes since v5: - Only compile in the measurement u-boot command when CONFIG_MEASURED_BOOT is enabled arch/sandbox/dts

[PATCH v7 4/6] bootm: Support boot measurement

2023-03-01 Thread Eddie James
Add a configuration option to measure the boot through the bootm function. Add the measurement state to the booti and bootz paths as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- Changes since v6: - Added comment for bootm_measure - Fixed line length in bootm_measure boot

[PATCH v7 2/6] tpm: sandbox: Update for needed TPM2 capabilities

2023-03-01 Thread Eddie James
The driver needs to support getting the PCRs in the capabilities command. Fix various other things and support the max number of PCRs for TPM2. Remove the !SANDBOX dependency for EFI TCG2 as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- Changes since

[PATCH v7 1/6] tpm: Fix spelling for tpmu_ha union

2023-03-01 Thread Eddie James
tmpu -> tpmu Signed-off-by: Eddie James Reviewed-by: Ilias Apalodimas --- include/tpm-v2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/tpm-v2.h b/include/tpm-v2.h index 2b6980e441..6684033deb 100644 --- a/include/tpm-v2.h +++ b/include/tpm-v2.h @@ -16

[PATCH v7 0/6] tpm: Support boot measurements

2023-03-01 Thread Eddie James
Skip measurement for EFI images that should be measured Changes since v1: - Refactor TPM layer functions to allow EFI system to use them, and remove duplicate EFI functions. - Add test case - Drop #ifdefs for bootm - Add devicetree measurement config option - Update sandbox TPM driver Eddie J

Re: [PATCH v6 6/6] doc: Add measured boot documentation

2023-03-01 Thread Eddie James
On 2/22/23 14:26, Heinrich Schuchardt wrote: Am 22. Februar 2023 19:02:42 MEZ schrieb Eddie James : Briefly describe the feature and specify the requirements. Signed-off-by: Eddie James --- doc/usage/index.rst | 1 + doc/usage/measured_boot.rst | 23 +++ 2 files

Re: [PATCH v6 3/6] tpm: Support boot measurements

2023-02-23 Thread Eddie James
On 2/23/23 03:47, Ilias Apalodimas wrote: On Thu, 23 Feb 2023 at 11:30, Ilias Apalodimas wrote: On Thu, 23 Feb 2023 at 11:02, Ilias Apalodimas wrote: Hi Eddie, final_event->number_of_events++; @@ -350,66 +142,6 @@ static efi_status_t tcg2_agile_log_append(u32 pcr_index, u32 even

[PATCH v6 3/6] tpm: Support boot measurements

2023-02-22 Thread Eddie James
Add TPM2 functions to support boot measurement. This includes starting up the TPM, initializing/appending the event log, and measuring the U-Boot version. Much of the code was used in the EFI subsystem, so remove it there and use the common functions. Signed-off-by: Eddie James --- Changes since

[PATCH v6 5/6] test: Add sandbox TPM boot measurement

2023-02-22 Thread Eddie James
Use the sandbox TPM driver to measure some boot images in a unit test case. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- Changes since v5: - Only compile in the measurement u-boot command when CONFIG_MEASURED_BOOT is enabled arch/sandbox/dts/sandbox.dtsi | 13 +++ arch

[PATCH v6 6/6] doc: Add measured boot documentation

2023-02-22 Thread Eddie James
Briefly describe the feature and specify the requirements. Signed-off-by: Eddie James --- doc/usage/index.rst | 1 + doc/usage/measured_boot.rst | 23 +++ 2 files changed, 24 insertions(+) create mode 100644 doc/usage/measured_boot.rst diff --git a/doc/usage

[PATCH v6 4/6] bootm: Support boot measurement

2023-02-22 Thread Eddie James
Add a configuration option to measure the boot through the bootm function. Add the measurement state to the booti and bootz paths as well. Signed-off-by: Eddie James --- boot/Kconfig| 23 boot/bootm.c| 70 + cmd/booti.c

[PATCH v6 2/6] tpm: sandbox: Update for needed TPM2 capabilities

2023-02-22 Thread Eddie James
The driver needs to support getting the PCRs in the capabilities command. Fix various other things and support the max number of PCRs for TPM2. Remove the !SANDBOX dependency for EFI TCG2 as well. Signed-off-by: Eddie James Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- Changes since

[PATCH v6 0/6] tpm: Support boot measurements

2023-02-22 Thread Eddie James
M driver Eddie James (6): tpm: Fix spelling for tpmu_ha union tpm: sandbox: Update for needed TPM2 capabilities tpm: Support boot measurements bootm: Support boot measurement test: Add sandbox TPM boot measurement doc: Add measured boot documentation arch/sandbox/dts/sandbox.dtsi

[PATCH v6 1/6] tpm: Fix spelling for tpmu_ha union

2023-02-22 Thread Eddie James
tmpu -> tpmu Signed-off-by: Eddie James Reviewed-by: Ilias Apalodimas --- include/tpm-v2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/tpm-v2.h b/include/tpm-v2.h index 2b6980e441..6684033deb 100644 --- a/include/tpm-v2.h +++ b/include/tpm-v2.h @@ -16

  1   2   3   >