[PATCH] image-host: Fix error value paths and emit error messages to stderr.

A recent refactoring in image-host.c messed up the return values of the function that reads the encryptiong keys. This patch fixes this and also makes sure that error output goes to stderr instead of to stdout. Signed-off-by: Hugo Cornelis --- tools/image-host.c | 10 +- 1 file changed

[PATCH] image-host: Fix error value paths and emit error messages to stderr.

Signed-off-by: Hugo Cornelis --- tools/image-host.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/image-host.c b/tools/image-host.c index b2a0f2e6d1..06b05dcacb 100644 --- a/tools/image-host.c +++ b/tools/image-host.c @@ -351,12 +351,12 @@ static int

Re: Fwd: New Defects reported by Coverity Scan for Das U-Boot

Hi Tom, sorry about that. Please find attached a patch. Can you please review? Thanks, Hugo

[PATCH] image-host: refactor and protect for very long filenames

and Yocto builds. Signed-off-by: Hugo Cornelis --- tools/image-host.c | 42 -- 1 file changed, 32 insertions(+), 10 deletions(-) diff --git a/tools/image-host.c b/tools/image-host.c index ca4950312f..0092fa830f 100644 --- a/tools/image-host.c +++ b/tools

Re: [PATCH 1/2] image-host: add a check of the return value of snprintf.

Hi Simon, thanks for the feedback. Yes, you were right. I have split the function into two functions. The patched is attached below (inline). Some of the calls can be further 'logically' reordered, I believe, but I don't know the program flow well enough to be sure. One other 'inconsistency' is

[PATCH 2/2] image-host: increase path length when setting up the cipher.

This patch increases the maximum path length of the filename containing the cipher key for the kernel from 128 to 256 characters. Signed-off-by: Hugo Cornelis --- tools/image-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/image-host.c b/tools/image-host.c

[PATCH 1/2] image-host: add a check of the return value of snprintf.

This patch allows to generate a sensible error message when generating binary images using very long filenames. This can happen with Buildroot and Yocto builds. Signed-off-by: Hugo Cornelis --- tools/image-host.c | 29 + 1 file changed, 25 insertions(+), 4

[PATCH 2/2] image-host: increase path length when setting up the cipher.

--- tools/image-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/image-host.c b/tools/image-host.c index 0c92a2ddeb..9afcc02192 100644 --- a/tools/image-host.c +++ b/tools/image-host.c @@ -361,7 +361,7 @@ static int fit_image_setup_cipher(struct image_cipher_info *

[PATCH 1/2] image-host: add a check of the return value of snprintf.

--- tools/image-host.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/tools/image-host.c b/tools/image-host.c index a6b0a94420..0c92a2ddeb 100644 --- a/tools/image-host.c +++ b/tools/image-host.c @@ -363,6 +363,7 @@ static int fit_image_setup_cipher

image-host: small improvements and fixes.

Yocto build can involve very long filenames. These two patches protect the Yocto build from failing without a sensible error message and increase the path length for the cipher key for the kernel from 128 to 256 characters.