Re: [U-Boot] [PATCH] pci: don't skip vendor ID 0

2017-01-26 Thread Gregory Fong
On Thu, Jan 26, 2017 at 5:57 AM, Leon Woestenberg wrote: > > On Thu, Jan 26, 2017 at 2:19 PM, Gregory Fong > wrote: >> >> It looks like the main problem is that >> struct pci_device_id with vendor and device both 0 is being used to >> indicate the end of a

Re: [U-Boot] [PATCH] pci: don't skip vendor ID 0

2017-01-26 Thread Gregory Fong
Hi Leon, On Thu, Jan 26, 2017 at 4:26 AM, Leon Woestenberg wrote: > On Thu, Jan 26, 2017 at 11:08 AM, Bin Meng wrote: > >>>> On Wed, Jan 25, 2017 at 1:25 PM, Gregory Fong >>>> wrote: >>>>> I've been looking through the book I have on PCI and

Re: [U-Boot] [PATCH] pci: don't skip vendor ID 0

2017-01-25 Thread Gregory Fong
Hi Bin, On Wed, Jan 25, 2017 at 10:14:56PM +0800, Bin Meng wrote: > Hi Gregory, > > On Wed, Jan 25, 2017 at 1:25 PM, Gregory Fong > wrote: > > Unlike 0x, 0 is not an invalid vendor ID. > > > > Signed-off-by: Gregory Fong > > --- > > Based

[U-Boot] [PATCH] pci: don't skip vendor ID 0

2017-01-25 Thread Gregory Fong
Unlike 0x, 0 is not an invalid vendor ID. Signed-off-by: Gregory Fong --- Based on question initially asked here: http://lists.denx.de/pipermail/u-boot/2016-December/276172.html I've been looking through the book I have on PCI and through various online resources, and haven't be

[U-Boot] Question re vendor check in drivers/pci/pci.c

2016-12-15 Thread Gregory Fong
Hello all, In pci_hose_scan_bus(), there is this check: if (vendor == 0x || vendor == 0x) continue; The test against the special invalid vendor value of 0x is definitely correct. But is it necessarily wrong for a vendor ID to be 0? Of course it's not used in the PCI ven