Re: [PATCH] common: The do_repeat flag interferes with commands issued via run_command API

2021-05-28 Thread Farhan Ali
TCH] common: The do_repeat flag interferes with commands issued > via run_command API > > The tag here should be "hush: ..." The subject should be an action, > such as "Clear do_repeat flag after running commands". > > On 5/27/21 5:24 PM, Farhan Ali wrote:

[PATCH] common: The do_repeat flag interferes with commands issued via run_command API

2021-05-27 Thread Farhan Ali
Must clear the do_repeat flag once it is consumed. Signed-off-by: Farhan Ali Cc: Simon Glass Cc: Sean Anderson Cc: Rasmus Villemoes Cc: Farhan Ali Cc: "peng.w...@smartm.com" Cc: Patrick Delaunay --- common/cli_hush.c | 5 + 1 file changed, 5 insertions(+) diff --gi

Re: [PATCH v2] spl: Add callback for preprocessing loaded FIT header before parsing

2021-03-29 Thread Farhan Ali
Phillipe, In our implementation we store our binaries outside the FIT header, and introduce a gap between the header and the start of binary data (-p and -E option in mkimage). After the FIT has been generated, we sign the FIT header and insert the signature into this gap. The weak function then c

Re: [PATCH v2] spl: Add callback for preprocessing loaded FIT header before parsing

2021-03-10 Thread Farhan Ali
On Wed, Mar 10, 2021 at 11:38 AM Alex G. wrote: > On 3/9/21 5:55 PM, Farhan Ali wrote: > > This change adds a callback for preprocessing the FIT header before > > it is parsed. There are 3 main reasons for this callback: > > > > (1) If a vulnerability is discovered

[PATCH v2] spl: Add callback for preprocessing loaded FIT header before parsing

2021-03-09 Thread Farhan Ali
specific metadata stored outside the FIT header, then this callback allows them to do that. Signed-off-by: Farhan Ali Cc: Simon Glass Cc: Alexandru Gagniuc Cc: Marek Vasut Cc: Michal Simek Cc: Philippe Reynes Cc: Samuel Holland --- Changes for v2: - Callback now returns a value - Added a log

[PATCH v2] cmd: gpt: Add option to write GPT partitions to environment variable

2021-02-26 Thread Farhan Ali
using the variable in the 'gpt write' and 'gpt verify' commands. Signed-off-by: Farhan Ali Cc: Simon Glass Cc: Heinrich Schuchardt Cc: Corneliu Doban Cc: Rayagonda Kokatanur Cc: Rasmus Villemoes --- Changes for v2: - Checked for argv[4] existence before calling do_g

Re: [PATCH] cmd: gpt: Add option to write GPT partitions to environment variable

2021-02-25 Thread Farhan Ali
12:03 PM Heinrich Schuchardt wrote: > On 2/25/21 7:56 PM, Farhan Ali wrote: > > This change would enhance the existing 'gpt read' command to allow > > (optionally) writing of the read GPT partitions to an environment > > variable. This would allow users to easily ch

[PATCH] cmd: gpt: Add option to write GPT partitions to environment variable

2021-02-25 Thread Farhan Ali
fy' commands. Signed-off-by: Farhan Ali --- Cc: Simon Glass Cc: Heinrich Schuchardt Cc: Corneliu Doban Cc: Rayagonda Kokatanur cmd/gpt.c | 46 ++ 1 file changed, 38 insertions(+), 8 deletions(-) diff --git a/cmd/gpt.c b/cmd/gpt.c index 76a

[PATCH] mtd: Update fail_addr when erase fails due to bad blocks

2021-02-24 Thread Farhan Ali
. Signed-off-by: Farhan Ali --- Cc: Simon Glass drivers/mtd/nand/raw/nand_base.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c index 6557fad..3679ee7 100644 --- a/drivers/mtd/nand/raw/nand_base.c +++ b/drivers/mtd/nand/raw

[PATCH] spl: Add callback for preprocessing loaded FIT header before parsing

2021-02-24 Thread Farhan Ali
specific metadata stored outside the FIT header, then this callback allows them to do that. Signed-off-by: Farhan Ali --- Cc: Simon Glass Cc: Alexandru Gagniuc Cc: Marek Vasut Cc: Michal Simek Cc: Philippe Reynes Cc: Samuel Holland common/spl/spl_fit.c | 9 + 1 file changed, 9 insertions